From 1e1b2364ab532969f8fb9869d44233d47e468ebd Mon Sep 17 00:00:00 2001 From: Nabin Hait Date: Mon, 29 Jan 2018 16:45:43 +0530 Subject: [PATCH] Optimization: don't update outstanding amount while cancelling payment entry for advance adjustment (#12689) --- erpnext/accounts/general_ledger.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/erpnext/accounts/general_ledger.py b/erpnext/accounts/general_ledger.py index c575d59ae74..03a06cc5f2b 100644 --- a/erpnext/accounts/general_ledger.py +++ b/erpnext/accounts/general_ledger.py @@ -191,8 +191,9 @@ def delete_gl_entries(gl_entries=None, voucher_type=None, voucher_no=None, for entry in gl_entries: validate_frozen_account(entry["account"], adv_adj) validate_balance_type(entry["account"], adv_adj) - validate_expense_against_budget(entry) + if not adv_adj: + validate_expense_against_budget(entry) - if entry.get("against_voucher") and update_outstanding == 'Yes': + if entry.get("against_voucher") and update_outstanding == 'Yes' and not adv_adj: update_outstanding_amt(entry["account"], entry.get("party_type"), entry.get("party"), entry.get("against_voucher_type"), entry.get("against_voucher"), on_cancel=True)