nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-08-15 07:28:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(tnc): get_terms_and_conditions render_template with safe_exec (backport #56944) (backport #56977) (#57106)

Browse Source 
Co-authored-by: Diptanil Saha <diptanil@frappe.io>
This commit is contained in:
mergify[bot]
2026-07-28 21:59:17 +05:30
committed by GitHub
parent 41effcf754
commit 1d60ab449c
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
erpnext/setup/doctype/terms_and_conditions/terms_and_conditions.py
View File

@@ -30,7 +30,7 @@ class TermsandConditions(Document):
def validate(self): def validate(self):
if self.terms: if self.terms:
validate_template(self.terms) validate_template(self.terms, restrict_globals=True)
if not cint(self.buying) and not cint(self.selling) and not cint(self.hr) and not cint(self.disabled): if not cint(self.buying) and not cint(self.selling) and not cint(self.hr) and not cint(self.disabled):
throw(_("At least one of the Applicable Modules should be selected")) throw(_("At least one of the Applicable Modules should be selected"))
@@ -40,7 +40,10 @@ def get_terms_and_conditions(template_name, doc):
if isinstance(doc, str): if isinstance(doc, str):
doc = json.loads(doc) doc = json.loads(doc)
terms_and_conditions = frappe.get_doc("Terms and Conditions", template_name) tnc = frappe.get_cached_doc("Terms and Conditions", template_name)
tnc.check_permission()
if terms_and_conditions.terms: if not tnc.terms:
return frappe.render_template(terms_and_conditions.terms, doc) return
return frappe.render_template(tnc.terms, doc, restrict_globals=1)