nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-26 00:14:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(test): assertion refactoring and exact decimals

Browse Source
This commit is contained in:
ruthra kumar
2024-11-11 14:16:49 +05:30
parent c53e9637dd
commit 1d11131afe
1 changed files with 21 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
erpnext/accounts/report/sales_register/test_sales_register.py
View File

@@ -22,12 +22,13 @@ class TestItemWiseSalesRegister(AccountsTestMixin, IntegrationTestCase):
if frappe.db.exists("Cost Center", cc_name): if frappe.db.exists("Cost Center", cc_name):
cc = frappe.get_doc("Cost Center", cc_name) cc = frappe.get_doc("Cost Center", cc_name)
else: else:
parent = frappe.db.get_value("Cost Center", self.cost_center, "parent_cost_center")
cc = frappe.get_doc( cc = frappe.get_doc(
{ {
"doctype": "Cost Center", "doctype": "Cost Center",
"parent_cost_center": self.cost_center,
"company": self.company, "company": self.company,
"is_group": False, "is_group": False,
"parent_cost_center": parent,
"cost_center_name": cc_name, "cost_center_name": cc_name,
} }
) )
@@ -63,12 +64,12 @@ class TestItemWiseSalesRegister(AccountsTestMixin, IntegrationTestCase):
expected_result = { expected_result = {
"voucher_type": si.doctype, "voucher_type": si.doctype,
"voucher_no": si.name, "voucher_no": si.name,
"posting_date": si.posting_date, "posting_date": getdate(),
"customer": self.customer, "customer": self.customer,
"receivable_account": self.debit_to, "receivable_account": self.debit_to,
"net_total": 98, "net_total": 98.0,
"grand_total": 98, "grand_total": 98.0,
"credit": 98, "debit": 98.0,
} }
report_output = {k: v for k, v in report[1][0].items() if k in expected_result} report_output = {k: v for k, v in report[1][0].items() if k in expected_result}
@@ -89,7 +90,7 @@ class TestItemWiseSalesRegister(AccountsTestMixin, IntegrationTestCase):
"credit_in_account_currency": 77, "credit_in_account_currency": 77,
"credit": 77, "credit": 77,
"is_advance": "Yes", "is_advance": "Yes",
"cost_center": self.south_cc, "cost_center": self.cost_center,
}, },
{ {
"account": self.cash, "account": self.cash,
@@ -115,7 +116,7 @@ class TestItemWiseSalesRegister(AccountsTestMixin, IntegrationTestCase):
"credit_in_account_currency": 98, "credit_in_account_currency": 98,
"credit": 98, "credit": 98,
"is_advance": "Yes", "is_advance": "Yes",
"cost_center": self.cost_center, "cost_center": self.south_cc,
}, },
{ {
"account": self.cash, "account": self.cash,
@@ -137,19 +138,20 @@ class TestItemWiseSalesRegister(AccountsTestMixin, IntegrationTestCase):
"cost_center": self.cost_center, "cost_center": self.cost_center,
} }
) )
result = [x for x in execute(filters)[1] if x.voucher_no == je1.name] report_output = execute(filters)[1]
filtered_output = [x for x in report_output if x.get("voucher_no") == je1.name]
self.assertEqual(len(filtered_output), 1)
expected_result = { expected_result = {
"voucher_type": je1.doctype, "voucher_type": je1.doctype,
"voucher_no": je1.name, "voucher_no": je1.name,
"posting_date": je1.posting_date, "posting_date": je1.posting_date,
"customer": self.customer, "customer": self.customer,
"receivable_account": self.debit_to, "receivable_account": self.debit_to,
"net_total": 77, "net_total": 77.0,
"cost_center": self.cost_center, "credit": 77.0,
"credit": 77,
} }
result_output = {k: v for k, v in result.items() if k in expected_result} result_fields = {k: v for k, v in filtered_output[0].items() if k in expected_result}
self.assertDictEqual(result_output, expected_result) self.assertDictEqual(result_fields, expected_result)
filters = frappe._dict( filters = frappe._dict(
{ {
@@ -161,16 +163,17 @@ class TestItemWiseSalesRegister(AccountsTestMixin, IntegrationTestCase):
"cost_center": self.south_cc, "cost_center": self.south_cc,
} }
) )
result = [x for x in execute(filters)[1] if x.voucher_no == je2.name] report_output = execute(filters)[1]
filtered_output = [x for x in report_output if x.get("voucher_no") == je2.name]
self.assertEqual(len(filtered_output), 1)
expected_result = { expected_result = {
"voucher_type": je2.doctype, "voucher_type": je2.doctype,
"voucher_no": je2.name, "voucher_no": je2.name,
"posting_date": je2.posting_date, "posting_date": je2.posting_date,
"customer": self.customer, "customer": self.customer,
"receivable_account": self.debit_to, "receivable_account": self.debit_to,
"net_total": 98, "net_total": 98.0,
"cost_center": self.south_cc, "credit": 98.0,
"credit": 98,
} }
result_output = {k: v for k, v in result.items() if k in expected_result} result_output = {k: v for k, v in filtered_output[0].items() if k in expected_result}
self.assertDictEqual(result_output, expected_result) self.assertDictEqual(result_output, expected_result)