nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-16 11:39:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: removed duplicate batch number validation

Browse Source
This commit is contained in:
RitvikSardana
2023-09-18 11:09:37 +05:30
parent b56e3b3f1a
commit 1cb9d45823
1 changed files with 2 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
erpnext/accounts/doctype/pos_invoice/pos_invoice.py
View File

@@ -57,7 +57,7 @@ class POSInvoice(SalesInvoice):
self.validate_payment_amount() self.validate_payment_amount()
self.validate_loyalty_transaction() self.validate_loyalty_transaction()
self.validate_company_with_pos_company() self.validate_company_with_pos_company()
self.validate_duplicate_serial_and_batch_no() self.validate_duplicate_serial_no()
if self.coupon_code: if self.coupon_code:
from erpnext.accounts.doctype.pricing_rule.utils import validate_coupon_code from erpnext.accounts.doctype.pricing_rule.utils import validate_coupon_code
@@ -158,27 +158,18 @@ class POSInvoice(SalesInvoice):
title=_("Item Unavailable"), title=_("Item Unavailable"),
) )
def validate_duplicate_serial_and_batch_no(self): def validate_duplicate_serial_no(self):
serial_nos = [] serial_nos = []
batch_nos = []
for row in self.get("items"): for row in self.get("items"):
if row.serial_no: if row.serial_no:
serial_nos = row.serial_no.split("\n") serial_nos = row.serial_no.split("\n")
if row.batch_no and not row.serial_no:
batch_nos.append(row.batch_no)
if serial_nos: if serial_nos:
for key, value in collections.Counter(serial_nos).items(): for key, value in collections.Counter(serial_nos).items():
if value > 1: if value > 1:
frappe.throw(_("Duplicate Serial No {0} found").format("key")) frappe.throw(_("Duplicate Serial No {0} found").format("key"))
if batch_nos:
for key, value in collections.Counter(batch_nos).items():
if value > 1:
frappe.throw(_("Duplicate Batch No {0} found").format("key"))
def validate_pos_reserved_batch_qty(self, item): def validate_pos_reserved_batch_qty(self, item):
filters = {"item_code": item.item_code, "warehouse": item.warehouse, "batch_no": item.batch_no} filters = {"item_code": item.item_code, "warehouse": item.warehouse, "batch_no": item.batch_no}