nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-22 22:49:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

cannot close task if dependent task are not closed / cancelled (#20433)

Browse Source
This commit is contained in:
Nabin Hait
2020-01-28 14:08:31 +05:30
committed by GitHub
parent 41d2357dc4
commit 1c5df5dede
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
erpnext/projects/doctype/task/task.py
View File

@@ -47,8 +47,8 @@ class Task(NestedSet):
def validate_status(self): def validate_status(self):
if self.status!=self.get_db_value("status") and self.status == "Closed": if self.status!=self.get_db_value("status") and self.status == "Closed":
for d in self.depends_on: for d in self.depends_on:
if frappe.db.get_value("Task", d.task, "status") != "Closed": if frappe.db.get_value("Task", d.task, "status") not in ("Closed", "Cancelled"):
frappe.throw(_("Cannot close task as its dependant task {0} is not closed.").format(d.task)) frappe.throw(_("Cannot close task as its dependant task {0} is not closed/cancelled.").format(d.task))
from frappe.desk.form.assign_to import clear from frappe.desk.form.assign_to import clear
clear(self.doctype, self.name) clear(self.doctype, self.name)