From 1c5df5dede615270c5553557e9e2e2fd3b6bc67b Mon Sep 17 00:00:00 2001 From: Nabin Hait Date: Tue, 28 Jan 2020 14:08:31 +0530 Subject: [PATCH] cannot close task if dependent task are not closed / cancelled (#20433) --- erpnext/projects/doctype/task/task.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/erpnext/projects/doctype/task/task.py b/erpnext/projects/doctype/task/task.py index 97d15130eb0..9285a5dada2 100755 --- a/erpnext/projects/doctype/task/task.py +++ b/erpnext/projects/doctype/task/task.py @@ -47,8 +47,8 @@ class Task(NestedSet): def validate_status(self): if self.status!=self.get_db_value("status") and self.status == "Closed": for d in self.depends_on: - if frappe.db.get_value("Task", d.task, "status") != "Closed": - frappe.throw(_("Cannot close task as its dependant task {0} is not closed.").format(d.task)) + if frappe.db.get_value("Task", d.task, "status") not in ("Closed", "Cancelled"): + frappe.throw(_("Cannot close task as its dependant task {0} is not closed/cancelled.").format(d.task)) from frappe.desk.form.assign_to import clear clear(self.doctype, self.name)