Merge pull request #57873 from mihir-kandoi/fix-conversion-factor-precision

fix: declare precision 9 on all conversion_factor fields
2026-08-14 23:18:40 +00:00 · 2026-08-07 22:20:57 +05:30
parent 594ff24dae ca5a673409
commit 1b2090820a
30 changed files with 66 additions and 35 deletions
--- a/erpnext/accounts/doctype/pos_invoice_item/pos_invoice_item.json
+++ b/erpnext/accounts/doctype/pos_invoice_item/pos_invoice_item.json
@@ -259,6 +259,7 @@
   "fieldname": "conversion_factor",
   "fieldtype": "Float",
   "label": "UOM Conversion Factor",
+   "precision": "9",
   "print_hide": 1,
   "reqd": 1
  },
@@ -888,7 +889,7 @@
 ],
 "istable": 1,
 "links": [],
- "modified": "2026-07-18 10:00:00.000000",
+ "modified": "2026-08-07 17:31:31.732720",
 "modified_by": "Administrator",
 "module": "Accounts",
 "name": "POS Invoice Item",
--- a/erpnext/accounts/doctype/purchase_invoice_item/purchase_invoice_item.json
+++ b/erpnext/accounts/doctype/purchase_invoice_item/purchase_invoice_item.json
@@ -241,6 +241,7 @@
   "fieldname": "conversion_factor",
   "fieldtype": "Float",
   "label": "UOM Conversion Factor",
+   "precision": "9",
   "print_hide": 1,
   "read_only": 1,
   "reqd": 1
@@ -1032,7 +1033,7 @@
 "idx": 1,
 "istable": 1,
 "links": [],
- "modified": "2026-07-18 10:00:00.000000",
+ "modified": "2026-08-07 17:31:31.732720",
 "modified_by": "Administrator",
 "module": "Accounts",
 "name": "Purchase Invoice Item",
--- a/erpnext/accounts/doctype/sales_invoice_item/sales_invoice_item.json
+++ b/erpnext/accounts/doctype/sales_invoice_item/sales_invoice_item.json
@@ -249,6 +249,7 @@
   "fieldname": "conversion_factor",
   "fieldtype": "Float",
   "label": "UOM Conversion Factor",
+   "precision": "9",
   "print_hide": 1,
   "reqd": 1
  },
@@ -1066,7 +1067,7 @@
 "idx": 1,
 "istable": 1,
 "links": [],
- "modified": "2026-07-18 10:00:00.000000",
+ "modified": "2026-08-07 17:31:31.732720",
 "modified_by": "Administrator",
 "module": "Accounts",
 "name": "Sales Invoice Item",
--- a/erpnext/buying/doctype/purchase_order_item/purchase_order_item.json
+++ b/erpnext/buying/doctype/purchase_order_item/purchase_order_item.json
@@ -260,6 +260,7 @@
   "label": "UOM Conversion Factor",
   "oldfieldname": "conversion_factor",
   "oldfieldtype": "Currency",
+   "precision": "9",
   "print_hide": 1,
   "print_width": "100px",
   "reqd": 1,
@@ -943,7 +944,7 @@
 "index_web_pages_for_search": 1,
 "istable": 1,
 "links": [],
- "modified": "2026-07-15 10:30:04.600510",
+ "modified": "2026-08-07 17:31:31.732720",
 "modified_by": "Administrator",
 "module": "Buying",
 "name": "Purchase Order Item",
--- a/erpnext/buying/doctype/purchase_receipt_item_supplied/purchase_receipt_item_supplied.json
+++ b/erpnext/buying/doctype/purchase_receipt_item_supplied/purchase_receipt_item_supplied.json
@@ -132,6 +132,7 @@
   "label": "Conversion Factor",
   "oldfieldname": "conversion_factor",
   "oldfieldtype": "Currency",
+   "precision": "9",
   "read_only": 1
  },
  {
@@ -207,7 +208,7 @@
 "idx": 1,
 "istable": 1,
 "links": [],
- "modified": "2024-03-27 13:10:26.235916",
+ "modified": "2026-08-07 17:31:31.732720",
 "modified_by": "Administrator",
 "module": "Buying",
 "name": "Purchase Receipt Item Supplied",
--- a/erpnext/buying/doctype/request_for_quotation_item/request_for_quotation_item.json
+++ b/erpnext/buying/doctype/request_for_quotation_item/request_for_quotation_item.json
@@ -241,6 +241,7 @@
   "fieldname": "conversion_factor",
   "fieldtype": "Float",
   "label": "UOM Conversion Factor",
+   "precision": "9",
   "print_hide": 1,
   "read_only": 1,
   "reqd": 1
@@ -274,7 +275,7 @@
 "index_web_pages_for_search": 1,
 "istable": 1,
 "links": [],
- "modified": "2026-06-15 00:00:00.000000",
+ "modified": "2026-08-07 17:31:31.732720",
 "modified_by": "Administrator",
 "module": "Buying",
 "name": "Request for Quotation Item",
--- a/erpnext/buying/doctype/supplier_quotation_item/supplier_quotation_item.json
+++ b/erpnext/buying/doctype/supplier_quotation_item/supplier_quotation_item.json
@@ -217,6 +217,7 @@
   "fieldname": "conversion_factor",
   "fieldtype": "Float",
   "label": "UOM Conversion Factor",
+   "precision": "9",
   "print_hide": 1,
   "read_only": 1,
   "reqd": 1
@@ -614,7 +615,7 @@
 "index_web_pages_for_search": 1,
 "istable": 1,
 "links": [],
- "modified": "2026-07-15 10:33:24.855979",
+ "modified": "2026-08-07 17:31:31.732720",
 "modified_by": "Administrator",
 "module": "Buying",
 "name": "Supplier Quotation Item",
--- a/erpnext/manufacturing/doctype/bom_creator_item/bom_creator_item.json
+++ b/erpnext/manufacturing/doctype/bom_creator_item/bom_creator_item.json
@@ -140,7 +140,8 @@
  {
   "fieldname": "conversion_factor",
   "fieldtype": "Float",
-   "label": "Conversion Factor"
+   "label": "Conversion Factor",
+   "precision": "9"
  },
  {
   "fetch_from": "item_code.stock_uom",
@@ -264,7 +265,7 @@
 "index_web_pages_for_search": 1,
 "istable": 1,
 "links": [],
- "modified": "2025-11-05 21:15:55.187671",
+ "modified": "2026-08-07 17:31:31.732720",
 "modified_by": "Administrator",
 "module": "Manufacturing",
 "name": "BOM Creator Item",
--- a/erpnext/manufacturing/doctype/bom_item/bom_item.json
+++ b/erpnext/manufacturing/doctype/bom_item/bom_item.json
@@ -177,7 +177,8 @@
  {
   "fieldname": "conversion_factor",
   "fieldtype": "Float",
-   "label": "Conversion Factor"
+   "label": "Conversion Factor",
+   "precision": "9"
  },
  {
   "fieldname": "rate_amount_section",
@@ -327,7 +328,7 @@
 "index_web_pages_for_search": 1,
 "istable": 1,
 "links": [],
- "modified": "2025-11-05 19:00:38.646539",
+ "modified": "2026-08-07 17:31:31.732720",
 "modified_by": "Administrator",
 "module": "Manufacturing",
 "name": "BOM Item",
--- a/erpnext/manufacturing/doctype/bom_secondary_item/bom_secondary_item.json
+++ b/erpnext/manufacturing/doctype/bom_secondary_item/bom_secondary_item.json
@@ -99,6 +99,7 @@
   "fieldtype": "Float",
   "label": "Conversion Factor",
   "non_negative": 1,
+   "precision": "9",
   "reqd": 1
  },
  {
@@ -217,7 +218,7 @@
 "index_web_pages_for_search": 1,
 "istable": 1,
 "links": [],
- "modified": "2026-06-16 16:51:40.000000",
+ "modified": "2026-08-07 17:31:31.732720",
 "modified_by": "Administrator",
 "module": "Manufacturing",
 "name": "BOM Secondary Item",
--- a/erpnext/manufacturing/doctype/material_request_plan_item/material_request_plan_item.json
+++ b/erpnext/manufacturing/doctype/material_request_plan_item/material_request_plan_item.json
@@ -193,6 +193,7 @@
   "fieldname": "conversion_factor",
   "fieldtype": "Float",
   "label": "Conversion Factor",
+   "precision": "9",
   "read_only": 1
  },
  {
@@ -266,7 +267,7 @@
 "grid_page_length": 50,
 "istable": 1,
 "links": [],
- "modified": "2025-10-30 17:01:25.996352",
+ "modified": "2026-08-07 17:31:31.732720",
 "modified_by": "Administrator",
 "module": "Manufacturing",
 "name": "Material Request Plan Item",
--- a/erpnext/public/js/controllers/transaction.js
+++ b/erpnext/public/js/controllers/transaction.js
@@ -1802,7 +1802,10 @@ erpnext.TransactionController = class TransactionController extends erpnext.taxe
 		let item = frappe.get_doc(cdt, cdn);
 		item.conversion_factor = 1.0;
 		if (item.stock_qty) {
-			item.conversion_factor = flt(item.stock_qty) / flt(item.qty);
+			item.conversion_factor = flt(
+				flt(item.stock_qty) / flt(item.qty),
+				precision("conversion_factor", item)
+			);
 		}

 		refresh_field("conversion_factor", item.name, item.parentfield);
--- a/erpnext/selling/doctype/delivery_schedule_item/delivery_schedule_item.json
+++ b/erpnext/selling/doctype/delivery_schedule_item/delivery_schedule_item.json
@@ -38,6 +38,7 @@
   "fieldname": "conversion_factor",
   "fieldtype": "Float",
   "label": "Conversion Factor",
+   "precision": "9",
   "read_only": 1
  },
  {
@@ -106,7 +107,7 @@
 "grid_page_length": 50,
 "index_web_pages_for_search": 1,
 "links": [],
- "modified": "2025-08-21 18:11:30.134073",
+ "modified": "2026-08-07 17:31:31.732720",
 "modified_by": "Administrator",
 "module": "Selling",
 "name": "Delivery Schedule Item",
--- a/erpnext/selling/doctype/quotation_item/quotation_item.json
+++ b/erpnext/selling/doctype/quotation_item/quotation_item.json
@@ -216,6 +216,7 @@
   "fieldname": "conversion_factor",
   "fieldtype": "Float",
   "label": "UOM Conversion Factor",
+   "precision": "9",
   "print_hide": 1,
   "read_only": 1,
   "reqd": 1
@@ -729,7 +730,7 @@
 "idx": 1,
 "istable": 1,
 "links": [],
- "modified": "2026-06-08 19:00:00.000000",
+ "modified": "2026-08-07 17:31:31.732720",
 "modified_by": "Administrator",
 "module": "Selling",
 "name": "Quotation Item",
--- a/erpnext/selling/doctype/sales_order_item/sales_order_item.json
+++ b/erpnext/selling/doctype/sales_order_item/sales_order_item.json
@@ -271,6 +271,7 @@
   "fieldname": "conversion_factor",
   "fieldtype": "Float",
   "label": "UOM Conversion Factor",
+   "precision": "9",
   "print_hide": 1,
   "read_only": 1,
   "reqd": 1
@@ -1055,7 +1056,7 @@
 "idx": 1,
 "istable": 1,
 "links": [],
- "modified": "2026-06-08 20:00:00.000000",
+ "modified": "2026-08-07 17:31:31.732720",
 "modified_by": "Administrator",
 "module": "Selling",
 "name": "Sales Order Item",
--- a/erpnext/stock/doctype/delivery_note_item/delivery_note_item.json
+++ b/erpnext/stock/doctype/delivery_note_item/delivery_note_item.json
@@ -257,6 +257,7 @@
   "fieldname": "conversion_factor",
   "fieldtype": "Float",
   "label": "UOM Conversion Factor",
+   "precision": "9",
   "print_hide": 1,
   "read_only": 1,
   "reqd": 1
@@ -982,7 +983,7 @@
 "index_web_pages_for_search": 1,
 "istable": 1,
 "links": [],
- "modified": "2026-07-18 10:00:00.000000",
+ "modified": "2026-08-07 17:31:31.732720",
 "modified_by": "Administrator",
 "module": "Stock",
 "name": "Delivery Note Item",
--- a/erpnext/stock/doctype/item/item.py
+++ b/erpnext/stock/doctype/item/item.py
@@ -1508,7 +1508,7 @@ def get_uom_conv_factor(uom: str | None, stock_uom: str | None):
 		"UOM Conversion Factor", {"to_uom": from_uom, "from_uom": to_uom}, ["value"], as_dict=1
 	)
 	if inverse_match:
-		return 1 / inverse_match.value
+		return flt(1 / inverse_match.value, frappe.get_precision("UOM Conversion Factor", "value"))

 	# This attempts to try and get conversion from intermediate UOM.
 	# case:
@@ -1528,7 +1528,7 @@ def get_uom_conv_factor(uom: str | None, stock_uom: str | None):
 	)

 	if intermediate_match:
-		return intermediate_match[0].value
+		return flt(intermediate_match[0].value, frappe.get_precision("UOM Conversion Factor", "value"))


@frappe.whitelist()
--- a/erpnext/stock/doctype/material_request_item/material_request_item.json
+++ b/erpnext/stock/doctype/material_request_item/material_request_item.json
@@ -159,6 +159,7 @@
   "fieldname": "conversion_factor",
   "fieldtype": "Float",
   "label": "UOM Conversion Factor",
+   "precision": "9",
   "print_hide": 1,
   "reqd": 1
  },
@@ -545,7 +546,7 @@
 "index_web_pages_for_search": 1,
 "istable": 1,
 "links": [],
- "modified": "2026-01-06 20:47:27.317226",
+ "modified": "2026-08-07 17:31:31.732720",
 "modified_by": "Administrator",
 "module": "Stock",
 "name": "Material Request Item",
--- a/erpnext/stock/doctype/packed_item/packed_item.json
+++ b/erpnext/stock/doctype/packed_item/packed_item.json
@@ -243,7 +243,8 @@
  {
   "fieldname": "conversion_factor",
   "fieldtype": "Float",
-   "label": "Conversion Factor"
+   "label": "Conversion Factor",
+   "precision": "9"
  },
  {
   "fieldname": "rate",
@@ -349,7 +350,7 @@
 "index_web_pages_for_search": 1,
 "istable": 1,
 "links": [],
- "modified": "2026-07-18 10:00:00.000000",
+ "modified": "2026-08-07 17:31:31.732720",
 "modified_by": "Administrator",
 "module": "Stock",
 "name": "Packed Item",
--- a/erpnext/stock/doctype/pick_list_item/pick_list_item.json
+++ b/erpnext/stock/doctype/pick_list_item/pick_list_item.json
@@ -126,6 +126,7 @@
   "fieldname": "conversion_factor",
   "fieldtype": "Float",
   "label": "UOM Conversion Factor",
+   "precision": "9",
   "read_only": 1
  },
  {
@@ -307,7 +308,7 @@
 ],
 "istable": 1,
 "links": [],
- "modified": "2026-07-18 10:00:00.000000",
+ "modified": "2026-08-07 17:31:31.732720",
 "modified_by": "Administrator",
 "module": "Stock",
 "name": "Pick List Item",
--- a/erpnext/stock/doctype/purchase_receipt_item/purchase_receipt_item.json
+++ b/erpnext/stock/doctype/purchase_receipt_item/purchase_receipt_item.json
@@ -291,6 +291,7 @@
   "label": "Conversion Factor",
   "oldfieldname": "conversion_factor",
   "oldfieldtype": "Currency",
+   "precision": "9",
   "print_hide": 1,
   "print_width": "100px",
   "reqd": 1,
@@ -1144,7 +1145,7 @@
 "idx": 1,
 "istable": 1,
 "links": [],
- "modified": "2026-07-16 15:00:00.000000",
+ "modified": "2026-08-07 17:31:31.732720",
 "modified_by": "Administrator",
 "module": "Stock",
 "name": "Purchase Receipt Item",
--- a/erpnext/stock/doctype/putaway_rule/putaway_rule.json
+++ b/erpnext/stock/doctype/putaway_rule/putaway_rule.json
@@ -106,12 +106,13 @@
   "fieldtype": "Float",
   "label": "Conversion Factor",
   "no_copy": 1,
+   "precision": "9",
   "read_only": 1
  }
 ],
 "index_web_pages_for_search": 1,
 "links": [],
- "modified": "2024-07-08 09:19:26.711470",
+ "modified": "2026-08-07 17:31:31.732720",
 "modified_by": "Administrator",
 "module": "Stock",
 "name": "Putaway Rule",
--- a/erpnext/stock/doctype/stock_entry_detail/stock_entry_detail.json
+++ b/erpnext/stock/doctype/stock_entry_detail/stock_entry_detail.json
@@ -257,6 +257,7 @@
   "label": "Conversion Factor",
   "oldfieldname": "conversion_factor",
   "oldfieldtype": "Currency",
+   "precision": "9",
   "print_hide": 1,
   "reqd": 1
  },
@@ -700,7 +701,7 @@
 "index_web_pages_for_search": 1,
 "istable": 1,
 "links": [],
- "modified": "2026-07-18 10:00:00.000000",
+ "modified": "2026-08-07 17:31:31.732720",
 "modified_by": "Administrator",
 "module": "Stock",
 "name": "Stock Entry Detail",
--- a/erpnext/stock/doctype/uom_conversion_detail/uom_conversion_detail.json
+++ b/erpnext/stock/doctype/uom_conversion_detail/uom_conversion_detail.json
@@ -28,7 +28,8 @@
   "label": "Conversion Factor",
   "non_negative": 1,
   "oldfieldname": "conversion_factor",
-   "oldfieldtype": "Float"
+   "oldfieldtype": "Float",
+   "precision": "9"
  },
  {
   "fieldname": "column_break_nmeg",
@@ -38,7 +39,7 @@
 "idx": 1,
 "istable": 1,
 "links": [],
- "modified": "2026-06-11 23:02:54.800673",
+ "modified": "2026-08-07 17:31:31.732720",
 "modified_by": "Administrator",
 "module": "Stock",
 "name": "UOM Conversion Detail",
--- a/erpnext/subcontracting/doctype/subcontracting_bom/subcontracting_bom.json
+++ b/erpnext/subcontracting/doctype/subcontracting_bom/subcontracting_bom.json
@@ -107,6 +107,7 @@
   "fieldname": "conversion_factor",
   "fieldtype": "Float",
   "label": "Conversion Factor",
+   "precision": "9",
   "read_only": 1
  },
  {
@@ -128,7 +129,7 @@
 ],
 "index_web_pages_for_search": 1,
 "links": [],
- "modified": "2024-03-27 13:10:45.904619",
+ "modified": "2026-08-07 17:31:31.732720",
 "modified_by": "Administrator",
 "module": "Subcontracting",
 "name": "Subcontracting BOM",
--- a/erpnext/subcontracting/doctype/subcontracting_inward_order_item/subcontracting_inward_order_item.json
+++ b/erpnext/subcontracting/doctype/subcontracting_inward_order_item/subcontracting_inward_order_item.json
@@ -87,6 +87,7 @@
   "fieldtype": "Float",
   "hidden": 1,
   "label": "Conversion Factor",
+   "precision": "9",
   "read_only": 1
  },
  {
@@ -186,7 +187,7 @@
 "index_web_pages_for_search": 1,
 "istable": 1,
 "links": [],
- "modified": "2025-10-18 18:04:04.204651",
+ "modified": "2026-08-07 17:31:31.732720",
 "modified_by": "Administrator",
 "module": "Subcontracting",
 "name": "Subcontracting Inward Order Item",
--- a/erpnext/subcontracting/doctype/subcontracting_order_item/subcontracting_order_item.json
+++ b/erpnext/subcontracting/doctype/subcontracting_order_item/subcontracting_order_item.json
@@ -174,6 +174,7 @@
   "fieldtype": "Float",
   "hidden": 1,
   "label": "Conversion Factor",
+   "precision": "9",
   "read_only": 1
  },
  {
@@ -425,7 +426,7 @@
 "index_web_pages_for_search": 1,
 "istable": 1,
 "links": [],
- "modified": "2026-02-27 23:03:36.436504",
+ "modified": "2026-08-07 17:31:31.732720",
 "modified_by": "Administrator",
 "module": "Subcontracting",
 "name": "Subcontracting Order Item",
--- a/erpnext/subcontracting/doctype/subcontracting_order_supplied_item/subcontracting_order_supplied_item.json
+++ b/erpnext/subcontracting/doctype/subcontracting_order_supplied_item/subcontracting_order_supplied_item.json
@@ -63,6 +63,7 @@
   "fieldtype": "Float",
   "hidden": 1,
   "label": "Conversion Factor",
+   "precision": "9",
   "read_only": 1
  },
  {
@@ -176,7 +177,7 @@
 "hide_toolbar": 1,
 "istable": 1,
 "links": [],
- "modified": "2025-10-30 16:00:43.379828",
+ "modified": "2026-08-07 17:31:31.732720",
 "modified_by": "Administrator",
 "module": "Subcontracting",
 "name": "Subcontracting Order Supplied Item",
--- a/erpnext/subcontracting/doctype/subcontracting_receipt_item/subcontracting_receipt_item.json
+++ b/erpnext/subcontracting/doctype/subcontracting_receipt_item/subcontracting_receipt_item.json
@@ -205,6 +205,7 @@
   "fieldtype": "Float",
   "hidden": 1,
   "label": "Conversion Factor",
+   "precision": "9",
   "read_only": 1
  },
  {
@@ -657,7 +658,7 @@
 "idx": 1,
 "istable": 1,
 "links": [],
- "modified": "2026-07-18 10:00:00.000000",
+ "modified": "2026-08-07 17:31:31.732720",
 "modified_by": "Administrator",
 "module": "Subcontracting",
 "name": "Subcontracting Receipt Item",
--- a/erpnext/subcontracting/doctype/subcontracting_receipt_supplied_item/subcontracting_receipt_supplied_item.json
+++ b/erpnext/subcontracting/doctype/subcontracting_receipt_supplied_item/subcontracting_receipt_supplied_item.json
@@ -134,6 +134,7 @@
   "fieldtype": "Float",
   "hidden": 1,
   "label": "Conversion Factor",
+   "precision": "9",
   "read_only": 1
  },
  {
@@ -275,7 +276,7 @@
 "idx": 1,
 "istable": 1,
 "links": [],
- "modified": "2026-07-18 10:00:00.000000",
+ "modified": "2026-08-07 17:31:31.732720",
 "modified_by": "Administrator",
 "module": "Subcontracting",
 "name": "Subcontracting Receipt Supplied Item",