fix: linter and sider issues

This commit is contained in:
Rucha Mahabal
2021-04-04 19:54:00 +05:30
parent 8c055b5469
commit 19c3286b06
4 changed files with 25 additions and 25 deletions

View File

@@ -112,7 +112,7 @@ class TestExpenseClaim(unittest.TestCase):
def test_expense_approver_perms(self): def test_expense_approver_perms(self):
user = "test_approver_perm_emp@example.com" user = "test_approver_perm_emp@example.com"
approver = make_employee(user, "_Test Company") make_employee(user, "_Test Company")
# check doc shared # check doc shared
payable_account = get_payable_account("_Test Company") payable_account = get_payable_account("_Test Company")
@@ -165,7 +165,7 @@ def make_expense_claim(payable_account, amount, sanctioned_amount, company, acco
"payable_account": payable_account, "payable_account": payable_account,
"approval_status": "Approved", "approval_status": "Approved",
"company": company, "company": company,
'currency': currency, "currency": currency,
"expenses": [{ "expenses": [{
"expense_type": "Travel", "expense_type": "Travel",
"default_account": account, "default_account": account,

View File

@@ -569,7 +569,7 @@ class TestLeaveApplication(unittest.TestCase):
def test_leave_approver_perms(self): def test_leave_approver_perms(self):
employee = get_employee() employee = get_employee()
user = "test_approver_perm_emp@example.com" user = "test_approver_perm_emp@example.com"
approver = make_employee(user, "_Test Company") make_employee(user, "_Test Company")
# set approver for employee # set approver for employee
employee.reload() employee.reload()

View File

@@ -34,8 +34,8 @@ def validate_leave_allocation_against_leave_application(ledger):
""", (ledger.employee, ledger.leave_type, ledger.from_date, ledger.to_date)) """, (ledger.employee, ledger.leave_type, ledger.from_date, ledger.to_date))
if leave_application_records: if leave_application_records:
frappe.throw(_("Leave allocation %s is linked with leave application %s" frappe.throw(_("Leave allocation {0} is linked with the Leave Application {1}").format(
% (ledger.transaction_name, ', '.join(leave_application_records)))) ledger.transaction_name, ', '.join(leave_application_records)))
def create_leave_ledger_entry(ref_doc, args, submit=True): def create_leave_ledger_entry(ref_doc, args, submit=True):
ledger = frappe._dict( ledger = frappe._dict(

View File

@@ -37,7 +37,7 @@ class TestShiftRequest(unittest.TestCase):
def test_shift_request_approver_perms(self): def test_shift_request_approver_perms(self):
employee = frappe.get_doc("Employee", "_T-Employee-00001") employee = frappe.get_doc("Employee", "_T-Employee-00001")
user = "test_approver_perm_emp@example.com" user = "test_approver_perm_emp@example.com"
approver = make_employee(user, "_Test Company") make_employee(user, "_Test Company")
# set approver for employee # set approver for employee
employee.reload() employee.reload()