nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-31 02:44:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(plaid): do not send null list in account ids (#23375)

Browse Source
This commit is contained in:
Mangesh-Khairnar
2020-09-21 18:04:34 +05:30
committed by GitHub
parent af585aae28
commit 19365d6d07
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
erpnext/erpnext_integrations/doctype/plaid_settings/plaid_connector.py
View File

@@ -46,7 +46,7 @@ class PlaidConnector():
try: try:
response = self.client.LinkToken.create(token_request) response = self.client.LinkToken.create(token_request)
except InvalidRequestError as e: except InvalidRequestError:
frappe.log_error(frappe.get_traceback(), _("Plaid invalid request error")) frappe.log_error(frappe.get_traceback(), _("Plaid invalid request error"))
frappe.msgprint(_("Please check your Plaid client ID and secret values")) frappe.msgprint(_("Please check your Plaid client ID and secret values"))
except APIError as e: except APIError as e:
@@ -72,10 +72,16 @@ class PlaidConnector():
def get_transactions(self, start_date, end_date, account_id=None): def get_transactions(self, start_date, end_date, account_id=None):
self.auth() self.auth()
account_ids = list(account_id) if account_id else None kwargs = dict(
access_token=self.access_token,
start_date=start_date,
end_date=end_date
)
if account_id:
kwargs.update(dict(account_ids=[account_id]))
try: try:
response = self.client.Transactions.get(self.access_token, start_date=start_date, end_date=end_date, account_ids=account_ids) response = self.client.Transactions.get(**kwargs)
transactions = response["transactions"] transactions = response["transactions"]
while len(transactions) < response["total_transactions"]: while len(transactions) < response["total_transactions"]:
response = self.client.Transactions.get(self.access_token, start_date=start_date, end_date=end_date, offset=len(transactions)) response = self.client.Transactions.get(self.access_token, start_date=start_date, end_date=end_date, offset=len(transactions))