From b8a7f6dac1bff8f54868ae1251b9beb02f6f45e8 Mon Sep 17 00:00:00 2001 From: ljain112 Date: Mon, 14 Apr 2025 19:06:22 +0530 Subject: [PATCH] fix: correct error message in validate_internal_transfer_qty (cherry picked from commit 5063f1174e5d6013ba14afedf6849b98ce0c65f8) --- erpnext/controllers/stock_controller.py | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/erpnext/controllers/stock_controller.py b/erpnext/controllers/stock_controller.py index 10799744d41..d07723f02df 100644 --- a/erpnext/controllers/stock_controller.py +++ b/erpnext/controllers/stock_controller.py @@ -1153,6 +1153,12 @@ class StockController(AccountsController): if self.doctype not in ["Purchase Invoice", "Purchase Receipt"]: return + self.__inter_company_reference = ( + self.get("inter_company_reference") + if self.doctype == "Purchase Invoice" + else self.get("inter_company_invoice_reference") + ) + item_wise_transfer_qty = self.get_item_wise_inter_transfer_qty() if not item_wise_transfer_qty: return @@ -1182,15 +1188,11 @@ class StockController(AccountsController): bold(key[1]), bold(flt(transferred_qty, precision)), bold(parent_doctype), - get_link_to_form(parent_doctype, self.get("inter_company_reference")), + get_link_to_form(parent_doctype, self.__inter_company_reference), ) ) def get_item_wise_inter_transfer_qty(self): - reference_field = "inter_company_reference" - if self.doctype == "Purchase Invoice": - reference_field = "inter_company_invoice_reference" - parent_doctype = { "Purchase Receipt": "Delivery Note", "Purchase Invoice": "Sales Invoice", @@ -1210,7 +1212,7 @@ class StockController(AccountsController): child_tab.item_code, child_tab.qty, ) - .where((parent_tab.name == self.get(reference_field)) & (parent_tab.docstatus == 1)) + .where((parent_tab.name == self.__inter_company_reference) & (parent_tab.docstatus == 1)) ) data = query.run(as_dict=True)