From 339b6692fe8ce09d50a47ef798c35197b6b810d6 Mon Sep 17 00:00:00 2001 From: Corentin Flr <10946971+cogk@users.noreply.github.com> Date: Thu, 13 Jun 2024 18:11:00 +0200 Subject: [PATCH] fix(SO): Fix logic to check if supplier has changed --- erpnext/selling/doctype/sales_order/sales_order.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/erpnext/selling/doctype/sales_order/sales_order.py b/erpnext/selling/doctype/sales_order/sales_order.py index 592a8eacfcf..6bf0aaf1901 100755 --- a/erpnext/selling/doctype/sales_order/sales_order.py +++ b/erpnext/selling/doctype/sales_order/sales_order.py @@ -541,9 +541,7 @@ class SalesOrder(SellingController): for item in self.items: if item.supplier: - supplier = frappe.db.get_value( - "Sales Order Item", {"parent": self.name, "item_code": item.item_code}, "supplier" - ) + supplier = frappe.db.get_value("Sales Order Item", item.name, "supplier") if item.ordered_qty > 0.0 and item.supplier != supplier: exc_list.append( _("Row #{0}: Not allowed to change Supplier as Purchase Order already exists").format(