From 1800ce27805db6b44b94955007e9855a7e072a8a Mon Sep 17 00:00:00 2001 From: GangaManoj Date: Fri, 14 Jan 2022 15:33:16 +0530 Subject: [PATCH] fix: Only allow posting of Depreciation Entries if the Asset is in the Submitted or Partially Depreciated state --- erpnext/assets/doctype/asset/depreciation.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/erpnext/assets/doctype/asset/depreciation.py b/erpnext/assets/doctype/asset/depreciation.py index 251fe3fa493..dd2c531d107 100644 --- a/erpnext/assets/doctype/asset/depreciation.py +++ b/erpnext/assets/doctype/asset/depreciation.py @@ -34,6 +34,8 @@ def make_depreciation_entry(asset_name, date=None): date = today() asset = frappe.get_doc("Asset", asset_name) + validate_asset(asset) + fixed_asset_account, accumulated_depreciation_account, depreciation_expense_account = \ get_depreciation_accounts(asset) @@ -101,6 +103,10 @@ def make_depreciation_entry(asset_name, date=None): return asset +def validate_asset(asset): + if asset.status not in ['Submitted', 'Partially Depreciated']: + frappe.throw(_("Cannot depreciate {0} Asset").format(asset.status)) + def get_depreciation_accounts(asset): fixed_asset_account = accumulated_depreciation_account = depreciation_expense_account = None