nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-06-02 19:59:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #24579 from marination/acc-dimension-update-hotfix

Browse Source 
fix: Avoid changing Ref. Doctype in Accounting Dimension after creation
This commit is contained in:
Deepesh Garg
2021-02-09 06:52:45 +05:30
committed by GitHub
parent 1618c92142 1118949867
commit 179d82615f
2 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
erpnext/accounts/doctype/accounting_dimension/accounting_dimension.js
View File

@@ -41,6 +41,8 @@ frappe.ui.form.on('Accounting Dimension', {
}); });
}); });
} }
frm.toggle_enable('document_type', frm.doc.__islocal);
}, },
document_type: function(frm) { document_type: function(frm) {

10
erpnext/accounts/doctype/accounting_dimension/accounting_dimension.py
View File

@@ -29,6 +29,16 @@ class AccountingDimension(Document):
if exists and self.is_new(): if exists and self.is_new():
frappe.throw("Document Type already used as a dimension") frappe.throw("Document Type already used as a dimension")
if not self.is_new():
self.validate_document_type_change()
def validate_document_type_change(self):
doctype_before_save = frappe.db.get_value("Accounting Dimension", self.name, "document_type")
if doctype_before_save != self.document_type:
message = _("Cannot change Reference Document Type.")
message += _("Please create a new Accounting Dimension if required.")
frappe.throw(message)
def after_insert(self): def after_insert(self):
if frappe.flags.in_test: if frappe.flags.in_test:
make_dimension_in_accounting_doctypes(doc=self) make_dimension_in_accounting_doctypes(doc=self)