nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-06-04 12:49:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(Employee): set user image and validate user id only if user data is found (#29452)

Browse Source
This commit is contained in:
Rucha Mahabal
2022-01-25 16:49:53 +05:30
committed by GitHub
parent 034773a670
commit 177a209f50
1 changed files with 12 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
erpnext/hr/doctype/employee/employee.py
View File

@@ -68,12 +68,18 @@ class Employee(NestedSet):
self.employee_name = ' '.join(filter(lambda x: x, [self.first_name, self.middle_name, self.last_name])) self.employee_name = ' '.join(filter(lambda x: x, [self.first_name, self.middle_name, self.last_name]))
def validate_user_details(self): def validate_user_details(self):
data = frappe.db.get_value('User', if self.user_id:
self.user_id, ['enabled', 'user_image'], as_dict=1) data = frappe.db.get_value("User",
if data.get("user_image") and self.image == '': self.user_id, ["enabled", "user_image"], as_dict=1)
self.image = data.get("user_image")
self.validate_for_enabled_user_id(data.get("enabled", 0)) if not data:
self.validate_duplicate_user_id() self.user_id = None
return
if data.get("user_image") and self.image == "":
self.image = data.get("user_image")
self.validate_for_enabled_user_id(data.get("enabled", 0))
self.validate_duplicate_user_id()
def update_nsm_model(self): def update_nsm_model(self):
frappe.utils.nestedset.update_nsm(self) frappe.utils.nestedset.update_nsm(self)