From 16a6a4913eeaad4378fda4a4a8465bf5dd03e002 Mon Sep 17 00:00:00 2001 From: Mihir Kandoi Date: Tue, 30 Jun 2026 12:17:37 +0530 Subject: [PATCH] fix(stock): log Material Request failure without the rolled-back doc (review) After rollback(save_point=reorder_mr) discards the just-inserted Material Request, mr.log_error() left a dangling Error Log reference. Use frappe.log_error(title=...). --- erpnext/stock/reorder_item.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/erpnext/stock/reorder_item.py b/erpnext/stock/reorder_item.py index 8955c7f46e6..dc6168f52ac 100644 --- a/erpnext/stock/reorder_item.py +++ b/erpnext/stock/reorder_item.py @@ -290,7 +290,7 @@ def create_material_request(material_requests): except Exception as exception: frappe.db.rollback(save_point="reorder_mr") exceptions_list.append(exception) - mr.log_error("Unable to create material request") + frappe.log_error(title="Unable to create material request") if company_wise_mr: if getattr(frappe.local, "reorder_email_notify", None) is None: