nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-04-19 14:55:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: consider payment term only when enabled

Browse Source 
(cherry picked from commit b1149fe950)
This commit is contained in:
SowmyaArunachalam
2026-01-28 22:23:10 +05:30
committed by Mergify
parent f7dd730bc3
commit 1470a79a1b
1 changed files with 22 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

45
erpnext/selling/doctype/quotation/quotation.py
View File

@@ -446,34 +446,33 @@ def _make_sales_order(source_name, target_doc=None, ignore_permissions=False, ar
child_filter = d.name in filtered_items if filtered_items else True child_filter = d.name in filtered_items if filtered_items else True
return child_filter return child_filter
doclist = get_mapped_doc(
"Quotation",
source_name,
{
"Quotation": {
"doctype": "Sales Order",
"validation": {"docstatus": ["=", 1]},
},
"Quotation Item": {
"doctype": "Sales Order Item",
"field_map": {"parent": "prevdoc_docname", "name": "quotation_item"},
"postprocess": update_item,
"condition": lambda d: can_map_row(d) and select_item(d),
},
"Sales Taxes and Charges": {"doctype": "Sales Taxes and Charges", "reset_value": True},
"Sales Team": {"doctype": "Sales Team", "add_if_empty": True},
},
target_doc,
set_missing_values,
ignore_permissions=ignore_permissions,
)
automatically_fetch_payment_terms = cint( automatically_fetch_payment_terms = cint(
frappe.get_single_value("Selling Settings", "automatically_fetch_payment_terms_from_quotation") frappe.get_single_value("Selling Settings", "automatically_fetch_payment_terms_from_quotation")
) )
mapping = {
"Quotation": {"doctype": "Sales Order", "validation": {"docstatus": ["=", 1]}},
"Quotation Item": {
"doctype": "Sales Order Item",
"field_map": {"parent": "prevdoc_docname", "name": "quotation_item"},
"postprocess": update_item,
"condition": lambda d: can_map_row(d) and select_item(d),
},
"Sales Taxes and Charges": {"doctype": "Sales Taxes and Charges", "reset_value": True},
"Sales Team": {"doctype": "Sales Team", "add_if_empty": True},
}
if automatically_fetch_payment_terms: if automatically_fetch_payment_terms:
doclist.set_payment_schedule() mapping["Payment Schedule"] = {"doctype": "Payment Schedule", "add_if_empty": True}
doclist = get_mapped_doc(
"Quotation",
source_name,
mapping,
target_doc,
set_missing_values,
ignore_permissions=ignore_permissions,
)
return doclist return doclist