nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-25 16:04:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: code cleanup

Browse Source 
(cherry picked from commit eea260b9f9)
This commit is contained in:
ruthra kumar
2024-03-19 11:18:11 +05:30
committed by Mergify
parent 0ea9ce7a5a
commit 1110dd93ff
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
erpnext/setup/doctype/transaction_deletion_record/transaction_deletion_record.py
View File

@@ -135,7 +135,6 @@ class TransactionDeletionRecord(Document):
job_names = self.generate_job_name_for_next_tasks(task=task) job_names = self.generate_job_name_for_next_tasks(task=task)
self.validate_running_task_for_doc(job_names=job_names) self.validate_running_task_for_doc(job_names=job_names)
# method = self.task_to_internal_method_map[task]
# Generate Job Id to uniquely identify each task for this document # Generate Job Id to uniquely identify each task for this document
job_id = self.generate_job_name_for_task(task) job_id = self.generate_job_name_for_task(task)
@@ -152,7 +151,6 @@ class TransactionDeletionRecord(Document):
def execute_task(self, task_to_execute: str | None = None): def execute_task(self, task_to_execute: str | None = None):
if task_to_execute: if task_to_execute:
pass
method = self.task_to_internal_method_map[task_to_execute] method = self.task_to_internal_method_map[task_to_execute]
if task := getattr(self, method, None): if task := getattr(self, method, None):
task() task()
@@ -312,7 +310,9 @@ class TransactionDeletionRecord(Document):
frappe.db.set_value(docfield.doctype, docfield.name, "done", 1) frappe.db.set_value(docfield.doctype, docfield.name, "done", 1)
pending_doctypes = frappe.db.get_all( pending_doctypes = frappe.db.get_all(
docfield.doctype, filters={"parent": self.name, "done": 0}, pluck="doctype_name" "Transaction Deletion Record Details",
filters={"parent": self.name, "done": 0},
pluck="doctype_name",
) )
if pending_doctypes: if pending_doctypes:
# as method is enqueued after commit, calling itself will not make validate_doc_status to throw # as method is enqueued after commit, calling itself will not make validate_doc_status to throw