From 0cd45a0022440d404b7a6f9a94de804569782f13 Mon Sep 17 00:00:00 2001 From: l0gesh29 Date: Tue, 12 Aug 2025 14:26:18 +0530 Subject: [PATCH] fix: handle default dimension for all company (cherry picked from commit 77021fff74a0e67b94289501b9d494bd2b9b3a51) --- ...ieldname_in_accounting_dimension_filter.py | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/erpnext/patches/v15_0/update_fieldname_in_accounting_dimension_filter.py b/erpnext/patches/v15_0/update_fieldname_in_accounting_dimension_filter.py index 11d2cc91446..25a35bc87fc 100644 --- a/erpnext/patches/v15_0/update_fieldname_in_accounting_dimension_filter.py +++ b/erpnext/patches/v15_0/update_fieldname_in_accounting_dimension_filter.py @@ -11,25 +11,26 @@ def execute(): frappe.qb.from_(ADF) .join(AD) .on(AD.document_type == ADF.accounting_dimension) - .select(ADF.name, AD.fieldname) + .select(ADF.name, AD.fieldname, ADF.accounting_dimension) ).run(as_dict=True) for doc in accounting_dimension_filter: + value = doc.fieldname or frappe.scrub(doc.accounting_dimension) frappe.db.set_value( "Accounting Dimension Filter", doc.name, "fieldname", - doc.fieldname, + value, update_modified=False, ) def default_accounting_dimension(): - for accounting_dimension in ["Cost Center", "Project"]: - frappe.db.set_value( - "Accounting Dimension Filter", - {"accounting_dimension": accounting_dimension}, - "fieldname", - frappe.scrub(accounting_dimension), - update_modified=False, + ADF = DocType("Accounting Dimension Filter") + for dim in ("Cost Center", "Project"): + ( + frappe.qb.update(ADF) + .set(ADF.fieldname, frappe.scrub(dim)) + .where(ADF.accounting_dimension == dim) + .run() )