From 0caba9f70dbefc7aa2114dcd69959a6cf1ea7cb5 Mon Sep 17 00:00:00 2001 From: Lakshit Jain <108322669+ljain112@users.noreply.github.com> Date: Thu, 24 Apr 2025 20:33:30 +0530 Subject: [PATCH] fix: do not check for permission if values are not changed in employee doctype (#47238) --- erpnext/setup/doctype/employee/employee.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/erpnext/setup/doctype/employee/employee.py b/erpnext/setup/doctype/employee/employee.py index 41bc41d5d34..eb5284019da 100755 --- a/erpnext/setup/doctype/employee/employee.py +++ b/erpnext/setup/doctype/employee/employee.py @@ -85,9 +85,10 @@ class Employee(NestedSet): self.reset_employee_emails_cache() def update_user_permissions(self): - if not has_permission("User Permission", ptype="write") or ( - not self.has_value_changed("user_id") and not self.has_value_changed("create_user_permission") - ): + if not self.has_value_changed("user_id") and not self.has_value_changed("create_user_permission"): + return + + if not has_permission("User Permission", ptype="write", raise_exception=False): return employee_user_permission_exists = frappe.db.exists(