refactor: clear records in batches in 'Transaction Deletion Record' (#34109)

refactor: clear records in batches in 'Transaction Deletion Record' (#34109)

refactor: clear records in batches
(cherry picked from commit 4a7b1de2d8)

Co-authored-by: ruthra kumar <ruthra@erpnext.com>
This commit is contained in:
mergify[bot]
2023-02-21 15:06:45 +05:30
committed by GitHub
parent 44c837f862
commit 0bd765b8ca

View File

@@ -3,13 +3,17 @@
import frappe import frappe
from frappe import _ from frappe import _, qb
from frappe.desk.notifications import clear_notifications from frappe.desk.notifications import clear_notifications
from frappe.model.document import Document from frappe.model.document import Document
from frappe.utils import cint from frappe.utils import cint, create_batch
class TransactionDeletionRecord(Document): class TransactionDeletionRecord(Document):
def __init__(self, *args, **kwargs):
super(TransactionDeletionRecord, self).__init__(*args, **kwargs)
self.batch_size = 5000
def validate(self): def validate(self):
frappe.only_for("System Manager") frappe.only_for("System Manager")
self.validate_doctypes_to_be_ignored() self.validate_doctypes_to_be_ignored()
@@ -155,8 +159,9 @@ class TransactionDeletionRecord(Document):
"DocField", filters={"fieldtype": "Table", "parent": doctype}, pluck="options" "DocField", filters={"fieldtype": "Table", "parent": doctype}, pluck="options"
) )
for table in child_tables: for batch in create_batch(parent_docs_to_be_deleted, self.batch_size):
frappe.db.delete(table, {"parent": ["in", parent_docs_to_be_deleted]}) for table in child_tables:
frappe.db.delete(table, {"parent": ["in", batch]})
def delete_docs_linked_with_specified_company(self, doctype, company_fieldname): def delete_docs_linked_with_specified_company(self, doctype, company_fieldname):
frappe.db.delete(doctype, {company_fieldname: self.company}) frappe.db.delete(doctype, {company_fieldname: self.company})
@@ -181,13 +186,16 @@ class TransactionDeletionRecord(Document):
frappe.db.sql("""update `tabSeries` set current = %s where name=%s""", (last, prefix)) frappe.db.sql("""update `tabSeries` set current = %s where name=%s""", (last, prefix))
def delete_version_log(self, doctype, company_fieldname): def delete_version_log(self, doctype, company_fieldname):
frappe.db.sql( dt = qb.DocType(doctype)
"""delete from `tabVersion` where ref_doctype=%s and docname in names = qb.from_(dt).select(dt.name).where(dt[company_fieldname] == self.company).run(as_list=1)
(select name from `tab{0}` where `{1}`=%s)""".format( names = [x[0] for x in names]
doctype, company_fieldname
), if names:
(doctype, self.company), versions = qb.DocType("Version")
) for batch in create_batch(names, self.batch_size):
qb.from_(versions).delete().where(
(versions.ref_doctype == doctype) & (versions.docname.isin(batch))
).run()
def delete_communications(self, doctype, company_fieldname): def delete_communications(self, doctype, company_fieldname):
reference_docs = frappe.get_all(doctype, filters={company_fieldname: self.company}) reference_docs = frappe.get_all(doctype, filters={company_fieldname: self.company})
@@ -199,7 +207,8 @@ class TransactionDeletionRecord(Document):
) )
communication_names = [c.name for c in communications] communication_names = [c.name for c in communications]
frappe.delete_doc("Communication", communication_names, ignore_permissions=True) for batch in create_batch(communication_names, self.batch_size):
frappe.delete_doc("Communication", batch, ignore_permissions=True)
@frappe.whitelist() @frappe.whitelist()