nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-27 00:44:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: make_gle_for_change_amount

Browse Source
This commit is contained in:
barredterra
2024-02-17 20:46:52 +01:00
parent 2ff06af154
commit 0bbf45cd8b
1 changed files with 38 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

77
erpnext/accounts/doctype/sales_invoice/sales_invoice.py
View File

@@ -1492,47 +1492,46 @@ class SalesInvoice(SellingController):
) )
if not skip_change_gl_entries: if not skip_change_gl_entries:
self.make_gle_for_change_amount(gl_entries) gl_entries.extend(self.get_gle_for_change_amount())
def make_gle_for_change_amount(self, gl_entries): def get_gle_for_change_amount(self) -> list[dict]:
if self.change_amount: if not self.change_amount:
if self.account_for_change_amount: return []
gl_entries.append(
self.get_gl_dict(
{
"account": self.debit_to,
"party_type": "Customer",
"party": self.customer,
"against": self.account_for_change_amount,
"debit": flt(self.base_change_amount),
"debit_in_account_currency": flt(self.base_change_amount)
if self.party_account_currency == self.company_currency
else flt(self.change_amount),
"against_voucher": self.return_against
if cint(self.is_return) and self.return_against
else self.name,
"against_voucher_type": self.doctype,
"cost_center": self.cost_center,
"project": self.project,
},
self.party_account_currency,
item=self,
)
)
gl_entries.append( if not self.account_for_change_amount:
self.get_gl_dict( frappe.throw(_("Please set Account for Change Amount"), title=_("Mandatory Field"))
{
"account": self.account_for_change_amount, return [
"against": self.customer, self.get_gl_dict(
"credit": self.base_change_amount, {
"cost_center": self.cost_center, "account": self.debit_to,
}, "party_type": "Customer",
item=self, "party": self.customer,
) "against": self.account_for_change_amount,
) "debit": flt(self.base_change_amount),
else: "debit_in_account_currency": flt(self.base_change_amount)
frappe.throw(_("Select change amount account"), title=_("Mandatory Field")) if self.party_account_currency == self.company_currency
else flt(self.change_amount),
"against_voucher": self.return_against
if cint(self.is_return) and self.return_against
else self.name,
"against_voucher_type": self.doctype,
"cost_center": self.cost_center,
"project": self.project,
},
self.party_account_currency,
item=self,
),
self.get_gl_dict(
{
"account": self.account_for_change_amount,
"against": self.customer,
"credit": self.base_change_amount,
"cost_center": self.cost_center,
},
item=self,
),
]
def make_write_off_gl_entry(self, gl_entries): def make_write_off_gl_entry(self, gl_entries):
# write off entries, applicable if only pos # write off entries, applicable if only pos