From 086d31b59f2a960b463c88ea1c32fac71958b142 Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Sat, 26 Mar 2022 13:06:20 +0530 Subject: [PATCH] fix: dont validate currency exchange in setup Redues ~4-5 seconds of time and chances of setup failure. --- .../currency_exchange_settings.py | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/erpnext/accounts/doctype/currency_exchange_settings/currency_exchange_settings.py b/erpnext/accounts/doctype/currency_exchange_settings/currency_exchange_settings.py index edea37dcfd9..d618c5ca117 100644 --- a/erpnext/accounts/doctype/currency_exchange_settings/currency_exchange_settings.py +++ b/erpnext/accounts/doctype/currency_exchange_settings/currency_exchange_settings.py @@ -11,6 +11,8 @@ from frappe.utils import nowdate class CurrencyExchangeSettings(Document): def validate(self): self.set_parameters_and_result() + if frappe.flags.in_test or frappe.flags.in_install or frappe.flags.in_setup_wizard: + return response, value = self.validate_parameters() self.validate_result(response, value) @@ -35,9 +37,6 @@ class CurrencyExchangeSettings(Document): self.append("req_params", {"key": "symbols", "value": "{to_currency}"}) def validate_parameters(self): - if frappe.flags.in_test: - return None, None - params = {} for row in self.req_params: params[row.key] = row.value.format( @@ -59,9 +58,6 @@ class CurrencyExchangeSettings(Document): return response, value def validate_result(self, response, value): - if frappe.flags.in_test: - return - try: for key in self.result_key: value = value[