nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-08-31 15:32:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: convert trivially-equivalent raw SQL to ORM helpers

Browse Source 
Convert test-only raw frappe.db.sql calls that have an exact ORM
equivalent: full-table/filtered deletes -> frappe.db.delete, count ->
frappe.db.count, row-existence assertions -> frappe.db.exists,
single-row scalar fetches -> frappe.db.get_value, and simple
equality/range-filter selects -> frappe.get_all. No behaviour change.

Raw SQL that genuinely needs it is left as-is (dynamic identifiers,
aggregates/group-by, positional as_list consumers, DB-catalog
introspection).
This commit is contained in:
Mihir Kandoi
2026-06-26 10:44:17 +05:30
parent 0e54e532ff
commit 0776f7f7fa
10 changed files with 49 additions and 79 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
erpnext/support/doctype/issue/test_issue.py
View File

@@ -14,11 +14,11 @@ from erpnext.tests.utils import ERPNextTestSuite
class TestSetUp(ERPNextTestSuite):
def setUp(self):
frappe.db.sql("delete from `tabService Level Agreement`")
frappe.db.sql("delete from `tabService Level Priority`")
frappe.db.sql("delete from `tabSLA Fulfilled On Status`")
frappe.db.sql("delete from `tabPause SLA On Status`")
frappe.db.sql("delete from `tabService Day`")
frappe.db.delete("Service Level Agreement")
frappe.db.delete("Service Level Priority")
frappe.db.delete("SLA Fulfilled On Status")
frappe.db.delete("Pause SLA On Status")
frappe.db.delete("Service Day")
frappe.db.set_single_value("Support Settings", "track_service_level_agreement", 1)
create_service_level_agreements_for_issues()