nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-08-12 14:11:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: implement auto-demotion of other primary contacts in Supplier and Customer import providers

Browse Source
This commit is contained in:
Sumit Jain
2026-08-09 21:53:14 +05:30
parent 179c7c0743
commit 04bea0733b
2 changed files with 38 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
erpnext/buying/doctype/supplier/supplier_import_provider.py
View File

@@ -126,6 +126,11 @@ class SupplierImportProvider(ImportProvider):
if flagged or primary is None:
primary = contact
if primary:
# Contact has no cross-contact auto-demotion (unlike Address's
# validate_preferred_address), so explicitly demote any other primary Contact on
# this party first — otherwise get_default_contact may return a Contact other
# than supplier_primary_contact.
_demote_other_primary_contacts("Supplier", supplier.name, primary.name)
frappe.db.set_value("Contact", primary.name, "is_primary_contact", 1)
supplier.db_set("supplier_primary_contact", primary.name)
supplier.db_set("mobile_no", primary.mobile_no)
@@ -184,6 +189,20 @@ class SupplierImportProvider(ImportProvider):
supplier.db_set("primary_address", get_address_display(primary.name))
def _demote_other_primary_contacts(link_doctype: str, link_name: str, keep: str) -> None:
"""Clear ``is_primary_contact`` on the party's other Contacts (keeps ``keep``)."""
linked = frappe.get_all(
"Dynamic Link",
filters={"link_doctype": link_doctype, "link_name": link_name, "parenttype": "Contact"},
pluck="parent",
)
for other in frappe.get_all(
"Contact", filters={"name": ["in", linked or [""]], "is_primary_contact": 1}, pluck="name"
):
if other != keep:
frappe.db.set_value("Contact", other, "is_primary_contact", 0)
def _doctype_docfields(doctype: str, prefer_plain_label: bool = False) -> list[dict]:
from frappe.model import display_fieldtypes, no_value_fields

19
erpnext/selling/doctype/customer/customer_import_provider.py
View File

@@ -133,6 +133,11 @@ class CustomerImportProvider(ImportProvider):
if flagged or primary is None:
primary = contact
if primary:
# Contact has no cross-contact auto-demotion (unlike Address's
# validate_preferred_address), so explicitly demote any other primary Contact on
# this party first — otherwise get_default_contact may return a Contact other
# than customer_primary_contact.
_demote_other_primary_contacts("Customer", customer.name, primary.name)
frappe.db.set_value("Contact", primary.name, "is_primary_contact", 1)
customer.db_set("customer_primary_contact", primary.name)
customer.db_set("mobile_no", primary.mobile_no)
@@ -192,6 +197,20 @@ class CustomerImportProvider(ImportProvider):
customer.db_set("primary_address", get_address_display(primary.name))
def _demote_other_primary_contacts(link_doctype: str, link_name: str, keep: str) -> None:
"""Clear ``is_primary_contact`` on the party's other Contacts (keeps ``keep``)."""
linked = frappe.get_all(
"Dynamic Link",
filters={"link_doctype": link_doctype, "link_name": link_name, "parenttype": "Contact"},
pluck="parent",
)
for other in frappe.get_all(
"Contact", filters={"name": ["in", linked or [""]], "is_primary_contact": 1}, pluck="name"
):
if other != keep:
frappe.db.set_value("Contact", other, "is_primary_contact", 0)
def _doctype_docfields(doctype: str, prefer_plain_label: bool = False) -> list[dict]:
"""Non-table importable fields of ``doctype`` as complete docfield dicts."""
from frappe.model import display_fieldtypes, no_value_fields