diff --git a/.eslintrc b/.eslintrc index 3b6ab7498d9..e40502acd6c 100644 --- a/.eslintrc +++ b/.eslintrc @@ -151,6 +151,7 @@ "context": true, "before": true, "beforeEach": true, - "onScan": true + "onScan": true, + "extend_cscript": true } } diff --git a/.git-blame-ignore-revs b/.git-blame-ignore-revs index be425ec2d9d..e7fa354a2e9 100644 --- a/.git-blame-ignore-revs +++ b/.git-blame-ignore-revs @@ -8,5 +8,8 @@ # # $ git config blame.ignoreRevsFile .git-blame-ignore-revs +# Replace use of Class.extend with native JS class +1fe891b287a1b3f225d29ee3d07e7b1824aba9e7 + # This commit just changes spaces to tabs for indentation in some files 5f473611bd6ed57703716244a054d3fb5ba9cd23 diff --git a/.github/helper/install.sh b/.github/helper/install.sh index 7b0f944c669..f7a71223436 100644 --- a/.github/helper/install.sh +++ b/.github/helper/install.sh @@ -44,3 +44,4 @@ sed -i 's/redis_socketio:/# redis_socketio:/g' Procfile bench get-app erpnext "${GITHUB_WORKSPACE}" bench start & bench --site test_site reinstall --yes +bench build --app frappe diff --git a/.github/workflows/server-tests.yml b/.github/workflows/server-tests.yml index 92685e2177d..69afa15187d 100644 --- a/.github/workflows/server-tests.yml +++ b/.github/workflows/server-tests.yml @@ -1,6 +1,10 @@ name: Server -on: [pull_request, workflow_dispatch] +on: + pull_request: + workflow_dispatch: + push: + branches: [ develop ] jobs: test: @@ -87,6 +91,7 @@ jobs: coveralls env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + COVERALLS_REPO_TOKEN: ${{ secrets.COVERALLS_TOKEN }} COVERALLS_FLAG_NAME: run-${{ matrix.container }} COVERALLS_SERVICE_NAME: ${{ github.event_name == 'pull_request' && 'github' || 'github-actions' }} COVERALLS_PARALLEL: true diff --git a/.gitignore b/.gitignore index 652fbdc3176..63c51c49765 100644 --- a/.gitignore +++ b/.gitignore @@ -7,6 +7,7 @@ latest_updates.json .wnf-lang-status *.egg-info dist/ +erpnext/public/dist erpnext/docs/current *.swp *.swo diff --git a/README.md b/README.md index 0a556f57b41..c6fc2512445 100644 --- a/README.md +++ b/README.md @@ -5,7 +5,7 @@

ERP made simple

-[![CI](https://github.com/frappe/erpnext/actions/workflows/ci-tests.yml/badge.svg?branch=develop)](https://github.com/frappe/erpnext/actions/workflows/ci-tests.yml) +[![CI](https://github.com/frappe/erpnext/actions/workflows/server-tests.yml/badge.svg?branch=develop)](https://github.com/frappe/erpnext/actions/workflows/server-tests.yml) [![Open Source Helpers](https://www.codetriage.com/frappe/erpnext/badges/users.svg)](https://www.codetriage.com/frappe/erpnext) [![Coverage Status](https://coveralls.io/repos/github/frappe/erpnext/badge.svg?branch=develop)](https://coveralls.io/github/frappe/erpnext?branch=develop) diff --git a/erpnext/__init__.py b/erpnext/__init__.py index a988d7217db..0c96d325c2e 100644 --- a/erpnext/__init__.py +++ b/erpnext/__init__.py @@ -5,7 +5,7 @@ import frappe from erpnext.hooks import regional_overrides from frappe.utils import getdate -__version__ = '13.2.0' +__version__ = '13.6.0' def get_default_company(user=None): '''Get default company for user''' diff --git a/erpnext/accounts/doctype/account/chart_of_accounts/verified/fr_plan_comptable_general.json b/erpnext/accounts/doctype/account/chart_of_accounts/verified/fr_plan_comptable_general.json index da1d10deb97..d60c5596618 100644 --- a/erpnext/accounts/doctype/account/chart_of_accounts/verified/fr_plan_comptable_general.json +++ b/erpnext/accounts/doctype/account/chart_of_accounts/verified/fr_plan_comptable_general.json @@ -1,1609 +1,1609 @@ { - "country_code": "fr", - "name": "France - Plan Comptable General", + "country_code": "fr", + "name": "France - Plan Comptable General", "tree": { "1-Comptes de Capitaux": { "10-Capital et R\u00e9serves": { "101-Capital": { - "1011-Capital souscrit - non appel\u00e9": {}, - "1012-Capital souscrit - appel\u00e9, non vers\u00e9": {}, + "1011-Capital souscrit - non appel\u00e9": {}, + "1012-Capital souscrit - appel\u00e9, non vers\u00e9": {}, "1013-Capital souscrit - appel\u00e9, vers\u00e9": { - "10131-Capital non amorti": {}, + "10131-Capital non amorti": {}, "10132-Capital amorti": {} - }, + }, "1018-Capital souscrit soumis \u00e0 des r\u00e9glementations particuli\u00e8res": {} - }, - "102-Fonds fiduciaires": {}, + }, + "102-Fonds fiduciaires": {}, "104-Primes li\u00e9es au capital social": { - "1041-Primes d'\u00e9mission": {}, - "1042-Primes de fusion": {}, - "1043-Primes d'apport": {}, - "1044-Primes de conversion d'obligations en actions": {}, + "1041-Primes d'\u00e9mission": {}, + "1042-Primes de fusion": {}, + "1043-Primes d'apport": {}, + "1044-Primes de conversion d'obligations en actions": {}, "1045-Bons de souscription d'actions": {} - }, + }, "105-Ecarts de r\u00e9\u00e9valuation": { - "1051-R\u00e9serve sp\u00e9ciale de r\u00e9\u00e9valuation": {}, - "1052-Ecart de r\u00e9\u00e9valuation libre": {}, - "1053-R\u00e9serve de r\u00e9\u00e9valuation": {}, - "1055-Ecarts de r\u00e9\u00e9valuation (autres op\u00e9rations l\u00e9gales)": {}, - "1057-Autres \u00e9carts de r\u00e9\u00e9valuation en France": {}, + "1051-R\u00e9serve sp\u00e9ciale de r\u00e9\u00e9valuation": {}, + "1052-Ecart de r\u00e9\u00e9valuation libre": {}, + "1053-R\u00e9serve de r\u00e9\u00e9valuation": {}, + "1055-Ecarts de r\u00e9\u00e9valuation (autres op\u00e9rations l\u00e9gales)": {}, + "1057-Autres \u00e9carts de r\u00e9\u00e9valuation en France": {}, "1058-Autres \u00e9carts de r\u00e9\u00e9valuation \u00e0 l'\u00e9tranger": {} - }, + }, "106-R\u00e9serves": { "1061-R\u00e9serve l\u00e9gale": { - "10611-R\u00e9serve l\u00e9gale proprement dite": {}, + "10611-R\u00e9serve l\u00e9gale proprement dite": {}, "10612-Plus-values nettes \u00e0 long terme": {} - }, - "1062-R\u00e9serves indisponibles": {}, - "1063-R\u00e9serves statutaires ou contractuelles": {}, + }, + "1062-R\u00e9serves indisponibles": {}, + "1063-R\u00e9serves statutaires ou contractuelles": {}, "1064-R\u00e9serves r\u00e9glement\u00e9es": { - "10641-Plus-values nettes \u00e0 long terme": {}, - "10643-R\u00e9serves cons\u00e9cutives \u00e0 l'octroi de subventions d'investissement": {}, + "10641-Plus-values nettes \u00e0 long terme": {}, + "10643-R\u00e9serves cons\u00e9cutives \u00e0 l'octroi de subventions d'investissement": {}, "10648-Autres r\u00e9serves r\u00e9glement\u00e9es": {} - }, + }, "1068-Autres r\u00e9serves": { - "10681-R\u00e9serve de propre assureur": {}, + "10681-R\u00e9serve de propre assureur": {}, "10688-R\u00e9serves diverses": {} } - }, - "107-Ecarts d'\u00e9quivalence": {}, - "108-Compte de l'exploitant": {}, + }, + "107-Ecarts d'\u00e9quivalence": {}, + "108-Compte de l'exploitant": {}, "109-Actionnaires: Capital souscrit - non appel\u00e9": {} - }, + }, "11-Report \u00e0 Nouveau": { - "110-Report \u00e0 nouveau (solde cr\u00e9diteur)": {}, + "110-Report \u00e0 nouveau (solde cr\u00e9diteur)": {}, "119-Report \u00e0 nouveau (solde d\u00e9biteur)": {} - }, + }, "12-R\u00e9sultat de l'Exercice": { - "120-R\u00e9sultat de l'exercice (b\u00e9n\u00e9fice)": {}, + "120-R\u00e9sultat de l'exercice (b\u00e9n\u00e9fice)": {}, "129-R\u00e9sultat de l'exercice (perte)": {} - }, + }, "13-Subventions d'Investissement": { "131-Subventions d'\u00e9quipement": { - "1311-Etat": {}, - "1312-R\u00e9gions": {}, - "1313-D\u00e9partements": {}, - "1314-Communes": {}, - "1315-Collectivit\u00e9s publiques": {}, - "1316-Entreprises publiques": {}, - "1317-Entreprises et organismes priv\u00e9s": {}, + "1311-Etat": {}, + "1312-R\u00e9gions": {}, + "1313-D\u00e9partements": {}, + "1314-Communes": {}, + "1315-Collectivit\u00e9s publiques": {}, + "1316-Entreprises publiques": {}, + "1317-Entreprises et organismes priv\u00e9s": {}, "1318-Autres": {} - }, - "138-Autres subventions d'investissement (m\u00eame ventilation que celle du compte 131)": {}, + }, + "138-Autres subventions d'investissement (m\u00eame ventilation que celle du compte 131)": {}, "139-Subventions d'investissement inscrites au compte de r\u00e9sultat": { "1391-Subventions d'\u00e9quipement": { - "13911-Subventions d'\u00e9quipement": { - "13911-Etat": {}, - "13912-R\u00e9gions": {}, - "13913-D\u00e9partements": {}, - "13914-Communes": {}, - "13915-Collectivit\u00e9s publiques": {}, - "13916-Entreprises publiques": {}, - "13917-Entreprises et organismes priv\u00e9s": {}, - "13918-Autres": {} - } - }, + "13911-Etat": {}, + "13912-R\u00e9gions": {}, + "13913-D\u00e9partements": {}, + "13914-Communes": {}, + "13915-Collectivit\u00e9s publiques": {}, + "13916-Entreprises publiques": {}, + "13917-Entreprises et organismes priv\u00e9s": {}, + "13918-Autres": {} + }, "1398-Autres subventions d'investissement (m\u00eame ventilation que celle du compte 1391)": {} } - }, + }, "14-Provisions R\u00e9glement\u00e9es": { "142-Provisions r\u00e9glement\u00e9es relative aux immobilisations": { - "1423-Provisions pour reconstitution des gisements miniers et p\u00e9troliers": {}, + "1423-Provisions pour reconstitution des gisements miniers et p\u00e9troliers": {}, "1424-Provisions pour investissement (participation des salari\u00e9s)": {} - }, + }, "143-Provisions r\u00e9glement\u00e9es relatives aux stocks": { - "1431-Hausse des prix": {}, + "1431-Hausse des prix": {}, "1432-Fluctuation des cours": {} - }, - "144-Provisions r\u00e9glement\u00e9es relatives aux autres \u00e9l\u00e9ments de l'actif": {}, - "145-Amortissements d\u00e9rogatoires": {}, - "146-Provision sp\u00e9ciale de r\u00e9\u00e9valuation": {}, - "147-Plus-values r\u00e9investies": {}, + }, + "144-Provisions r\u00e9glement\u00e9es relatives aux autres \u00e9l\u00e9ments de l'actif": {}, + "145-Amortissements d\u00e9rogatoires": {}, + "146-Provision sp\u00e9ciale de r\u00e9\u00e9valuation": {}, + "147-Plus-values r\u00e9investies": {}, "148-Autres provisions r\u00e9glement\u00e9es": {} - }, + }, "15-Provisions": { "151-Provisions pour risques": { - "1511-Provisions pour litiges": {}, - "1512-Provisions pour garanties donn\u00e9es aux clients": {}, - "1513-Provisions pour pertes sur march\u00e9s \u00e0 terme": {}, - "1514-Provisions pour amendes et p\u00e9nalit\u00e9s": {}, - "1515-Provisions pour pertes de change": {}, - "1516-Provisions pour pertes sur contrats": {}, + "1511-Provisions pour litiges": {}, + "1512-Provisions pour garanties donn\u00e9es aux clients": {}, + "1513-Provisions pour pertes sur march\u00e9s \u00e0 terme": {}, + "1514-Provisions pour amendes et p\u00e9nalit\u00e9s": {}, + "1515-Provisions pour pertes de change": {}, + "1516-Provisions pour pertes sur contrats": {}, "1518-Autres provisions pour risques": {} - }, - "153-Provisions pour pensions et obligations similaires": {}, - "154-Provisions pour restructurations": {}, - "155-Provisions pour imp\u00f4ts": {}, - "156-Provisions pour renouvellement des immobilisations (entreprises concessionnaires) ": {}, + }, + "153-Provisions pour pensions et obligations similaires": {}, + "154-Provisions pour restructurations": {}, + "155-Provisions pour imp\u00f4ts": {}, + "156-Provisions pour renouvellement des immobilisations (entreprises concessionnaires) ": {}, "157-Provisions pour charges \u00e0 r\u00e9partir sur plusieurs exercices": { "1572-Provisions pour gros entretien ou grandes r\u00e9visions": {} - }, + }, "158-Autres provisions pour charges": { "1581-Provisions pour remises en \u00e9tat": {} } - }, + }, "16-Emprunts et Dettes Assimil\u00e9es": { - "161-Emprunts obligataires convertibles": {}, - "162-Obligations repr\u00e9sentatives de passifs nets remis en fiducie": {}, - "163-Autres emprunts obligataires": {}, - "164-Emprunts aupr\u00e8s des \u00e9tablissements de cr\u00e9dit": {}, + "161-Emprunts obligataires convertibles": {}, + "162-Obligations repr\u00e9sentatives de passifs nets remis en fiducie": {}, + "163-Autres emprunts obligataires": {}, + "164-Emprunts aupr\u00e8s des \u00e9tablissements de cr\u00e9dit": {}, "165-D\u00e9p\u00f4ts et cautionnements re\u00e7us": { - "1651-D\u00e9p\u00f4ts": {}, + "1651-D\u00e9p\u00f4ts": {}, "1655-Cautionnements": {} - }, + }, "166-Participation des salari\u00e9s aux r\u00e9sultats": { - "1661-Comptes bloqu\u00e9s": {}, + "1661-Comptes bloqu\u00e9s": {}, "1662-Fonds de participation": {} - }, + }, "167-Emprunts et dettes assortis de conditions particuli\u00e8res": { - "1671-Emissions de titres participatifs": {}, - "1674-Avances conditionn\u00e9es de l'Etat": {}, + "1671-Emissions de titres participatifs": {}, + "1674-Avances conditionn\u00e9es de l'Etat": {}, "1675-Emprunts participatifs": {} - }, + }, "168-Autres emprunts et dettes assimil\u00e9es": { - "1681-Autres emprunts": {}, - "1685-Rentes viag\u00e8res capitalis\u00e9es": {}, - "1687-Autres dettes": {}, + "1681-Autres emprunts": {}, + "1685-Rentes viag\u00e8res capitalis\u00e9es": {}, + "1687-Autres dettes": {}, "1688-Int\u00e9r\u00eats courus": { - "16881-Int\u00e9r\u00eats courus sur emprunts obligataires convertibles": {}, - "16883-Int\u00e9r\u00eats courus sur autres emprunts obligataires": {}, - "16884-Int\u00e9r\u00eats courus sur emprunts aupr\u00e8s des \u00e9tablissements de cr\u00e9dit": {}, - "16885-Int\u00e9r\u00eats courus sur d\u00e9p\u00f4ts et cautionnements re\u00e7us": {}, - "16886-Int\u00e9r\u00eats courus sur participation des salari\u00e9s aux r\u00e9sultats": {}, - "16887-Int\u00e9r\u00eats courus sur emprunts et dettes assortis de conditions particuli\u00e8res": {}, + "16881-Int\u00e9r\u00eats courus sur emprunts obligataires convertibles": {}, + "16883-Int\u00e9r\u00eats courus sur autres emprunts obligataires": {}, + "16884-Int\u00e9r\u00eats courus sur emprunts aupr\u00e8s des \u00e9tablissements de cr\u00e9dit": {}, + "16885-Int\u00e9r\u00eats courus sur d\u00e9p\u00f4ts et cautionnements re\u00e7us": {}, + "16886-Int\u00e9r\u00eats courus sur participation des salari\u00e9s aux r\u00e9sultats": {}, + "16887-Int\u00e9r\u00eats courus sur emprunts et dettes assortis de conditions particuli\u00e8res": {}, "16888-Int\u00e9r\u00eats courus sur autres emprunts et dettes assimil\u00e9es": {} - }, + }, "169-Primes de remboursement des obligations": {} } - }, + }, "17-Dettes Rattach\u00e9es \u00e0 des Participations": { - "171-Dettes rattach\u00e9es \u00e0 des participations (groupe)": {}, - "174-Dettes rattach\u00e9es \u00e0 des participations (hors groupe)": {}, + "171-Dettes rattach\u00e9es \u00e0 des participations (groupe)": {}, + "174-Dettes rattach\u00e9es \u00e0 des participations (hors groupe)": {}, "178-Dettes rattach\u00e9es \u00e0 des soci\u00e9t\u00e9s en participation": { - "1781-Principal": {}, + "1781-Principal": {}, "1788-Int\u00e9r\u00eats courus": {} } - }, + }, "18-Comptes de liaison des \u00e9tablisssements et soci\u00e9t\u00e9s en participation": { - "181-Comptes de liaison des \u00e9tablissements": {}, - "186-Biens et prestations de services \u00e9chang\u00e9s entre \u00e9tablissements (charges)": {}, - "187-Biens et prestations de services \u00e9chang\u00e9s entre \u00e9tablissements (produits)": {}, + "181-Comptes de liaison des \u00e9tablissements": {}, + "186-Biens et prestations de services \u00e9chang\u00e9s entre \u00e9tablissements (charges)": {}, + "187-Biens et prestations de services \u00e9chang\u00e9s entre \u00e9tablissements (produits)": {}, "188-Comptes de liaison des soci\u00e9t\u00e9s en participation": {} - }, + }, "root_type": "Equity" - }, + }, "2-Comptes d'Immobilisations": { "20-Immobilisations incorporelles": { "201-Frais \u00e9tablissement": { - "2011-Frais de constitution": {}, + "2011-Frais de constitution": {}, "2012-Frais de premier \u00e9tablissement": { - "20121-Frais de prospection": {}, + "20121-Frais de prospection": {}, "20122-Frais de publicit\u00e9": {} - }, + }, "2013-Frais d'augmentation de capital et d'op\u00e9rations diverses (fusions, scissions, transformations)": {} - }, - "203-Frais de recherche et de d\u00e9veloppement": {}, - "205-Concessions et droits similaires, brevets, licences, marques, proc\u00e9d\u00e9s, logiciels, droits et valeurs similaires": {}, - "206-Droit au bail": {}, - "207-Fonds commercial": {}, + }, + "203-Frais de recherche et de d\u00e9veloppement": {}, + "205-Concessions et droits similaires, brevets, licences, marques, proc\u00e9d\u00e9s, logiciels, droits et valeurs similaires": {}, + "206-Droit au bail": {}, + "207-Fonds commercial": {}, "208-Autres immobilisations incorporelles": { "2081-Mali de fusion sur actifs incorporels": {} } - }, + }, "21-Immobilisations corporelles": { "211-Terrains": { "2111-Terrains nus": { "account_type": "Fixed Asset" - }, + }, "2112-Terrains am\u00e9nag\u00e9s": { "account_type": "Fixed Asset" - }, + }, "2113-Sous-sols et sur-sols": { "account_type": "Fixed Asset" - }, + }, "2114-Terrains de carri\u00e8res (tr\u00e9fonds)": { "account_type": "Fixed Asset" - }, + }, "2115-Terrains b\u00e2tis": { "21151-Ensembles immobiliers industriels (A, B)": { "account_type": "Fixed Asset" - }, + }, "21155-Ensembles immobiliers administratifs et commerciaux (A, B)": { "account_type": "Fixed Asset" - }, + }, "21158-Autres ensembles immobiliers": { "211581-Autres ensembles immobiliers affect\u00e9s aux op\u00e9rations professionnelles (A, B)": { "account_type": "Fixed Asset" - }, + }, "211588-Autres ensembles immobiliers affect\u00e9s aux op\u00e9rations non professionnelles (A, B)": { "account_type": "Fixed Asset" - }, + }, "account_type": "Fixed Asset" - }, + }, "account_type": "Fixed Asset" - }, + }, "account_type": "Fixed Asset" - }, + }, "212-Agencements et am\u00e9nagements de terrains (m\u00eame ventilation que celle du compte 211)": { "account_type": "Fixed Asset" - }, + }, "213-Constructions": { "2131-B\u00e2timents": { "21311-Ensembles immobiliers industriels (A, B)": { "account_type": "Fixed Asset" - }, + }, "21315-Ensembles immobiliers administratifs et commerciaux (A, B)": { "account_type": "Fixed Asset" - }, + }, "21318-Autres ensembles immobiliers": { "213181-Autres ensembles immobiliers affect\u00e9s aux op\u00e9rations professionnelles (A, B)": { "account_type": "Fixed Asset" - }, + }, "213188-Autres ensembles immobiliers affect\u00e9s aux op\u00e9rations non professionnelles (A, B)": { "account_type": "Fixed Asset" - }, + }, "account_type": "Fixed Asset" - }, + }, "account_type": "Fixed Asset" - }, + }, "2135-Installations g\u00e9n\u00e9rales, agencements, am\u00e9nagements des constructions": { "21351-Ensembles immobiliers industriels (A, B)": { "account_type": "Fixed Asset" - }, + }, "21355-Ensembles immobiliers administratifs et commerciaux (A, B)": { "account_type": "Fixed Asset" - }, + }, "21358-Autres ensembles immobiliers": { "213581-Autres ensembles immobiliers affect\u00e9s aux op\u00e9rations professionnelles (A, B)": { "account_type": "Fixed Asset" - }, + }, "213588-Autres ensembles immobiliers affect\u00e9s aux op\u00e9rations non professionnelles (A, B)": { "account_type": "Fixed Asset" - }, + }, "account_type": "Fixed Asset" - }, + }, "account_type": "Fixed Asset" - }, + }, "2138-Ouvrages d'infrastructure": { "21381-Voies de terre": { "account_type": "Fixed Asset" - }, + }, "21382-Voies de fer": { "account_type": "Fixed Asset" - }, + }, "21383-Voies d'eau": { "account_type": "Fixed Asset" - }, + }, "21384-Barrages": { "account_type": "Fixed Asset" - }, + }, "21385-Pistes d'a\u00e9rodromes": { "account_type": "Fixed Asset" - }, + }, "account_type": "Fixed Asset" - }, + }, "account_type": "Fixed Asset" - }, + }, "214-Constructions sur sol d'autrui (m\u00eame ventilation que celle du compte 213)": { "account_type": "Fixed Asset" - }, + }, "215-Installations techniques, mat\u00e9riel et outillage industriels": { "2151-Installations complexes sp\u00e9cialis\u00e9es": { "21511-Installations complexes sp\u00e9cialis\u00e9es - sur sol propre": { "account_type": "Fixed Asset" - }, + }, "21514-Installations complexes sp\u00e9cialis\u00e9es - sur sol d'autrui": { "account_type": "Fixed Asset" - }, + }, "account_type": "Fixed Asset" - }, + }, "2153-Installations \u00e0 caract\u00e8re sp\u00e9cifique": { "21531-Installations \u00e0 caract\u00e8re sp\u00e9cifique - sur sol propre": { "account_type": "Fixed Asset" - }, + }, "21534-Installations \u00e0 caract\u00e8re sp\u00e9cifique - sur sol d'autrui": { "account_type": "Fixed Asset" - }, + }, "account_type": "Fixed Asset" - }, + }, "2154-Mat\u00e9riel industriel": { "account_type": "Fixed Asset" - }, + }, "2155-Outillage industriel": { "account_type": "Fixed Asset" - }, + }, "2157-Agencements et am\u00e9nagements du mat\u00e9riel et outillage industriel": { "account_type": "Fixed Asset" - }, + }, "account_type": "Fixed Asset" - }, + }, "218-Autres immobilisations corporelles": { "2181-Installations g\u00e9n\u00e9rales, agencements, am\u00e9nagements divers": { "account_type": "Fixed Asset" - }, + }, "2182-Mat\u00e9riel de transport": { "account_type": "Fixed Asset" - }, + }, "2183-Mat\u00e9riel de bureau et mat\u00e9riel informatique": { "account_type": "Fixed Asset" - }, + }, "2184-Mobilier": { "account_type": "Fixed Asset" - }, + }, "2185-Cheptel": { "account_type": "Fixed Asset" - }, + }, "2186-Emballages r\u00e9cup\u00e9rables": { "account_type": "Fixed Asset" - }, - "2187-Mali de fusion sur actifs corporels": {}, + }, + "2187-Mali de fusion sur actifs corporels": {}, "account_type": "Fixed Asset" - }, + }, "account_type": "Fixed Asset" - }, - "22-Immobilisations mises en concession": {}, + }, + "22-Immobilisations mises en concession": {}, "23-Immobilisations en cours": { "231-Immobilisations corporelles en cours": { - "2312-Terrains": {}, - "2313-Constructions": {}, - "2315-Installations techniques, mat\u00e9riel et outillage industriels": {}, + "2312-Terrains": {}, + "2313-Constructions": {}, + "2315-Installations techniques, mat\u00e9riel et outillage industriels": {}, "2318-Autres immobilisations corporelles": {} - }, - "232-Immobilisations incorporelles en cours": {}, - "237-Avances et acomptes vers\u00e9s sur commandes d'immobilisations incorporelles": {}, + }, + "232-Immobilisations incorporelles en cours": {}, + "237-Avances et acomptes vers\u00e9s sur commandes d'immobilisations incorporelles": {}, "238-Avances et acomptes vers\u00e9s sur commandes d'immobilisations corporelles": { - "2382-Terrains": {}, - "2383-Constructions": {}, - "2385-Installations techniques, mat\u00e9riel et outillage industriels": {}, + "2382-Terrains": {}, + "2383-Constructions": {}, + "2385-Installations techniques, mat\u00e9riel et outillage industriels": {}, "2388-Autres immobilisations corporelles": {} } - }, + }, "25-Parts dans des entreprises li\u00e9es et cr\u00e9ances sur des entreprises li\u00e9es": { "is_group": 1 - }, + }, "26-Participations et cr\u00e9ances rattach\u00e9es \u00e0 des participations": { "261-Titres de participation": { - "2611-Actions": {}, + "2611-Actions": {}, "2618-Autres titres": {} - }, + }, "266-Autres formes de participation": { "2661-Droit repr\u00e9sentatifs d'actifs nets remis en fiducie": {} - }, + }, "267-Cr\u00e9ances rattach\u00e9es \u00e0 des participations": { - "2671-Cr\u00e9ances rattach\u00e9es \u00e0 des participations (groupe)": {}, - "2674-Cr\u00e9ances rattach\u00e9es \u00e0 des participations (hors groupe)": {}, - "2675-Versements repr\u00e9sentatifs d'apports non capitalis\u00e9s (appel de fonds)": {}, - "2676-Avances consolidables": {}, - "2677-Autres cr\u00e9ances rattach\u00e9es \u00e0 des participations": {}, + "2671-Cr\u00e9ances rattach\u00e9es \u00e0 des participations (groupe)": {}, + "2674-Cr\u00e9ances rattach\u00e9es \u00e0 des participations (hors groupe)": {}, + "2675-Versements repr\u00e9sentatifs d'apports non capitalis\u00e9s (appel de fonds)": {}, + "2676-Avances consolidables": {}, + "2677-Autres cr\u00e9ances rattach\u00e9es \u00e0 des participations": {}, "2678-Int\u00e9r\u00eats courus": {} - }, + }, "268-Cr\u00e9ances rattach\u00e9es \u00e0 des soci\u00e9t\u00e9s en participation": { - "2681-Principal": {}, + "2681-Principal": {}, "2688-Int\u00e9r\u00eats courus": {} - }, + }, "269-Versements restant \u00e0 effectuer sur titres de participation non lib\u00e9r\u00e9s": {} - }, + }, "27-Autres immobilisations financi\u00e8res": { "271-Titres immobilis\u00e9s autres que les titres immobilis\u00e9s de l'activit\u00e9 de portefeuille (droit de propri\u00e9t\u00e9)": { - "2711-Actions": {}, + "2711-Actions": {}, "2718-Autres titres": {} - }, + }, "272-Titres immobilis\u00e9s (droit de cr\u00e9ance)": { - "2721-Obligations": {}, + "2721-Obligations": {}, "2722-Bons": {} - }, - "273-Titres immobilis\u00e9s de l'activit\u00e9 de portefeuille": {}, + }, + "273-Titres immobilis\u00e9s de l'activit\u00e9 de portefeuille": {}, "274-Pr\u00eats": { - "2741-Pr\u00eats participatifs": {}, - "2742-Pr\u00eats aux associ\u00e9s": {}, - "2743-Pr\u00eats au personnel": {}, + "2741-Pr\u00eats participatifs": {}, + "2742-Pr\u00eats aux associ\u00e9s": {}, + "2743-Pr\u00eats au personnel": {}, "2748-Autres pr\u00eats": {} - }, + }, "275-D\u00e9p\u00f4ts et cautionnements vers\u00e9s": { - "2751-D\u00e9p\u00f4ts": {}, + "2751-D\u00e9p\u00f4ts": {}, "2755-Cautionnements": {} - }, + }, "276-Autres cr\u00e9ances immobilis\u00e9es": { - "2761-Cr\u00e9ances diverses": {}, + "2761-Cr\u00e9ances diverses": {}, "2768-Int\u00e9r\u00eats courus": { - "27682-Int\u00e9r\u00eats courus sur titres immobilis\u00e9s (droit de cr\u00e9ance)": {}, - "27684-Int\u00e9r\u00eats courus sur pr\u00eats": {}, - "27685-Int\u00e9r\u00eats courus sur d\u00e9p\u00f4ts et cautionnements": {}, + "27682-Int\u00e9r\u00eats courus sur titres immobilis\u00e9s (droit de cr\u00e9ance)": {}, + "27684-Int\u00e9r\u00eats courus sur pr\u00eats": {}, + "27685-Int\u00e9r\u00eats courus sur d\u00e9p\u00f4ts et cautionnements": {}, "27688-Int\u00e9r\u00eats courus sur cr\u00e9ances diverses": {} } - }, + }, "277-(Actions propres ou parts propres)": { - "2771-Actions propres ou parts propres": {}, + "2771-Actions propres ou parts propres": {}, "2772-Actions propres ou parts propres en voie d'annulation": {} - }, - "278-Mali de fusion sur actifs financiers": {}, + }, + "278-Mali de fusion sur actifs financiers": {}, "279-Versements restant \u00e0 effectuer sur titres immobilis\u00e9s non lib\u00e9r\u00e9s": {} - }, + }, "28-Amortissements des immobilisations": { "280-Amortissements des immobilisations incorporelles": { "2801-Frais d'\u00e9tablissement (m\u00eame ventilation que celle du compte 212)": { "account_type": "Accumulated Depreciation" - }, + }, "2803-Frais de recherche et de d\u00e9veloppement": { "account_type": "Accumulated Depreciation" - }, + }, "2805-Concessions et droits similaires, brevets, licences, logiciels, droits et valeurs similaires": { "account_type": "Accumulated Depreciation" - }, + }, "2807-Fonds commercial": { "account_type": "Accumulated Depreciation" - }, + }, "2808-Autres immobilisations incorporelles": { "28081-Mali de fusion sur actifs incorporels": { "account_type": "Accumulated Depreciation" - }, + }, "account_type": "Accumulated Depreciation" - }, + }, "account_type": "Accumulated Depreciation" - }, + }, "281-Amortissements des immobilisations corporelles": { "2811-Terrains de gisement": { "account_type": "Accumulated Depreciation" - }, + }, "2812-Agencements, am\u00e9nagements de terrains (m\u00eame ventilation que celle du compte 212)": { "account_type": "Accumulated Depreciation" - }, + }, "2813-Constructions (m\u00eame ventilation que celle du compte 213)": { "account_type": "Accumulated Depreciation" - }, + }, "2814-Constructions sur sol d'autrui (m\u00eame ventilation que celle du compte du 214)": { "account_type": "Accumulated Depreciation" - }, + }, "2815-Installations techniques, mat\u00e9riel et outillage industriels (m\u00eame ventilation que celle du compte 218)": { "account_type": "Accumulated Depreciation" - }, + }, "2818-Autres immobilisations corporelles (m\u00eame ventilation que celle du compte 218)": { "28187-Mali de fusion sur actifs corporels": { "account_type": "Accumulated Depreciation" - }, + }, "account_type": "Accumulated Depreciation" - }, + }, "account_type": "Accumulated Depreciation" - }, - "282-Amortissements des immobilisations mises en concession": {}, + }, + "282-Amortissements des immobilisations mises en concession": {}, "account_type": "Accumulated Depreciation" - }, + }, "29-D\u00e9pr\u00e9ciations des immobilisations": { "290-D\u00e9pr\u00e9ciations des immobilisations incorporelles": { - "2905-Marques, proc\u00e9d\u00e9s, droits et valeurs similaires": {}, - "2906-Droit au bail": {}, - "2907-Fonds commercial": {}, + "2905-Marques, proc\u00e9d\u00e9s, droits et valeurs similaires": {}, + "2906-Droit au bail": {}, + "2907-Fonds commercial": {}, "2908-Autres immobilisations incorporelles": { "29081-Mali de fusion sur actifs incorporels": {} } - }, + }, "291-D\u00e9pr\u00e9ciations des immobilisations corporelles (m\u00eame ventilation que celle du compte 21)": { "2911-Terrains (autres que terrains de gisement)": { "29187-Mali de fusion sur actifs corporels": {} } - }, - "292-D\u00e9pr\u00e9ciations des immobilisations mises en concession": {}, + }, + "292-D\u00e9pr\u00e9ciations des immobilisations mises en concession": {}, "293-D\u00e9pr\u00e9ciations des immobilisations en cours": { - "2931-Immobilisations corporelles en cours": {}, + "2931-Immobilisations corporelles en cours": {}, "2932-Immobilisations incorporelles en cours": {} - }, + }, "296-D\u00e9pr\u00e9ciations des participations et cr\u00e9ances rattach\u00e9es \u00e0 des participations": { - "2961-Titres de participation": {}, - "2966-Autres formes de participation": {}, - "2967-Cr\u00e9ances rattach\u00e9es \u00e0 des participations (m\u00eame ventilation que celle du compte 267)": {}, + "2961-Titres de participation": {}, + "2966-Autres formes de participation": {}, + "2967-Cr\u00e9ances rattach\u00e9es \u00e0 des participations (m\u00eame ventilation que celle du compte 267)": {}, "2968-Cr\u00e9ances rattach\u00e9es \u00e0 des soci\u00e9t\u00e9s en participation (m\u00eame ventilation que celle du compte 268)": {} - }, + }, "297-D\u00e9pr\u00e9ciations des autres immobilisations financi\u00e8res": { - "2971-Titres immobilis\u00e9s autres que les titres immobilis\u00e9s de l'activit\u00e9 de portefeuille - droit de propri\u00e9t\u00e9": {}, - "2972-Titres immobilis\u00e9s - droit de cr\u00e9ance (m\u00eame ventilation que celle du compte 272)": {}, - "2973- Titres immobilis\u00e9s de l'activit\u00e9 de portefuille": {}, - "2974-Pr\u00eats (m\u00eame ventilation que celle du compte 274)": {}, - "2975-D\u00e9p\u00f4ts et cautionnements vers\u00e9s (m\u00eame ventilation que celle du compte 275)": {}, + "2971-Titres immobilis\u00e9s autres que les titres immobilis\u00e9s de l'activit\u00e9 de portefeuille - droit de propri\u00e9t\u00e9": {}, + "2972-Titres immobilis\u00e9s - droit de cr\u00e9ance (m\u00eame ventilation que celle du compte 272)": {}, + "2973- Titres immobilis\u00e9s de l'activit\u00e9 de portefuille": {}, + "2974-Pr\u00eats (m\u00eame ventilation que celle du compte 274)": {}, + "2975-D\u00e9p\u00f4ts et cautionnements vers\u00e9s (m\u00eame ventilation que celle du compte 275)": {}, "2976-Autres cr\u00e9ances immobilis\u00e9es (m\u00eame ventilation que celle du compte 276)": { "29787-Mali de fusion sur actifs financiers": {} } } - }, + }, "root_type": "Asset" - }, + }, "3-Comptes de Stocks et En-Cours": { "31-Mati\u00e8res premi\u00e8res (et fournitures)": { - "311-Mati\u00e8res (ou groupe) A": {}, - "312-Mati\u00e8res (ou groupe) B": {}, + "311-Mati\u00e8res (ou groupe) A": {}, + "312-Mati\u00e8res (ou groupe) B": {}, "317-Fournitures A, B, C, ...": {} - }, + }, "32-Autres approvisionnements": { "321-Mat\u00e8res consommables": { - "3211-Mati\u00e8res (ou groupe) C": {}, + "3211-Mati\u00e8res (ou groupe) C": {}, "3212-Mati\u00e8res (ou groupe) D": {} - }, + }, "322-Fournitures consommables": { - "3221-Combustibles": {}, - "3222-Produits d'entretien": {}, - "3223-Fournitures d'atelier et d'usine": {}, - "3224-Fournitures de magasin": {}, + "3221-Combustibles": {}, + "3222-Produits d'entretien": {}, + "3223-Fournitures d'atelier et d'usine": {}, + "3224-Fournitures de magasin": {}, "3225-Fournitures de bureau": {} - }, + }, "326-Emballages": { - "3261-Emballages perdus": {}, - "3265-Emballages r\u00e9cup\u00e9rables non identifiables": {}, + "3261-Emballages perdus": {}, + "3265-Emballages r\u00e9cup\u00e9rables non identifiables": {}, "3267-Emballages \u00e0 usage mixte": {} } - }, + }, "33-En-cours de production de biens": { "331-Produits en cours": { - "3311-Produits en cours P1": {}, + "3311-Produits en cours P1": {}, "3312-Produits en cours P2": {} - }, + }, "335-Travaux en cours": { - "Travaux en cours T1": {}, - "Travaux en cours T2": {} + "3351-Travaux en cours T1": {}, + "3352-Travaux en cours T2": {} } - }, + }, "34-En-cours de production de services": { "341-Etudes en cours": { - "3411-Etudes en cours E1": {}, + "3411-Etudes en cours E1": {}, "3412-Etudes en cours E2": {} - }, + }, "345-Prestations de services en cours": { - "3451-Prestations de services S1": {}, + "3451-Prestations de services S1": {}, "3452-Prestations de services S2": {} } - }, + }, "35-Stocks de produits": { "351-Produits interm\u00e9diaires": { "3511-Produits interm\u00e9diaires (ou groupe) A": { - "account_type": "Stock", + "account_type": "Stock", "is_group": 1 - }, + }, "3512-Produits interm\u00e9diaires (ou groupe) B": { - "account_type": "Stock", + "account_type": "Stock", "is_group": 1 - }, + }, "account_type": "Stock" - }, + }, "355-Produits finis": { "3551-Produits finis (ou groupe) A": { - "account_type": "Stock", + "account_type": "Stock", "is_group": 1 - }, + }, "3552-Produits finis (ou groupe) B": { - "account_type": "Stock", + "account_type": "Stock", "is_group": 1 - }, + }, "account_type": "Stock" - }, + }, "358-Produits r\u00e9siduels (ou mati\u00e8res de r\u00e9cup\u00e9ration)": { "3581-D\u00e9chets": { - "account_type": "Stock", + "account_type": "Stock", "is_group": 1 - }, + }, "3585-Rebuts": { - "account_type": "Stock", + "account_type": "Stock", "is_group": 1 - }, + }, "3586-Mati\u00e8res de r\u00e9cup\u00e9ration": { - "account_type": "Stock", + "account_type": "Stock", "is_group": 1 - }, + }, "account_type": "Stock" - }, + }, "account_type": "Stock" - }, - "36-(Compte \u00e0 ouvrir, le cas \u00e9ch\u00e9ant, sous l'intitul\u00e9 \"stocks provenant d'immobilisations\")": {}, + }, + "36-(Compte \u00e0 ouvrir, le cas \u00e9ch\u00e9ant, sous l'intitul\u00e9 \"stocks provenant d'immobilisations\")": {}, "37-Stocks de marchandises": { - "371-Marchandises (ou groupe) A": {}, + "371-Marchandises (ou groupe) A": {}, "372-Marchandises (ou groupe) B": {} - }, - "38-Stocks en voie d'acheminement, mis en d\u00e9p\u00f4t ou donn\u00e9s en consignation (en cas d'inventaire permanent en comptabilit\u00e9 g\u00e9n\u00e9rale)": {}, + }, + "38-Stocks en voie d'acheminement, mis en d\u00e9p\u00f4t ou donn\u00e9s en consignation (en cas d'inventaire permanent en comptabilit\u00e9 g\u00e9n\u00e9rale)": { + "account_type": "Stock" + }, "39-D\u00e9pr\u00e9ciations des stocks et en-cours": { "391-D\u00e9pr\u00e9ciations des mati\u00e8res premi\u00e8res (et fournitures)": { - "3911-Mati\u00e8res (ou groupe) A": {}, - "3912-Mati\u00e8res (ou groupe) B": {}, + "3911-Mati\u00e8res (ou groupe) A": {}, + "3912-Mati\u00e8res (ou groupe) B": {}, "3917-Fournitures A, B, C, ...": {} - }, + }, "392-D\u00e9pr\u00e9ciations des autres approvisionnements": { - "3921-Mati\u00e8res consommables (m\u00eame ventilation que celle du compte 321)": {}, - "3922-Fournitures consommables (m\u00eame ventilation que celle du compte 322)": {}, + "3921-Mati\u00e8res consommables (m\u00eame ventilation que celle du compte 321)": {}, + "3922-Fournitures consommables (m\u00eame ventilation que celle du compte 322)": {}, "3926-Emballages (m\u00eame ventilation que celle du compte 326)": {} - }, + }, "393-D\u00e9pr\u00e9ciations des en-cours de production de biens": { - "3931-Etudes en cours (m\u00eame ventilation que celle du compte 341)": {}, + "3931-Etudes en cours (m\u00eame ventilation que celle du compte 341)": {}, "3935-Travaux en cours (m\u00eame ventilation que celle du compte 335)": {} - }, + }, "394-D\u00e9pr\u00e9ciations des en-cours de production de services": { - "3941-Etudes en cours (m\u00eame ventilation que celle du compte 341)": {}, + "3941-Etudes en cours (m\u00eame ventilation que celle du compte 341)": {}, "3945-Prestations de services en cours (m\u00eame ventilation que celle du compte 345)": {} - }, + }, "395-D\u00e9pr\u00e9ciations des stocks de produits": { - "3951-Produits interm\u00e9diaires (m\u00eame ventilation que celle du compte 351)": {}, + "3951-Produits interm\u00e9diaires (m\u00eame ventilation que celle du compte 351)": {}, "3955-Produits finis (m\u00eame ventilation que celle du compte 355)": {} - }, + }, "397-D\u00e9pr\u00e9ciations des stocks de marchandises": { - "3971-Marchandise (ou groupe) A": {}, + "3971-Marchandise (ou groupe) A": {}, "3972-Marchandise (ou groupe) B": {} } - }, + }, "root_type": "Asset" - }, + }, "4-Comptes de Tiers (ACTIF)": { "40-Fournisseurs et Comptes Rattach\u00e9s (ACTIF)": { "409-Fournisseurs d\u00e9biteurs": { - "4091-Fournisseurs - Avances et acomptes vers\u00e9s sur commandes": {}, - "4096-Fournisseurs - Cr\u00e9ances pour emballages et mat\u00e9riel \u00e0 rendre": {}, + "4091-Fournisseurs - Avances et acomptes vers\u00e9s sur commandes": {}, + "4096-Fournisseurs - Cr\u00e9ances pour emballages et mat\u00e9riel \u00e0 rendre": {}, "4097-Fournisseurs - Autres avoirs": { - "40971-Fournisseurs d'exploitation": {}, + "40971-Fournisseurs d'exploitation": {}, "40974-Fournisseurs d'immobilisation": {} - }, + }, "4098-Rabais, remises, ristournes \u00e0 obtenir et autres avoirs non encore re\u00e7us": {} } - }, + }, "41-Clients et comptes rattach\u00e9s (ACTIF)": { "410-Clients et Comptes rattach\u00e9s": { "account_type": "Receivable" - }, + }, "411-Clients": { "4111-Clients - Ventes de biens ou de prestations de services": { "account_type": "Receivable" - }, + }, "4117-Clients - Retenues de garantie": { "account_type": "Receivable" - }, + }, "account_type": "Receivable" - }, + }, "413-Clients - Effets \u00e0 recevoir": { "account_type": "Receivable" - }, + }, "416-Clients douteux ou litigieux": { "account_type": "Receivable" - }, + }, "418-Clients - Produits non encore factur\u00e9s": { "4181-Clients - Factures \u00e0 \u00e9tablir": { "account_type": "Receivable" - }, + }, "4188-Clients - Int\u00e9r\u00eats courus": { "account_type": "Receivable" - }, + }, "account_type": "Receivable" - }, + }, "account_type": "Receivable" - }, + }, "42-Personnel et comptes rattach\u00e9s (ACTIF)": { "425-Personnel - Avances et acomptes": {} - }, + }, "43-S\u00e9curit\u00e9 sociale et autres organismes sociaux (ACTIF)": { - "431-S\u00e9curit\u00e9 sociale": {}, - "437-Autres organismes sociaux": {}, + "431-S\u00e9curit\u00e9 sociale": {}, + "437-Autres organismes sociaux": {}, "438-Organismes sociaux - Produits \u00e0 recevoir": { "4387-Produits \u00e0 recevoir": {} } - }, + }, "44-Etat et autres collectivit\u00e9s publiques (ACTIF)": { "441-Etat - Subventions \u00e0 recevoir": { - "4411-Subventions d'investissement": {}, - "4417-Subventions d'exploitation": {}, - "4418-Subventions d'\u00e9quilibre": {}, + "4411-Subventions d'investissement": {}, + "4417-Subventions d'exploitation": {}, + "4418-Subventions d'\u00e9quilibre": {}, "4419-Avances sur subventions": {} - }, + }, "443-Op\u00e9rations particuli\u00e8res avec l'Etat, les collectivit\u00e9s publiques, les organismes internationaux": { - "4431-Cr\u00e9ances sur l'Etat r\u00e9sultant de la suppression de la r\u00e8gle du d\u00e9calage d'un mois en mati\u00e8re de TVA": {}, + "4431-Cr\u00e9ances sur l'Etat r\u00e9sultant de la suppression de la r\u00e8gle du d\u00e9calage d'un mois en mati\u00e8re de TVA": {}, "4438-Int\u00e9r\u00eats courus sur cr\u00e9ances figurant au compte 4431": {} - }, + }, "445-Etat - Taxes sur le chiffre d'affaires (ACTIF)": { - "4452-TVA due intracommunautaire": {}, + "4452-TVA due intracommunautaire": {}, "4456-Taxes sur le chiffre d'affaires d\u00e9ductibles": { - "44562-TVA sur immobilisations": {}, - "44563-TVA transf\u00e9r\u00e9e par d'autres entreprises": {}, + "44562-TVA sur immobilisations": {}, + "44563-TVA transf\u00e9r\u00e9e par d'autres entreprises": {}, "44566-TVA sur autres biens et services": { "tax_rate": 20.0 - }, - "44567-Cr\u00e9dit de TVA \u00e0 reporter": {}, + }, + "44567-Cr\u00e9dit de TVA \u00e0 reporter": {}, "44568-Taxes assimil\u00e9es \u00e0 la TVA": {} - }, + }, "4458-Taxes sur le chiffre d'affaires \u00e0 r\u00e9gulariser ou en attente (ACTIF)": { - "44581-Acomptes - R\u00e9gime simplifi\u00e9 d'imposition": {}, - "44582-Acomptes - R\u00e9gime du forfait": {}, - "44583-Remboursement de taxes sur le chiffre d'affaires demand\u00e9": {}, + "44581-Acomptes - R\u00e9gime simplifi\u00e9 d'imposition": {}, + "44582-Acomptes - R\u00e9gime du forfait": {}, + "44583-Remboursement de taxes sur le chiffre d'affaires demand\u00e9": {}, "44586-Taxes sur le chiffre d'affaires sur factures non parvenues": {} } - }, + }, "448-Etat - Charges \u00e0 payer et produits \u00e0 recevoir": { - "4482-Charges fiscales sur cong\u00e9s \u00e0 payer": {}, - "4486-Charges \u00e0 payer": {}, + "4482-Charges fiscales sur cong\u00e9s \u00e0 payer": {}, + "4486-Charges \u00e0 payer": {}, "4487-Produits \u00e0 recevoir": {} } - }, + }, "45-Groupe et associ\u00e9s (ACTIF)": { "456-Associ\u00e9s - Op\u00e9rations sur le capital (ACTIF)": { "4562-Apporteurs - Capital appel\u00e9, non vers\u00e9": { - "45621-Actionnaires - Capital souscrit et appel\u00e9, non vers\u00e9": {}, + "45621-Actionnaires - Capital souscrit et appel\u00e9, non vers\u00e9": {}, "45625-Associ\u00e9s - Capital appel\u00e9, non vers\u00e9": {} } } - }, + }, "46-D\u00e9biteurs divers et cr\u00e9diteurs divers (ACTIF)": { - "462-Cr\u00e9ances sur cessions d'immobilisations": {}, - "465-Cr\u00e9ances sur cessions de valeurs mobili\u00e8res de placement": {}, - "467-Autres comptes d\u00e9biteurs ou cr\u00e9diteurs (ACTIF)": {}, + "462-Cr\u00e9ances sur cessions d'immobilisations": {}, + "465-Cr\u00e9ances sur cessions de valeurs mobili\u00e8res de placement": {}, + "467-Autres comptes d\u00e9biteurs ou cr\u00e9diteurs (ACTIF)": {}, "468-Divers - Charges \u00e0 payer et produits \u00e0 recevoir (ACTIF)": { "4687-Produits \u00e0 recevoir": {} } - }, + }, "47-Comptes transitoires ou d'attente (ACTIF)": { "471-Comptes d'attente (ACTIF)": { "account_type": "Temporary" - }, + }, "476-Diff\u00e9rences de conversion (ACTIF)": { - "4761-Diminution des cr\u00e9ances": {}, - "4762-Augmentation des dettes": {}, + "4761-Diminution des cr\u00e9ances": {}, + "4762-Augmentation des dettes": {}, "4768-Diff\u00e9rences compens\u00e9es par couverture de change": {} - }, + }, "478-Autres comptes transitoires (ACTIF)": { - "4781-Mali de fusion sur actif circulant": {}, + "4781-Mali de fusion sur actif circulant": {}, "4786-Diff\u00e9rences d'\u00e9valuation sur instruments de tr\u00e9sorerie (ACTIF)": {} } - }, + }, "48-Comptes de r\u00e9gularisation (ACTIF)": { "481-Charges \u00e0 r\u00e9partir sur plusieurs exercices": { "4816-Frais d'\u00e9mission des emprunts": {} - }, - "486-Charges constat\u00e9es d'avance": {}, + }, + "486-Charges constat\u00e9es d'avance": {}, "488-Comptes de r\u00e9partition p\u00e9riodique des charges et des produits (ACTIF)": { "4886-Charges": {} } - }, + }, "49-D\u00e9pr\u00e9ciation des comptes de tiers (ACTIF)": { - "491-D\u00e9pr\u00e9ciations des comptes clients": {}, + "491-D\u00e9pr\u00e9ciations des comptes clients": {}, "495-D\u00e9pr\u00e9ciations des comptes du groupe et des associ\u00e9s": { - "4951-Comptes du groupe": {}, - "4955-Comptes courants des associ\u00e9s": {}, + "4951-Comptes du groupe": {}, + "4955-Comptes courants des associ\u00e9s": {}, "4958-Op\u00e9rations faites en commun et en GIE": {} - }, + }, "496-D\u00e9pr\u00e9ciations des comptes de d\u00e9biteurs divers": { - "4962-Cr\u00e9ances sur cessions d'immobilisations": {}, - "4965-Cr\u00e9ances sur cessions de valeurs mobili\u00e8res de placement": {}, + "4962-Cr\u00e9ances sur cessions d'immobilisations": {}, + "4965-Cr\u00e9ances sur cessions de valeurs mobili\u00e8res de placement": {}, "4967-Autres comptes d\u00e9biteurs": {} } - }, + }, "root_type": "Asset" - }, + }, "4-Comptes de Tiers (PASSIF)": { "40-Fournisseurs et Comptes Rattach\u00e9s (PASSIF)": { "401-Fournisseurs": { "4011-Fournisseurs - Achats de biens ou de prestations de services": { "account_type": "Payable" - }, + }, "4017-Fournisseurs - Retenues de garantie": { "account_type": "Payable" - }, + }, "account_type": "Payable" - }, + }, "403-Fournisseurs - Effets \u00e0 payer": { "account_type": "Payable" - }, + }, "404-Fournisseurs d'immobilisations": { "4041-Fournisseurs - Achats d'immobilisations": { "account_type": "Payable" - }, + }, "4047-Fournisseurs d'immobilisations - Retenues de garantie": { "account_type": "Payable" - }, + }, "account_type": "Payable" - }, + }, "405-Fournisseurs d'immobilisations - Effets \u00e0 payer": { "account_type": "Payable" - }, + }, "408-Fournisseurs - Factures non parvenues": { "4081-Fournisseurs": { "account_type": "Stock Received But Not Billed" - }, + }, "4084-Fournisseurs d'immobilisations": { "account_type": "Stock Received But Not Billed" - }, + }, "4088-Fournisseurs - Int\u00e9r\u00eats courus": { "account_type": "Stock Received But Not Billed" - }, + }, "account_type": "Stock Received But Not Billed" - }, + }, "account_type": "Payable" - }, + }, "41-Clients et comptes rattach\u00e9s (PASSIF)": { "419-Clients cr\u00e9diteurs": { - "4191-Clients - Avances et acomptes re\u00e7us sur commandes": {}, - "4196-Clients - Dettes pour emballages et mat\u00e9riels consign\u00e9s": {}, - "4197-Clients - Autres avoirs": {}, + "4191-Clients - Avances et acomptes re\u00e7us sur commandes": {}, + "4196-Clients - Dettes pour emballages et mat\u00e9riels consign\u00e9s": {}, + "4197-Clients - Autres avoirs": {}, "4198-Rabais, remises, ristournes \u00e0 accorder et autres avoirs \u00e0 \u00e9tablir": {} } - }, + }, "42-Personnel et comptes rattach\u00e9s (PASSIF)": { - "421-Personnel - R\u00e9mun\u00e9rations dues": {}, - "422-Comit\u00e9s d'entreprises, d'\u00e9tablissement...": {}, + "421-Personnel - R\u00e9mun\u00e9rations dues": {}, + "422-Comit\u00e9s d'entreprises, d'\u00e9tablissement...": {}, "424-Participation des salari\u00e9s aux r\u00e9sultats": { - "4246-R\u00e9serve sp\u00e9ciale": {}, + "4246-R\u00e9serve sp\u00e9ciale": {}, "4248-Comptes courants": {} - }, - "426-Personnel - D\u00e9p\u00f4ts": {}, - "427-Personnel - Oppositions": {}, + }, + "426-Personnel - D\u00e9p\u00f4ts": {}, + "427-Personnel - Oppositions": {}, "428-Personnel - Charges \u00e0 payer et produits \u00e0 recevoir": { - "4282-Dettes provisionn\u00e9es pour cong\u00e9s \u00e0 payer": {}, - "4284-Dettes provisionn\u00e9es pour participation des salari\u00e9s aux r\u00e9sultats": {}, - "4286-Autres charges \u00e0 payer": {}, + "4282-Dettes provisionn\u00e9es pour cong\u00e9s \u00e0 payer": {}, + "4284-Dettes provisionn\u00e9es pour participation des salari\u00e9s aux r\u00e9sultats": {}, + "4286-Autres charges \u00e0 payer": {}, "4287-Produits \u00e0 recevoir": {} } - }, + }, "43-S\u00e9curit\u00e9 sociale et autres organismes sociaux (PASSIF)": { "438-Organismes sociaux - Charges \u00e0 payer": { - "4382-Charges sociales sur cong\u00e9s \u00e0 payer": {}, + "4382-Charges sociales sur cong\u00e9s \u00e0 payer": {}, "4386-Autres charges \u00e0 payer": {} } - }, + }, "44-Etat et autres collectivit\u00e9s publiques (PASSIF)": { "442-Etat - Imp\u00f4ts et taxes recouvrables sur des tiers": { - "4424-Obligataires": {}, + "4424-Obligataires": {}, "4425-Associ\u00e9s": {} - }, - "444-Etat - Imp\u00f4ts sur les b\u00e9n\u00e9fices": {}, + }, + "444-Etat - Imp\u00f4ts sur les b\u00e9n\u00e9fices": {}, "445-Etat - Taxes sur le chiffre d'affaires (PASSIF)": { "4455-Taxes sur le chiffre d'affaires \u00e0 d\u00e9caisser": { - "44551-TVA \u00e0 d\u00e9caisser": {}, + "44551-TVA \u00e0 d\u00e9caisser": {}, "44558-Taxes assimil\u00e9es \u00e0 la TVA": {} - }, + }, "4457-Taxes sur le chiffre d'affaires collect\u00e9es par l'entreprise": { "44571-TVA collect\u00e9e": { - "account_type": "Tax", + "account_type": "Tax", "is_group": 1 - }, + }, "44578-Taxes assimil\u00e9es \u00e0 la TVA": {} - }, + }, "4458-Taxes sur le chiffre d'affaires \u00e0 r\u00e9gulariser ou en attente (PASSIF)": { - "44584-TVA r\u00e9cup\u00e9r\u00e9e d'avance": {}, + "44584-TVA r\u00e9cup\u00e9r\u00e9e d'avance": {}, "44587-Taxes sur le chiffre d'affaires sur factures \u00e0 \u00e9tablir": {} } - }, - "446-Obligations cautionn\u00e9es": {}, - "447-Autres imp\u00f4ts, taxes et versements assimil\u00e9s": {}, + }, + "446-Obligations cautionn\u00e9es": {}, + "447-Autres imp\u00f4ts, taxes et versements assimil\u00e9s": {}, "449-Quotas d'\u00e9mission \u00e0 acqu\u00e9rir": {} - }, + }, "45-Groupe et associ\u00e9s (PASSIF)": { - "451-Groupe (PASSIF)": {}, + "451-Groupe (PASSIF)": {}, "455-Associ\u00e9s - Comptes courants (PASSIF)": { - "4551-Principal (PASSIF)": {}, + "4551-Principal (PASSIF)": {}, "4558-Int\u00e9r\u00eats courus (PASSIF)": {} - }, + }, "456-Associ\u00e9s - Op\u00e9rations sur le capital (PASSIF)": { "4561-Associ\u00e9s - Comptes d'apport en soci\u00e9t\u00e9": { - "45611-Apports en nature": {}, + "45611-Apports en nature": {}, "45615-Apports en num\u00e9raire": {} - }, - "4563-Associ\u00e9s - Versements re\u00e7us sur augmentation de capital": {}, - "4564-Associ\u00e9s - Versements anticip\u00e9s": {}, - "4566-Actionnaires d\u00e9faillants": {}, + }, + "4563-Associ\u00e9s - Versements re\u00e7us sur augmentation de capital": {}, + "4564-Associ\u00e9s - Versements anticip\u00e9s": {}, + "4566-Actionnaires d\u00e9faillants": {}, "4567-Associ\u00e9s - Capital \u00e0 rembourser": {} - }, - "457-Associ\u00e9s - Dividendes \u00e0 payer": {}, + }, + "457-Associ\u00e9s - Dividendes \u00e0 payer": {}, "458-Associ\u00e9s - Op\u00e9rations faites en commun et en GIE": { - "4581-Op\u00e9rations courantes": {}, + "4581-Op\u00e9rations courantes": {}, "4588-Int\u00e9r\u00eats courus": {} } - }, + }, "46-D\u00e9biteurs divers et cr\u00e9diteurs divers (PASSIF)": { - "464-Dettes sur acquisitions de valeurs mobili\u00e8res de placement": {}, - "467-Autres comptes d\u00e9biteurs ou cr\u00e9diteurs (PASSIF)": {}, + "464-Dettes sur acquisitions de valeurs mobili\u00e8res de placement": {}, + "467-Autres comptes d\u00e9biteurs ou cr\u00e9diteurs (PASSIF)": {}, "468-Divers - Charges \u00e0 payer et produits \u00e0 recevoir (PASSIF)": { "4686-Charges \u00e0 payer": {} } - }, + }, "47-Comptes transitoires ou d'attente (PASSIF)": { "471-Comptes d'attente (PASSIF)": { "account_type": "Temporary" - }, + }, "477-Diff\u00e9rences de conversion (PASSIF)": { - "4771-Augmentation des cr\u00e9ances": {}, - "4772-Diminution des dettes": {}, + "4771-Augmentation des cr\u00e9ances": {}, + "4772-Diminution des dettes": {}, "4778-Diff\u00e9rences compens\u00e9es par couverture de change": {} - }, + }, "478-Autres comptes transitoires (PASSIF)": { "4787-Diff\u00e9rences d'\u00e9valuation sur instruments de tr\u00e9sorerie (PASSIF)": {} } - }, + }, "48-Comptes de r\u00e9gularisation (PASSIF)": { - "487-Produits constat\u00e9s d'avance": {}, + "487-Produits constat\u00e9s d'avance": {}, "488-Comptes de r\u00e9partition p\u00e9riodique des charges et des produits (PASSIF)": { "4887-Produits": {} } - }, + }, "root_type": "Liability" - }, + }, "5-Comptes Financiers": { "50-Valeurs mobili\u00e8res de placement": { - "501-Parts dans des entreprises li\u00e9es": {}, + "501-Parts dans des entreprises li\u00e9es": {}, "502-Actions propres": { - "5021-Actions destin\u00e9es \u00e0 \u00eatre attribu\u00e9es aux employ\u00e9s et affect\u00e9es \u00e0 des plans d\u00e9termin\u00e9s": {}, + "5021-Actions destin\u00e9es \u00e0 \u00eatre attribu\u00e9es aux employ\u00e9s et affect\u00e9es \u00e0 des plans d\u00e9termin\u00e9s": {}, "5022-Actions disponibles pour \u00eatre attribu\u00e9es aux employ\u00e9s ou pour la r\u00e9gularisation des cours de bourse": {} - }, + }, "503-Actions": { - "5031-Titres cot\u00e9s": {}, + "5031-Titres cot\u00e9s": {}, "5035-Titres non cot\u00e9s": {} - }, - "504-Autres titres conf\u00e9rant un droit de propri\u00e9t\u00e9": {}, - "505-Obligations et bons \u00e9mis par la soci\u00e9t\u00e9 et rachet\u00e9s par elle": {}, + }, + "504-Autres titres conf\u00e9rant un droit de propri\u00e9t\u00e9": {}, + "505-Obligations et bons \u00e9mis par la soci\u00e9t\u00e9 et rachet\u00e9s par elle": {}, "506-Obligations": { - "5061-Titres cot\u00e9s": {}, + "5061-Titres cot\u00e9s": {}, "5065-Titres non cot\u00e9s": {} - }, - "507-Bons du Tr\u00e9sor et bons de caisse \u00e0 court terme": {}, + }, + "507-Bons du Tr\u00e9sor et bons de caisse \u00e0 court terme": {}, "508-Autres valeurs mobili\u00e8res de placement et autres cr\u00e9ances assimil\u00e9es": { - "5081-Autres valeurs mobili\u00e8res": {}, - "5082-Bons de souscription": {}, + "5081-Autres valeurs mobili\u00e8res": {}, + "5082-Bons de souscription": {}, "5088-Int\u00e9r\u00eats courus sur obligations, bons et valeurs assimil\u00e9es": {} - }, + }, "509-Versements restant \u00e0 effectuer sur valeurs mobili\u00e8res de placement non lib\u00e9r\u00e9es": {} - }, + }, "51-Banques, \u00e9tablissements financiers et assimil\u00e9s": { "511-Valeurs \u00e0 l'encaissement": { - "5111-Coupons \u00e9chus \u00e0 l'encaissement": {}, - "5112-Ch\u00e8ques \u00e0 encaisser": {}, - "5113-Effets \u00e0 l'encaissement": {}, + "5111-Coupons \u00e9chus \u00e0 l'encaissement": {}, + "5112-Ch\u00e8ques \u00e0 encaisser": {}, + "5113-Effets \u00e0 l'encaissement": {}, "5114-Effets \u00e0 l'escompte": {} - }, + }, "512-Banques": { "5121-Comptes en monnaie nationale": { "account_type": "Bank" - }, + }, "5124-Comptes en devises": { "account_type": "Bank" - }, + }, "account_type": "Bank" - }, - "514-Ch\u00e8ques postaux": {}, - "515-\"Caisses\" du Tr\u00e9sor et des \u00e9tablissements publics": {}, - "516-Soci\u00e9t\u00e9s de bourse": {}, - "517-Autres organismes financiers": {}, + }, + "514-Ch\u00e8ques postaux": {}, + "515-\"Caisses\" du Tr\u00e9sor et des \u00e9tablissements publics": {}, + "516-Soci\u00e9t\u00e9s de bourse": {}, + "517-Autres organismes financiers": {}, "518-Int\u00e9r\u00eats courus": { - "5181-Int\u00e9r\u00eats courus \u00e0 payer": {}, + "5181-Int\u00e9r\u00eats courus \u00e0 payer": {}, "5188-Int\u00e9r\u00eats courus \u00e0 recevoir": {} - }, + }, "519-Concours bancaires courants": { - "5191-Cr\u00e9dit de mobilisation des cr\u00e9ances commerciales (CMCC)": {}, - "5193-Mobilisation de cr\u00e9ances n\u00e9es \u00e0 l'\u00e9tranger": {}, + "5191-Cr\u00e9dit de mobilisation des cr\u00e9ances commerciales (CMCC)": {}, + "5193-Mobilisation de cr\u00e9ances n\u00e9es \u00e0 l'\u00e9tranger": {}, "5198-Int\u00e9r\u00eats courus sur concours bancaires courants": {} } - }, + }, "52-Instruments de tr\u00e9sorerie": { "is_group": 1 - }, + }, "53-Caisse": { "531-Caisse si\u00e8ge social": { "5311-Caisse en monnaie nationale": { "account_type": "Cash" - }, + }, "5314-Caisse en devises": { "account_type": "Cash" - }, + }, "account_type": "Cash" - }, + }, "532-Caisse succursale (ou usine) A": { "account_type": "Cash" - }, + }, "533-Caisse succursale (ou usine) B": { "account_type": "Cash" - }, + }, "account_type": "Cash" - }, + }, "54-R\u00e9gies d'avance et accr\u00e9ditifs": { "is_group": 1 - }, + }, "58-Virements internes": { "is_group": 1 - }, + }, "59-D\u00e9pr\u00e9ciations des comptes financiers": { "590-D\u00e9pr\u00e9ciations des valeurs mobili\u00e8res de placement": { - "5903-Actions": {}, - "5904-Autres titres conf\u00e9rant un droit de propri\u00e9t\u00e9": {}, - "5906-Obligations": {}, + "5903-Actions": {}, + "5904-Autres titres conf\u00e9rant un droit de propri\u00e9t\u00e9": {}, + "5906-Obligations": {}, "5908-Autres valeurs mobili\u00e8res de placement et cr\u00e9ances assimil\u00e9es": {} } - }, + }, "root_type": "Asset" - }, + }, "6-Comptes de Charges": { "60-Achats (sauf 603)": { "601-Achats stock\u00e9s - Mati\u00e8res premi\u00e8res (et fournitures)": { "6011-Mati\u00e8res (ou groupe) A": { "account_type": "Cost of Goods Sold" - }, + }, "6012-Mati\u00e8res (ou groupe) B": { "account_type": "Cost of Goods Sold" - }, + }, "6017-Fournitures A, B, C...": { "account_type": "Cost of Goods Sold" - }, + }, "account_type": "Cost of Goods Sold" - }, + }, "602-Achats stock\u00e9s - Autres approvisionnements": { "6021-Mati\u00e8res consommables": { "60211-Mati\u00e8res (ou groupe) C": { "account_type": "Cost of Goods Sold" - }, + }, "60212-Mati\u00e8res (ou groupe) D": { "account_type": "Cost of Goods Sold" - }, + }, "account_type": "Cost of Goods Sold" - }, + }, "6022-Fournitures consommables": { "60221-Combustibles": { "account_type": "Cost of Goods Sold" - }, + }, "60222-Produits d'entretien": { "account_type": "Cost of Goods Sold" - }, + }, "60223-Fournitures d'atelier et d'usine": { "account_type": "Cost of Goods Sold" - }, + }, "60224-Fournitures de magasin": { "account_type": "Cost of Goods Sold" - }, + }, "60225-Fournitures de bureau": { "account_type": "Cost of Goods Sold" - }, + }, "account_type": "Cost of Goods Sold" - }, + }, "6026-Emballages": { "60261-Emballages perdus": { "account_type": "Cost of Goods Sold" - }, + }, "60265-Emballages r\u00e9cup\u00e9rables non identifiables": { "account_type": "Cost of Goods Sold" - }, + }, "60267-Emballages \u00e0 usage mixte": { "account_type": "Cost of Goods Sold" - }, + }, "account_type": "Cost of Goods Sold" - }, + }, "account_type": "Cost of Goods Sold" - }, + }, "603-Variations des stocks (approvisionnements et marchandises)": { "6031-Variation des stocks de mati\u00e8res premi\u00e8res (et fournitures)": { "account_type": "Stock Adjustment" - }, + }, "6032-Variation des stocks des autres approvisionnements": { "account_type": "Stock Adjustment" - }, + }, "6037-Variation des stocks de marchandises": { "account_type": "Stock Adjustment" - }, + }, "account_type": "Stock Adjustment" - }, + }, "604-Achats d'\u00e9tudes et prestations de service": { "account_type": "Cost of Goods Sold" - }, + }, "605-Achats de mat\u00e9riel, \u00e9quipements et travaux": { "account_type": "Cost of Goods Sold" - }, + }, "606-Achats non stock\u00e9s de mati\u00e8res et founitures": { "6061-Fournitures non stockables (eau, \u00e9nergie...)": { "account_type": "Cost of Goods Sold" - }, + }, "6063-Fournitures d'entretien et de petit \u00e9quipement": { "account_type": "Cost of Goods Sold" - }, + }, "6064-Fournitures administratives": { "account_type": "Cost of Goods Sold" - }, + }, "6068-Autres mati\u00e8res et fournitures": { "account_type": "Cost of Goods Sold" - }, + }, "account_type": "Cost of Goods Sold" - }, + }, "607-Achats de marchandises": { "6071-Marchandises (ou groupe) A": { "account_type": "Cost of Goods Sold" - }, + }, "6072-Marchandises (ou groupe) B": { "account_type": "Cost of Goods Sold" - }, + }, "account_type": "Cost of Goods Sold" - }, + }, "608-(Compte r\u00e9serv\u00e9, le cas \u00e9ch\u00e9ant, \u00e0 la recapitulation des Frais accessoires incorpor\u00e9s aux achats)": { "account_type": "Expenses Included In Valuation" - }, + }, "609-Rabais, remises et ristournes obtenus sur achats": { - "6091-Rabais, remises et ristournes obtenus sur achats - de mati\u00e8res premi\u00e8res (et fournitures)": {}, - "6092-Rabais, remises et ristournes obtenus sur achats - d'autres approvisionnements stock\u00e9s": {}, - "6094-Rabais, remises et ristournes obtenus sur achats - d'\u00e9tudes et prestations de services": {}, - "6095-Rabais, remises et ristournes obtenus sur achats - de mat\u00e9riel, \u00e9quipements et travaux": {}, - "6096-Rabais, remises et ristournes obtenus sur achats - d'approvisionnements non stock\u00e9s": {}, - "6097-Rabais, remises et ristournes obtenus sur achats - de marchandises": {}, + "6091-Rabais, remises et ristournes obtenus sur achats - de mati\u00e8res premi\u00e8res (et fournitures)": {}, + "6092-Rabais, remises et ristournes obtenus sur achats - d'autres approvisionnements stock\u00e9s": {}, + "6094-Rabais, remises et ristournes obtenus sur achats - d'\u00e9tudes et prestations de services": {}, + "6095-Rabais, remises et ristournes obtenus sur achats - de mat\u00e9riel, \u00e9quipements et travaux": {}, + "6096-Rabais, remises et ristournes obtenus sur achats - d'approvisionnements non stock\u00e9s": {}, + "6097-Rabais, remises et ristournes obtenus sur achats - de marchandises": {}, "6098-Rabais, remises et ristournes non affect\u00e9s": {} } - }, + }, "61-Services ext\u00e9rieurs": { - "611-Sous-traitance g\u00e9n\u00e9rale": {}, + "611-Sous-traitance g\u00e9n\u00e9rale": {}, "612-Redevances de cr\u00e9dit-bail": { - "6122-Cr\u00e9dit-bail mobilier": {}, + "6122-Cr\u00e9dit-bail mobilier": {}, "6125-Cr\u00e9dit-bail immobilier": {} - }, + }, "613-Locations": { - "6132-Locations immobili\u00e8res": {}, - "6135-Locations mobili\u00e8res": {}, + "6132-Locations immobili\u00e8res": {}, + "6135-Locations mobili\u00e8res": {}, "6136-Malis sur emballages": {} - }, - "614-Charges locatives et de copropri\u00e9t\u00e9": {}, + }, + "614-Charges locatives et de copropri\u00e9t\u00e9": {}, "615-Entretiens et r\u00e9parations": { - "6152-Entretiens et r\u00e9parations - sur biens immobiliers": {}, - "6155-Entretiens et r\u00e9parations - sur biens mobiliers": {}, + "6152-Entretiens et r\u00e9parations - sur biens immobiliers": {}, + "6155-Entretiens et r\u00e9parations - sur biens mobiliers": {}, "6156-Maintenance": {} - }, + }, "616-Primes d'assurance": { - "6161-Multirisques": {}, - "6162-Assurance obligatoire dommage construction": {}, + "6161-Multirisques": {}, + "6162-Assurance obligatoire dommage construction": {}, "6163-Assurance-transport": { - "61636-Assurance-transport - sur achats": {}, - "61637-Assurance-transport - sur ventes": {}, + "61636-Assurance-transport - sur achats": {}, + "61637-Assurance-transport - sur ventes": {}, "61638-Assurance-transport - sur autres biens": {} - }, - "6164-Risques d'exploitation": {}, + }, + "6164-Risques d'exploitation": {}, "6165-Insolvabilit\u00e9 clients": {} - }, - "617-Etudes et recherches": {}, + }, + "617-Etudes et recherches": {}, "618-Divers": { - "6181-Documentation g\u00e9n\u00e9rale": {}, - "6183-Documentation technique": {}, + "6181-Documentation g\u00e9n\u00e9rale": {}, + "6183-Documentation technique": {}, "6185-Frais de colloques, s\u00e9minaires, conf\u00e9rences": {} - }, + }, "619-Rabais, remises et ristournes obtenus sur services ext\u00e9rieurs": {} - }, + }, "62-Autres services ext\u00e9rieurs": { "621-Personnel ext\u00e9rieur \u00e0 l'entreprise": { - "6211-Personnel int\u00e9rimaire": {}, + "6211-Personnel int\u00e9rimaire": {}, "6214-Personnel d\u00e9tach\u00e9 ou pr\u00eat\u00e9 \u00e0 l'entreprise": {} - }, + }, "622-R\u00e9mun\u00e9rations d'interm\u00e9diaires et honoraires": { - "6221-Commissions et courtages sur achats": {}, - "6222-Commissions et courtages sur ventes": {}, - "6224-R\u00e9mun\u00e9rations des transitaires": {}, - "6225-R\u00e9mun\u00e9rations d'affacturage": {}, - "6226-Honoraires": {}, - "6227-Frais d'actes et de contentieux": {}, + "6221-Commissions et courtages sur achats": {}, + "6222-Commissions et courtages sur ventes": {}, + "6224-R\u00e9mun\u00e9rations des transitaires": {}, + "6225-R\u00e9mun\u00e9rations d'affacturage": {}, + "6226-Honoraires": {}, + "6227-Frais d'actes et de contentieux": {}, "6228-Divers": {} - }, + }, "623-Publicit\u00e9, publications, relations publiques": { - "6231-Annonces et insertions": {}, - "6232-Echantillons": {}, - "6233-Foires et expositions": {}, - "6234-Cadeaux \u00e0 la client\u00e8le": {}, - "6235-Primes": {}, - "6236-Catalogues et imprim\u00e9s": {}, - "6237-Publications": {}, + "6231-Annonces et insertions": {}, + "6232-Echantillons": {}, + "6233-Foires et expositions": {}, + "6234-Cadeaux \u00e0 la client\u00e8le": {}, + "6235-Primes": {}, + "6236-Catalogues et imprim\u00e9s": {}, + "6237-Publications": {}, "6238-Divers (pourboires, dons courants...)": {} - }, + }, "624-Transports de biens et transports collectifs du personnel": { - "6241-Transports sur achats": {}, + "6241-Transports sur achats": {}, "6242-Transports sur ventes": { "account_type": "Chargeable" - }, - "6243-Transports entre \u00e9tablissements ou chantiers": {}, - "6244-Transports administratifs": {}, - "6247-Transports collectifs du personnel": {}, + }, + "6243-Transports entre \u00e9tablissements ou chantiers": {}, + "6244-Transports administratifs": {}, + "6247-Transports collectifs du personnel": {}, "6248-Divers": {} - }, + }, "625-D\u00e9placements, missions et r\u00e9ceptions": { - "6251-Voyages et d\u00e9placements": {}, - "6255-Frais de d\u00e9m\u00e9nagement": {}, - "6256-Missions": {}, + "6251-Voyages et d\u00e9placements": {}, + "6255-Frais de d\u00e9m\u00e9nagement": {}, + "6256-Missions": {}, "6257-R\u00e9ceptions": {} - }, - "626-Frais postaux et de t\u00e9l\u00e9communications": {}, + }, + "626-Frais postaux et de t\u00e9l\u00e9communications": {}, "627-Services bancaires et assimil\u00e9s": { - "6271-Frais sur titres (achat, vente, garde)": {}, - "6272-Commissions et frais sur \u00e9mission d'emprunts": {}, - "6275-Frais sur effets": {}, - "6276-Location de coffres": {}, + "6271-Frais sur titres (achat, vente, garde)": {}, + "6272-Commissions et frais sur \u00e9mission d'emprunts": {}, + "6275-Frais sur effets": {}, + "6276-Location de coffres": {}, "6278-Autres frais et commissions sur prestations de services": {} - }, + }, "628-Divers": { - "6281-Concours divers (cotisations...)": {}, + "6281-Concours divers (cotisations...)": {}, "6284-Frais de recrutement de personnel": {} - }, + }, "629-Rabais, remises et ristournes obtenus sur autres services ext\u00e9rieurs": {} - }, + }, "63-Imp\u00f4ts, taxes et versements assimil\u00e9s": { "631-Imp\u00f4ts, taxes et versements assimil\u00e9s sur r\u00e9mun\u00e9rations (administrations des imp\u00f4ts)": { - "6311-Taxes sur les salaires": {}, - "6312-Taxe d'apprentissage": {}, - "6313-Participation des employeurs \u00e0 la formation professionnelle continue": {}, - "6314-Cotisation pour d\u00e9faut d'investissement obligatoire dans la construction": {}, + "6311-Taxes sur les salaires": {}, + "6312-Taxe d'apprentissage": {}, + "6313-Participation des employeurs \u00e0 la formation professionnelle continue": {}, + "6314-Cotisation pour d\u00e9faut d'investissement obligatoire dans la construction": {}, "6318-Autres": {} - }, + }, "633-Imp\u00f4ts, taxes et versements assimil\u00e9s sur r\u00e9mun\u00e9rations (autres organismes)": { - "6331-Versement de transport": {}, - "6332-Allocations logement": {}, - "6333-Participation des employeurs \u00e0 la formation professionnelle continue": {}, - "6334-Participation des employeurs \u00e0 l'effort de construction": {}, - "6335-Versements lib\u00e9ratoires ouvrant droit \u00e0 l'\u00e9xon\u00e9ration de la taxe d'apprentissage": {}, + "6331-Versement de transport": {}, + "6332-Allocations logement": {}, + "6333-Participation des employeurs \u00e0 la formation professionnelle continue": {}, + "6334-Participation des employeurs \u00e0 l'effort de construction": {}, + "6335-Versements lib\u00e9ratoires ouvrant droit \u00e0 l'\u00e9xon\u00e9ration de la taxe d'apprentissage": {}, "6338-Autres": {} - }, + }, "635-Autres imp\u00f4ts, taxes et versements assimil\u00e9s (administrations des imp\u00f4ts)": { "6351-Imp\u00f4ts directs (sauf imp\u00f4ts sur les b\u00e9n\u00e9fices)": { - "63511-Contribution \u00e9conomique territoriale": {}, - "63512-Taxes fonci\u00e8res": {}, - "63513-Autres imp\u00f4ts locaux": {}, + "63511-Contribution \u00e9conomique territoriale": {}, + "63512-Taxes fonci\u00e8res": {}, + "63513-Autres imp\u00f4ts locaux": {}, "63514-Taxe sur les v\u00e9hicules des soci\u00e9t\u00e9s": {} - }, - "6352-Taxes sur le chiffre d'affaires non r\u00e9cup\u00e9rables": {}, - "6353-Imp\u00f4ts indirects": {}, + }, + "6352-Taxes sur le chiffre d'affaires non r\u00e9cup\u00e9rables": {}, + "6353-Imp\u00f4ts indirects": {}, "6354-Droits d'enregistrement et de timbre": { "63541-Droits de mutation": {} - }, + }, "6358-Autres droits": {} - }, + }, "637-Autres imp\u00f4ts, taxes et versements assimil\u00e9s (autres organismes)": { - "6371-Contribution sociale de solidarit\u00e9 \u00e0 la charge des soci\u00e9t\u00e9s": {}, - "6372-Taxes per\u00e7ues par les organismes publics internationaux": {}, - "6374-Imp\u00f4ts et taxes exigibles \u00e0 l'\u00e9tranger": {}, + "6371-Contribution sociale de solidarit\u00e9 \u00e0 la charge des soci\u00e9t\u00e9s": {}, + "6372-Taxes per\u00e7ues par les organismes publics internationaux": {}, + "6374-Imp\u00f4ts et taxes exigibles \u00e0 l'\u00e9tranger": {}, "6378-Taxes diverses": {} } - }, + }, "64-Charges de personnel": { "641-R\u00e9mun\u00e9rations du personnel": { - "6411-Salaires, appointements": {}, - "6412-Cong\u00e9s pay\u00e9s": {}, - "6413-Primes et gratifications": {}, - "6414-Indemnit\u00e9s et avantages divers": {}, + "6411-Salaires, appointements": {}, + "6412-Cong\u00e9s pay\u00e9s": {}, + "6413-Primes et gratifications": {}, + "6414-Indemnit\u00e9s et avantages divers": {}, "6415-Suppl\u00e9ment familial": {} - }, - "644-R\u00e9mun\u00e9ration du travail de l'exploitant": {}, + }, + "644-R\u00e9mun\u00e9ration du travail de l'exploitant": {}, "645-Charges de s\u00e9curit\u00e9 sociale et de pr\u00e9voyance": { - "6451-Cotisations \u00e0 l'URSSAF": {}, - "6452-Cotisations aux mutuelles": {}, - "6453-Cotisations aux caisses de retraites": {}, + "6451-Cotisations \u00e0 l'URSSAF": {}, + "6452-Cotisations aux mutuelles": {}, + "6453-Cotisations aux caisses de retraites": {}, "6454-Cotisations aux ASSEDIC": {} - }, - "646-Cotisations sociales personnelles de l'exploitant": {}, + }, + "646-Cotisations sociales personnelles de l'exploitant": {}, "647-Autres charges sociales": { "is_group": 1 - }, + }, "648-Autres charges de personnel": {} - }, + }, "65-Autres charges de gestion courante": { "651-Redevances pour concessions, brevets, licences, marques, proc\u00e9d\u00e9s, logiciels, droits et valeurs similaires": { - "6511-Redevances pour concessions, brevets, licences, marques, proc\u00e9d\u00e9s, logiciels": {}, - "6516-Droits d'auteur et de reproduction": {}, + "6511-Redevances pour concessions, brevets, licences, marques, proc\u00e9d\u00e9s, logiciels": {}, + "6516-Droits d'auteur et de reproduction": {}, "6518-Autres droits et valeurs similaires": {} - }, - "653-Jetons de pr\u00e9sence": {}, + }, + "653-Jetons de pr\u00e9sence": {}, "654-Pertes sur cr\u00e9ances irr\u00e9couvrables": { - "6541-Cr\u00e9ances de l'exercice": {}, + "6541-Cr\u00e9ances de l'exercice": {}, "6544-Cr\u00e9ances des exercices ant\u00e9rieurs": {} - }, + }, "655-Quotes-parts de r\u00e9sultat sur op\u00e9rations faites en commun": { - "6551-Quote-part de b\u00e9n\u00e9fice transf\u00e9r\u00e9e (comptabilit\u00e9 du g\u00e9rant)": {}, + "6551-Quote-part de b\u00e9n\u00e9fice transf\u00e9r\u00e9e (comptabilit\u00e9 du g\u00e9rant)": {}, "6555-Quote-part de perte support\u00e9e (comptabilit\u00e9 des associ\u00e9s non g\u00e9rants)": {} - }, - "656-Pertes de change sur cr\u00e9ances et dettes commerciales": {}, + }, + "656-Pertes de change sur cr\u00e9ances et dettes commerciales": {}, "658-Charges diverses de gestion courante": {} - }, + }, "66-Charges financi\u00e8res": { "661-Charges d'int\u00e9r\u00eats": { "6611-Int\u00e9r\u00eats des emprunts et dettes": { - "66116-Int\u00e9r\u00eats des emprunts et dettes - des emprunts et dettes assimil\u00e9es": {}, + "66116-Int\u00e9r\u00eats des emprunts et dettes - des emprunts et dettes assimil\u00e9es": {}, "66117-Int\u00e9r\u00eats des emprunts et dettes - des dettes rattach\u00e9es \u00e0 des participations": {} - }, - "6612-Charges de la fiducie, r\u00e9sultat de la p\u00e9riode": {}, - "6615-Int\u00e9r\u00eats des comptes courants et des d\u00e9p\u00f4ts cr\u00e9diteurs": {}, - "6616-Int\u00e9r\u00eats bancaires et sur op\u00e9rations de financement (escompte...)": {}, - "6617-Int\u00e9r\u00eats des obligations cautionn\u00e9es": {}, + }, + "6612-Charges de la fiducie, r\u00e9sultat de la p\u00e9riode": {}, + "6615-Int\u00e9r\u00eats des comptes courants et des d\u00e9p\u00f4ts cr\u00e9diteurs": {}, + "6616-Int\u00e9r\u00eats bancaires et sur op\u00e9rations de financement (escompte...)": {}, + "6617-Int\u00e9r\u00eats des obligations cautionn\u00e9es": {}, "6618-Int\u00e9r\u00eats des autres dettes": { - "66181-Int\u00e9r\u00eats des autres dettes - des dettes commerciales": {}, + "66181-Int\u00e9r\u00eats des autres dettes - des dettes commerciales": {}, "66188-Int\u00e9r\u00eats des autres dettes - des dettes diverses": {} } - }, - "664-Pertes sur cr\u00e9ances li\u00e9es \u00e0 des participations": {}, - "665-Escomptes accord\u00e9s": {}, + }, + "664-Pertes sur cr\u00e9ances li\u00e9es \u00e0 des participations": {}, + "665-Escomptes accord\u00e9s": {}, "666-Pertes de change financi\u00e8res": { "account_type": "Round Off" - }, - "667-Charges nettes sur cessions de valeurs mobili\u00e8res de placement": {}, + }, + "667-Charges nettes sur cessions de valeurs mobili\u00e8res de placement": {}, "668-Autres charges financi\u00e8res": {} - }, + }, "67-Charges exceptionnelles": { "671-Charges exceptionnelles sur op\u00e9rations de gestion": { - "6711-P\u00e9nalit\u00e9s sur march\u00e9s (et d\u00e9dits pay\u00e9s sur achats et ventes)": {}, - "6712-P\u00e9nalit\u00e9s, amendes fiscales et p\u00e9nales": {}, - "6713-Dons, lib\u00e9ralit\u00e9s": {}, - "6714-Cr\u00e9ances devenues irr\u00e9couvrables dans l'exercice": {}, - "6715-Subventions accord\u00e9es": {}, - "6717-Rappel d'imp\u00f4ts (autres qu'imp\u00f4ts sur les b\u00e9n\u00e9fices)": {}, + "6711-P\u00e9nalit\u00e9s sur march\u00e9s (et d\u00e9dits pay\u00e9s sur achats et ventes)": {}, + "6712-P\u00e9nalit\u00e9s, amendes fiscales et p\u00e9nales": {}, + "6713-Dons, lib\u00e9ralit\u00e9s": {}, + "6714-Cr\u00e9ances devenues irr\u00e9couvrables dans l'exercice": {}, + "6715-Subventions accord\u00e9es": {}, + "6717-Rappel d'imp\u00f4ts (autres qu'imp\u00f4ts sur les b\u00e9n\u00e9fices)": {}, "6718-Autres charges exceptionnelles sur op\u00e9rations de gestion": {} - }, - "672-(Compte \u00e0 la disposition des entit\u00e9s pour enregistrer, en cours d'exercice, les charges sur exercices ant\u00e9rieurs)": {}, + }, + "672-(Compte \u00e0 la disposition des entit\u00e9s pour enregistrer, en cours d'exercice, les charges sur exercices ant\u00e9rieurs)": {}, "674-Op\u00e9rations de constitution ou liquidation des fiducies": { - "6741-Op\u00e9rations li\u00e9es \u00e0 la constitution de la fiducie - transfert des \u00e9l\u00e9ments": {}, + "6741-Op\u00e9rations li\u00e9es \u00e0 la constitution de la fiducie - transfert des \u00e9l\u00e9ments": {}, "6742-Op\u00e9rations li\u00e9es \u00e0 la liquidation de la fiducie": {} - }, + }, "675-Valeurs comptables des \u00e9l\u00e9ments d'actif c\u00e9d\u00e9s": { - "6751-Immobilisations incorporelles": {}, - "6752-Immobilisations corporelles": {}, - "6756-Immobilisations financi\u00e8res": {}, + "6751-Immobilisations incorporelles": {}, + "6752-Immobilisations corporelles": {}, + "6756-Immobilisations financi\u00e8res": {}, "6758-Autres \u00e9l\u00e9ments d'actif": {} - }, + }, "678-Autres charges exceptionnelles": { - "6781-Mali provenant de clauses d'indexation": {}, - "6782-Lots": {}, - "6783-Malis provenant du rachat par l'entreprise d'actions et obligations \u00e9mises par elles-m\u00eame": {}, + "6781-Mali provenant de clauses d'indexation": {}, + "6782-Lots": {}, + "6783-Malis provenant du rachat par l'entreprise d'actions et obligations \u00e9mises par elles-m\u00eame": {}, "6788-Charges exceptionnelles diverses": {} } - }, + }, "68-Dotations aux amortissements, d\u00e9pr\u00e9ciations et provisions": { "681-Dotations aux amortissements, d\u00e9pr\u00e9ciations et provisions - Charges d'exploitation": { "6811-Dotations aux amortissements sur immobilisations incorporelles et corporelles": { "68111-Immobilisations incorporelles": { "account_type": "Depreciation" - }, + }, "68112-Immobilisations corporelles": { "account_type": "Depreciation" - }, + }, "account_type": "Depreciation" - }, + }, "6812-Dotations aux amortissements des charges d'exploitation \u00e0 r\u00e9partir": { "account_type": "Depreciation" - }, + }, "6815-Dotations aux provisions d'exploitation": { "account_type": "Depreciation" - }, + }, "6816-Dotations aux d\u00e9pr\u00e9ciations des immobilisations incorporelles et corporelles": { "68161-Immobilisations incorporelles": { "account_type": "Depreciation" - }, + }, "68162-Immobilisations corporelles": { "account_type": "Depreciation" - }, + }, "account_type": "Depreciation" - }, + }, "6817-Dotations pour d\u00e9pr\u00e9ciations des actifs circulants": { "68173-Stocks et en-cours": { "account_type": "Depreciation" - }, + }, "68174-Cr\u00e9ances": { "account_type": "Depreciation" - }, + }, "account_type": "Depreciation" - }, + }, "account_type": "Depreciation" - }, + }, "686-Dotations aux amortissements, d\u00e9pr\u00e9ciations et provisions - Charges financi\u00e8res": { "6861-Dotations aux amortissements des primes de remboursement des obligations": { "account_type": "Depreciation" - }, + }, "6865-Dotations aux provisions financi\u00e8res": { "account_type": "Depreciation" - }, + }, "6866-Dotations aux d\u00e9pr\u00e9ciations des \u00e9l\u00e9ments financiers": { "68662-Immobilisations financi\u00e8res": { "account_type": "Depreciation" - }, + }, "68665-Valeurs mobili\u00e8res de placement": { "account_type": "Depreciation" - }, + }, "account_type": "Depreciation" - }, + }, "6868-Autres dotations": { "account_type": "Depreciation" - }, + }, "account_type": "Depreciation" - }, + }, "687-Dotations aux amortissements, d\u00e9pr\u00e9ciations et provisions - Charges exceptionnelles": { "6871-Dotations aux amortissements exceptionnels des immobilisations": { "account_type": "Depreciation" - }, + }, "6872-Dotations aux provisions r\u00e9glement\u00e9es (immobilisations)": { "68725-Amortissements d\u00e9rogatoires": { "account_type": "Depreciation" - }, + }, "account_type": "Depreciation" - }, + }, "6873-Dotations aux provisions r\u00e9glement\u00e9es (stocks)": { "account_type": "Depreciation" - }, + }, "6874-Dotations aux autres provisions r\u00e9glement\u00e9es": { "account_type": "Depreciation" - }, + }, "6875-Dotations aux provisions exceptionnelles": { "account_type": "Depreciation" - }, + }, "6876-Dotations aux d\u00e9pr\u00e9ciations exceptionnelles": { "account_type": "Depreciation" - }, + }, "account_type": "Depreciation" - }, + }, "account_type": "Depreciation" - }, + }, "69-Participation des salari\u00e9s, imp\u00f4ts sur les b\u00e9n\u00e9fices et assimil\u00e9s": { - "691-Participation des salari\u00e9s aux r\u00e9sultats": {}, + "691-Participation des salari\u00e9s aux r\u00e9sultats": {}, "695-Imp\u00f4ts sur les b\u00e9n\u00e9fices": { - "6951-Imp\u00f4ts dus en France": {}, - "6952-Contribution additionnelle \u00e0 l'imp\u00f4t sur les b\u00e9n\u00e9fices": {}, + "6951-Imp\u00f4ts dus en France": {}, + "6952-Contribution additionnelle \u00e0 l'imp\u00f4t sur les b\u00e9n\u00e9fices": {}, "6954-Imp\u00f4ts dus \u00e0 l'\u00e9tranger": {} - }, - "696-Suppl\u00e9ments d'imp\u00f4ts sur les soci\u00e9t\u00e9s, li\u00e9s aux distributions": {}, + }, + "696-Suppl\u00e9ments d'imp\u00f4ts sur les soci\u00e9t\u00e9s, li\u00e9s aux distributions": {}, "698-Int\u00e9gration fiscale": { - "6981-Int\u00e9gration fiscale - Charges": {}, + "6981-Int\u00e9gration fiscale - Charges": {}, "6989-Int\u00e9gration fiscale - Produits": {} - }, + }, "699-Produits - Report en arri\u00e8re des d\u00e9ficits": {} - }, + }, "root_type": "Expense" - }, + }, "7-Comptes de Produits": { "70-Ventes de produits fabriqu\u00e9s, prestations de services, marchandises": { "701-Ventes de produits finis": { - "7011-Produits finis (ou groupe) A": {}, + "7011-Produits finis (ou groupe) A": {}, "7012-Produits (ou groupe) B": {} - }, - "702-Ventes de produits interm\u00e9diaires": {}, - "703-Ventes de produits r\u00e9siduels": {}, + }, + "702-Ventes de produits interm\u00e9diaires": {}, + "703-Ventes de produits r\u00e9siduels": {}, "704-Travaux": { - "7041-Travaux de cat\u00e9gorie (ou activit\u00e9) A": {}, + "7041-Travaux de cat\u00e9gorie (ou activit\u00e9) A": {}, "7042-Travaux de cat\u00e9gorie (ou activit\u00e9) B": {} - }, - "705-Etudes": {}, - "706-Prestations de services": {}, + }, + "705-Etudes": {}, + "706-Prestations de services": {}, "707-Ventes de marchandises": { - "7071-Marchandises (ou groupe) A": {}, + "7071-Marchandises (ou groupe) A": {}, "7072-Marchandises (ou groupe) B": {} - }, + }, "708-Produits des activit\u00e9s annexes": { - "7081-Produits des services exploit\u00e9s dans l'int\u00e9r\u00eat du personnel": {}, - "7082-Commissions et courtages": {}, - "7083-Locations diverses": {}, - "7084-Mise \u00e0 disposition de personnel factur\u00e9e": {}, - "7085-Ports et frais accessoires factur\u00e9s": {}, - "7086-Bonis sur reprises d'emballages consign\u00e9s": {}, - "7087-Bonifications obtenues des clients et primes sur ventes": {}, + "7081-Produits des services exploit\u00e9s dans l'int\u00e9r\u00eat du personnel": {}, + "7082-Commissions et courtages": {}, + "7083-Locations diverses": {}, + "7084-Mise \u00e0 disposition de personnel factur\u00e9e": {}, + "7085-Ports et frais accessoires factur\u00e9s": {}, + "7086-Bonis sur reprises d'emballages consign\u00e9s": {}, + "7087-Bonifications obtenues des clients et primes sur ventes": {}, "7088-Autres produits d'activit\u00e9s annexes (cessions d'approvisionnements...)": {} - }, + }, "709-Rabais, remises et ristournes accord\u00e9s par l'entreprise": { - "7091-Rabais, remises et ristournes accord\u00e9s par l'entreprise - sur ventes de produits finis": {}, - "7092-Rabais, remises et ristournes accord\u00e9s par l'entreprise - sur ventes de produits interm\u00e9diaires": {}, - "7094-Rabais, remises et ristournes accord\u00e9s par l'entreprise - sur travaux": {}, - "7095-Rabais, remises et ristournes accord\u00e9s par l'entreprise - sur \u00e9tudes": {}, - "7096-Rabais, remises et ristournes accord\u00e9s par l'entreprise - sur prestations de services": {}, - "7097-Rabais, remises et ristournes accord\u00e9s par l'entreprise - sur ventes de marchandises": {}, + "7091-Rabais, remises et ristournes accord\u00e9s par l'entreprise - sur ventes de produits finis": {}, + "7092-Rabais, remises et ristournes accord\u00e9s par l'entreprise - sur ventes de produits interm\u00e9diaires": {}, + "7094-Rabais, remises et ristournes accord\u00e9s par l'entreprise - sur travaux": {}, + "7095-Rabais, remises et ristournes accord\u00e9s par l'entreprise - sur \u00e9tudes": {}, + "7096-Rabais, remises et ristournes accord\u00e9s par l'entreprise - sur prestations de services": {}, + "7097-Rabais, remises et ristournes accord\u00e9s par l'entreprise - sur ventes de marchandises": {}, "7098-Rabais, remises et ristournes accord\u00e9s par l'entreprise - sur produits des activit\u00e9s annexes": {} } - }, + }, "71-Production stock\u00e9e (ou d\u00e9stockage)": { "713-Variation des stocks (en-cours de production, produits)": { "7133-Variation des en-cours de production de biens": { - "71331-Produits en cours": {}, + "71331-Produits en cours": {}, "71335-Travaux en cours": {} - }, + }, "7134-Variation des en-cours de production de services": { - "71341-Etudes en cours": {}, + "71341-Etudes en cours": {}, "71345-Prestations de services en cours": {} - }, + }, "7135-Variation des stocks de produits": { - "71351-Produits interm\u00e9diaires": {}, - "71355-Produits finis": {}, + "71351-Produits interm\u00e9diaires": {}, + "71355-Produits finis": {}, "71358-Produits r\u00e9siduels": {} } } - }, + }, "72-Production immobilis\u00e9e": { - "721-Immobilisations incorporelles": {}, + "721-Immobilisations incorporelles": {}, "722-Immobilisations corporelles": {} - }, + }, "74-Subventions d'exploitation": { "is_group": 1 - }, + }, "75-Autres produits de gestion courante": { "751-Redevances pour concessions, brevets, licences, marques, proc\u00e9d\u00e9s, logiciels, droits et valeurs similaires": { - "7511-Redevances pour concessions, brevets, licences, marques, proc\u00e9d\u00e9s, logiciels": {}, - "7516-Droits d'auteur et de reproduction": {}, + "7511-Redevances pour concessions, brevets, licences, marques, proc\u00e9d\u00e9s, logiciels": {}, + "7516-Droits d'auteur et de reproduction": {}, "7518-Autres droits et valeurs similaires": {} - }, - "752-Revenus des immeubles non affect\u00e9s aux activit\u00e9s professionnelles": {}, - "753-Jetons de pr\u00e9sence et r\u00e9mun\u00e9rations d'administrateurs, g\u00e9rants...": {}, - "754-Ristournes per\u00e7ues des coop\u00e9ratives (provenant des exc\u00e9dents)": {}, + }, + "752-Revenus des immeubles non affect\u00e9s aux activit\u00e9s professionnelles": {}, + "753-Jetons de pr\u00e9sence et r\u00e9mun\u00e9rations d'administrateurs, g\u00e9rants...": {}, + "754-Ristournes per\u00e7ues des coop\u00e9ratives (provenant des exc\u00e9dents)": {}, "755-Quotes-parts de r\u00e9sultats sur op\u00e9rations faites en commun": { - "7551-Quote-part de perte transf\u00e9r\u00e9e (comptabilit\u00e9 du g\u00e9rant)": {}, + "7551-Quote-part de perte transf\u00e9r\u00e9e (comptabilit\u00e9 du g\u00e9rant)": {}, "7555-Quote-part de b\u00e9n\u00e9fice attribu\u00e9 (comptabilit\u00e9 des associ\u00e9s non g\u00e9rants)": {} - }, - "756-Gains de change sur cr\u00e9ances et dettes commerciales": {}, + }, + "756-Gains de change sur cr\u00e9ances et dettes commerciales": {}, "758-Produits divers de gestion courante": {} - }, + }, "76-Produits financiers": { "761-Produits de participations": { - "7611-Revenus des titres de participation": {}, - "7612-Produits de la fiducie, r\u00e9sultat de la p\u00e9riode": {}, - "7616-Revenus sur autres formes de participation": {}, + "7611-Revenus des titres de participation": {}, + "7612-Produits de la fiducie, r\u00e9sultat de la p\u00e9riode": {}, + "7616-Revenus sur autres formes de participation": {}, "7617-Revenus des cr\u00e9ances rattach\u00e9es \u00e0 des participations": {} - }, + }, "762-Produits des autres immobilisations financi\u00e8res": { - "7621-Revenus des titres immobilis\u00e9s": {}, - "7626-Revenus des pr\u00eats": {}, + "7621-Revenus des titres immobilis\u00e9s": {}, + "7626-Revenus des pr\u00eats": {}, "7627-Revenus des cr\u00e9ances immobilis\u00e9es": {} - }, + }, "763-Revenus des autres cr\u00e9ances": { - "7631-Revenus des cr\u00e9ances commerciales": {}, + "7631-Revenus des cr\u00e9ances commerciales": {}, "7638-Revenus des cr\u00e9ances diverses": {} - }, - "764-Revenus des valeurs mobili\u00e8res de placement": {}, - "765-Escomptes obtenus": {}, + }, + "764-Revenus des valeurs mobili\u00e8res de placement": {}, + "765-Escomptes obtenus": {}, "766-Gains de change financi\u00e8res": { "account_type": "Round Off" - }, - "767-Produits nets sur cessions de valeurs mobili\u00e8res de placement": {}, + }, + "767-Produits nets sur cessions de valeurs mobili\u00e8res de placement": {}, "768-Autres produits financiers": {} - }, + }, "77-Produits exceptionnels": { "771-Produits exceptionnels sur op\u00e9rations de gestion": { - "7711-D\u00e9dits et p\u00e9nalit\u00e9s per\u00e7us sur achats et sur ventes": {}, - "7713-Lib\u00e9ralit\u00e9s re\u00e7ues": {}, - "7714-Rentr\u00e9es sur cr\u00e9ances amorties": {}, - "7715-Subventions d'\u00e9quilibre": {}, - "7717-D\u00e9gr\u00e8vements d'imp\u00f4ts autres qu'imp\u00f4ts sur les b\u00e9n\u00e9fices": {}, + "7711-D\u00e9dits et p\u00e9nalit\u00e9s per\u00e7us sur achats et sur ventes": {}, + "7713-Lib\u00e9ralit\u00e9s re\u00e7ues": {}, + "7714-Rentr\u00e9es sur cr\u00e9ances amorties": {}, + "7715-Subventions d'\u00e9quilibre": {}, + "7717-D\u00e9gr\u00e8vements d'imp\u00f4ts autres qu'imp\u00f4ts sur les b\u00e9n\u00e9fices": {}, "7718-Autres produits exceptionnels sur op\u00e9rations de gestion": {} - }, - "772-(Compte \u00e0 la disposition des entit\u00e9s pour enregistrer, en cours d'exercice, les Produits sur exercices ant\u00e9rieurs)": {}, + }, + "772-(Compte \u00e0 la disposition des entit\u00e9s pour enregistrer, en cours d'exercice, les Produits sur exercices ant\u00e9rieurs)": {}, "774-Op\u00e9rations de constitution ou liquidation des fiducies": { - "7741-Op\u00e9rations li\u00e9es \u00e0 la constitution de la fiducie - transfert des \u00e9l\u00e9ments": {}, + "7741-Op\u00e9rations li\u00e9es \u00e0 la constitution de la fiducie - transfert des \u00e9l\u00e9ments": {}, "7742-Op\u00e9rations li\u00e9es \u00e0 la liquidation de la fiducie": {} - }, + }, "775-Produits des cessions d'\u00e9l\u00e9ments d'actif": { - "7751-Immobilisations incorporelles": {}, - "7752-Immobilisations corporelles": {}, - "7756-Immobilisations financi\u00e8res": {}, + "7751-Immobilisations incorporelles": {}, + "7752-Immobilisations corporelles": {}, + "7756-Immobilisations financi\u00e8res": {}, "7758-Autres \u00e9l\u00e9ments d'actif": {} - }, - "777-Quote-part des subventions d'investissement vir\u00e9e au r\u00e9sultat de l'exercice": {}, + }, + "777-Quote-part des subventions d'investissement vir\u00e9e au r\u00e9sultat de l'exercice": {}, "778-Autres produits exceptionnels": { - "7781-Bonis provenant de clauses d'indexation": {}, - "7782-Lots": {}, - "7783-Bonis provenant du rachat par l'entreprise d'actions et d'obligations \u00e9mises par elle-m\u00eame": {}, + "7781-Bonis provenant de clauses d'indexation": {}, + "7782-Lots": {}, + "7783-Bonis provenant du rachat par l'entreprise d'actions et d'obligations \u00e9mises par elle-m\u00eame": {}, "7788-Produits exceptionnels divers": {} } - }, + }, "78-Reprises sur amortissements, d\u00e9pr\u00e9ciations et provisions": { "781-Reprises sur amortissements, d\u00e9pr\u00e9ciations et provisions (\u00e0 inscrire dans les produits d'exploitation)": { "7811-Reprises sur amortissements des immobilisations incorporelles et corporelles": { - "78111-Immobilisations incorporelles": {}, + "78111-Immobilisations incorporelles": {}, "78112-Immobilisations corporelles": {} - }, - "7815-Reprises sur provisions d'exploitation": {}, + }, + "7815-Reprises sur provisions d'exploitation": {}, "7816-Reprises sur d\u00e9pr\u00e9ciations des immobilisations corporelles et incorporelles": { - "78161-Immobilisations incorporelles": {}, + "78161-Immobilisations incorporelles": {}, "78162-Immobilisations corporelles": {} - }, + }, "7817-Reprises sur d\u00e9pr\u00e9ciations des actifs circulants": { - "78173-Stocks et en-cours": {}, + "78173-Stocks et en-cours": {}, "78174-Cr\u00e9ances": {} } - }, + }, "786-Reprises sur d\u00e9pr\u00e9ciations et provisions (\u00e0 inscrire dans les produits financiers)": { - "7865-Reprises sur provisions financi\u00e8res": {}, + "7865-Reprises sur provisions financi\u00e8res": {}, "7866-Reprises sur d\u00e9pr\u00e9ciations des \u00e9l\u00e9ments financiers": { - "78662-Immobilisations financi\u00e8res": {}, + "78662-Immobilisations financi\u00e8res": {}, "78665-Valeurs mobili\u00e8res de placement": {} } - }, + }, "787-Reprises sur d\u00e9pr\u00e9ciations et provisions (\u00e0 inscrire dans les produits exceptionnels)": { "7872-Reprises sur provisions r\u00e9glement\u00e9es (immobilisations)": { - "78725-Amortissements d\u00e9rogatoires": {}, - "78726-Provision sp\u00e9ciale de r\u00e9\u00e9valuation": {}, + "78725-Amortissements d\u00e9rogatoires": {}, + "78726-Provision sp\u00e9ciale de r\u00e9\u00e9valuation": {}, "78727-Plus-values r\u00e9investies": {} - }, - "7873-Reprises sur provisions r\u00e9glement\u00e9es (stocks)": {}, - "7874-Reprises sur autres provisions r\u00e9glement\u00e9es": {}, - "7875-Reprises sur provisions exceptionnelles": {}, + }, + "7873-Reprises sur provisions r\u00e9glement\u00e9es (stocks)": {}, + "7874-Reprises sur autres provisions r\u00e9glement\u00e9es": {}, + "7875-Reprises sur provisions exceptionnelles": {}, "7876-Reprises sur d\u00e9pr\u00e9ciations exceptionnelles": {} } - }, + }, "79-Transferts de charges": { - "791-Transferts de charges d'exploitation": {}, - "796-Transferts de charges financi\u00e8res": {}, + "791-Transferts de charges d'exploitation": {}, + "796-Transferts de charges financi\u00e8res": {}, "797-Transferts de charges exceptionnelles": {} - }, + }, "root_type": "Income" } } diff --git a/erpnext/accounts/doctype/account/chart_of_accounts/verified/fr_plan_comptable_general_avec_code.json b/erpnext/accounts/doctype/account/chart_of_accounts/verified/fr_plan_comptable_general_avec_code.json new file mode 100644 index 00000000000..b6673795bea --- /dev/null +++ b/erpnext/accounts/doctype/account/chart_of_accounts/verified/fr_plan_comptable_general_avec_code.json @@ -0,0 +1,3144 @@ +{ + "country_code": "fr", + "name": "France - Plan Comptable General avec code", + "tree": { + "Comptes de Capitaux": { + "root_type": "Equity", + "Capital et R\u00e9serves": { + "Capital": { + "Capital souscrit - non appel\u00e9": { + "account_number": "1011" + }, + "Capital souscrit - appel\u00e9, non vers\u00e9": { + "account_number": "1012" + }, + "Capital souscrit - appel\u00e9, vers\u00e9": { + "Capital non amorti": { + "account_number": "10131" + }, + "Capital amorti": { + "account_number": "10132" + }, + "account_number": "1013" + }, + "Capital souscrit soumis \u00e0 des r\u00e9glementations particuli\u00e8res": { + "account_number": "1018" + }, + "account_number": "101" + }, + "Fonds fiduciaires": { + "account_number": "102" + }, + "Primes li\u00e9es au capital social": { + "Primes d'\u00e9mission": { + "account_number": "1041" + }, + "Primes de fusion": { + "account_number": "1042" + }, + "Primes d'apport": { + "account_number": "1043" + }, + "Primes de conversion d'obligations en actions": { + "account_number": "1044" + }, + "Bons de souscription d'actions": { + "account_number": "1045" + }, + "account_number": "104" + }, + "Ecarts de r\u00e9\u00e9valuation": { + "R\u00e9serve sp\u00e9ciale de r\u00e9\u00e9valuation": { + "account_number": "1051" + }, + "Ecart de r\u00e9\u00e9valuation libre": { + "account_number": "1052" + }, + "R\u00e9serve de r\u00e9\u00e9valuation": { + "account_number": "1053" + }, + "Ecarts de r\u00e9\u00e9valuation (autres op\u00e9rations l\u00e9gales)": { + "account_number": "1055" + }, + "Autres \u00e9carts de r\u00e9\u00e9valuation en France": { + "account_number": "1057" + }, + "Autres \u00e9carts de r\u00e9\u00e9valuation \u00e0 l'\u00e9tranger": { + "account_number": "1058" + }, + "account_number": "105" + }, + "R\u00e9serves": { + "R\u00e9serve l\u00e9gale": { + "R\u00e9serve l\u00e9gale proprement dite": { + "account_number": "10611" + }, + "Plus-values nettes \u00e0 long terme": { + "account_number": "10612" + }, + "account_number": "1061" + }, + "R\u00e9serves indisponibles": { + "account_number": "1062" + }, + "R\u00e9serves statutaires ou contractuelles": { + "account_number": "1063" + }, + "R\u00e9serves r\u00e9glement\u00e9es": { + "Plus-values nettes \u00e0 long terme": { + "account_number": "10641" + }, + "R\u00e9serves cons\u00e9cutives \u00e0 l'octroi de subventions d'investissement": { + "account_number": "10643" + }, + "Autres r\u00e9serves r\u00e9glement\u00e9es": { + "account_number": "10648" + }, + "account_number": "1064" + }, + "Autres r\u00e9serves": { + "R\u00e9serve de propre assureur": { + "account_number": "10681" + }, + "R\u00e9serves diverses": { + "account_number": "10688" + }, + "account_number": "1068" + }, + "account_number": "106" + }, + "Ecarts d'\u00e9quivalence": { + "account_number": "107" + }, + "Compte de l'exploitant": { + "account_number": "108" + }, + "Actionnaires: Capital souscrit - non appel\u00e9": { + "account_number": "109" + }, + "account_number": "10" + }, + "Report \u00e0 Nouveau": { + "Report \u00e0 nouveau (solde cr\u00e9diteur)": { + "account_number": "110" + }, + "Report \u00e0 nouveau (solde d\u00e9biteur)": { + "account_number": "119" + }, + "account_number": "11" + }, + "R\u00e9sultat de l'Exercice": { + "R\u00e9sultat de l'exercice (b\u00e9n\u00e9fice)": { + "account_number": "120" + }, + "R\u00e9sultat de l'exercice (perte)": { + "account_number": "129" + }, + "account_number": "12" + }, + "Subventions d'Investissement": { + "Subventions d'\u00e9quipement": { + "Etat": { + "account_number": "1311" + }, + "R\u00e9gions": { + "account_number": "1312" + }, + "D\u00e9partements": { + "account_number": "1313" + }, + "Communes": { + "account_number": "1314" + }, + "Collectivit\u00e9s publiques": { + "account_number": "1315" + }, + "Entreprises publiques": { + "account_number": "1316" + }, + "Entreprises et organismes priv\u00e9s": { + "account_number": "1317" + }, + "Autres": { + "account_number": "1318" + }, + "account_number": "131" + }, + "Autres subventions d'investissement (m\u00eame ventilation que celle du compte 131)": { + "account_number": "138" + }, + "Subventions d'investissement inscrites au compte de r\u00e9sultat": { + "Subventions d'\u00e9quipement": { + "Etat": { + "account_number": "13911" + }, + "R\u00e9gions": { + "account_number": "13912" + }, + "D\u00e9partements": { + "account_number": "13913" + }, + "Communes": { + "account_number": "13914" + }, + "Collectivit\u00e9s publiques": { + "account_number": "13915" + }, + "Entreprises publiques": { + "account_number": "13916" + }, + "Entreprises et organismes priv\u00e9s": { + "account_number": "13917" + }, + "Autres": { + "account_number": "13918" + }, + "account_number": "1391" + }, + "Autres subventions d'investissement (m\u00eame ventilation que celle du compte 1391)": { + "account_number": "1398" + }, + "account_number": "139" + }, + "account_number": "13" + }, + "Provisions R\u00e9glement\u00e9es": { + "Provisions r\u00e9glement\u00e9es relative aux immobilisations": { + "Provisions pour reconstitution des gisements miniers et p\u00e9troliers": { + "account_number": "1423" + }, + "Provisions pour investissement (participation des salari\u00e9s)": { + "account_number": "1424" + }, + "account_number": "142" + }, + "Provisions r\u00e9glement\u00e9es relatives aux stocks": { + "Hausse des prix": { + "account_number": "1431" + }, + "Fluctuation des cours": { + "account_number": "1432" + }, + "account_number": "143" + }, + "Provisions r\u00e9glement\u00e9es relatives aux autres \u00e9l\u00e9ments de l'actif": { + "account_number": "144" + }, + "Amortissements d\u00e9rogatoires": { + "account_number": "145" + }, + "Provision sp\u00e9ciale de r\u00e9\u00e9valuation": { + "account_number": "146" + }, + "Plus-values r\u00e9investies": { + "account_number": "147" + }, + "Autres provisions r\u00e9glement\u00e9es": { + "account_number": "148" + }, + "account_number": "14" + }, + "Provisions": { + "Provisions pour risques": { + "Provisions pour litiges": { + "account_number": "1511" + }, + "Provisions pour garanties donn\u00e9es aux clients": { + "account_number": "1512" + }, + "Provisions pour pertes sur march\u00e9s \u00e0 terme": { + "account_number": "1513" + }, + "Provisions pour amendes et p\u00e9nalit\u00e9s": { + "account_number": "1514" + }, + "Provisions pour pertes de change": { + "account_number": "1515" + }, + "Provisions pour pertes sur contrats": { + "account_number": "1516" + }, + "Autres provisions pour risques": { + "account_number": "1518" + }, + "account_number": "151" + }, + "Provisions pour pensions et obligations similaires": { + "account_number": "153" + }, + "Provisions pour restructurations": { + "account_number": "154" + }, + "Provisions pour imp\u00f4ts": { + "account_number": "155" + }, + "Provisions pour renouvellement des immobilisations (entreprises concessionnaires) ": { + "account_number": "156" + }, + "Provisions pour charges \u00e0 r\u00e9partir sur plusieurs exercices": { + "Provisions pour gros entretien ou grandes r\u00e9visions": { + "account_number": "1572" + }, + "account_number": "157" + }, + "Autres provisions pour charges": { + "Provisions pour remises en \u00e9tat": { + "account_number": "1581" + }, + "account_number": "158" + }, + "account_number": "15" + }, + "Emprunts et Dettes Assimil\u00e9es": { + "Emprunts obligataires convertibles": { + "account_number": "161" + }, + "Obligations repr\u00e9sentatives de passifs nets remis en fiducie": { + "account_number": "162" + }, + "Autres emprunts obligataires": { + "account_number": "163" + }, + "Emprunts aupr\u00e8s des \u00e9tablissements de cr\u00e9dit": { + "account_number": "164" + }, + "D\u00e9p\u00f4ts et cautionnements re\u00e7us": { + "D\u00e9p\u00f4ts": { + "account_number": "1651" + }, + "Cautionnements": { + "account_number": "1655" + }, + "account_number": "165" + }, + "Participation des salari\u00e9s aux r\u00e9sultats": { + "Comptes bloqu\u00e9s": { + "account_number": "1661" + }, + "Fonds de participation": { + "account_number": "1662" + }, + "account_number": "166" + }, + "Emprunts et dettes assortis de conditions particuli\u00e8res": { + "Emissions de titres participatifs": { + "account_number": "1671" + }, + "Avances conditionn\u00e9es de l'Etat": { + "account_number": "1674" + }, + "Emprunts participatifs": { + "account_number": "1675" + }, + "account_number": "167" + }, + "Autres emprunts et dettes assimil\u00e9es": { + "Autres emprunts": { + "account_number": "1681" + }, + "Rentes viag\u00e8res capitalis\u00e9es": { + "account_number": "1685" + }, + "Autres dettes": { + "account_number": "1687" + }, + "Int\u00e9r\u00eats courus": { + "Int\u00e9r\u00eats courus sur emprunts obligataires convertibles": { + "account_number": "16881" + }, + "Int\u00e9r\u00eats courus sur autres emprunts obligataires": { + "account_number": "16883" + }, + "Int\u00e9r\u00eats courus sur emprunts aupr\u00e8s des \u00e9tablissements de cr\u00e9dit": { + "account_number": "16884" + }, + "Int\u00e9r\u00eats courus sur d\u00e9p\u00f4ts et cautionnements re\u00e7us": { + "account_number": "16885" + }, + "Int\u00e9r\u00eats courus sur participation des salari\u00e9s aux r\u00e9sultats": { + "account_number": "16886" + }, + "Int\u00e9r\u00eats courus sur emprunts et dettes assortis de conditions particuli\u00e8res": { + "account_number": "16887" + }, + "Int\u00e9r\u00eats courus sur autres emprunts et dettes assimil\u00e9es": { + "account_number": "16888" + }, + "account_number": "1688" + }, + "Primes de remboursement des obligations": { + "account_number": "169" + }, + "account_number": "168" + }, + "account_number": "16" + }, + "Dettes Rattach\u00e9es \u00e0 des Participations": { + "Dettes rattach\u00e9es \u00e0 des participations (groupe)": { + "account_number": "171" + }, + "Dettes rattach\u00e9es \u00e0 des participations (hors groupe)": { + "account_number": "174" + }, + "Dettes rattach\u00e9es \u00e0 des soci\u00e9t\u00e9s en participation": { + "Principal": { + "account_number": "1781" + }, + "Int\u00e9r\u00eats courus": { + "account_number": "1788" + }, + "account_number": "178" + }, + "account_number": "17" + }, + "Comptes de liaison des \u00e9tablisssements et soci\u00e9t\u00e9s en participation": { + "Comptes de liaison des \u00e9tablissements": { + "account_number": "181" + }, + "Biens et prestations de services \u00e9chang\u00e9s entre \u00e9tablissements (charges)": { + "account_number": "186" + }, + "Biens et prestations de services \u00e9chang\u00e9s entre \u00e9tablissements (produits)": { + "account_number": "187" + }, + "Comptes de liaison des soci\u00e9t\u00e9s en participation": { + "account_number": "188" + }, + "account_number": "18" + }, + "account_number": "1" + }, + "Comptes d'Immobilisations": { + "root_type": "Asset", + "Immobilisations incorporelles": { + "Frais \u00e9tablissement": { + "Frais de constitution": { + "account_number": "2011" + }, + "Frais de premier \u00e9tablissement": { + "Frais de prospection": { + "account_number": "20121" + }, + "Frais de publicit\u00e9": { + "account_number": "20122" + }, + "account_number": "2012" + }, + "Frais d'augmentation de capital et d'op\u00e9rations diverses (fusions, scissions, transformations)": { + "account_number": "2013" + }, + "account_number": "201" + }, + "Frais de recherche et de d\u00e9veloppement": { + "account_number": "203" + }, + "Concessions et droits similaires, brevets, licences, marques, proc\u00e9d\u00e9s, logiciels, droits et valeurs similaires": { + "account_number": "205" + }, + "Droit au bail": { + "account_number": "206" + }, + "Fonds commercial": { + "account_number": "207" + }, + "Autres immobilisations incorporelles": { + "Mali de fusion sur actifs incorporels": { + "account_number": "2081" + }, + "account_number": "208" + }, + "account_number": "20" + }, + "Immobilisations corporelles": { + "account_type": "Fixed Asset", + "Terrains": { + "account_type": "Fixed Asset", + "Terrains nus": { + "account_type": "Fixed Asset", + "account_number": "2111" + }, + "Terrains am\u00e9nag\u00e9s": { + "account_type": "Fixed Asset", + "account_number": "2112" + }, + "Sous-sols et sur-sols": { + "account_type": "Fixed Asset", + "account_number": "2113" + }, + "Terrains de carri\u00e8res (tr\u00e9fonds)": { + "account_type": "Fixed Asset", + "account_number": "2114" + }, + "Terrains b\u00e2tis": { + "account_type": "Fixed Asset", + "Ensembles immobiliers industriels (A, B)": { + "account_type": "Fixed Asset", + "account_number": "21151" + }, + "Ensembles immobiliers administratifs et commerciaux (A, B)": { + "account_type": "Fixed Asset", + "account_number": "21155" + }, + "Autres ensembles immobiliers": { + "account_type": "Fixed Asset", + "Autres ensembles immobiliers affect\u00e9s aux op\u00e9rations professionnelles (A, B)": { + "account_type": "Fixed Asset", + "account_number": "211581" + }, + "Autres ensembles immobiliers affect\u00e9s aux op\u00e9rations non professionnelles (A, B)": { + "account_type": "Fixed Asset", + "account_number": "211588" + }, + "account_number": "21158" + }, + "account_number": "2115" + }, + "account_number": "211" + }, + "Agencements et am\u00e9nagements de terrains (m\u00eame ventilation que celle du compte 211)": { + "account_type": "Fixed Asset", + "account_number": "212" + }, + "Constructions": { + "account_type": "Fixed Asset", + "B\u00e2timents": { + "account_type": "Fixed Asset", + "Ensembles immobiliers industriels (A, B)": { + "account_type": "Fixed Asset", + "account_number": "21311" + }, + "Ensembles immobiliers administratifs et commerciaux (A, B)": { + "account_type": "Fixed Asset", + "account_number": "21315" + }, + "Autres ensembles immobiliers": { + "account_type": "Fixed Asset", + "Autres ensembles immobiliers affect\u00e9s aux op\u00e9rations professionnelles (A, B)": { + "account_type": "Fixed Asset", + "account_number": "213181" + }, + "Autres ensembles immobiliers affect\u00e9s aux op\u00e9rations non professionnelles (A, B)": { + "account_type": "Fixed Asset", + "account_number": "213188" + }, + "account_number": "21318" + }, + "account_number": "2131" + }, + "Installations g\u00e9n\u00e9rales, agencements, am\u00e9nagements des constructions": { + "account_type": "Fixed Asset", + "Ensembles immobiliers industriels (A, B)": { + "account_type": "Fixed Asset", + "account_number": "21351" + }, + "Ensembles immobiliers administratifs et commerciaux (A, B)": { + "account_type": "Fixed Asset", + "account_number": "21355" + }, + "Autres ensembles immobiliers": { + "account_type": "Fixed Asset", + "Autres ensembles immobiliers affect\u00e9s aux op\u00e9rations professionnelles (A, B)": { + "account_type": "Fixed Asset", + "account_number": "213581" + }, + "Autres ensembles immobiliers affect\u00e9s aux op\u00e9rations non professionnelles (A, B)": { + "account_type": "Fixed Asset", + "account_number": "213588" + }, + "account_number": "21358" + }, + "account_number": "2135" + }, + "Ouvrages d'infrastructure": { + "account_type": "Fixed Asset", + "Voies de terre": { + "account_type": "Fixed Asset", + "account_number": "21381" + }, + "Voies de fer": { + "account_type": "Fixed Asset", + "account_number": "21382" + }, + "Voies d'eau": { + "account_type": "Fixed Asset", + "account_number": "21383" + }, + "Barrages": { + "account_type": "Fixed Asset", + "account_number": "21384" + }, + "Pistes d'a\u00e9rodromes": { + "account_type": "Fixed Asset", + "account_number": "21385" + }, + "account_number": "2138" + }, + "account_number": "213" + }, + "Constructions sur sol d'autrui (m\u00eame ventilation que celle du compte 213)": { + "account_type": "Fixed Asset", + "account_number": "214" + }, + "Installations techniques, mat\u00e9riel et outillage industriels": { + "account_type": "Fixed Asset", + "Installations complexes sp\u00e9cialis\u00e9es": { + "account_type": "Fixed Asset", + "Installations complexes sp\u00e9cialis\u00e9es - sur sol propre": { + "account_type": "Fixed Asset", + "account_number": "21511" + }, + "Installations complexes sp\u00e9cialis\u00e9es - sur sol d'autrui": { + "account_type": "Fixed Asset", + "account_number": "21514" + }, + "account_number": "2151" + }, + "Installations \u00e0 caract\u00e8re sp\u00e9cifique": { + "account_type": "Fixed Asset", + "Installations \u00e0 caract\u00e8re sp\u00e9cifique - sur sol propre": { + "account_type": "Fixed Asset", + "account_number": "21531" + }, + "Installations \u00e0 caract\u00e8re sp\u00e9cifique - sur sol d'autrui": { + "account_type": "Fixed Asset", + "account_number": "21534" + }, + "account_number": "2153" + }, + "Mat\u00e9riel industriel": { + "account_type": "Fixed Asset", + "account_number": "2154" + }, + "Outillage industriel": { + "account_type": "Fixed Asset", + "account_number": "2155" + }, + "Agencements et am\u00e9nagements du mat\u00e9riel et outillage industriel": { + "account_type": "Fixed Asset", + "account_number": "2157" + }, + "account_number": "215" + }, + "Autres immobilisations corporelles": { + "account_type": "Fixed Asset", + "Installations g\u00e9n\u00e9rales, agencements, am\u00e9nagements divers": { + "account_type": "Fixed Asset", + "account_number": "2181" + }, + "Mat\u00e9riel de transport": { + "account_type": "Fixed Asset", + "account_number": "2182" + }, + "Mat\u00e9riel de bureau et mat\u00e9riel informatique": { + "account_type": "Fixed Asset", + "account_number": "2183" + }, + "Mobilier": { + "account_type": "Fixed Asset", + "account_number": "2184" + }, + "Cheptel": { + "account_type": "Fixed Asset", + "account_number": "2185" + }, + "Emballages r\u00e9cup\u00e9rables": { + "account_type": "Fixed Asset", + "account_number": "2186" + }, + "Mali de fusion sur actifs corporels": { + "account_number": "2187" + }, + "account_number": "218" + }, + "account_number": "21" + }, + "Immobilisations mises en concession": { + "account_number": "22" + }, + "Immobilisations en cours": { + "Immobilisations corporelles en cours": { + "Terrains": { + "account_number": "2312" + }, + "Constructions": { + "account_number": "2313" + }, + "Installations techniques, mat\u00e9riel et outillage industriels": { + "account_number": "2315" + }, + "Autres immobilisations corporelles": { + "account_number": "2318" + }, + "account_number": "231" + }, + "Immobilisations incorporelles en cours": { + "account_number": "232" + }, + "Avances et acomptes vers\u00e9s sur commandes d'immobilisations incorporelles": { + "account_number": "237" + }, + "Avances et acomptes vers\u00e9s sur commandes d'immobilisations corporelles": { + "Terrains": { + "account_number": "2382" + }, + "Constructions": { + "account_number": "2383" + }, + "Installations techniques, mat\u00e9riel et outillage industriels": { + "account_number": "2385" + }, + "Autres immobilisations corporelles": { + "account_number": "2388" + }, + "account_number": "238" + }, + "account_number": "23" + }, + "Parts dans des entreprises li\u00e9es et cr\u00e9ances sur des entreprises li\u00e9es": { + "is_group": 1, + "account_number": "25" + }, + "Participations et cr\u00e9ances rattach\u00e9es \u00e0 des participations": { + "Titres de participation": { + "Actions": { + "account_number": "2611" + }, + "Autres titres": { + "account_number": "2618" + }, + "account_number": "261" + }, + "Autres formes de participation": { + "Droit repr\u00e9sentatifs d'actifs nets remis en fiducie": { + "account_number": "2661" + }, + "account_number": "266" + }, + "Cr\u00e9ances rattach\u00e9es \u00e0 des participations": { + "Cr\u00e9ances rattach\u00e9es \u00e0 des participations (groupe)": { + "account_number": "2671" + }, + "Cr\u00e9ances rattach\u00e9es \u00e0 des participations (hors groupe)": { + "account_number": "2674" + }, + "Versements repr\u00e9sentatifs d'apports non capitalis\u00e9s (appel de fonds)": { + "account_number": "2675" + }, + "Avances consolidables": { + "account_number": "2676" + }, + "Autres cr\u00e9ances rattach\u00e9es \u00e0 des participations": { + "account_number": "2677" + }, + "Int\u00e9r\u00eats courus": { + "account_number": "2678" + }, + "account_number": "267" + }, + "Cr\u00e9ances rattach\u00e9es \u00e0 des soci\u00e9t\u00e9s en participation": { + "Principal": { + "account_number": "2681" + }, + "Int\u00e9r\u00eats courus": { + "account_number": "2688" + }, + "account_number": "268" + }, + "Versements restant \u00e0 effectuer sur titres de participation non lib\u00e9r\u00e9s": { + "account_number": "269" + }, + "account_number": "26" + }, + "Autres immobilisations financi\u00e8res": { + "Titres immobilis\u00e9s autres que les titres immobilis\u00e9s de l'activit\u00e9 de portefeuille (droit de propri\u00e9t\u00e9)": { + "Actions": { + "account_number": "2711" + }, + "Autres titres": { + "account_number": "2718" + }, + "account_number": "271" + }, + "Titres immobilis\u00e9s (droit de cr\u00e9ance)": { + "Obligations": { + "account_number": "2721" + }, + "Bons": { + "account_number": "2722" + }, + "account_number": "272" + }, + "Titres immobilis\u00e9s de l'activit\u00e9 de portefeuille": { + "account_number": "273" + }, + "Pr\u00eats": { + "Pr\u00eats participatifs": { + "account_number": "2741" + }, + "Pr\u00eats aux associ\u00e9s": { + "account_number": "2742" + }, + "Pr\u00eats au personnel": { + "account_number": "2743" + }, + "Autres pr\u00eats": { + "account_number": "2748" + }, + "account_number": "274" + }, + "D\u00e9p\u00f4ts et cautionnements vers\u00e9s": { + "D\u00e9p\u00f4ts": { + "account_number": "2751" + }, + "Cautionnements": { + "account_number": "2755" + }, + "account_number": "275" + }, + "Autres cr\u00e9ances immobilis\u00e9es": { + "Cr\u00e9ances diverses": { + "account_number": "2761" + }, + "Int\u00e9r\u00eats courus": { + "Int\u00e9r\u00eats courus sur titres immobilis\u00e9s (droit de cr\u00e9ance)": { + "account_number": "27682" + }, + "Int\u00e9r\u00eats courus sur pr\u00eats": { + "account_number": "27684" + }, + "Int\u00e9r\u00eats courus sur d\u00e9p\u00f4ts et cautionnements": { + "account_number": "27685" + }, + "Int\u00e9r\u00eats courus sur cr\u00e9ances diverses": { + "account_number": "27688" + }, + "account_number": "2768" + }, + "account_number": "276" + }, + "(Actions propres ou parts propres)": { + "Actions propres ou parts propres": { + "account_number": "2771" + }, + "Actions propres ou parts propres en voie d'annulation": { + "account_number": "2772" + }, + "account_number": "277" + }, + "Mali de fusion sur actifs financiers": { + "account_number": "278" + }, + "Versements restant \u00e0 effectuer sur titres immobilis\u00e9s non lib\u00e9r\u00e9s": { + "account_number": "279" + }, + "account_number": "27" + }, + "Amortissements des immobilisations": { + "account_type": "Accumulated Depreciation", + "Amortissements des immobilisations incorporelles": { + "account_type": "Accumulated Depreciation", + "Frais d'\u00e9tablissement (m\u00eame ventilation que celle du compte 212)": { + "account_type": "Accumulated Depreciation", + "account_number": "2801" + }, + "Frais de recherche et de d\u00e9veloppement": { + "account_type": "Accumulated Depreciation", + "account_number": "2803" + }, + "Concessions et droits similaires, brevets, licences, logiciels, droits et valeurs similaires": { + "account_type": "Accumulated Depreciation", + "account_number": "2805" + }, + "Fonds commercial": { + "account_type": "Accumulated Depreciation", + "account_number": "2807" + }, + "Autres immobilisations incorporelles": { + "account_type": "Accumulated Depreciation", + "Mali de fusion sur actifs incorporels": { + "account_type": "Accumulated Depreciation", + "account_number": "28081" + }, + "account_number": "2808" + }, + "account_number": "280" + }, + "Amortissements des immobilisations corporelles": { + "account_type": "Accumulated Depreciation", + "Terrains de gisement": { + "account_type": "Accumulated Depreciation", + "account_number": "2811" + }, + "Agencements, am\u00e9nagements de terrains (m\u00eame ventilation que celle du compte 212)": { + "account_type": "Accumulated Depreciation", + "account_number": "2812" + }, + "Constructions (m\u00eame ventilation que celle du compte 213)": { + "account_type": "Accumulated Depreciation", + "account_number": "2813" + }, + "Constructions sur sol d'autrui (m\u00eame ventilation que celle du compte du 214)": { + "account_type": "Accumulated Depreciation", + "account_number": "2814" + }, + "Installations techniques, mat\u00e9riel et outillage industriels (m\u00eame ventilation que celle du compte 218)": { + "account_type": "Accumulated Depreciation", + "account_number": "2815" + }, + "Autres immobilisations corporelles (m\u00eame ventilation que celle du compte 218)": { + "account_type": "Accumulated Depreciation", + "Mali de fusion sur actifs corporels": { + "account_type": "Accumulated Depreciation", + "account_number": "28187" + }, + "account_number": "2818" + }, + "account_number": "281" + }, + "Amortissements des immobilisations mises en concession": { + "account_number": "282" + }, + "account_number": "28" + }, + "D\u00e9pr\u00e9ciations des immobilisations": { + "D\u00e9pr\u00e9ciations des immobilisations incorporelles": { + "Marques, proc\u00e9d\u00e9s, droits et valeurs similaires": { + "account_number": "2905" + }, + "Droit au bail": { + "account_number": "2906" + }, + "Fonds commercial": { + "account_number": "2907" + }, + "Autres immobilisations incorporelles": { + "Mali de fusion sur actifs incorporels": { + "account_number": "29081" + }, + "account_number": "2908" + }, + "account_number": "290" + }, + "D\u00e9pr\u00e9ciations des immobilisations corporelles (m\u00eame ventilation que celle du compte 21)": { + "Terrains (autres que terrains de gisement)": { + "Mali de fusion sur actifs corporels": { + "account_number": "29187" + }, + "account_number": "2911" + }, + "account_number": "291" + }, + "D\u00e9pr\u00e9ciations des immobilisations mises en concession": { + "account_number": "292" + }, + "D\u00e9pr\u00e9ciations des immobilisations en cours": { + "Immobilisations corporelles en cours": { + "account_number": "2931" + }, + "Immobilisations incorporelles en cours": { + "account_number": "2932" + }, + "account_number": "293" + }, + "D\u00e9pr\u00e9ciations des participations et cr\u00e9ances rattach\u00e9es \u00e0 des participations": { + "Titres de participation": { + "account_number": "2961" + }, + "Autres formes de participation": { + "account_number": "2966" + }, + "Cr\u00e9ances rattach\u00e9es \u00e0 des participations (m\u00eame ventilation que celle du compte 267)": { + "account_number": "2967" + }, + "Cr\u00e9ances rattach\u00e9es \u00e0 des soci\u00e9t\u00e9s en participation (m\u00eame ventilation que celle du compte 268)": { + "account_number": "2968" + }, + "account_number": "296" + }, + "D\u00e9pr\u00e9ciations des autres immobilisations financi\u00e8res": { + "Titres immobilis\u00e9s autres que les titres immobilis\u00e9s de l'activit\u00e9 de portefeuille - droit de propri\u00e9t\u00e9": { + "account_number": "2971" + }, + "Titres immobilis\u00e9s - droit de cr\u00e9ance (m\u00eame ventilation que celle du compte 272)": { + "account_number": "2972" + }, + " Titres immobilis\u00e9s de l'activit\u00e9 de portefuille": { + "account_number": "2973" + }, + "Pr\u00eats (m\u00eame ventilation que celle du compte 274)": { + "account_number": "2974" + }, + "D\u00e9p\u00f4ts et cautionnements vers\u00e9s (m\u00eame ventilation que celle du compte 275)": { + "account_number": "2975" + }, + "Autres cr\u00e9ances immobilis\u00e9es (m\u00eame ventilation que celle du compte 276)": { + "Mali de fusion sur actifs financiers": { + "account_number": "29787" + }, + "account_number": "2976" + }, + "account_number": "297" + }, + "account_number": "29" + }, + "account_number": "2" + }, + "Comptes de Stocks et En-Cours": { + "root_type": "Asset", + "Mati\u00e8res premi\u00e8res (et fournitures)": { + "Mati\u00e8res (ou groupe) A": { + "account_number": "311" + }, + "Mati\u00e8res (ou groupe) B": { + "account_number": "312" + }, + "Fournitures A, B, C, ...": { + "account_number": "317" + }, + "account_number": "31" + }, + "Autres approvisionnements": { + "Mat\u00e8res consommables": { + "Mati\u00e8res (ou groupe) C": { + "account_number": "3211" + }, + "Mati\u00e8res (ou groupe) D": { + "account_number": "3212" + }, + "account_number": "321" + }, + "Fournitures consommables": { + "Combustibles": { + "account_number": "3221" + }, + "Produits d'entretien": { + "account_number": "3222" + }, + "Fournitures d'atelier et d'usine": { + "account_number": "3223" + }, + "Fournitures de magasin": { + "account_number": "3224" + }, + "Fournitures de bureau": { + "account_number": "3225" + }, + "account_number": "322" + }, + "Emballages": { + "Emballages perdus": { + "account_number": "3261" + }, + "Emballages r\u00e9cup\u00e9rables non identifiables": { + "account_number": "3265" + }, + "Emballages \u00e0 usage mixte": { + "account_number": "3267" + }, + "account_number": "326" + }, + "account_number": "32" + }, + "En-cours de production de biens": { + "Produits en cours": { + "Produits en cours P1": { + "account_number": "3311" + }, + "Produits en cours P2": { + "account_number": "3312" + }, + "account_number": "331" + }, + "Travaux en cours": { + "Travaux en cours T1": { + "account_number": "3351" + }, + "Travaux en cours T2": { + "account_number": "3352" + }, + "account_number": "335" + }, + "account_number": "33" + }, + "En-cours de production de services": { + "Etudes en cours": { + "Etudes en cours E1": { + "account_number": "3411" + }, + "Etudes en cours E2": { + "account_number": "3412" + }, + "account_number": "341" + }, + "Prestations de services en cours": { + "Prestations de services S1": { + "account_number": "3451" + }, + "Prestations de services S2": { + "account_number": "3452" + }, + "account_number": "345" + }, + "account_number": "34" + }, + "Stocks de produits": { + "account_type": "Stock", + "Produits interm\u00e9diaires": { + "account_type": "Stock", + "Produits interm\u00e9diaires (ou groupe) A": { + "account_type": "Stock", + "is_group": 1, + "account_number": "3511" + }, + "Produits interm\u00e9diaires (ou groupe) B": { + "account_type": "Stock", + "is_group": 1, + "account_number": "3512" + }, + "account_number": "351" + }, + "Produits finis": { + "account_type": "Stock", + "Produits finis (ou groupe) A": { + "account_type": "Stock", + "is_group": 1, + "account_number": "3551" + }, + "Produits finis (ou groupe) B": { + "account_type": "Stock", + "is_group": 1, + "account_number": "3552" + }, + "account_number": "355" + }, + "Produits r\u00e9siduels (ou mati\u00e8res de r\u00e9cup\u00e9ration)": { + "account_type": "Stock", + "D\u00e9chets": { + "account_type": "Stock", + "is_group": 1, + "account_number": "3581" + }, + "Rebuts": { + "account_type": "Stock", + "is_group": 1, + "account_number": "3585" + }, + "Mati\u00e8res de r\u00e9cup\u00e9ration": { + "account_type": "Stock", + "is_group": 1, + "account_number": "3586" + }, + "account_number": "358" + }, + "account_number": "35" + }, + "(Compte \u00e0 ouvrir, le cas \u00e9ch\u00e9ant, sous l'intitul\u00e9 \"stocks provenant d'immobilisations\")": { + "account_number": "36" + }, + "Stocks de marchandises": { + "Marchandises (ou groupe) A": { + "account_number": "371" + }, + "Marchandises (ou groupe) B": { + "account_number": "372" + }, + "account_number": "37" + }, + "Stocks en voie d'acheminement, mis en d\u00e9p\u00f4t ou donn\u00e9s en consignation (en cas d'inventaire permanent en comptabilit\u00e9 g\u00e9n\u00e9rale)": { + "account_type": "Stock", + "account_number": "38" + }, + "D\u00e9pr\u00e9ciations des stocks et en-cours": { + "D\u00e9pr\u00e9ciations des mati\u00e8res premi\u00e8res (et fournitures)": { + "Mati\u00e8res (ou groupe) A": { + "account_number": "3911" + }, + "Mati\u00e8res (ou groupe) B": { + "account_number": "3912" + }, + "Fournitures A, B, C, ...": { + "account_number": "3917" + }, + "account_number": "391" + }, + "D\u00e9pr\u00e9ciations des autres approvisionnements": { + "Mati\u00e8res consommables (m\u00eame ventilation que celle du compte 321)": { + "account_number": "3921" + }, + "Fournitures consommables (m\u00eame ventilation que celle du compte 322)": { + "account_number": "3922" + }, + "Emballages (m\u00eame ventilation que celle du compte 326)": { + "account_number": "3926" + }, + "account_number": "392" + }, + "D\u00e9pr\u00e9ciations des en-cours de production de biens": { + "Etudes en cours (m\u00eame ventilation que celle du compte 341)": { + "account_number": "3931" + }, + "Travaux en cours (m\u00eame ventilation que celle du compte 335)": { + "account_number": "3935" + }, + "account_number": "393" + }, + "D\u00e9pr\u00e9ciations des en-cours de production de services": { + "Etudes en cours (m\u00eame ventilation que celle du compte 341)": { + "account_number": "3941" + }, + "Prestations de services en cours (m\u00eame ventilation que celle du compte 345)": { + "account_number": "3945" + }, + "account_number": "394" + }, + "D\u00e9pr\u00e9ciations des stocks de produits": { + "Produits interm\u00e9diaires (m\u00eame ventilation que celle du compte 351)": { + "account_number": "3951" + }, + "Produits finis (m\u00eame ventilation que celle du compte 355)": { + "account_number": "3955" + }, + "account_number": "395" + }, + "D\u00e9pr\u00e9ciations des stocks de marchandises": { + "Marchandise (ou groupe) A": { + "account_number": "3971" + }, + "Marchandise (ou groupe) B": { + "account_number": "3972" + }, + "account_number": "397" + }, + "account_number": "39" + }, + "account_number": "3" + }, + "4-Comptes de Tiers (ACTIF)": { + "root_type": "Asset", + "40-Fournisseurs et Comptes Rattach\u00e9s (ACTIF)": { + "Fournisseurs d\u00e9biteurs": { + "Fournisseurs - Avances et acomptes vers\u00e9s sur commandes": { + "account_number": "4091" + }, + "Fournisseurs - Cr\u00e9ances pour emballages et mat\u00e9riel \u00e0 rendre": { + "account_number": "4096" + }, + "Fournisseurs - Autres avoirs": { + "Fournisseurs d'exploitation": { + "account_number": "40971" + }, + "Fournisseurs d'immobilisation": { + "account_number": "40974" + }, + "account_number": "4097" + }, + "Rabais, remises, ristournes \u00e0 obtenir et autres avoirs non encore re\u00e7us": { + "account_number": "4098" + }, + "account_number": "409" + } + }, + "41-Clients et comptes rattach\u00e9s (ACTIF)": { + "account_type": "Receivable", + "Clients et Comptes rattach\u00e9s": { + "account_type": "Receivable", + "account_number": "410" + }, + "Clients": { + "account_type": "Receivable", + "Clients - Ventes de biens ou de prestations de services": { + "account_type": "Receivable", + "account_number": "4111" + }, + "Clients - Retenues de garantie": { + "account_type": "Receivable", + "account_number": "4117" + }, + "account_number": "411" + }, + "Clients - Effets \u00e0 recevoir": { + "account_type": "Receivable", + "account_number": "413" + }, + "Clients douteux ou litigieux": { + "account_type": "Receivable", + "account_number": "416" + }, + "Clients - Produits non encore factur\u00e9s": { + "account_type": "Receivable", + "Clients - Factures \u00e0 \u00e9tablir": { + "account_type": "Receivable", + "account_number": "4181" + }, + "Clients - Int\u00e9r\u00eats courus": { + "account_type": "Receivable", + "account_number": "4188" + }, + "account_number": "418" + } + }, + "42-Personnel et comptes rattach\u00e9s (ACTIF)": { + "Personnel - Avances et acomptes": { + "account_number": "425" + } + }, + "43-S\u00e9curit\u00e9 sociale et autres organismes sociaux (ACTIF)": { + "S\u00e9curit\u00e9 sociale": { + "account_number": "431" + }, + "Autres organismes sociaux": { + "account_number": "437" + }, + "438-Organismes sociaux - Produits \u00e0 recevoir": { + "Produits \u00e0 recevoir": { + "account_number": "4387" + } + } + }, + "44-Etat et autres collectivit\u00e9s publiques (ACTIF)": { + "Etat - Subventions \u00e0 recevoir": { + "Subventions d'investissement": { + "account_number": "4411" + }, + "Subventions d'exploitation": { + "account_number": "4417" + }, + "Subventions d'\u00e9quilibre": { + "account_number": "4418" + }, + "Avances sur subventions": { + "account_number": "4419" + }, + "account_number": "441" + }, + "Op\u00e9rations particuli\u00e8res avec l'Etat, les collectivit\u00e9s publiques, les organismes internationaux": { + "Cr\u00e9ances sur l'Etat r\u00e9sultant de la suppression de la r\u00e8gle du d\u00e9calage d'un mois en mati\u00e8re de TVA": { + "account_number": "4431" + }, + "Int\u00e9r\u00eats courus sur cr\u00e9ances figurant au compte 4431": { + "account_number": "4438" + }, + "account_number": "443" + }, + "Etat - Taxes sur le chiffre d'affaires (ACTIF)": { + "TVA due intracommunautaire": { + "account_number": "4452" + }, + "Taxes sur le chiffre d'affaires d\u00e9ductibles": { + "TVA sur immobilisations": { + "account_number": "44562" + }, + "TVA transf\u00e9r\u00e9e par d'autres entreprises": { + "account_number": "44563" + }, + "TVA sur autres biens et services": { + "tax_rate": 20, + "account_number": "44566" + }, + "Cr\u00e9dit de TVA \u00e0 reporter": { + "account_number": "44567" + }, + "Taxes assimil\u00e9es \u00e0 la TVA": { + "account_number": "44568" + }, + "account_number": "4456" + }, + "4458-Taxes sur le chiffre d'affaires \u00e0 r\u00e9gulariser ou en attente (ACTIF)": { + "Acomptes - R\u00e9gime simplifi\u00e9 d'imposition": { + "account_number": "44581" + }, + "Acomptes - R\u00e9gime du forfait": { + "account_number": "44582" + }, + "Remboursement de taxes sur le chiffre d'affaires demand\u00e9": { + "account_number": "44583" + }, + "Taxes sur le chiffre d'affaires sur factures non parvenues": { + "account_number": "44586" + } + } + }, + "Etat - Charges \u00e0 payer et produits \u00e0 recevoir": { + "Charges fiscales sur cong\u00e9s \u00e0 payer": { + "account_number": "4482" + }, + "Charges \u00e0 payer": { + "account_number": "4486" + }, + "Produits \u00e0 recevoir": { + "account_number": "4487" + }, + "account_number": "448" + } + }, + "45-Groupe et associ\u00e9s (ACTIF)": { + "Associ\u00e9s - Op\u00e9rations sur le capital (ACTIF)": { + "456-Apporteurs - Capital appel\u00e9, non vers\u00e9": { + "Actionnaires - Capital souscrit et appel\u00e9, non vers\u00e9": { + "account_number": "45621" + }, + "Associ\u00e9s - Capital appel\u00e9, non vers\u00e9": { + "account_number": "45625" + }, + "account_number": "4562" + } + } + }, + "46-D\u00e9biteurs divers et cr\u00e9diteurs divers (ACTIF)": { + "Cr\u00e9ances sur cessions d'immobilisations": { + "account_number": "462" + }, + "Cr\u00e9ances sur cessions de valeurs mobili\u00e8res de placement": { + "account_number": "465" + }, + "467-Autres comptes d\u00e9biteurs ou cr\u00e9diteurs (ACTIF)": {}, + "468-Divers - Charges \u00e0 payer et produits \u00e0 recevoir (ACTIF)": { + "Produits \u00e0 recevoir": { + "account_number": "4687" + } + } + }, + "47-Comptes transitoires ou d'attente (ACTIF)": { + "471-Comptes d'attente (ACTIF)": { + "account_type": "Temporary" + }, + "Diff\u00e9rences de conversion (ACTIF)": { + "Diminution des cr\u00e9ances": { + "account_number": "4761" + }, + "Augmentation des dettes": { + "account_number": "4762" + }, + "Diff\u00e9rences compens\u00e9es par couverture de change": { + "account_number": "4768" + }, + "account_number": "476" + }, + "Autres comptes transitoires (ACTIF)": { + "Mali de fusion sur actif circulant": { + "account_number": "4781" + }, + "478-Diff\u00e9rences d'\u00e9valuation sur instruments de tr\u00e9sorerie (ACTIF)": { + "account_number": "4786" + } + } + }, + "48-Comptes de r\u00e9gularisation (ACTIF)": { + "Charges \u00e0 r\u00e9partir sur plusieurs exercices": { + "Frais d'\u00e9mission des emprunts": { + "account_number": "4816" + }, + "account_number": "481" + }, + "Charges constat\u00e9es d'avance": { + "account_number": "486" + }, + "488-Comptes de r\u00e9partition p\u00e9riodique des charges et des produits (ACTIF)": { + "Charges": { + "account_number": "4886" + } + } + }, + "49-D\u00e9pr\u00e9ciation des comptes de tiers (ACTIF)": { + "D\u00e9pr\u00e9ciations des comptes clients": { + "account_number": "491" + }, + "D\u00e9pr\u00e9ciations des comptes du groupe et des associ\u00e9s": { + "Comptes du groupe": { + "account_number": "4951" + }, + "Comptes courants des associ\u00e9s": { + "account_number": "4955" + }, + "Op\u00e9rations faites en commun et en GIE": { + "account_number": "4958" + }, + "account_number": "495" + }, + "D\u00e9pr\u00e9ciations des comptes de d\u00e9biteurs divers": { + "Cr\u00e9ances sur cessions d'immobilisations": { + "account_number": "4962" + }, + "Cr\u00e9ances sur cessions de valeurs mobili\u00e8res de placement": { + "account_number": "4965" + }, + "Autres comptes d\u00e9biteurs": { + "account_number": "4967" + }, + "account_number": "496" + } + } + }, + "4-Comptes de Tiers (PASSIF)": { + "root_type": "Liability", + "40-Fournisseurs et Comptes Rattach\u00e9s (PASSIF)": { + "account_type": "Payable", + "Fournisseurs": { + "account_type": "Payable", + "Fournisseurs - Achats de biens ou de prestations de services": { + "account_type": "Payable", + "account_number": "4011" + }, + "Fournisseurs - Retenues de garantie": { + "account_type": "Payable", + "account_number": "4017" + }, + "account_number": "401" + }, + "Fournisseurs - Effets \u00e0 payer": { + "account_type": "Payable", + "account_number": "403" + }, + "Fournisseurs d'immobilisations": { + "account_type": "Payable", + "Fournisseurs - Achats d'immobilisations": { + "account_type": "Payable", + "account_number": "4041" + }, + "Fournisseurs d'immobilisations - Retenues de garantie": { + "account_type": "Payable", + "account_number": "4047" + }, + "account_number": "404" + }, + "Fournisseurs d'immobilisations - Effets \u00e0 payer": { + "account_type": "Payable", + "account_number": "405" + }, + "Fournisseurs - Factures non parvenues": { + "account_type": "Stock Received But Not Billed", + "Fournisseurs": { + "account_type": "Stock Received But Not Billed", + "account_number": "4081" + }, + "Fournisseurs d'immobilisations": { + "account_type": "Stock Received But Not Billed", + "account_number": "4084" + }, + "Fournisseurs - Int\u00e9r\u00eats courus": { + "account_type": "Stock Received But Not Billed", + "account_number": "4088" + }, + "account_number": "408" + } + }, + "41-Clients et comptes rattach\u00e9s (PASSIF)": { + "Clients cr\u00e9diteurs": { + "Clients - Avances et acomptes re\u00e7us sur commandes": { + "account_number": "4191" + }, + "Clients - Dettes pour emballages et mat\u00e9riels consign\u00e9s": { + "account_number": "4196" + }, + "Clients - Autres avoirs": { + "account_number": "4197" + }, + "Rabais, remises, ristournes \u00e0 accorder et autres avoirs \u00e0 \u00e9tablir": { + "account_number": "4198" + }, + "account_number": "419" + } + }, + "42-Personnel et comptes rattach\u00e9s (PASSIF)": { + "Personnel - R\u00e9mun\u00e9rations dues": { + "account_number": "421" + }, + "Comit\u00e9s d'entreprises, d'\u00e9tablissement...": { + "account_number": "422" + }, + "Participation des salari\u00e9s aux r\u00e9sultats": { + "R\u00e9serve sp\u00e9ciale": { + "account_number": "4246" + }, + "Comptes courants": { + "account_number": "4248" + }, + "account_number": "424" + }, + "Personnel - D\u00e9p\u00f4ts": { + "account_number": "426" + }, + "Personnel - Oppositions": { + "account_number": "427" + }, + "Personnel - Charges \u00e0 payer et produits \u00e0 recevoir": { + "Dettes provisionn\u00e9es pour cong\u00e9s \u00e0 payer": { + "account_number": "4282" + }, + "Dettes provisionn\u00e9es pour participation des salari\u00e9s aux r\u00e9sultats": { + "account_number": "4284" + }, + "Autres charges \u00e0 payer": { + "account_number": "4286" + }, + "Produits \u00e0 recevoir": { + "account_number": "4287" + }, + "account_number": "428" + } + }, + "43-S\u00e9curit\u00e9 sociale et autres organismes sociaux (PASSIF)": { + "438-Organismes sociaux - Charges \u00e0 payer": { + "Charges sociales sur cong\u00e9s \u00e0 payer": { + "account_number": "4382" + }, + "Autres charges \u00e0 payer": { + "account_number": "4386" + } + } + }, + "44-Etat et autres collectivit\u00e9s publiques (PASSIF)": { + "Etat - Imp\u00f4ts et taxes recouvrables sur des tiers": { + "Obligataires": { + "account_number": "4424" + }, + "Associ\u00e9s": { + "account_number": "4425" + }, + "account_number": "442" + }, + "Etat - Imp\u00f4ts sur les b\u00e9n\u00e9fices": { + "account_number": "444" + }, + "Etat - Taxes sur le chiffre d'affaires (PASSIF)": { + "Taxes sur le chiffre d'affaires \u00e0 d\u00e9caisser": { + "TVA \u00e0 d\u00e9caisser": { + "account_number": "44551" + }, + "Taxes assimil\u00e9es \u00e0 la TVA": { + "account_number": "44558" + }, + "account_number": "4455" + }, + "Taxes sur le chiffre d'affaires collect\u00e9es par l'entreprise": { + "TVA collect\u00e9e": { + "account_type": "Tax", + "is_group": 1, + "account_number": "44571" + }, + "Taxes assimil\u00e9es \u00e0 la TVA": { + "account_number": "44578" + }, + "account_number": "4457" + }, + "4458-Taxes sur le chiffre d'affaires \u00e0 r\u00e9gulariser ou en attente (PASSIF)": { + "TVA r\u00e9cup\u00e9r\u00e9e d'avance": { + "account_number": "44584" + }, + "Taxes sur le chiffre d'affaires sur factures \u00e0 \u00e9tablir": { + "account_number": "44587" + } + } + }, + "Obligations cautionn\u00e9es": { + "account_number": "446" + }, + "Autres imp\u00f4ts, taxes et versements assimil\u00e9s": { + "account_number": "447" + }, + "Quotas d'\u00e9mission \u00e0 acqu\u00e9rir": { + "account_number": "449" + } + }, + "45-Groupe et associ\u00e9s (PASSIF)": { + "Groupe (PASSIF)": { + "account_number": "451" + }, + "Associ\u00e9s - Comptes courants (PASSIF)": { + "Principal (PASSIF)": { + "account_number": "4551" + }, + "Int\u00e9r\u00eats courus (PASSIF)": { + "account_number": "4558" + }, + "account_number": "455" + }, + "Associ\u00e9s - Op\u00e9rations sur le capital (PASSIF)": { + "456-Associ\u00e9s - Comptes d'apport en soci\u00e9t\u00e9": { + "Apports en nature": { + "account_number": "45611" + }, + "Apports en num\u00e9raire": { + "account_number": "45615" + }, + "account_number": "4561" + }, + "Associ\u00e9s - Versements re\u00e7us sur augmentation de capital": { + "account_number": "4563" + }, + "Associ\u00e9s - Versements anticip\u00e9s": { + "account_number": "4564" + }, + "Actionnaires d\u00e9faillants": { + "account_number": "4566" + }, + "Associ\u00e9s - Capital \u00e0 rembourser": { + "account_number": "4567" + } + }, + "Associ\u00e9s - Dividendes \u00e0 payer": { + "account_number": "457" + }, + "Associ\u00e9s - Op\u00e9rations faites en commun et en GIE": { + "Op\u00e9rations courantes": { + "account_number": "4581" + }, + "Int\u00e9r\u00eats courus": { + "account_number": "4588" + }, + "account_number": "458" + } + }, + "46-D\u00e9biteurs divers et cr\u00e9diteurs divers (PASSIF)": { + "Dettes sur acquisitions de valeurs mobili\u00e8res de placement": { + "account_number": "464" + }, + "467-Autres comptes d\u00e9biteurs ou cr\u00e9diteurs (PASSIF)": {}, + "468-Divers - Charges \u00e0 payer et produits \u00e0 recevoir (PASSIF)": { + "Charges \u00e0 payer": { + "account_number": "4686" + } + } + }, + "47-Comptes transitoires ou d'attente (PASSIF)": { + "471-Comptes d'attente (PASSIF)": { + "account_type": "Temporary" + }, + "Diff\u00e9rences de conversion (PASSIF)": { + "Augmentation des cr\u00e9ances": { + "account_number": "4771" + }, + "Diminution des dettes": { + "account_number": "4772" + }, + "Diff\u00e9rences compens\u00e9es par couverture de change": { + "account_number": "4778" + }, + "account_number": "477" + }, + "478-Autres comptes transitoires (PASSIF)": { + "Diff\u00e9rences d'\u00e9valuation sur instruments de tr\u00e9sorerie (PASSIF)": { + "account_number": "4787" + } + } + }, + "48-Comptes de r\u00e9gularisation (PASSIF)": { + "Produits constat\u00e9s d'avance": { + "account_number": "487" + }, + "448-Comptes de r\u00e9partition p\u00e9riodique des charges et des produits (PASSIF)": { + "Produits": { + "account_number": "4887" + } + } + } + }, + "Comptes Financiers": { + "root_type": "Asset", + "Valeurs mobili\u00e8res de placement": { + "Parts dans des entreprises li\u00e9es": { + "account_number": "501" + }, + "Actions propres": { + "Actions destin\u00e9es \u00e0 \u00eatre attribu\u00e9es aux employ\u00e9s et affect\u00e9es \u00e0 des plans d\u00e9termin\u00e9s": { + "account_number": "5021" + }, + "Actions disponibles pour \u00eatre attribu\u00e9es aux employ\u00e9s ou pour la r\u00e9gularisation des cours de bourse": { + "account_number": "5022" + }, + "account_number": "502" + }, + "Actions": { + "Titres cot\u00e9s": { + "account_number": "5031" + }, + "Titres non cot\u00e9s": { + "account_number": "5035" + }, + "account_number": "503" + }, + "Autres titres conf\u00e9rant un droit de propri\u00e9t\u00e9": { + "account_number": "504" + }, + "Obligations et bons \u00e9mis par la soci\u00e9t\u00e9 et rachet\u00e9s par elle": { + "account_number": "505" + }, + "Obligations": { + "Titres cot\u00e9s": { + "account_number": "5061" + }, + "Titres non cot\u00e9s": { + "account_number": "5065" + }, + "account_number": "506" + }, + "Bons du Tr\u00e9sor et bons de caisse \u00e0 court terme": { + "account_number": "507" + }, + "Autres valeurs mobili\u00e8res de placement et autres cr\u00e9ances assimil\u00e9es": { + "Autres valeurs mobili\u00e8res": { + "account_number": "5081" + }, + "Bons de souscription": { + "account_number": "5082" + }, + "Int\u00e9r\u00eats courus sur obligations, bons et valeurs assimil\u00e9es": { + "account_number": "5088" + }, + "account_number": "508" + }, + "Versements restant \u00e0 effectuer sur valeurs mobili\u00e8res de placement non lib\u00e9r\u00e9es": { + "account_number": "509" + }, + "account_number": "50" + }, + "Banques, \u00e9tablissements financiers et assimil\u00e9s": { + "Valeurs \u00e0 l'encaissement": { + "Coupons \u00e9chus \u00e0 l'encaissement": { + "account_number": "5111" + }, + "Ch\u00e8ques \u00e0 encaisser": { + "account_number": "5112" + }, + "Effets \u00e0 l'encaissement": { + "account_number": "5113" + }, + "Effets \u00e0 l'escompte": { + "account_number": "5114" + }, + "account_number": "511" + }, + "Banques": { + "account_type": "Bank", + "Comptes en monnaie nationale": { + "account_type": "Bank", + "account_number": "5121" + }, + "Comptes en devises": { + "account_type": "Bank", + "account_number": "5124" + }, + "account_number": "512" + }, + "Ch\u00e8ques postaux": { + "account_number": "514" + }, + "\"Caisses\" du Tr\u00e9sor et des \u00e9tablissements publics": { + "account_number": "515" + }, + "Soci\u00e9t\u00e9s de bourse": { + "account_number": "516" + }, + "Autres organismes financiers": { + "account_number": "517" + }, + "Int\u00e9r\u00eats courus": { + "Int\u00e9r\u00eats courus \u00e0 payer": { + "account_number": "5181" + }, + "Int\u00e9r\u00eats courus \u00e0 recevoir": { + "account_number": "5188" + }, + "account_number": "518" + }, + "Concours bancaires courants": { + "Cr\u00e9dit de mobilisation des cr\u00e9ances commerciales (CMCC)": { + "account_number": "5191" + }, + "Mobilisation de cr\u00e9ances n\u00e9es \u00e0 l'\u00e9tranger": { + "account_number": "5193" + }, + "Int\u00e9r\u00eats courus sur concours bancaires courants": { + "account_number": "5198" + }, + "account_number": "519" + }, + "account_number": "51" + }, + "Instruments de tr\u00e9sorerie": { + "is_group": 1, + "account_number": "52" + }, + "Caisse": { + "account_type": "Cash", + "Caisse si\u00e8ge social": { + "account_type": "Cash", + "Caisse en monnaie nationale": { + "account_type": "Cash", + "account_number": "5311" + }, + "Caisse en devises": { + "account_type": "Cash", + "account_number": "5314" + }, + "account_number": "531" + }, + "Caisse succursale (ou usine) A": { + "account_type": "Cash", + "account_number": "532" + }, + "Caisse succursale (ou usine) B": { + "account_type": "Cash", + "account_number": "533" + }, + "account_number": "53" + }, + "R\u00e9gies d'avance et accr\u00e9ditifs": { + "is_group": 1, + "account_number": "54" + }, + "Virements internes": { + "is_group": 1, + "account_number": "58" + }, + "D\u00e9pr\u00e9ciations des comptes financiers": { + "D\u00e9pr\u00e9ciations des valeurs mobili\u00e8res de placement": { + "Actions": { + "account_number": "5903" + }, + "Autres titres conf\u00e9rant un droit de propri\u00e9t\u00e9": { + "account_number": "5904" + }, + "Obligations": { + "account_number": "5906" + }, + "Autres valeurs mobili\u00e8res de placement et cr\u00e9ances assimil\u00e9es": { + "account_number": "5908" + }, + "account_number": "590" + }, + "account_number": "59" + }, + "account_number": "5" + }, + "Comptes de Charges": { + "root_type": "Expense", + "Achats (sauf 603)": { + "Achats stock\u00e9s - Mati\u00e8res premi\u00e8res (et fournitures)": { + "account_type": "Cost of Goods Sold", + "Mati\u00e8res (ou groupe) A": { + "account_type": "Cost of Goods Sold", + "account_number": "6011" + }, + "Mati\u00e8res (ou groupe) B": { + "account_type": "Cost of Goods Sold", + "account_number": "6012" + }, + "Fournitures A, B, C...": { + "account_type": "Cost of Goods Sold", + "account_number": "6017" + }, + "account_number": "601" + }, + "Achats stock\u00e9s - Autres approvisionnements": { + "account_type": "Cost of Goods Sold", + "Mati\u00e8res consommables": { + "account_type": "Cost of Goods Sold", + "Mati\u00e8res (ou groupe) C": { + "account_type": "Cost of Goods Sold", + "account_number": "60211" + }, + "Mati\u00e8res (ou groupe) D": { + "account_type": "Cost of Goods Sold", + "account_number": "60212" + }, + "account_number": "6021" + }, + "Fournitures consommables": { + "account_type": "Cost of Goods Sold", + "Combustibles": { + "account_type": "Cost of Goods Sold", + "account_number": "60221" + }, + "Produits d'entretien": { + "account_type": "Cost of Goods Sold", + "account_number": "60222" + }, + "Fournitures d'atelier et d'usine": { + "account_type": "Cost of Goods Sold", + "account_number": "60223" + }, + "Fournitures de magasin": { + "account_type": "Cost of Goods Sold", + "account_number": "60224" + }, + "Fournitures de bureau": { + "account_type": "Cost of Goods Sold", + "account_number": "60225" + }, + "account_number": "6022" + }, + "Emballages": { + "account_type": "Cost of Goods Sold", + "Emballages perdus": { + "account_type": "Cost of Goods Sold", + "account_number": "60261" + }, + "Emballages r\u00e9cup\u00e9rables non identifiables": { + "account_type": "Cost of Goods Sold", + "account_number": "60265" + }, + "Emballages \u00e0 usage mixte": { + "account_type": "Cost of Goods Sold", + "account_number": "60267" + }, + "account_number": "6026" + }, + "account_number": "602" + }, + "Variations des stocks (approvisionnements et marchandises)": { + "account_type": "Stock Adjustment", + "Variation des stocks de mati\u00e8res premi\u00e8res (et fournitures)": { + "account_type": "Stock Adjustment", + "account_number": "6031" + }, + "Variation des stocks des autres approvisionnements": { + "account_type": "Stock Adjustment", + "account_number": "6032" + }, + "Variation des stocks de marchandises": { + "account_type": "Stock Adjustment", + "account_number": "6037" + }, + "account_number": "603" + }, + "Achats d'\u00e9tudes et prestations de service": { + "account_type": "Cost of Goods Sold", + "account_number": "604" + }, + "Achats de mat\u00e9riel, \u00e9quipements et travaux": { + "account_type": "Cost of Goods Sold", + "account_number": "605" + }, + "Achats non stock\u00e9s de mati\u00e8res et founitures": { + "account_type": "Cost of Goods Sold", + "Fournitures non stockables (eau, \u00e9nergie...)": { + "account_type": "Cost of Goods Sold", + "account_number": "6061" + }, + "Fournitures d'entretien et de petit \u00e9quipement": { + "account_type": "Cost of Goods Sold", + "account_number": "6063" + }, + "Fournitures administratives": { + "account_type": "Cost of Goods Sold", + "account_number": "6064" + }, + "Autres mati\u00e8res et fournitures": { + "account_type": "Cost of Goods Sold", + "account_number": "6068" + }, + "account_number": "606" + }, + "Achats de marchandises": { + "account_type": "Cost of Goods Sold", + "Marchandises (ou groupe) A": { + "account_type": "Cost of Goods Sold", + "account_number": "6071" + }, + "Marchandises (ou groupe) B": { + "account_type": "Cost of Goods Sold", + "account_number": "6072" + }, + "account_number": "607" + }, + "(Compte r\u00e9serv\u00e9, le cas \u00e9ch\u00e9ant, \u00e0 la recapitulation des Frais accessoires incorpor\u00e9s aux achats)": { + "account_type": "Expenses Included In Valuation", + "account_number": "608" + }, + "Rabais, remises et ristournes obtenus sur achats": { + "Rabais, remises et ristournes obtenus sur achats - de mati\u00e8res premi\u00e8res (et fournitures)": { + "account_number": "6091" + }, + "Rabais, remises et ristournes obtenus sur achats - d'autres approvisionnements stock\u00e9s": { + "account_number": "6092" + }, + "Rabais, remises et ristournes obtenus sur achats - d'\u00e9tudes et prestations de services": { + "account_number": "6094" + }, + "Rabais, remises et ristournes obtenus sur achats - de mat\u00e9riel, \u00e9quipements et travaux": { + "account_number": "6095" + }, + "Rabais, remises et ristournes obtenus sur achats - d'approvisionnements non stock\u00e9s": { + "account_number": "6096" + }, + "Rabais, remises et ristournes obtenus sur achats - de marchandises": { + "account_number": "6097" + }, + "Rabais, remises et ristournes non affect\u00e9s": { + "account_number": "6098" + }, + "account_number": "609" + }, + "account_number": "60" + }, + "Services ext\u00e9rieurs": { + "Sous-traitance g\u00e9n\u00e9rale": { + "account_number": "611" + }, + "Redevances de cr\u00e9dit-bail": { + "Cr\u00e9dit-bail mobilier": { + "account_number": "6122" + }, + "Cr\u00e9dit-bail immobilier": { + "account_number": "6125" + }, + "account_number": "612" + }, + "Locations": { + "Locations immobili\u00e8res": { + "account_number": "6132" + }, + "Locations mobili\u00e8res": { + "account_number": "6135" + }, + "Malis sur emballages": { + "account_number": "6136" + }, + "account_number": "613" + }, + "Charges locatives et de copropri\u00e9t\u00e9": { + "account_number": "614" + }, + "Entretiens et r\u00e9parations": { + "Entretiens et r\u00e9parations - sur biens immobiliers": { + "account_number": "6152" + }, + "Entretiens et r\u00e9parations - sur biens mobiliers": { + "account_number": "6155" + }, + "Maintenance": { + "account_number": "6156" + }, + "account_number": "615" + }, + "Primes d'assurance": { + "Multirisques": { + "account_number": "6161" + }, + "Assurance obligatoire dommage construction": { + "account_number": "6162" + }, + "Assurance-transport": { + "Assurance-transport - sur achats": { + "account_number": "61636" + }, + "Assurance-transport - sur ventes": { + "account_number": "61637" + }, + "Assurance-transport - sur autres biens": { + "account_number": "61638" + }, + "account_number": "6163" + }, + "Risques d'exploitation": { + "account_number": "6164" + }, + "Insolvabilit\u00e9 clients": { + "account_number": "6165" + }, + "account_number": "616" + }, + "Etudes et recherches": { + "account_number": "617" + }, + "Divers": { + "Documentation g\u00e9n\u00e9rale": { + "account_number": "6181" + }, + "Documentation technique": { + "account_number": "6183" + }, + "Frais de colloques, s\u00e9minaires, conf\u00e9rences": { + "account_number": "6185" + }, + "account_number": "618" + }, + "Rabais, remises et ristournes obtenus sur services ext\u00e9rieurs": { + "account_number": "619" + }, + "account_number": "61" + }, + "Autres services ext\u00e9rieurs": { + "Personnel ext\u00e9rieur \u00e0 l'entreprise": { + "Personnel int\u00e9rimaire": { + "account_number": "6211" + }, + "Personnel d\u00e9tach\u00e9 ou pr\u00eat\u00e9 \u00e0 l'entreprise": { + "account_number": "6214" + }, + "account_number": "621" + }, + "R\u00e9mun\u00e9rations d'interm\u00e9diaires et honoraires": { + "Commissions et courtages sur achats": { + "account_number": "6221" + }, + "Commissions et courtages sur ventes": { + "account_number": "6222" + }, + "R\u00e9mun\u00e9rations des transitaires": { + "account_number": "6224" + }, + "R\u00e9mun\u00e9rations d'affacturage": { + "account_number": "6225" + }, + "Honoraires": { + "account_number": "6226" + }, + "Frais d'actes et de contentieux": { + "account_number": "6227" + }, + "Divers": { + "account_number": "6228" + }, + "account_number": "622" + }, + "Publicit\u00e9, publications, relations publiques": { + "Annonces et insertions": { + "account_number": "6231" + }, + "Echantillons": { + "account_number": "6232" + }, + "Foires et expositions": { + "account_number": "6233" + }, + "Cadeaux \u00e0 la client\u00e8le": { + "account_number": "6234" + }, + "Primes": { + "account_number": "6235" + }, + "Catalogues et imprim\u00e9s": { + "account_number": "6236" + }, + "Publications": { + "account_number": "6237" + }, + "Divers (pourboires, dons courants...)": { + "account_number": "6238" + }, + "account_number": "623" + }, + "Transports de biens et transports collectifs du personnel": { + "Transports sur achats": { + "account_number": "6241" + }, + "Transports sur ventes": { + "account_type": "Chargeable", + "account_number": "6242" + }, + "Transports entre \u00e9tablissements ou chantiers": { + "account_number": "6243" + }, + "Transports administratifs": { + "account_number": "6244" + }, + "Transports collectifs du personnel": { + "account_number": "6247" + }, + "Divers": { + "account_number": "6248" + }, + "account_number": "624" + }, + "D\u00e9placements, missions et r\u00e9ceptions": { + "Voyages et d\u00e9placements": { + "account_number": "6251" + }, + "Frais de d\u00e9m\u00e9nagement": { + "account_number": "6255" + }, + "Missions": { + "account_number": "6256" + }, + "R\u00e9ceptions": { + "account_number": "6257" + }, + "account_number": "625" + }, + "Frais postaux et de t\u00e9l\u00e9communications": { + "account_number": "626" + }, + "Services bancaires et assimil\u00e9s": { + "Frais sur titres (achat, vente, garde)": { + "account_number": "6271" + }, + "Commissions et frais sur \u00e9mission d'emprunts": { + "account_number": "6272" + }, + "Frais sur effets": { + "account_number": "6275" + }, + "Location de coffres": { + "account_number": "6276" + }, + "Autres frais et commissions sur prestations de services": { + "account_number": "6278" + }, + "account_number": "627" + }, + "Divers": { + "Concours divers (cotisations...)": { + "account_number": "6281" + }, + "Frais de recrutement de personnel": { + "account_number": "6284" + }, + "account_number": "628" + }, + "Rabais, remises et ristournes obtenus sur autres services ext\u00e9rieurs": { + "account_number": "629" + }, + "account_number": "62" + }, + "Imp\u00f4ts, taxes et versements assimil\u00e9s": { + "Imp\u00f4ts, taxes et versements assimil\u00e9s sur r\u00e9mun\u00e9rations (administrations des imp\u00f4ts)": { + "Taxes sur les salaires": { + "account_number": "6311" + }, + "Taxe d'apprentissage": { + "account_number": "6312" + }, + "Participation des employeurs \u00e0 la formation professionnelle continue": { + "account_number": "6313" + }, + "Cotisation pour d\u00e9faut d'investissement obligatoire dans la construction": { + "account_number": "6314" + }, + "Autres": { + "account_number": "6318" + }, + "account_number": "631" + }, + "Imp\u00f4ts, taxes et versements assimil\u00e9s sur r\u00e9mun\u00e9rations (autres organismes)": { + "Versement de transport": { + "account_number": "6331" + }, + "Allocations logement": { + "account_number": "6332" + }, + "Participation des employeurs \u00e0 la formation professionnelle continue": { + "account_number": "6333" + }, + "Participation des employeurs \u00e0 l'effort de construction": { + "account_number": "6334" + }, + "Versements lib\u00e9ratoires ouvrant droit \u00e0 l'\u00e9xon\u00e9ration de la taxe d'apprentissage": { + "account_number": "6335" + }, + "Autres": { + "account_number": "6338" + }, + "account_number": "633" + }, + "Autres imp\u00f4ts, taxes et versements assimil\u00e9s (administrations des imp\u00f4ts)": { + "Imp\u00f4ts directs (sauf imp\u00f4ts sur les b\u00e9n\u00e9fices)": { + "Contribution \u00e9conomique territoriale": { + "account_number": "63511" + }, + "Taxes fonci\u00e8res": { + "account_number": "63512" + }, + "Autres imp\u00f4ts locaux": { + "account_number": "63513" + }, + "Taxe sur les v\u00e9hicules des soci\u00e9t\u00e9s": { + "account_number": "63514" + }, + "account_number": "6351" + }, + "Taxes sur le chiffre d'affaires non r\u00e9cup\u00e9rables": { + "account_number": "6352" + }, + "Imp\u00f4ts indirects": { + "account_number": "6353" + }, + "Droits d'enregistrement et de timbre": { + "Droits de mutation": { + "account_number": "63541" + }, + "account_number": "6354" + }, + "Autres droits": { + "account_number": "6358" + }, + "account_number": "635" + }, + "Autres imp\u00f4ts, taxes et versements assimil\u00e9s (autres organismes)": { + "Contribution sociale de solidarit\u00e9 \u00e0 la charge des soci\u00e9t\u00e9s": { + "account_number": "6371" + }, + "Taxes per\u00e7ues par les organismes publics internationaux": { + "account_number": "6372" + }, + "Imp\u00f4ts et taxes exigibles \u00e0 l'\u00e9tranger": { + "account_number": "6374" + }, + "Taxes diverses": { + "account_number": "6378" + }, + "account_number": "637" + }, + "account_number": "63" + }, + "Charges de personnel": { + "R\u00e9mun\u00e9rations du personnel": { + "Salaires, appointements": { + "account_number": "6411" + }, + "Cong\u00e9s pay\u00e9s": { + "account_number": "6412" + }, + "Primes et gratifications": { + "account_number": "6413" + }, + "Indemnit\u00e9s et avantages divers": { + "account_number": "6414" + }, + "Suppl\u00e9ment familial": { + "account_number": "6415" + }, + "account_number": "641" + }, + "R\u00e9mun\u00e9ration du travail de l'exploitant": { + "account_number": "644" + }, + "Charges de s\u00e9curit\u00e9 sociale et de pr\u00e9voyance": { + "Cotisations \u00e0 l'URSSAF": { + "account_number": "6451" + }, + "Cotisations aux mutuelles": { + "account_number": "6452" + }, + "Cotisations aux caisses de retraites": { + "account_number": "6453" + }, + "Cotisations aux ASSEDIC": { + "account_number": "6454" + }, + "account_number": "645" + }, + "Cotisations sociales personnelles de l'exploitant": { + "account_number": "646" + }, + "Autres charges sociales": { + "is_group": 1, + "account_number": "647" + }, + "Autres charges de personnel": { + "account_number": "648" + }, + "account_number": "64" + }, + "Autres charges de gestion courante": { + "Redevances pour concessions, brevets, licences, marques, proc\u00e9d\u00e9s, logiciels, droits et valeurs similaires": { + "Redevances pour concessions, brevets, licences, marques, proc\u00e9d\u00e9s, logiciels": { + "account_number": "6511" + }, + "Droits d'auteur et de reproduction": { + "account_number": "6516" + }, + "Autres droits et valeurs similaires": { + "account_number": "6518" + }, + "account_number": "651" + }, + "Jetons de pr\u00e9sence": { + "account_number": "653" + }, + "Pertes sur cr\u00e9ances irr\u00e9couvrables": { + "Cr\u00e9ances de l'exercice": { + "account_number": "6541" + }, + "Cr\u00e9ances des exercices ant\u00e9rieurs": { + "account_number": "6544" + }, + "account_number": "654" + }, + "Quotes-parts de r\u00e9sultat sur op\u00e9rations faites en commun": { + "Quote-part de b\u00e9n\u00e9fice transf\u00e9r\u00e9e (comptabilit\u00e9 du g\u00e9rant)": { + "account_number": "6551" + }, + "Quote-part de perte support\u00e9e (comptabilit\u00e9 des associ\u00e9s non g\u00e9rants)": { + "account_number": "6555" + }, + "account_number": "655" + }, + "Pertes de change sur cr\u00e9ances et dettes commerciales": { + "account_number": "656" + }, + "Charges diverses de gestion courante": { + "account_number": "658" + }, + "account_number": "65" + }, + "Charges financi\u00e8res": { + "Charges d'int\u00e9r\u00eats": { + "Int\u00e9r\u00eats des emprunts et dettes": { + "Int\u00e9r\u00eats des emprunts et dettes - des emprunts et dettes assimil\u00e9es": { + "account_number": "66116" + }, + "Int\u00e9r\u00eats des emprunts et dettes - des dettes rattach\u00e9es \u00e0 des participations": { + "account_number": "66117" + }, + "account_number": "6611" + }, + "Charges de la fiducie, r\u00e9sultat de la p\u00e9riode": { + "account_number": "6612" + }, + "Int\u00e9r\u00eats des comptes courants et des d\u00e9p\u00f4ts cr\u00e9diteurs": { + "account_number": "6615" + }, + "Int\u00e9r\u00eats bancaires et sur op\u00e9rations de financement (escompte...)": { + "account_number": "6616" + }, + "Int\u00e9r\u00eats des obligations cautionn\u00e9es": { + "account_number": "6617" + }, + "Int\u00e9r\u00eats des autres dettes": { + "Int\u00e9r\u00eats des autres dettes - des dettes commerciales": { + "account_number": "66181" + }, + "Int\u00e9r\u00eats des autres dettes - des dettes diverses": { + "account_number": "66188" + }, + "account_number": "6618" + }, + "account_number": "661" + }, + "Pertes sur cr\u00e9ances li\u00e9es \u00e0 des participations": { + "account_number": "664" + }, + "Escomptes accord\u00e9s": { + "account_number": "665" + }, + "Pertes de change financi\u00e8res": { + "account_type": "Round Off", + "account_number": "666" + }, + "Charges nettes sur cessions de valeurs mobili\u00e8res de placement": { + "account_number": "667" + }, + "Autres charges financi\u00e8res": { + "account_number": "668" + }, + "account_number": "66" + }, + "Charges exceptionnelles": { + "Charges exceptionnelles sur op\u00e9rations de gestion": { + "P\u00e9nalit\u00e9s sur march\u00e9s (et d\u00e9dits pay\u00e9s sur achats et ventes)": { + "account_number": "6711" + }, + "P\u00e9nalit\u00e9s, amendes fiscales et p\u00e9nales": { + "account_number": "6712" + }, + "Dons, lib\u00e9ralit\u00e9s": { + "account_number": "6713" + }, + "Cr\u00e9ances devenues irr\u00e9couvrables dans l'exercice": { + "account_number": "6714" + }, + "Subventions accord\u00e9es": { + "account_number": "6715" + }, + "Rappel d'imp\u00f4ts (autres qu'imp\u00f4ts sur les b\u00e9n\u00e9fices)": { + "account_number": "6717" + }, + "Autres charges exceptionnelles sur op\u00e9rations de gestion": { + "account_number": "6718" + }, + "account_number": "671" + }, + "(Compte \u00e0 la disposition des entit\u00e9s pour enregistrer, en cours d'exercice, les charges sur exercices ant\u00e9rieurs)": { + "account_number": "672" + }, + "Op\u00e9rations de constitution ou liquidation des fiducies": { + "Op\u00e9rations li\u00e9es \u00e0 la constitution de la fiducie - transfert des \u00e9l\u00e9ments": { + "account_number": "6741" + }, + "Op\u00e9rations li\u00e9es \u00e0 la liquidation de la fiducie": { + "account_number": "6742" + }, + "account_number": "674" + }, + "Valeurs comptables des \u00e9l\u00e9ments d'actif c\u00e9d\u00e9s": { + "Immobilisations incorporelles": { + "account_number": "6751" + }, + "Immobilisations corporelles": { + "account_number": "6752" + }, + "Immobilisations financi\u00e8res": { + "account_number": "6756" + }, + "Autres \u00e9l\u00e9ments d'actif": { + "account_number": "6758" + }, + "account_number": "675" + }, + "Autres charges exceptionnelles": { + "Mali provenant de clauses d'indexation": { + "account_number": "6781" + }, + "Lots": { + "account_number": "6782" + }, + "Malis provenant du rachat par l'entreprise d'actions et obligations \u00e9mises par elles-m\u00eame": { + "account_number": "6783" + }, + "Charges exceptionnelles diverses": { + "account_number": "6788" + }, + "account_number": "678" + }, + "account_number": "67" + }, + "Dotations aux amortissements, d\u00e9pr\u00e9ciations et provisions": { + "account_type": "Depreciation", + "Dotations aux amortissements, d\u00e9pr\u00e9ciations et provisions - Charges d'exploitation": { + "account_type": "Depreciation", + "Dotations aux amortissements sur immobilisations incorporelles et corporelles": { + "account_type": "Depreciation", + "Immobilisations incorporelles": { + "account_type": "Depreciation", + "account_number": "68111" + }, + "Immobilisations corporelles": { + "account_type": "Depreciation", + "account_number": "68112" + }, + "account_number": "6811" + }, + "Dotations aux amortissements des charges d'exploitation \u00e0 r\u00e9partir": { + "account_type": "Depreciation", + "account_number": "6812" + }, + "Dotations aux provisions d'exploitation": { + "account_type": "Depreciation", + "account_number": "6815" + }, + "Dotations aux d\u00e9pr\u00e9ciations des immobilisations incorporelles et corporelles": { + "account_type": "Depreciation", + "Immobilisations incorporelles": { + "account_type": "Depreciation", + "account_number": "68161" + }, + "Immobilisations corporelles": { + "account_type": "Depreciation", + "account_number": "68162" + }, + "account_number": "6816" + }, + "Dotations pour d\u00e9pr\u00e9ciations des actifs circulants": { + "account_type": "Depreciation", + "Stocks et en-cours": { + "account_type": "Depreciation", + "account_number": "68173" + }, + "Cr\u00e9ances": { + "account_type": "Depreciation", + "account_number": "68174" + }, + "account_number": "6817" + }, + "account_number": "681" + }, + "Dotations aux amortissements, d\u00e9pr\u00e9ciations et provisions - Charges financi\u00e8res": { + "account_type": "Depreciation", + "Dotations aux amortissements des primes de remboursement des obligations": { + "account_type": "Depreciation", + "account_number": "6861" + }, + "Dotations aux provisions financi\u00e8res": { + "account_type": "Depreciation", + "account_number": "6865" + }, + "Dotations aux d\u00e9pr\u00e9ciations des \u00e9l\u00e9ments financiers": { + "account_type": "Depreciation", + "Immobilisations financi\u00e8res": { + "account_type": "Depreciation", + "account_number": "68662" + }, + "Valeurs mobili\u00e8res de placement": { + "account_type": "Depreciation", + "account_number": "68665" + }, + "account_number": "6866" + }, + "Autres dotations": { + "account_type": "Depreciation", + "account_number": "6868" + }, + "account_number": "686" + }, + "Dotations aux amortissements, d\u00e9pr\u00e9ciations et provisions - Charges exceptionnelles": { + "account_type": "Depreciation", + "Dotations aux amortissements exceptionnels des immobilisations": { + "account_type": "Depreciation", + "account_number": "6871" + }, + "Dotations aux provisions r\u00e9glement\u00e9es (immobilisations)": { + "account_type": "Depreciation", + "Amortissements d\u00e9rogatoires": { + "account_type": "Depreciation", + "account_number": "68725" + }, + "account_number": "6872" + }, + "Dotations aux provisions r\u00e9glement\u00e9es (stocks)": { + "account_type": "Depreciation", + "account_number": "6873" + }, + "Dotations aux autres provisions r\u00e9glement\u00e9es": { + "account_type": "Depreciation", + "account_number": "6874" + }, + "Dotations aux provisions exceptionnelles": { + "account_type": "Depreciation", + "account_number": "6875" + }, + "Dotations aux d\u00e9pr\u00e9ciations exceptionnelles": { + "account_type": "Depreciation", + "account_number": "6876" + }, + "account_number": "687" + }, + "account_number": "68" + }, + "Participation des salari\u00e9s, imp\u00f4ts sur les b\u00e9n\u00e9fices et assimil\u00e9s": { + "Participation des salari\u00e9s aux r\u00e9sultats": { + "account_number": "691" + }, + "Imp\u00f4ts sur les b\u00e9n\u00e9fices": { + "Imp\u00f4ts dus en France": { + "account_number": "6951" + }, + "Contribution additionnelle \u00e0 l'imp\u00f4t sur les b\u00e9n\u00e9fices": { + "account_number": "6952" + }, + "Imp\u00f4ts dus \u00e0 l'\u00e9tranger": { + "account_number": "6954" + }, + "account_number": "695" + }, + "Suppl\u00e9ments d'imp\u00f4ts sur les soci\u00e9t\u00e9s, li\u00e9s aux distributions": { + "account_number": "696" + }, + "Int\u00e9gration fiscale": { + "Int\u00e9gration fiscale - Charges": { + "account_number": "6981" + }, + "Int\u00e9gration fiscale - Produits": { + "account_number": "6989" + }, + "account_number": "698" + }, + "Produits - Report en arri\u00e8re des d\u00e9ficits": { + "account_number": "699" + }, + "account_number": "69" + }, + "account_number": "6" + }, + "Comptes de Produits": { + "root_type": "Income", + "Ventes de produits fabriqu\u00e9s, prestations de services, marchandises": { + "Ventes de produits finis": { + "Produits finis (ou groupe) A": { + "account_number": "7011" + }, + "Produits (ou groupe) B": { + "account_number": "7012" + }, + "account_number": "701" + }, + "Ventes de produits interm\u00e9diaires": { + "account_number": "702" + }, + "Ventes de produits r\u00e9siduels": { + "account_number": "703" + }, + "Travaux": { + "Travaux de cat\u00e9gorie (ou activit\u00e9) A": { + "account_number": "7041" + }, + "Travaux de cat\u00e9gorie (ou activit\u00e9) B": { + "account_number": "7042" + }, + "account_number": "704" + }, + "Etudes": { + "account_number": "705" + }, + "Prestations de services": { + "account_number": "706" + }, + "Ventes de marchandises": { + "Marchandises (ou groupe) A": { + "account_number": "7071" + }, + "Marchandises (ou groupe) B": { + "account_number": "7072" + }, + "account_number": "707" + }, + "Produits des activit\u00e9s annexes": { + "Produits des services exploit\u00e9s dans l'int\u00e9r\u00eat du personnel": { + "account_number": "7081" + }, + "Commissions et courtages": { + "account_number": "7082" + }, + "Locations diverses": { + "account_number": "7083" + }, + "Mise \u00e0 disposition de personnel factur\u00e9e": { + "account_number": "7084" + }, + "Ports et frais accessoires factur\u00e9s": { + "account_number": "7085" + }, + "Bonis sur reprises d'emballages consign\u00e9s": { + "account_number": "7086" + }, + "Bonifications obtenues des clients et primes sur ventes": { + "account_number": "7087" + }, + "Autres produits d'activit\u00e9s annexes (cessions d'approvisionnements...)": { + "account_number": "7088" + }, + "account_number": "708" + }, + "Rabais, remises et ristournes accord\u00e9s par l'entreprise": { + "Rabais, remises et ristournes accord\u00e9s par l'entreprise - sur ventes de produits finis": { + "account_number": "7091" + }, + "Rabais, remises et ristournes accord\u00e9s par l'entreprise - sur ventes de produits interm\u00e9diaires": { + "account_number": "7092" + }, + "Rabais, remises et ristournes accord\u00e9s par l'entreprise - sur travaux": { + "account_number": "7094" + }, + "Rabais, remises et ristournes accord\u00e9s par l'entreprise - sur \u00e9tudes": { + "account_number": "7095" + }, + "Rabais, remises et ristournes accord\u00e9s par l'entreprise - sur prestations de services": { + "account_number": "7096" + }, + "Rabais, remises et ristournes accord\u00e9s par l'entreprise - sur ventes de marchandises": { + "account_number": "7097" + }, + "Rabais, remises et ristournes accord\u00e9s par l'entreprise - sur produits des activit\u00e9s annexes": { + "account_number": "7098" + }, + "account_number": "709" + }, + "account_number": "70" + }, + "Production stock\u00e9e (ou d\u00e9stockage)": { + "Variation des stocks (en-cours de production, produits)": { + "Variation des en-cours de production de biens": { + "Produits en cours": { + "account_number": "71331" + }, + "Travaux en cours": { + "account_number": "71335" + }, + "account_number": "7133" + }, + "Variation des en-cours de production de services": { + "Etudes en cours": { + "account_number": "71341" + }, + "Prestations de services en cours": { + "account_number": "71345" + }, + "account_number": "7134" + }, + "Variation des stocks de produits": { + "Produits interm\u00e9diaires": { + "account_number": "71351" + }, + "Produits finis": { + "account_number": "71355" + }, + "Produits r\u00e9siduels": { + "account_number": "71358" + }, + "account_number": "7135" + }, + "account_number": "713" + }, + "account_number": "71" + }, + "Production immobilis\u00e9e": { + "Immobilisations incorporelles": { + "account_number": "721" + }, + "Immobilisations corporelles": { + "account_number": "722" + }, + "account_number": "72" + }, + "Subventions d'exploitation": { + "is_group": 1, + "account_number": "74" + }, + "Autres produits de gestion courante": { + "Redevances pour concessions, brevets, licences, marques, proc\u00e9d\u00e9s, logiciels, droits et valeurs similaires": { + "Redevances pour concessions, brevets, licences, marques, proc\u00e9d\u00e9s, logiciels": { + "account_number": "7511" + }, + "Droits d'auteur et de reproduction": { + "account_number": "7516" + }, + "Autres droits et valeurs similaires": { + "account_number": "7518" + }, + "account_number": "751" + }, + "Revenus des immeubles non affect\u00e9s aux activit\u00e9s professionnelles": { + "account_number": "752" + }, + "Jetons de pr\u00e9sence et r\u00e9mun\u00e9rations d'administrateurs, g\u00e9rants...": { + "account_number": "753" + }, + "Ristournes per\u00e7ues des coop\u00e9ratives (provenant des exc\u00e9dents)": { + "account_number": "754" + }, + "Quotes-parts de r\u00e9sultats sur op\u00e9rations faites en commun": { + "Quote-part de perte transf\u00e9r\u00e9e (comptabilit\u00e9 du g\u00e9rant)": { + "account_number": "7551" + }, + "Quote-part de b\u00e9n\u00e9fice attribu\u00e9 (comptabilit\u00e9 des associ\u00e9s non g\u00e9rants)": { + "account_number": "7555" + }, + "account_number": "755" + }, + "Gains de change sur cr\u00e9ances et dettes commerciales": { + "account_number": "756" + }, + "Produits divers de gestion courante": { + "account_number": "758" + }, + "account_number": "75" + }, + "Produits financiers": { + "Produits de participations": { + "Revenus des titres de participation": { + "account_number": "7611" + }, + "Produits de la fiducie, r\u00e9sultat de la p\u00e9riode": { + "account_number": "7612" + }, + "Revenus sur autres formes de participation": { + "account_number": "7616" + }, + "Revenus des cr\u00e9ances rattach\u00e9es \u00e0 des participations": { + "account_number": "7617" + }, + "account_number": "761" + }, + "Produits des autres immobilisations financi\u00e8res": { + "Revenus des titres immobilis\u00e9s": { + "account_number": "7621" + }, + "Revenus des pr\u00eats": { + "account_number": "7626" + }, + "Revenus des cr\u00e9ances immobilis\u00e9es": { + "account_number": "7627" + }, + "account_number": "762" + }, + "Revenus des autres cr\u00e9ances": { + "Revenus des cr\u00e9ances commerciales": { + "account_number": "7631" + }, + "Revenus des cr\u00e9ances diverses": { + "account_number": "7638" + }, + "account_number": "763" + }, + "Revenus des valeurs mobili\u00e8res de placement": { + "account_number": "764" + }, + "Escomptes obtenus": { + "account_number": "765" + }, + "Gains de change financi\u00e8res": { + "account_type": "Round Off", + "account_number": "766" + }, + "Produits nets sur cessions de valeurs mobili\u00e8res de placement": { + "account_number": "767" + }, + "Autres produits financiers": { + "account_number": "768" + }, + "account_number": "76" + }, + "Produits exceptionnels": { + "Produits exceptionnels sur op\u00e9rations de gestion": { + "D\u00e9dits et p\u00e9nalit\u00e9s per\u00e7us sur achats et sur ventes": { + "account_number": "7711" + }, + "Lib\u00e9ralit\u00e9s re\u00e7ues": { + "account_number": "7713" + }, + "Rentr\u00e9es sur cr\u00e9ances amorties": { + "account_number": "7714" + }, + "Subventions d'\u00e9quilibre": { + "account_number": "7715" + }, + "D\u00e9gr\u00e8vements d'imp\u00f4ts autres qu'imp\u00f4ts sur les b\u00e9n\u00e9fices": { + "account_number": "7717" + }, + "Autres produits exceptionnels sur op\u00e9rations de gestion": { + "account_number": "7718" + }, + "account_number": "771" + }, + "(Compte \u00e0 la disposition des entit\u00e9s pour enregistrer, en cours d'exercice, les Produits sur exercices ant\u00e9rieurs)": { + "account_number": "772" + }, + "Op\u00e9rations de constitution ou liquidation des fiducies": { + "Op\u00e9rations li\u00e9es \u00e0 la constitution de la fiducie - transfert des \u00e9l\u00e9ments": { + "account_number": "7741" + }, + "Op\u00e9rations li\u00e9es \u00e0 la liquidation de la fiducie": { + "account_number": "7742" + }, + "account_number": "774" + }, + "Produits des cessions d'\u00e9l\u00e9ments d'actif": { + "Immobilisations incorporelles": { + "account_number": "7751" + }, + "Immobilisations corporelles": { + "account_number": "7752" + }, + "Immobilisations financi\u00e8res": { + "account_number": "7756" + }, + "Autres \u00e9l\u00e9ments d'actif": { + "account_number": "7758" + }, + "account_number": "775" + }, + "Quote-part des subventions d'investissement vir\u00e9e au r\u00e9sultat de l'exercice": { + "account_number": "777" + }, + "Autres produits exceptionnels": { + "Bonis provenant de clauses d'indexation": { + "account_number": "7781" + }, + "Lots": { + "account_number": "7782" + }, + "Bonis provenant du rachat par l'entreprise d'actions et d'obligations \u00e9mises par elle-m\u00eame": { + "account_number": "7783" + }, + "Produits exceptionnels divers": { + "account_number": "7788" + }, + "account_number": "778" + }, + "account_number": "77" + }, + "Reprises sur amortissements, d\u00e9pr\u00e9ciations et provisions": { + "Reprises sur amortissements, d\u00e9pr\u00e9ciations et provisions (\u00e0 inscrire dans les produits d'exploitation)": { + "Reprises sur amortissements des immobilisations incorporelles et corporelles": { + "Immobilisations incorporelles": { + "account_number": "78111" + }, + "Immobilisations corporelles": { + "account_number": "78112" + }, + "account_number": "7811" + }, + "Reprises sur provisions d'exploitation": { + "account_number": "7815" + }, + "Reprises sur d\u00e9pr\u00e9ciations des immobilisations corporelles et incorporelles": { + "Immobilisations incorporelles": { + "account_number": "78161" + }, + "Immobilisations corporelles": { + "account_number": "78162" + }, + "account_number": "7816" + }, + "Reprises sur d\u00e9pr\u00e9ciations des actifs circulants": { + "Stocks et en-cours": { + "account_number": "78173" + }, + "Cr\u00e9ances": { + "account_number": "78174" + }, + "account_number": "7817" + }, + "account_number": "781" + }, + "Reprises sur d\u00e9pr\u00e9ciations et provisions (\u00e0 inscrire dans les produits financiers)": { + "Reprises sur provisions financi\u00e8res": { + "account_number": "7865" + }, + "Reprises sur d\u00e9pr\u00e9ciations des \u00e9l\u00e9ments financiers": { + "Immobilisations financi\u00e8res": { + "account_number": "78662" + }, + "Valeurs mobili\u00e8res de placement": { + "account_number": "78665" + }, + "account_number": "7866" + }, + "account_number": "786" + }, + "Reprises sur d\u00e9pr\u00e9ciations et provisions (\u00e0 inscrire dans les produits exceptionnels)": { + "Reprises sur provisions r\u00e9glement\u00e9es (immobilisations)": { + "Amortissements d\u00e9rogatoires": { + "account_number": "78725" + }, + "Provision sp\u00e9ciale de r\u00e9\u00e9valuation": { + "account_number": "78726" + }, + "Plus-values r\u00e9investies": { + "account_number": "78727" + }, + "account_number": "7872" + }, + "Reprises sur provisions r\u00e9glement\u00e9es (stocks)": { + "account_number": "7873" + }, + "Reprises sur autres provisions r\u00e9glement\u00e9es": { + "account_number": "7874" + }, + "Reprises sur provisions exceptionnelles": { + "account_number": "7875" + }, + "Reprises sur d\u00e9pr\u00e9ciations exceptionnelles": { + "account_number": "7876" + }, + "account_number": "787" + }, + "account_number": "78" + }, + "Transferts de charges": { + "Transferts de charges d'exploitation": { + "account_number": "791" + }, + "Transferts de charges financi\u00e8res": { + "account_number": "796" + }, + "Transferts de charges exceptionnelles": { + "account_number": "797" + }, + "account_number": "79" + }, + "account_number": "7" + } + } +} \ No newline at end of file diff --git a/erpnext/accounts/doctype/bank_reconciliation_tool/bank_reconciliation_tool.js b/erpnext/accounts/doctype/bank_reconciliation_tool/bank_reconciliation_tool.js index f7d471b725e..78e7ff6ea29 100644 --- a/erpnext/accounts/doctype/bank_reconciliation_tool/bank_reconciliation_tool.js +++ b/erpnext/accounts/doctype/bank_reconciliation_tool/bank_reconciliation_tool.js @@ -15,7 +15,7 @@ frappe.ui.form.on("Bank Reconciliation Tool", { }, refresh: function (frm) { - frappe.require("assets/js/bank-reconciliation-tool.min.js", () => + frappe.require("bank-reconciliation-tool.bundle.js", () => frm.trigger("make_reconciliation_tool") ); frm.upload_statement_button = frm.page.set_secondary_action( diff --git a/erpnext/accounts/doctype/bank_statement_import/bank_statement_import.js b/erpnext/accounts/doctype/bank_statement_import/bank_statement_import.js index 016f29a7b51..0a2e0bc9ba3 100644 --- a/erpnext/accounts/doctype/bank_statement_import/bank_statement_import.js +++ b/erpnext/accounts/doctype/bank_statement_import/bank_statement_import.js @@ -320,7 +320,7 @@ frappe.ui.form.on("Bank Statement Import", { return; } - frappe.require("/assets/js/data_import_tools.min.js", () => { + frappe.require("data_import_tools.bundle.js", () => { frm.import_preview = new frappe.data_import.ImportPreview({ wrapper: frm.get_field("import_preview").$wrapper, doctype: frm.doc.reference_doctype, diff --git a/erpnext/accounts/doctype/journal_entry/journal_entry.js b/erpnext/accounts/doctype/journal_entry/journal_entry.js index d76641dc9bd..957a50f0132 100644 --- a/erpnext/accounts/doctype/journal_entry/journal_entry.js +++ b/erpnext/accounts/doctype/journal_entry/journal_entry.js @@ -194,19 +194,19 @@ var update_jv_details = function(doc, r) { refresh_field("accounts"); } -erpnext.accounts.JournalEntry = frappe.ui.form.Controller.extend({ - onload: function() { +erpnext.accounts.JournalEntry = class JournalEntry extends frappe.ui.form.Controller { + onload() { this.load_defaults(); this.setup_queries(); this.setup_balance_formatter(); erpnext.accounts.dimensions.setup_dimension_filters(this.frm, this.frm.doctype); - }, + } - onload_post_render: function() { + onload_post_render() { cur_frm.get_field("accounts").grid.set_multiple_add("account"); - }, + } - load_defaults: function() { + load_defaults() { //this.frm.show_print_first = true; if(this.frm.doc.__islocal && this.frm.doc.company) { frappe.model.set_default_values(this.frm.doc); @@ -216,9 +216,9 @@ erpnext.accounts.JournalEntry = frappe.ui.form.Controller.extend({ var posting_date = this.frm.doc.posting_date; if(!this.frm.doc.amended_from) this.frm.set_value('posting_date', posting_date || frappe.datetime.get_today()); } - }, + } - setup_queries: function() { + setup_queries() { var me = this; me.frm.set_query("account", "accounts", function(doc, cdt, cdn) { @@ -324,9 +324,9 @@ erpnext.accounts.JournalEntry = frappe.ui.form.Controller.extend({ }); - }, + } - setup_balance_formatter: function() { + setup_balance_formatter() { const formatter = function(value, df, options, doc) { var currency = frappe.meta.get_field_currency(df, doc); var dr_or_cr = value ? ('') : ""; @@ -337,9 +337,9 @@ erpnext.accounts.JournalEntry = frappe.ui.form.Controller.extend({ }; this.frm.fields_dict.accounts.grid.update_docfield_property('balance', 'formatter', formatter); this.frm.fields_dict.accounts.grid.update_docfield_property('party_balance', 'formatter', formatter); - }, + } - reference_name: function(doc, cdt, cdn) { + reference_name(doc, cdt, cdn) { var d = frappe.get_doc(cdt, cdn); if(d.reference_name) { @@ -351,9 +351,9 @@ erpnext.accounts.JournalEntry = frappe.ui.form.Controller.extend({ this.get_outstanding('Journal Entry', d.reference_name, doc.company, d); } } - }, + } - get_outstanding: function(doctype, docname, company, child, due_date) { + get_outstanding(doctype, docname, company, child, due_date) { var me = this; var args = { "doctype": doctype, @@ -375,9 +375,9 @@ erpnext.accounts.JournalEntry = frappe.ui.form.Controller.extend({ } } }); - }, + } - accounts_add: function(doc, cdt, cdn) { + accounts_add(doc, cdt, cdn) { var row = frappe.get_doc(cdt, cdn); $.each(doc.accounts, function(i, d) { if(d.account && d.party && d.party_type) { @@ -400,9 +400,9 @@ erpnext.accounts.JournalEntry = frappe.ui.form.Controller.extend({ cur_frm.cscript.update_totals(doc); erpnext.accounts.dimensions.copy_dimension_from_first_row(this.frm, cdt, cdn, 'accounts'); - }, + } -}); +}; cur_frm.script_manager.make(erpnext.accounts.JournalEntry); diff --git a/erpnext/accounts/doctype/opening_invoice_creation_tool/opening_invoice_creation_tool.js b/erpnext/accounts/doctype/opening_invoice_creation_tool/opening_invoice_creation_tool.js index b2e86267c8f..a8c07d6bb9b 100644 --- a/erpnext/accounts/doctype/opening_invoice_creation_tool/opening_invoice_creation_tool.js +++ b/erpnext/accounts/doctype/opening_invoice_creation_tool/opening_invoice_creation_tool.js @@ -49,7 +49,15 @@ frappe.ui.form.on('Opening Invoice Creation Tool', { doc: frm.doc, btn: $(btn_primary), method: "make_invoices", - freeze_message: __("Creating {0} Invoice", [frm.doc.invoice_type]) + freeze: 1, + freeze_message: __("Creating {0} Invoice", [frm.doc.invoice_type]), + callback: function(r) { + if (r.message.length == 1) { + frappe.msgprint(__("{0} Invoice created successfully.", [frm.doc.invoice_type])); + } else if (r.message.length < 50) { + frappe.msgprint(__("{0} Invoices created successfully.", [frm.doc.invoice_type])); + } + } }); }); diff --git a/erpnext/accounts/doctype/opening_invoice_creation_tool/opening_invoice_creation_tool.py b/erpnext/accounts/doctype/opening_invoice_creation_tool/opening_invoice_creation_tool.py index 29dc96e8c6f..d76d9099628 100644 --- a/erpnext/accounts/doctype/opening_invoice_creation_tool/opening_invoice_creation_tool.py +++ b/erpnext/accounts/doctype/opening_invoice_creation_tool/opening_invoice_creation_tool.py @@ -216,7 +216,8 @@ def start_import(invoices): return names def publish(index, total, doctype): - if total < 5: return + if total < 50: + return frappe.publish_realtime( "opening_invoice_creation_progress", dict( @@ -241,4 +242,3 @@ def get_temporary_opening_account(company=None): return accounts[0].name - diff --git a/erpnext/accounts/doctype/payment_entry/payment_entry.js b/erpnext/accounts/doctype/payment_entry/payment_entry.js index d3ac3a66760..439b1edbce6 100644 --- a/erpnext/accounts/doctype/payment_entry/payment_entry.js +++ b/erpnext/accounts/doctype/payment_entry/payment_entry.js @@ -7,6 +7,8 @@ cur_frm.cscript.tax_table = "Advance Taxes and Charges"; frappe.ui.form.on('Payment Entry', { onload: function(frm) { + frm.ignore_doctypes_on_cancel_all = ['Sales Invoice', 'Purchase Invoice']; + if(frm.doc.__islocal) { if (!frm.doc.paid_from) frm.set_value("paid_from_account_currency", null); if (!frm.doc.paid_to) frm.set_value("paid_to_account_currency", null); diff --git a/erpnext/accounts/doctype/payment_reconciliation/payment_reconciliation.js b/erpnext/accounts/doctype/payment_reconciliation/payment_reconciliation.js index d1523cd7aca..c71a62dfb3c 100644 --- a/erpnext/accounts/doctype/payment_reconciliation/payment_reconciliation.js +++ b/erpnext/accounts/doctype/payment_reconciliation/payment_reconciliation.js @@ -34,8 +34,8 @@ frappe.ui.form.on("Payment Reconciliation Payment", { } }); -erpnext.accounts.PaymentReconciliationController = frappe.ui.form.Controller.extend({ - onload: function() { +erpnext.accounts.PaymentReconciliationController = class PaymentReconciliationController extends frappe.ui.form.Controller { + onload() { var me = this; this.frm.set_query("party", function() { @@ -84,18 +84,18 @@ erpnext.accounts.PaymentReconciliationController = frappe.ui.form.Controller.ext frappe.throw({message: __("Please Select Both Company and Party Type First"), title: title}); } }; - }, + } - refresh: function() { + refresh() { this.frm.disable_save(); this.toggle_primary_action(); - }, + } - onload_post_render: function() { + onload_post_render() { this.toggle_primary_action(); - }, + } - party: function() { + party() { var me = this if (!me.frm.doc.receivable_payable_account && me.frm.doc.party_type && me.frm.doc.party) { return frappe.call({ @@ -112,9 +112,9 @@ erpnext.accounts.PaymentReconciliationController = frappe.ui.form.Controller.ext } }); } - }, + } - get_unreconciled_entries: function() { + get_unreconciled_entries() { var me = this; return this.frm.call({ doc: me.frm.doc, @@ -125,9 +125,9 @@ erpnext.accounts.PaymentReconciliationController = frappe.ui.form.Controller.ext } }); - }, + } - reconcile: function() { + reconcile() { var me = this; var show_dialog = me.frm.doc.payments.filter(d => d.difference_amount && !d.difference_account); @@ -209,9 +209,9 @@ erpnext.accounts.PaymentReconciliationController = frappe.ui.form.Controller.ext } else { this.reconcile_payment_entries(); } - }, + } - reconcile_payment_entries: function() { + reconcile_payment_entries() { var me = this; return this.frm.call({ @@ -222,9 +222,9 @@ erpnext.accounts.PaymentReconciliationController = frappe.ui.form.Controller.ext me.toggle_primary_action(); } }); - }, + } - set_invoice_options: function() { + set_invoice_options() { var me = this; var invoices = []; @@ -244,9 +244,9 @@ erpnext.accounts.PaymentReconciliationController = frappe.ui.form.Controller.ext } refresh_field("payments"); - }, + } - toggle_primary_action: function() { + toggle_primary_action() { if ((this.frm.doc.payments || []).length) { this.frm.fields_dict.reconcile.$input && this.frm.fields_dict.reconcile.$input.addClass("btn-primary"); @@ -260,6 +260,6 @@ erpnext.accounts.PaymentReconciliationController = frappe.ui.form.Controller.ext } } -}); +}; -$.extend(cur_frm.cscript, new erpnext.accounts.PaymentReconciliationController({frm: cur_frm})); +extend_cscript(cur_frm.cscript, new erpnext.accounts.PaymentReconciliationController({frm: cur_frm})); diff --git a/erpnext/accounts/doctype/period_closing_voucher/period_closing_voucher.py b/erpnext/accounts/doctype/period_closing_voucher/period_closing_voucher.py index b0a5b04de64..9cfb47876c8 100644 --- a/erpnext/accounts/doctype/period_closing_voucher/period_closing_voucher.py +++ b/erpnext/accounts/doctype/period_closing_voucher/period_closing_voucher.py @@ -142,7 +142,7 @@ class PeriodClosingVoucher(AccountsController): sum(t1.debit_in_account_currency) - sum(t1.credit_in_account_currency) as bal_in_account_currency, sum(t1.debit) - sum(t1.credit) as bal_in_company_currency from `tabGL Entry` t1, `tabAccount` t2 - where t1.account = t2.name and t2.report_type = 'Profit and Loss' + where t1.is_cancelled = 0 and t1.account = t2.name and t2.report_type = 'Profit and Loss' and t2.docstatus < 2 and t2.company = %s and t1.posting_date between %s and %s group by t1.account, {dimension_fields} diff --git a/erpnext/accounts/doctype/pos_invoice/pos_invoice.js b/erpnext/accounts/doctype/pos_invoice/pos_invoice.js index 493bd448024..181e9f8ec09 100644 --- a/erpnext/accounts/doctype/pos_invoice/pos_invoice.js +++ b/erpnext/accounts/doctype/pos_invoice/pos_invoice.js @@ -4,18 +4,18 @@ {% include 'erpnext/selling/sales_common.js' %}; frappe.provide("erpnext.accounts"); -erpnext.selling.POSInvoiceController = erpnext.selling.SellingController.extend({ +erpnext.selling.POSInvoiceController = class POSInvoiceController extends erpnext.selling.SellingController { setup(doc) { this.setup_posting_date_time_check(); - this._super(doc); - }, + super.setup(doc); + } - company: function() { + company() { erpnext.accounts.dimensions.update_dimension(this.frm, this.frm.doctype); - }, + } onload(doc) { - this._super(); + super.onload(); this.frm.ignore_doctypes_on_cancel_all = ['POS Invoice Merge Log']; if(doc.__islocal && doc.is_pos && frappe.get_route_str() !== 'point-of-sale') { this.frm.script_manager.trigger("is_pos"); @@ -23,10 +23,10 @@ erpnext.selling.POSInvoiceController = erpnext.selling.SellingController.extend( } erpnext.accounts.dimensions.setup_dimension_filters(this.frm, this.frm.doctype); - }, + } refresh(doc) { - this._super(); + super.refresh(); if (doc.docstatus == 1 && !doc.is_return) { this.frm.add_custom_button(__('Return'), this.make_sales_return, __('Create')); this.frm.page.set_inner_btn_group_as_primary(__('Create')); @@ -36,13 +36,13 @@ erpnext.selling.POSInvoiceController = erpnext.selling.SellingController.extend( this.frm.return_print_format = "Sales Invoice Return"; this.frm.set_value('consolidated_invoice', ''); } - }, + } - is_pos: function() { + is_pos() { this.set_pos_data(); - }, + } - set_pos_data: async function() { + async set_pos_data() { if(this.frm.doc.is_pos) { this.frm.set_value("allocate_advances_automatically", 0); if(!this.frm.doc.company) { @@ -69,7 +69,7 @@ erpnext.selling.POSInvoiceController = erpnext.selling.SellingController.extend( } } } - }, + } customer() { if (!this.frm.doc.customer) return @@ -86,13 +86,13 @@ erpnext.selling.POSInvoiceController = erpnext.selling.SellingController.extend( }, () => { this.apply_pricing_rule(); }); - }, + } - amount: function(){ + amount(){ this.write_off_outstanding_amount_automatically() - }, + } - change_amount: function(){ + change_amount(){ if(this.frm.doc.paid_amount > this.frm.doc.grand_total){ this.calculate_write_off_amount(); }else { @@ -101,16 +101,16 @@ erpnext.selling.POSInvoiceController = erpnext.selling.SellingController.extend( } this.frm.refresh_fields(); - }, + } - loyalty_amount: function(){ + loyalty_amount(){ this.calculate_outstanding_amount(); this.frm.refresh_field("outstanding_amount"); this.frm.refresh_field("paid_amount"); this.frm.refresh_field("base_paid_amount"); - }, + } - write_off_outstanding_amount_automatically: function() { + write_off_outstanding_amount_automatically() { if(cint(this.frm.doc.write_off_outstanding_amount_automatically)) { frappe.model.round_floats_in(this.frm.doc, ["grand_total", "paid_amount"]); // this will make outstanding amount 0 @@ -125,17 +125,17 @@ erpnext.selling.POSInvoiceController = erpnext.selling.SellingController.extend( this.calculate_outstanding_amount(false); this.frm.refresh_fields(); - }, + } - make_sales_return: function() { + make_sales_return() { frappe.model.open_mapped_doc({ method: "erpnext.accounts.doctype.pos_invoice.pos_invoice.make_sales_return", frm: cur_frm }) - }, -}) + } +} -$.extend(cur_frm.cscript, new erpnext.selling.POSInvoiceController({ frm: cur_frm })) +extend_cscript(cur_frm.cscript, new erpnext.selling.POSInvoiceController({ frm: cur_frm })) frappe.ui.form.on('POS Invoice', { redeem_loyalty_points: function(frm) { @@ -235,4 +235,4 @@ frappe.ui.form.on('POS Invoice', { }); }); } -}); \ No newline at end of file +}); diff --git a/erpnext/accounts/doctype/process_statement_of_accounts/process_statement_of_accounts.html b/erpnext/accounts/doctype/process_statement_of_accounts/process_statement_of_accounts.html index 7328f168e3d..f8d191cc3f8 100644 --- a/erpnext/accounts/doctype/process_statement_of_accounts/process_statement_of_accounts.html +++ b/erpnext/accounts/doctype/process_statement_of_accounts/process_statement_of_accounts.html @@ -106,4 +106,4 @@ {{ terms_and_conditions }} {% endif %} - \ No newline at end of file + diff --git a/erpnext/accounts/doctype/process_statement_of_accounts/process_statement_of_accounts.json b/erpnext/accounts/doctype/process_statement_of_accounts/process_statement_of_accounts.json index 27a5f50ce2a..295a3b86a9e 100644 --- a/erpnext/accounts/doctype/process_statement_of_accounts/process_statement_of_accounts.json +++ b/erpnext/accounts/doctype/process_statement_of_accounts/process_statement_of_accounts.json @@ -286,7 +286,7 @@ } ], "links": [], - "modified": "2021-05-21 10:14:22.426672", + "modified": "2021-05-21 11:14:22.426672", "modified_by": "Administrator", "module": "Accounts", "name": "Process Statement Of Accounts", diff --git a/erpnext/accounts/doctype/purchase_invoice/purchase_invoice.js b/erpnext/accounts/doctype/purchase_invoice/purchase_invoice.js index dc9094c3e91..7562418fd2f 100644 --- a/erpnext/accounts/doctype/purchase_invoice/purchase_invoice.js +++ b/erpnext/accounts/doctype/purchase_invoice/purchase_invoice.js @@ -4,10 +4,10 @@ frappe.provide("erpnext.accounts"); {% include 'erpnext/public/js/controllers/buying.js' %}; -erpnext.accounts.PurchaseInvoice = erpnext.buying.BuyingController.extend({ - setup: function(doc) { +erpnext.accounts.PurchaseInvoice = class PurchaseInvoice extends erpnext.buying.BuyingController { + setup(doc) { this.setup_posting_date_time_check(); - this._super(doc); + super.setup(doc); // formatter for purchase invoice item if(this.frm.doc.update_stock) { @@ -25,10 +25,10 @@ erpnext.accounts.PurchaseInvoice = erpnext.buying.BuyingController.extend({ } }; }); - }, + } - onload: function() { - this._super(); + onload() { + super.onload(); if(!this.frm.doc.__islocal) { // show credit_to in print format @@ -44,11 +44,11 @@ erpnext.accounts.PurchaseInvoice = erpnext.buying.BuyingController.extend({ } erpnext.accounts.dimensions.setup_dimension_filters(this.frm, this.frm.doctype); - }, + } - refresh: function(doc) { + refresh(doc) { const me = this; - this._super(); + super.refresh(); hide_fields(this.frm.doc); // Show / Hide button @@ -157,26 +157,26 @@ erpnext.accounts.PurchaseInvoice = erpnext.buying.BuyingController.extend({ } this.frm.set_df_property("tax_withholding_category", "hidden", doc.apply_tds ? 0 : 1); - }, + } - unblock_invoice: function() { + unblock_invoice() { const me = this; frappe.call({ 'method': 'erpnext.accounts.doctype.purchase_invoice.purchase_invoice.unblock_invoice', 'args': {'name': me.frm.doc.name}, 'callback': (r) => me.frm.reload_doc() }); - }, + } - block_invoice: function() { + block_invoice() { this.make_comment_dialog_and_block_invoice(); - }, + } - change_release_date: function() { + change_release_date() { this.make_dialog_and_set_release_date(); - }, + } - can_change_release_date: function(date) { + can_change_release_date(date) { const diff = frappe.datetime.get_diff(date, frappe.datetime.nowdate()); if (diff < 0) { frappe.throw(__('New release date should be in the future')); @@ -184,9 +184,9 @@ erpnext.accounts.PurchaseInvoice = erpnext.buying.BuyingController.extend({ } else { return true; } - }, + } - make_comment_dialog_and_block_invoice: function(){ + make_comment_dialog_and_block_invoice(){ const me = this; const title = __('Block Invoice'); @@ -228,9 +228,9 @@ erpnext.accounts.PurchaseInvoice = erpnext.buying.BuyingController.extend({ }); this.dialog.show(); - }, + } - make_dialog_and_set_release_date: function() { + make_dialog_and_set_release_date() { const me = this; const title = __('Set New Release Date'); @@ -259,17 +259,17 @@ erpnext.accounts.PurchaseInvoice = erpnext.buying.BuyingController.extend({ }); this.dialog.show(); - }, + } - set_release_date: function(data) { + set_release_date(data) { return frappe.call({ 'method': 'erpnext.accounts.doctype.purchase_invoice.purchase_invoice.change_release_date', 'args': data, 'callback': (r) => this.frm.reload_doc() }); - }, + } - supplier: function() { + supplier() { var me = this; // Do not update if inter company reference is there as the details will already be updated @@ -291,9 +291,9 @@ erpnext.accounts.PurchaseInvoice = erpnext.buying.BuyingController.extend({ me.frm.set_df_property("apply_tds", "read_only", me.frm.supplier_tds ? 0 : 1); me.frm.set_df_property("tax_withholding_category", "hidden", me.frm.supplier_tds ? 0 : 1); }) - }, + } - apply_tds: function(frm) { + apply_tds(frm) { var me = this; if (!me.frm.doc.apply_tds) { @@ -303,9 +303,9 @@ erpnext.accounts.PurchaseInvoice = erpnext.buying.BuyingController.extend({ me.frm.set_value("tax_withholding_category", me.frm.supplier_tds); me.frm.set_df_property("tax_withholding_category", "hidden", 0); } - }, + } - credit_to: function() { + credit_to() { var me = this; if(this.frm.doc.credit_to) { me.frm.call({ @@ -323,16 +323,16 @@ erpnext.accounts.PurchaseInvoice = erpnext.buying.BuyingController.extend({ } }); } - }, + } - make_inter_company_invoice: function(frm) { + make_inter_company_invoice(frm) { frappe.model.open_mapped_doc({ method: "erpnext.accounts.doctype.purchase_invoice.purchase_invoice.make_inter_company_sales_invoice", frm: frm }); - }, + } - is_paid: function() { + is_paid() { hide_fields(this.frm.doc); if(cint(this.frm.doc.is_paid)) { this.frm.set_value("allocate_advances_automatically", 0); @@ -343,44 +343,44 @@ erpnext.accounts.PurchaseInvoice = erpnext.buying.BuyingController.extend({ } this.calculate_outstanding_amount(); this.frm.refresh_fields(); - }, + } - write_off_amount: function() { + write_off_amount() { this.set_in_company_currency(this.frm.doc, ["write_off_amount"]); this.calculate_outstanding_amount(); this.frm.refresh_fields(); - }, + } - paid_amount: function() { + paid_amount() { this.set_in_company_currency(this.frm.doc, ["paid_amount"]); this.write_off_amount(); this.frm.refresh_fields(); - }, + } - allocated_amount: function() { + allocated_amount() { this.calculate_total_advance(); this.frm.refresh_fields(); - }, + } - items_add: function(doc, cdt, cdn) { + items_add(doc, cdt, cdn) { var row = frappe.get_doc(cdt, cdn); this.frm.script_manager.copy_from_first_row("items", row, ["expense_account", "cost_center", "project"]); - }, + } - on_submit: function() { + on_submit() { $.each(this.frm.doc["items"] || [], function(i, row) { if(row.purchase_receipt) frappe.model.clear_doc("Purchase Receipt", row.purchase_receipt) }) - }, + } - make_debit_note: function() { + make_debit_note() { frappe.model.open_mapped_doc({ method: "erpnext.accounts.doctype.purchase_invoice.purchase_invoice.make_debit_note", frm: cur_frm }) - }, -}); + } +}; cur_frm.script_manager.make(erpnext.accounts.PurchaseInvoice); diff --git a/erpnext/accounts/doctype/purchase_invoice/purchase_invoice.py b/erpnext/accounts/doctype/purchase_invoice/purchase_invoice.py index 45d89ad1c87..c1cc092554d 100644 --- a/erpnext/accounts/doctype/purchase_invoice/purchase_invoice.py +++ b/erpnext/accounts/doctype/purchase_invoice/purchase_invoice.py @@ -517,6 +517,8 @@ class PurchaseInvoice(BuyingController): if d.category in ('Valuation', 'Total and Valuation') and flt(d.base_tax_amount_after_discount_amount)] + exchange_rate_map, net_rate_map = get_purchase_document_details(self) + for item in self.get("items"): if flt(item.base_net_amount): account_currency = get_account_currency(item.expense_account) @@ -634,6 +636,34 @@ class PurchaseInvoice(BuyingController): "project": item.project or self.project }, account_currency, item=item)) + # check if the exchange rate has changed + if item.get('purchase_receipt'): + if exchange_rate_map[item.purchase_receipt] and \ + self.conversion_rate != exchange_rate_map[item.purchase_receipt] and \ + item.net_rate == net_rate_map[item.pr_detail]: + + discrepancy_caused_by_exchange_rate_difference = (item.qty * item.net_rate) * \ + (exchange_rate_map[item.purchase_receipt] - self.conversion_rate) + + gl_entries.append( + self.get_gl_dict({ + "account": expense_account, + "against": self.supplier, + "debit": discrepancy_caused_by_exchange_rate_difference, + "cost_center": item.cost_center, + "project": item.project or self.project + }, account_currency, item=item) + ) + gl_entries.append( + self.get_gl_dict({ + "account": self.get_company_default("exchange_gain_loss_account"), + "against": self.supplier, + "credit": discrepancy_caused_by_exchange_rate_difference, + "cost_center": item.cost_center, + "project": item.project or self.project + }, account_currency, item=item) + ) + # If asset is bought through this document and not linked to PR if self.update_stock and item.landed_cost_voucher_amount: expenses_included_in_asset_valuation = self.get_company_default("expenses_included_in_asset_valuation") @@ -1141,6 +1171,36 @@ class PurchaseInvoice(BuyingController): if update: self.db_set('status', self.status, update_modified = update_modified) +# to get details of purchase invoice/receipt from which this doc was created for exchange rate difference handling +def get_purchase_document_details(doc): + if doc.doctype == 'Purchase Invoice': + doc_reference = 'purchase_receipt' + items_reference = 'pr_detail' + parent_doctype = 'Purchase Receipt' + child_doctype = 'Purchase Receipt Item' + else: + doc_reference = 'purchase_invoice' + items_reference = 'purchase_invoice_item' + parent_doctype = 'Purchase Invoice' + child_doctype = 'Purchase Invoice Item' + + purchase_receipts_or_invoices = [] + items = [] + + for item in doc.get('items'): + if item.get(doc_reference): + purchase_receipts_or_invoices.append(item.get(doc_reference)) + if item.get(items_reference): + items.append(item.get(items_reference)) + + exchange_rate_map = frappe._dict(frappe.get_all(parent_doctype, filters={'name': ('in', + purchase_receipts_or_invoices)}, fields=['name', 'conversion_rate'], as_list=1)) + + net_rate_map = frappe._dict(frappe.get_all(child_doctype, filters={'name': ('in', + items)}, fields=['name', 'net_rate'], as_list=1)) + + return exchange_rate_map, net_rate_map + def get_list_context(context=None): from erpnext.controllers.website_list_for_contact import get_list_context list_context = get_list_context(context) diff --git a/erpnext/accounts/doctype/purchase_invoice/test_purchase_invoice.py b/erpnext/accounts/doctype/purchase_invoice/test_purchase_invoice.py index 2f5d36c8fab..ec93314c0f6 100644 --- a/erpnext/accounts/doctype/purchase_invoice/test_purchase_invoice.py +++ b/erpnext/accounts/doctype/purchase_invoice/test_purchase_invoice.py @@ -230,6 +230,27 @@ class TestPurchaseInvoice(unittest.TestCase): self.assertEqual(expected_values[gle.account][1], gle.debit) self.assertEqual(expected_values[gle.account][2], gle.credit) + def test_purchase_invoice_with_exchange_rate_difference(self): + pr = make_purchase_receipt(currency = "USD", conversion_rate = 70) + pi = make_purchase_invoice(currency = "USD", conversion_rate = 80, do_not_save = "True") + + pi.items[0].purchase_receipt = pr.name + pi.items[0].pr_detail = pr.items[0].name + + pi.insert() + pi.submit() + + # fetching the latest GL Entry with 'Exchange Gain/Loss - _TC' account + gl_entries = frappe.get_all('GL Entry', filters = {'account': 'Exchange Gain/Loss - _TC'}) + voucher_no = frappe.get_value('GL Entry', gl_entries[0]['name'], 'voucher_no') + + self.assertEqual(pi.name, voucher_no) + + exchange_gain_loss_amount = frappe.get_value('GL Entry', gl_entries[0]['name'], 'debit') + discrepancy_caused_by_exchange_rate_diff = abs(pi.items[0].base_net_amount - pr.items[0].base_net_amount) + + self.assertEqual(exchange_gain_loss_amount, discrepancy_caused_by_exchange_rate_diff) + def test_purchase_invoice_change_naming_series(self): pi = frappe.copy_doc(test_records[1]) pi.insert() diff --git a/erpnext/accounts/doctype/purchase_invoice_item/purchase_invoice_item.json b/erpnext/accounts/doctype/purchase_invoice_item/purchase_invoice_item.json index 8a55ff87e39..b39022dd758 100644 --- a/erpnext/accounts/doctype/purchase_invoice_item/purchase_invoice_item.json +++ b/erpnext/accounts/doctype/purchase_invoice_item/purchase_invoice_item.json @@ -854,7 +854,7 @@ "idx": 1, "istable": 1, "links": [], - "modified": "2021-06-16 19:57:03.101571", + "modified": "2021-06-16 19:43:51.099386", "modified_by": "Administrator", "module": "Accounts", "name": "Purchase Invoice Item", diff --git a/erpnext/accounts/doctype/sales_invoice/sales_invoice.js b/erpnext/accounts/doctype/sales_invoice/sales_invoice.js index f813425e6b5..bb556516702 100644 --- a/erpnext/accounts/doctype/sales_invoice/sales_invoice.js +++ b/erpnext/accounts/doctype/sales_invoice/sales_invoice.js @@ -5,17 +5,17 @@ frappe.provide("erpnext.accounts"); -erpnext.accounts.SalesInvoiceController = erpnext.selling.SellingController.extend({ - setup: function(doc) { +erpnext.accounts.SalesInvoiceController = class SalesInvoiceController extends erpnext.selling.SellingController { + setup(doc) { this.setup_posting_date_time_check(); - this._super(doc); - }, - company: function() { + super.setup(doc); + } + company() { erpnext.accounts.dimensions.update_dimension(this.frm, this.frm.doctype); - }, - onload: function() { + } + onload() { var me = this; - this._super(); + super.onload(); this.frm.ignore_doctypes_on_cancel_all = ['POS Invoice', 'Timesheet', 'POS Invoice Merge Log', 'POS Closing Entry']; if(!this.frm.doc.__islocal && !this.frm.doc.customer && this.frm.doc.debit_to) { @@ -35,11 +35,11 @@ erpnext.accounts.SalesInvoiceController = erpnext.selling.SellingController.exte } erpnext.queries.setup_warehouse_query(this.frm); erpnext.accounts.dimensions.setup_dimension_filters(this.frm, this.frm.doctype); - }, + } - refresh: function(doc, dt, dn) { + refresh(doc, dt, dn) { const me = this; - this._super(); + super.refresh(); if(cur_frm.msgbox && cur_frm.msgbox.$wrapper.is(":visible")) { // hide new msgbox cur_frm.msgbox.hide(); @@ -138,16 +138,16 @@ erpnext.accounts.SalesInvoiceController = erpnext.selling.SellingController.exte }, __('Create')); } } - }, + } - make_maintenance_schedule: function() { + make_maintenance_schedule() { frappe.model.open_mapped_doc({ method: "erpnext.accounts.doctype.sales_invoice.sales_invoice.make_maintenance_schedule", frm: cur_frm }) - }, + } - on_submit: function(doc, dt, dn) { + on_submit(doc, dt, dn) { var me = this; if (frappe.get_route()[0] != 'Form') { @@ -157,9 +157,9 @@ erpnext.accounts.SalesInvoiceController = erpnext.selling.SellingController.exte $.each(doc["items"], function(i, row) { if(row.delivery_note) frappe.model.clear_doc("Delivery Note", row.delivery_note) }) - }, + } - set_default_print_format: function() { + set_default_print_format() { // set default print format to POS type or Credit Note if(cur_frm.doc.is_pos) { if(cur_frm.pos_print_format) { @@ -180,9 +180,9 @@ erpnext.accounts.SalesInvoiceController = erpnext.selling.SellingController.exte cur_frm.meta._default_print_format = null; } } - }, + } - sales_order_btn: function() { + sales_order_btn() { var me = this; this.$sales_order_btn = this.frm.add_custom_button(__('Sales Order'), function() { @@ -201,9 +201,9 @@ erpnext.accounts.SalesInvoiceController = erpnext.selling.SellingController.exte } }) }, __("Get Items From")); - }, + } - quotation_btn: function() { + quotation_btn() { var me = this; this.$quotation_btn = this.frm.add_custom_button(__('Quotation'), function() { @@ -225,9 +225,9 @@ erpnext.accounts.SalesInvoiceController = erpnext.selling.SellingController.exte } }) }, __("Get Items From")); - }, + } - delivery_note_btn: function() { + delivery_note_btn() { var me = this; this.$delivery_note_btn = this.frm.add_custom_button(__('Delivery Note'), function() { @@ -253,12 +253,12 @@ erpnext.accounts.SalesInvoiceController = erpnext.selling.SellingController.exte } }); }, __("Get Items From")); - }, + } - tc_name: function() { + tc_name() { this.get_terms(); - }, - customer: function() { + } + customer() { if (this.frm.doc.is_pos){ var pos_profile = this.frm.doc.pos_profile; } @@ -289,16 +289,16 @@ erpnext.accounts.SalesInvoiceController = erpnext.selling.SellingController.exte } }); } - }, + } - make_inter_company_invoice: function() { + make_inter_company_invoice() { frappe.model.open_mapped_doc({ method: "erpnext.accounts.doctype.sales_invoice.sales_invoice.make_inter_company_purchase_invoice", frm: me.frm }); - }, + } - debit_to: function() { + debit_to() { var me = this; if(this.frm.doc.debit_to) { me.frm.call({ @@ -316,14 +316,14 @@ erpnext.accounts.SalesInvoiceController = erpnext.selling.SellingController.exte } }); } - }, + } - allocated_amount: function() { + allocated_amount() { this.calculate_total_advance(); this.frm.refresh_fields(); - }, + } - write_off_outstanding_amount_automatically: function() { + write_off_outstanding_amount_automatically() { if(cint(this.frm.doc.write_off_outstanding_amount_automatically)) { frappe.model.round_floats_in(this.frm.doc, ["grand_total", "paid_amount"]); // this will make outstanding amount 0 @@ -338,39 +338,39 @@ erpnext.accounts.SalesInvoiceController = erpnext.selling.SellingController.exte this.calculate_outstanding_amount(false); this.frm.refresh_fields(); - }, + } - write_off_amount: function() { + write_off_amount() { this.set_in_company_currency(this.frm.doc, ["write_off_amount"]); this.write_off_outstanding_amount_automatically(); - }, + } - items_add: function(doc, cdt, cdn) { + items_add(doc, cdt, cdn) { var row = frappe.get_doc(cdt, cdn); this.frm.script_manager.copy_from_first_row("items", row, ["income_account", "cost_center"]); - }, + } - set_dynamic_labels: function() { - this._super(); + set_dynamic_labels() { + super.set_dynamic_labels(); this.frm.events.hide_fields(this.frm) - }, + } - items_on_form_rendered: function() { + items_on_form_rendered() { erpnext.setup_serial_or_batch_no(); - }, + } - packed_items_on_form_rendered: function(doc, grid_row) { + packed_items_on_form_rendered(doc, grid_row) { erpnext.setup_serial_or_batch_no(); - }, + } - make_sales_return: function() { + make_sales_return() { frappe.model.open_mapped_doc({ method: "erpnext.accounts.doctype.sales_invoice.sales_invoice.make_sales_return", frm: cur_frm }) - }, + } - asset: function(frm, cdt, cdn) { + asset(frm, cdt, cdn) { var row = locals[cdt][cdn]; if(row.asset) { frappe.call({ @@ -384,18 +384,18 @@ erpnext.accounts.SalesInvoiceController = erpnext.selling.SellingController.exte } }) } - }, + } - is_pos: function(frm){ + is_pos(frm){ this.set_pos_data(); - }, + } - pos_profile: function() { + pos_profile() { this.frm.doc.taxes = [] this.set_pos_data(); - }, + } - set_pos_data: function() { + set_pos_data() { if(this.frm.doc.is_pos) { this.frm.set_value("allocate_advances_automatically", 0); if(!this.frm.doc.company) { @@ -425,13 +425,13 @@ erpnext.accounts.SalesInvoiceController = erpnext.selling.SellingController.exte } } else this.frm.trigger("refresh"); - }, + } - amount: function(){ + amount(){ this.write_off_outstanding_amount_automatically() - }, + } - change_amount: function(){ + change_amount(){ if(this.frm.doc.paid_amount > this.frm.doc.grand_total){ this.calculate_write_off_amount(); }else { @@ -440,18 +440,18 @@ erpnext.accounts.SalesInvoiceController = erpnext.selling.SellingController.exte } this.frm.refresh_fields(); - }, + } - loyalty_amount: function(){ + loyalty_amount(){ this.calculate_outstanding_amount(); this.frm.refresh_field("outstanding_amount"); this.frm.refresh_field("paid_amount"); this.frm.refresh_field("base_paid_amount"); } -}); +}; // for backward compatibility: combine new and previous states -$.extend(cur_frm.cscript, new erpnext.accounts.SalesInvoiceController({frm: cur_frm})); +extend_cscript(cur_frm.cscript, new erpnext.accounts.SalesInvoiceController({frm: cur_frm})); cur_frm.cscript['Make Delivery Note'] = function() { frappe.model.open_mapped_doc({ diff --git a/erpnext/accounts/doctype/sales_invoice/test_sales_invoice.py b/erpnext/accounts/doctype/sales_invoice/test_sales_invoice.py index 114b7d2d352..fe531d3b227 100644 --- a/erpnext/accounts/doctype/sales_invoice/test_sales_invoice.py +++ b/erpnext/accounts/doctype/sales_invoice/test_sales_invoice.py @@ -1957,6 +1957,33 @@ class TestSalesInvoice(unittest.TestCase): einvoice = make_einvoice(si) validate_totals(einvoice) + def test_item_tax_net_range(self): + item = create_item("T Shirt") + + item.set('taxes', []) + item.append("taxes", { + "item_tax_template": "_Test Account Excise Duty @ 10 - _TC", + "minimum_net_rate": 0, + "maximum_net_rate": 500 + }) + + item.append("taxes", { + "item_tax_template": "_Test Account Excise Duty @ 12 - _TC", + "minimum_net_rate": 501, + "maximum_net_rate": 1000 + }) + + item.save() + + sales_invoice = create_sales_invoice(item = "T Shirt", rate=700, do_not_submit=True) + self.assertEqual(sales_invoice.items[0].item_tax_template, "_Test Account Excise Duty @ 12 - _TC") + + # Apply discount + sales_invoice.apply_discount_on = 'Net Total' + sales_invoice.discount_amount = 300 + sales_invoice.save() + self.assertEqual(sales_invoice.items[0].item_tax_template, "_Test Account Excise Duty @ 10 - _TC") + def get_sales_invoice_for_e_invoice(): si = make_sales_invoice_for_ewaybill() si.naming_series = 'INV-2020-.#####' @@ -1985,33 +2012,6 @@ def get_sales_invoice_for_e_invoice(): return si - def test_item_tax_net_range(self): - item = create_item("T Shirt") - - item.set('taxes', []) - item.append("taxes", { - "item_tax_template": "_Test Account Excise Duty @ 10 - _TC", - "minimum_net_rate": 0, - "maximum_net_rate": 500 - }) - - item.append("taxes", { - "item_tax_template": "_Test Account Excise Duty @ 12 - _TC", - "minimum_net_rate": 501, - "maximum_net_rate": 1000 - }) - - item.save() - - sales_invoice = create_sales_invoice(item = "T Shirt", rate=700, do_not_submit=True) - self.assertEqual(sales_invoice.items[0].item_tax_template, "_Test Account Excise Duty @ 12 - _TC") - - # Apply discount - sales_invoice.apply_discount_on = 'Net Total' - sales_invoice.discount_amount = 300 - sales_invoice.save() - self.assertEqual(sales_invoice.items[0].item_tax_template, "_Test Account Excise Duty @ 10 - _TC") - def make_test_address_for_ewaybill(): if not frappe.db.exists('Address', '_Test Address for Eway bill-Billing'): address = frappe.get_doc({ diff --git a/erpnext/accounts/report/profitability_analysis/profitability_analysis.py b/erpnext/accounts/report/profitability_analysis/profitability_analysis.py index 60e675f2f1f..48bd7308bca 100644 --- a/erpnext/accounts/report/profitability_analysis/profitability_analysis.py +++ b/erpnext/accounts/report/profitability_analysis/profitability_analysis.py @@ -168,21 +168,24 @@ def get_columns(filters): "label": _("Income"), "fieldtype": "Currency", "options": "currency", - "width": 120 + "width": 305 + }, { "fieldname": "expense", "label": _("Expense"), "fieldtype": "Currency", "options": "currency", - "width": 120 + "width": 305 + }, { "fieldname": "gross_profit_loss", "label": _("Gross Profit / Loss"), "fieldtype": "Currency", "options": "currency", - "width": 120 + "width": 307 + } ] diff --git a/erpnext/accounts/report/tax_detail/__init__.py b/erpnext/accounts/report/tax_detail/__init__.py new file mode 100644 index 00000000000..e69de29bb2d diff --git a/erpnext/accounts/report/tax_detail/tax_detail.js b/erpnext/accounts/report/tax_detail/tax_detail.js new file mode 100644 index 00000000000..ed6fac4e605 --- /dev/null +++ b/erpnext/accounts/report/tax_detail/tax_detail.js @@ -0,0 +1,451 @@ +// Copyright (c) 2021, Frappe Technologies Pvt. Ltd. and contributors +// For license information, please see license.txt +// Contributed by Case Solved and sponsored by Nulight Studios +/* eslint-disable */ + +frappe.provide('frappe.query_reports'); + +frappe.query_reports["Tax Detail"] = { + filters: [ + { + fieldname: "company", + label: __("Company"), + fieldtype: "Link", + options: "Company", + default: frappe.defaults.get_user_default("company"), + reqd: 1 + }, + { + fieldname: "from_date", + label: __("From Date"), + fieldtype: "Date", + default: frappe.datetime.month_start(frappe.datetime.get_today()), + reqd: 1, + width: "60px" + }, + { + fieldname: "to_date", + label: __("To Date"), + fieldtype: "Date", + default: frappe.datetime.month_end(frappe.datetime.get_today()), + reqd: 1, + width: "60px" + }, + { + fieldname: "report_name", + label: __("Report Name"), + fieldtype: "Read Only", + default: frappe.query_report.report_name, + hidden: 1, + reqd: 1 + }, + { + fieldname: "mode", + label: __("Mode"), + fieldtype: "Read Only", + default: "edit", + hidden: 1, + reqd: 1 + } + ], + onload: function onload(report) { + // Remove Add Column and Save from menu + report.page.add_inner_button(__("New Report"), () => new_report(), __("Custom Report")); + report.page.add_inner_button(__("Load Report"), () => load_report(), __("Custom Report")); + hide_filters(report); + } +}; + +function hide_filters(report) { + report.page.page_form[0].querySelectorAll('.form-group.frappe-control').forEach(function setHidden(field) { + if (field.dataset.fieldtype == "Read Only") { + field.classList.add("hidden"); + } + }); +} + +erpnext.TaxDetail = class TaxDetail { + constructor() { + this.patch(); + this.load_report(); + } + // Monkey patch the QueryReport class + patch() { + this.qr = frappe.query_report; + this.super = { + refresh_report: this.qr.refresh_report, + show_footer_message: this.qr.show_footer_message + } + this.qr.refresh_report = () => this.refresh_report(); + this.qr.show_footer_message = () => this.show_footer_message(); + } + show_footer_message() { + // The last thing to run after datatable_render in refresh() + this.super.show_footer_message.apply(this.qr); + if (this.qr.report_name !== 'Tax Detail') { + this.show_help(); + if (this.loading) { + this.set_section(''); + } else { + this.reload_component(''); + } + } + this.loading = false; + } + refresh_report() { + // Infrequent report build (onload), load filters & data + // super function runs a refresh() serially + // already run within frappe.run_serially + this.loading = true; + this.super.refresh_report.apply(this.qr); + if (this.qr.report_name !== 'Tax Detail') { + frappe.call({ + method: 'erpnext.accounts.report.tax_detail.tax_detail.get_custom_reports', + args: {name: this.qr.report_name} + }).then((r) => { + const data = JSON.parse(r.message[this.qr.report_name]['json']); + this.create_controls(); + this.sections = data.sections || {}; + this.controls['show_detail'].set_input(data.show_detail); + }); + } + } + load_report() { + // One-off report build like titles, menu, etc + // Run when this object is created which happens in qr.load_report + this.qr.menu_items = this.get_menu_items(); + } + get_menu_items() { + // Replace Save action + let new_items = []; + const save = __('Save'); + + for (let item of this.qr.menu_items) { + if (item.label === save) { + new_items.push({ + label: save, + action: () => this.save_report(), + standard: false + }); + } else { + new_items.push(item); + } + } + return new_items; + } + save_report() { + this.check_datatable(); + if (this.qr.report_name !== 'Tax Detail') { + frappe.call({ + method:'erpnext.accounts.report.tax_detail.tax_detail.save_custom_report', + args: { + reference_report: 'Tax Detail', + report_name: this.qr.report_name, + data: { + columns: this.qr.get_visible_columns(), + sections: this.sections, + show_detail: this.controls['show_detail'].get_input_value() + } + }, + freeze: true + }).then((r) => { + this.set_section(''); + }); + } + } + check_datatable() { + if (!this.qr.datatable) { + frappe.throw(__('Please change the date range to load data first')); + } + } + set_section(name) { + // Sets the given section name and then reloads the data + if (name && !this.sections[name]) { + this.sections[name] = {}; + } + let options = Object.keys(this.sections); + options.unshift(''); + this.controls['section_name'].$wrapper.find("select").empty().add_options(options); + const org_mode = this.qr.get_filter_value('mode'); + let refresh = false; + if (name) { + this.controls['section_name'].set_input(name); + this.qr.set_filter_value('mode', 'edit'); + if (org_mode === 'run') { + refresh = true; + } + } else { + this.controls['section_name'].set_input(''); + this.qr.set_filter_value('mode', 'run'); + if (org_mode === 'edit') { + refresh = true; + } + } + if (refresh) { + this.qr.refresh(); + } + this.reload_component(''); + } + reload_component(component_name) { + const section_name = this.controls['section_name'].get_input_value(); + if (section_name) { + const section = this.sections[section_name]; + const component_names = Object.keys(section); + component_names.unshift(''); + this.controls['component'].$wrapper.find("select").empty().add_options(component_names); + this.controls['component'].set_input(component_name); + if (component_name) { + this.controls['component_type'].set_input(section[component_name].type); + } + } else { + this.controls['component'].$wrapper.find("select").empty(); + this.controls['component'].set_input(''); + } + this.set_table_filters(); + } + set_table_filters() { + let filters = {}; + const section_name = this.controls['section_name'].get_input_value(); + const component_name = this.controls['component'].get_input_value(); + if (section_name && component_name) { + const component_type = this.sections[section_name][component_name].type; + if (component_type === 'filter') { + filters = this.sections[section_name][component_name]['filters']; + } + } + this.setAppliedFilters(filters); + } + setAppliedFilters(filters) { + if (this.qr.datatable) { + Array.from(this.qr.datatable.header.querySelectorAll('.dt-filter')).map(function setFilters(input) { + let idx = input.dataset.colIndex; + if (filters[idx]) { + input.value = filters[idx]; + } else { + input.value = null; + } + }); + this.qr.datatable.columnmanager.applyFilter(filters); + } + } + delete(name, type) { + if (type === 'section') { + delete this.sections[name]; + const new_section = Object.keys(this.sections)[0] || ''; + this.set_section(new_section); + } + if (type === 'component') { + const cur_section = this.controls['section_name'].get_input_value(); + delete this.sections[cur_section][name]; + this.reload_component(''); + } + } + create_controls() { + let controls = {}; + // SELECT in data.js + controls['section_name'] = this.qr.page.add_field({ + label: __('Section'), + fieldtype: 'Select', + fieldname: 'section_name', + change: (e) => { + this.set_section(this.controls['section_name'].get_input_value()); + } + }); + // BUTTON in button.js + controls['new_section'] = this.qr.page.add_field({ + label: __('New Section'), + fieldtype: 'Button', + fieldname: 'new_section', + click: () => { + frappe.prompt({ + label: __('Section Name'), + fieldname: 'name', + fieldtype: 'Data' + }, (values) => { + this.set_section(values.name); + }); + } + }); + controls['delete_section'] = this.qr.page.add_field({ + label: __('Delete Section'), + fieldtype: 'Button', + fieldname: 'delete_section', + click: () => { + let cur_section = this.controls['section_name'].get_input_value(); + if (cur_section) { + frappe.confirm(__('Are you sure you want to delete section') + ' ' + cur_section + '?', + () => {this.delete(cur_section, 'section')}); + } + } + }); + controls['component'] = this.qr.page.add_field({ + label: __('Component'), + fieldtype: 'Select', + fieldname: 'component', + change: (e) => { + this.reload_component(this.controls['component'].get_input_value()); + } + }); + controls['component_type'] = this.qr.page.add_field({ + label: __('Component Type'), + fieldtype: 'Select', + fieldname: 'component_type', + default: 'filter', + options: [ + {label: __('Filtered Row Subtotal'), value: 'filter'}, + {label: __('Section Subtotal'), value: 'section'} + ] + }); + controls['add_component'] = this.qr.page.add_field({ + label: __('Add Component'), + fieldtype: 'Button', + fieldname: 'add_component', + click: () => { + this.check_datatable(); + let section_name = this.controls['section_name'].get_input_value(); + if (section_name) { + const component_type = this.controls['component_type'].get_input_value(); + let idx = 0; + const names = Object.keys(this.sections[section_name]); + if (names.length > 0) { + const idxs = names.map((key) => parseInt(key.match(/\d+$/)) || 0); + idx = Math.max(...idxs) + 1; + } + const filters = this.qr.datatable.columnmanager.getAppliedFilters(); + if (component_type === 'filter') { + const name = 'Filter' + idx.toString(); + let data = { + type: component_type, + filters: filters + } + this.sections[section_name][name] = data; + this.reload_component(name); + } else if (component_type === 'section') { + if (filters && Object.keys(filters).length !== 0) { + frappe.show_alert({ + message: __('Column filters ignored'), + indicator: 'yellow' + }); + } + let data = { + type: component_type + } + frappe.prompt({ + label: __('Section'), + fieldname: 'section', + fieldtype: 'Select', + options: Object.keys(this.sections) + }, (values) => { + this.sections[section_name][values.section] = data; + this.reload_component(values.section); + }); + } else { + frappe.throw(__('Please select the Component Type first')); + } + } else { + frappe.throw(__('Please select the Section first')); + } + } + }); + controls['delete_component'] = this.qr.page.add_field({ + label: __('Delete Component'), + fieldtype: 'Button', + fieldname: 'delete_component', + click: () => { + const component = this.controls['component'].get_input_value(); + if (component) { + frappe.confirm(__('Are you sure you want to delete component') + ' ' + component + '?', + () => {this.delete(component, 'component')}); + } + } + }); + controls['save'] = this.qr.page.add_field({ + label: __('Save & Run'), + fieldtype: 'Button', + fieldname: 'save', + click: () => { + this.save_report(); + } + }); + controls['show_detail'] = this.qr.page.add_field({ + label: __('Show Detail'), + fieldtype: 'Check', + fieldname: 'show_detail', + default: 1 + }); + this.controls = controls; + } + show_help() { + const help = __('Your custom report is built from General Ledger Entries within the date range. You can add multiple sections to the report using the New Section button. Each component added to a section adds a subset of the data into the specified section. Beware of duplicated data rows. The Filtered Row component type saves the datatable column filters to specify the added data. The Section component type refers to the data in a previously defined section, but it cannot refer to its parent section. The Amount column is summed to give the section subtotal. Use the Show Detail box to see the data rows included in each section in the final report. Once finished, hit Save & Run. Report contributed by'); + this.qr.$report_footer.append('
' + __('Help') + `: ${help} Case Solved
`); + } +} + +if (!window.taxdetail) { + window.taxdetail = new erpnext.TaxDetail(); +} + +function get_reports(cb) { + frappe.call({ + method: 'erpnext.accounts.report.tax_detail.tax_detail.get_custom_reports', + freeze: true + }).then((r) => { + cb(r.message); + }) +} + +function new_report() { + const dialog = new frappe.ui.Dialog({ + title: __('New Report'), + fields: [ + { + fieldname: 'report_name', + label: __('Report Name'), + fieldtype: 'Data', + default: 'VAT Return' + } + ], + primary_action_label: __('Create'), + primary_action: function new_report_pa(values) { + frappe.call({ + method:'erpnext.accounts.report.tax_detail.tax_detail.save_custom_report', + args: { + reference_report: 'Tax Detail', + report_name: values.report_name, + data: { + columns: [], + sections: {}, + show_detail: 1 + } + }, + freeze: true + }).then((r) => { + frappe.set_route('query-report', values.report_name); + }); + dialog.hide(); + } + }); + dialog.show(); +} + +function load_report() { + get_reports(function load_report_cb(reports) { + const dialog = new frappe.ui.Dialog({ + title: __('Load Report'), + fields: [ + { + fieldname: 'report_name', + label: __('Report Name'), + fieldtype: 'Select', + options: Object.keys(reports) + } + ], + primary_action_label: __('Load'), + primary_action: function load_report_pa(values) { + dialog.hide(); + frappe.set_route('query-report', values.report_name); + } + }); + dialog.show(); + }); +} diff --git a/erpnext/accounts/report/tax_detail/tax_detail.json b/erpnext/accounts/report/tax_detail/tax_detail.json new file mode 100644 index 00000000000..d52ffd05ac0 --- /dev/null +++ b/erpnext/accounts/report/tax_detail/tax_detail.json @@ -0,0 +1,32 @@ +{ + "add_total_row": 0, + "columns": [], + "creation": "2021-02-19 16:44:21.175113", + "disable_prepared_report": 0, + "disabled": 0, + "docstatus": 0, + "doctype": "Report", + "filters": [], + "idx": 0, + "is_standard": "Yes", + "modified": "2021-02-19 16:44:21.175113", + "modified_by": "Administrator", + "module": "Accounts", + "name": "Tax Detail", + "owner": "Administrator", + "prepared_report": 0, + "ref_doctype": "GL Entry", + "report_name": "Tax Detail", + "report_type": "Script Report", + "roles": [ + { + "role": "Accounts User" + }, + { + "role": "Accounts Manager" + }, + { + "role": "Auditor" + } + ] +} \ No newline at end of file diff --git a/erpnext/accounts/report/tax_detail/tax_detail.py b/erpnext/accounts/report/tax_detail/tax_detail.py new file mode 100644 index 00000000000..18436de3d8a --- /dev/null +++ b/erpnext/accounts/report/tax_detail/tax_detail.py @@ -0,0 +1,296 @@ +# Copyright (c) 2021, Frappe Technologies Pvt. Ltd. and contributors +# For license information, please see license.txt +# Contributed by Case Solved and sponsored by Nulight Studios + +from __future__ import unicode_literals +import frappe +import json +from frappe import _ + +# NOTE: Payroll is implemented using Journal Entries which are included as GL Entries + +# field lists in multiple doctypes will be coalesced +required_sql_fields = { + ("GL Entry", 1): ["posting_date"], + ("Account",): ["root_type", "account_type"], + ("GL Entry", 2): ["account", "voucher_type", "voucher_no", "debit", "credit"], + ("Purchase Invoice Item", "Sales Invoice Item"): ["base_net_amount", "item_tax_rate", "item_tax_template", "item_group", "item_name"], + ("Purchase Invoice", "Sales Invoice"): ["taxes_and_charges", "tax_category"], +} + + +def execute(filters=None): + if not filters: + return [], [] + + fieldlist = required_sql_fields + fieldstr = get_fieldstr(fieldlist) + + gl_entries = frappe.db.sql(""" + select {fieldstr} + from `tabGL Entry` ge + inner join `tabAccount` a on + ge.account=a.name and ge.company=a.company + left join `tabSales Invoice` si on + ge.company=si.company and ge.voucher_type='Sales Invoice' and ge.voucher_no=si.name + left join `tabSales Invoice Item` sii on + a.root_type='Income' and si.name=sii.parent + left join `tabPurchase Invoice` pi on + ge.company=pi.company and ge.voucher_type='Purchase Invoice' and ge.voucher_no=pi.name + left join `tabPurchase Invoice Item` pii on + a.root_type='Expense' and pi.name=pii.parent + where + ge.company=%(company)s and + ge.posting_date>=%(from_date)s and + ge.posting_date<=%(to_date)s + order by ge.posting_date, ge.voucher_no + """.format(fieldstr=fieldstr), filters, as_dict=1) + + report_data = modify_report_data(gl_entries) + summary = None + if filters['mode'] == 'run' and filters['report_name'] != 'Tax Detail': + report_data, summary = run_report(filters['report_name'], report_data) + + # return columns, data, message, chart, report_summary + return get_columns(fieldlist), report_data, None, None, summary + +def run_report(report_name, data): + "Applies the sections and filters saved in the custom report" + report_config = json.loads(frappe.get_doc('Report', report_name).json) + # Columns indexed from 1 wrt colno + columns = report_config.get('columns') + sections = report_config.get('sections', {}) + show_detail = report_config.get('show_detail', 1) + report = {} + new_data = [] + summary = [] + for section_name, section in sections.items(): + report[section_name] = {'rows': [], 'subtotal': 0.0} + for component_name, component in section.items(): + if component['type'] == 'filter': + for row in data: + matched = True + for colno, filter_string in component['filters'].items(): + filter_field = columns[int(colno) - 1]['fieldname'] + if not filter_match(row[filter_field], filter_string): + matched = False + break + if matched: + report[section_name]['rows'] += [row] + report[section_name]['subtotal'] += row['amount'] + if component['type'] == 'section': + if component_name == section_name: + frappe.throw(_("A report component cannot refer to its parent section") + ": " + section_name) + try: + report[section_name]['rows'] += report[component_name]['rows'] + report[section_name]['subtotal'] += report[component_name]['subtotal'] + except KeyError: + frappe.throw(_("A report component can only refer to an earlier section") + ": " + section_name) + + if show_detail: + new_data += report[section_name]['rows'] + new_data += [{'voucher_no': section_name, 'amount': report[section_name]['subtotal']}] + summary += [{'label': section_name, 'datatype': 'Currency', 'value': report[section_name]['subtotal']}] + if show_detail: + new_data += [{}] + return new_data or data, summary or None + +def filter_match(value, string): + "Approximation to datatable filters" + import datetime + if string == '': + return True + if value is None: + value = -999999999999999 + elif isinstance(value, datetime.date): + return True + + if isinstance(value, str): + value = value.lower() + string = string.lower() + if string[0] == '<': + return True if string[1:].strip() else False + elif string[0] == '>': + return False if string[1:].strip() else True + elif string[0] == '=': + return string[1:] in value if string[1:] else False + elif string[0:2] == '!=': + return string[2:] not in value + elif len(string.split(':')) == 2: + pre, post = string.split(':') + return (True if not pre.strip() and post.strip() in value else False) + else: + return string in value + else: + if string[0] in ['<', '>', '=']: + operator = string[0] + if operator == '=': + operator = '==' + string = string[1:].strip() + elif string[0:2] == '!=': + operator = '!=' + string = string[2:].strip() + elif len(string.split(':')) == 2: + pre, post = string.split(':') + try: + return (True if float(pre) <= value and float(post) >= value else False) + except ValueError: + return (False if pre.strip() else True) + else: + return string in str(value) + + try: + num = float(string) if string.strip() else 0 + return frappe.safe_eval(f'{value} {operator} {num}') + except ValueError: + if operator == '<': + return True + return False + + +def abbrev(dt): + return ''.join(l[0].lower() for l in dt.split(' ')) + '.' + +def doclist(dt, dfs): + return [abbrev(dt) + f for f in dfs] + +def as_split(fields): + for field in fields: + split = field.split(' as ') + yield (split[0], split[1] if len(split) > 1 else split[0]) + +def coalesce(doctypes, fields): + coalesce = [] + for name, new_name in as_split(fields): + sharedfields = ', '.join(abbrev(dt) + name for dt in doctypes) + coalesce += [f'coalesce({sharedfields}) as {new_name}'] + return coalesce + +def get_fieldstr(fieldlist): + fields = [] + for doctypes, docfields in fieldlist.items(): + if len(doctypes) == 1 or isinstance(doctypes[1], int): + fields += doclist(doctypes[0], docfields) + else: + fields += coalesce(doctypes, docfields) + return ', '.join(fields) + +def get_columns(fieldlist): + columns = {} + for doctypes, docfields in fieldlist.items(): + fieldmap = {name: new_name for name, new_name in as_split(docfields)} + for doctype in doctypes: + if isinstance(doctype, int): + break + meta = frappe.get_meta(doctype) + # get column field metadata from the db + fieldmeta = {} + for field in meta.get('fields'): + if field.fieldname in fieldmap.keys(): + new_name = fieldmap[field.fieldname] + fieldmeta[new_name] = { + "label": _(field.label), + "fieldname": new_name, + "fieldtype": field.fieldtype, + "options": field.options + } + # edit the columns to match the modified data + for field in fieldmap.values(): + col = modify_report_columns(doctype, field, fieldmeta[field]) + if col: + columns[col["fieldname"]] = col + # use of a dict ensures duplicate columns are removed + return list(columns.values()) + +def modify_report_columns(doctype, field, column): + "Because data is rearranged into other columns" + if doctype in ["Sales Invoice Item", "Purchase Invoice Item"]: + if field in ["item_tax_rate", "base_net_amount"]: + return None + + if doctype == "GL Entry" and field in ["debit", "credit"]: + column.update({"label": _("Amount"), "fieldname": "amount"}) + + if field == "taxes_and_charges": + column.update({"label": _("Taxes and Charges Template")}) + return column + +def modify_report_data(data): + import json + new_data = [] + for line in data: + if line.debit: + line.amount = -line.debit + else: + line.amount = line.credit + # Remove Invoice GL Tax Entries and generate Tax entries from the invoice lines + if "Invoice" in line.voucher_type: + if line.account_type not in ("Tax", "Round Off"): + new_data += [line] + if line.item_tax_rate: + tax_rates = json.loads(line.item_tax_rate) + for account, rate in tax_rates.items(): + tax_line = line.copy() + tax_line.account_type = "Tax" + tax_line.account = account + if line.voucher_type == "Sales Invoice": + line.amount = line.base_net_amount + tax_line.amount = line.base_net_amount * (rate / 100) + if line.voucher_type == "Purchase Invoice": + line.amount = -line.base_net_amount + tax_line.amount = -line.base_net_amount * (rate / 100) + new_data += [tax_line] + else: + new_data += [line] + return new_data + + +# JS client utilities + +custom_report_dict = { + 'ref_doctype': 'GL Entry', + 'report_type': 'Custom Report', + 'reference_report': 'Tax Detail' +} + +@frappe.whitelist() +def get_custom_reports(name=None): + filters = custom_report_dict.copy() + if name: + filters['name'] = name + reports = frappe.get_list('Report', + filters = filters, + fields = ['name', 'json'], + as_list=False + ) + reports_dict = {rep.pop('name'): rep for rep in reports} + # Prevent custom reports with the same name + reports_dict['Tax Detail'] = {'json': None} + return reports_dict + +@frappe.whitelist() +def save_custom_report(reference_report, report_name, data): + if reference_report != 'Tax Detail': + frappe.throw(_("The wrong report is referenced.")) + if report_name == 'Tax Detail': + frappe.throw(_("The parent report cannot be overwritten.")) + + doc = { + 'doctype': 'Report', + 'report_name': report_name, + 'is_standard': 'No', + 'module': 'Accounts', + 'json': data + } + doc.update(custom_report_dict) + + try: + newdoc = frappe.get_doc(doc) + newdoc.insert() + frappe.msgprint(_("Report created successfully")) + except frappe.exceptions.DuplicateEntryError: + dbdoc = frappe.get_doc('Report', report_name) + dbdoc.update(doc) + dbdoc.save() + frappe.msgprint(_("Report updated successfully")) + return report_name diff --git a/erpnext/accounts/report/tax_detail/test_tax_detail.json b/erpnext/accounts/report/tax_detail/test_tax_detail.json new file mode 100644 index 00000000000..3a4b1754554 --- /dev/null +++ b/erpnext/accounts/report/tax_detail/test_tax_detail.json @@ -0,0 +1,840 @@ +[ + { + "account_manager": null, + "accounts": [], + "companies": [], + "credit_limits": [], + "customer_details": null, + "customer_group": "All Customer Groups", + "customer_name": "_Test Customer", + "customer_pos_id": null, + "customer_primary_address": null, + "customer_primary_contact": null, + "customer_type": "Company", + "default_bank_account": null, + "default_commission_rate": 0.0, + "default_currency": null, + "default_price_list": null, + "default_sales_partner": null, + "disabled": 0, + "dn_required": 0, + "docstatus": 0, + "doctype": "Customer", + "email_id": null, + "gender": null, + "image": null, + "industry": null, + "is_frozen": 0, + "is_internal_customer": 0, + "language": "en", + "lead_name": null, + "loyalty_program": null, + "loyalty_program_tier": null, + "market_segment": null, + "mobile_no": null, + "modified": "2021-02-15 05:18:03.624724", + "name": "_Test Customer", + "naming_series": "CUST-.YYYY.-", + "pan": null, + "parent": null, + "parentfield": null, + "parenttype": null, + "payment_terms": null, + "primary_address": null, + "represents_company": "", + "sales_team": [], + "salutation": null, + "so_required": 0, + "tax_category": null, + "tax_id": null, + "tax_withholding_category": null, + "territory": "All Territories", + "website": null + },{ + "accounts": [], + "allow_purchase_invoice_creation_without_purchase_order": 0, + "allow_purchase_invoice_creation_without_purchase_receipt": 0, + "companies": [], + "country": "United Kingdom", + "default_bank_account": null, + "default_currency": null, + "default_price_list": null, + "disabled": 0, + "docstatus": 0, + "doctype": "Supplier", + "hold_type": "", + "image": null, + "is_frozen": 0, + "is_internal_supplier": 0, + "is_transporter": 0, + "language": "en", + "modified": "2021-03-31 16:47:10.109316", + "name": "_Test Supplier", + "naming_series": "SUP-.YYYY.-", + "on_hold": 0, + "pan": null, + "parent": null, + "parentfield": null, + "parenttype": null, + "payment_terms": null, + "prevent_pos": 0, + "prevent_rfqs": 0, + "release_date": null, + "represents_company": null, + "supplier_details": null, + "supplier_group": "Raw Material", + "supplier_name": "_Test Supplier", + "supplier_type": "Company", + "tax_category": null, + "tax_id": null, + "tax_withholding_category": null, + "warn_pos": 0, + "warn_rfqs": 0, + "website": null + },{ + "account_currency": "GBP", + "account_name": "Debtors", + "account_number": "", + "account_type": "Receivable", + "balance_must_be": "", + "company": "_T", + "disabled": 0, + "docstatus": 0, + "doctype": "Account", + "freeze_account": "No", + "include_in_gross": 0, + "inter_company_account": 0, + "is_group": 0, + "lft": 58, + "modified": "2021-03-26 04:44:19.955468", + "name": "Debtors - _T", + "old_parent": null, + "parent": null, + "parent_account": "Application of Funds (Assets) - _T", + "parentfield": null, + "parenttype": null, + "report_type": "Balance Sheet", + "rgt": 59, + "root_type": "Asset", + "tax_rate": 0.0 + },{ + "account_currency": "GBP", + "account_name": "Sales", + "account_number": "", + "account_type": "Income Account", + "balance_must_be": "", + "company": "_T", + "disabled": 0, + "docstatus": 0, + "doctype": "Account", + "freeze_account": "No", + "include_in_gross": 0, + "inter_company_account": 0, + "is_group": 0, + "lft": 291, + "modified": "2021-03-26 04:50:21.697703", + "name": "Sales - _T", + "old_parent": null, + "parent": null, + "parent_account": "Income - _T", + "parentfield": null, + "parenttype": null, + "report_type": "Profit and Loss", + "rgt": 292, + "root_type": "Income", + "tax_rate": 0.0 + },{ + "account_currency": "GBP", + "account_name": "VAT on Sales", + "account_number": "", + "account_type": "Tax", + "balance_must_be": "", + "company": "_T", + "disabled": 0, + "docstatus": 0, + "doctype": "Account", + "freeze_account": "No", + "include_in_gross": 0, + "inter_company_account": 0, + "is_group": 0, + "lft": 317, + "modified": "2021-03-26 04:50:21.697703", + "name": "VAT on Sales - _T", + "old_parent": null, + "parent": null, + "parent_account": "Source of Funds (Liabilities) - _T", + "parentfield": null, + "parenttype": null, + "report_type": "Balance Sheet", + "rgt": 318, + "root_type": "Liability", + "tax_rate": 0.0 + },{ + "account_currency": "GBP", + "account_name": "Cost of Goods Sold", + "account_number": "", + "account_type": "Cost of Goods Sold", + "balance_must_be": "", + "company": "_T", + "disabled": 0, + "docstatus": 0, + "doctype": "Account", + "freeze_account": "No", + "include_in_gross": 0, + "inter_company_account": 0, + "is_group": 0, + "lft": 171, + "modified": "2021-03-26 04:44:19.994857", + "name": "Cost of Goods Sold - _T", + "old_parent": null, + "parent": null, + "parent_account": "Expenses - _T", + "parentfield": null, + "parenttype": null, + "report_type": "Profit and Loss", + "rgt": 172, + "root_type": "Expense", + "tax_rate": 0.0 + },{ + "account_currency": "GBP", + "account_name": "VAT on Purchases", + "account_number": "", + "account_type": "Tax", + "balance_must_be": "", + "company": "_T", + "disabled": 0, + "docstatus": 0, + "doctype": "Account", + "freeze_account": "No", + "include_in_gross": 0, + "inter_company_account": 0, + "is_group": 0, + "lft": 80, + "modified": "2021-03-26 04:44:19.961983", + "name": "VAT on Purchases - _T", + "old_parent": null, + "parent": null, + "parent_account": "Application of Funds (Assets) - _T", + "parentfield": null, + "parenttype": null, + "report_type": "Balance Sheet", + "rgt": 81, + "root_type": "Asset", + "tax_rate": 0.0 + },{ + "account_currency": "GBP", + "account_name": "Creditors", + "account_number": "", + "account_type": "Payable", + "balance_must_be": "", + "company": "_T", + "disabled": 0, + "docstatus": 0, + "doctype": "Account", + "freeze_account": "No", + "include_in_gross": 0, + "inter_company_account": 0, + "is_group": 0, + "lft": 302, + "modified": "2021-03-26 04:50:21.697703", + "name": "Creditors - _T", + "old_parent": null, + "parent": null, + "parent_account": "Source of Funds (Liabilities) - _T", + "parentfield": null, + "parenttype": null, + "report_type": "Balance Sheet", + "rgt": 303, + "root_type": "Liability", + "tax_rate": 0.0 + },{ + "additional_discount_percentage": 0.0, + "address_display": null, + "adjust_advance_taxes": 0, + "advances": [], + "against_expense_account": "Cost of Goods Sold - _T", + "allocate_advances_automatically": 0, + "amended_from": null, + "apply_discount_on": "Grand Total", + "apply_tds": 0, + "auto_repeat": null, + "base_discount_amount": 0.0, + "base_grand_total": 511.68, + "base_in_words": "GBP Five Hundred And Eleven and Sixty Eight Pence only.", + "base_net_total": 426.4, + "base_paid_amount": 0.0, + "base_rounded_total": 511.68, + "base_rounding_adjustment": 0.0, + "base_taxes_and_charges_added": 85.28, + "base_taxes_and_charges_deducted": 0.0, + "base_total": 426.4, + "base_total_taxes_and_charges": 85.28, + "base_write_off_amount": 0.0, + "bill_date": null, + "bill_no": null, + "billing_address": null, + "billing_address_display": null, + "buying_price_list": "Standard Buying", + "cash_bank_account": null, + "clearance_date": null, + "company": "_T", + "contact_display": null, + "contact_email": null, + "contact_mobile": null, + "contact_person": null, + "conversion_rate": 1.0, + "cost_center": null, + "credit_to": "Creditors - _T", + "currency": "GBP", + "disable_rounded_total": 0, + "discount_amount": 0.0, + "docstatus": 0, + "doctype": "Purchase Invoice", + "due_date": null, + "from_date": null, + "grand_total": 511.68, + "group_same_items": 0, + "hold_comment": null, + "ignore_pricing_rule": 0, + "in_words": "GBP Five Hundred And Eleven and Sixty Eight Pence only.", + "inter_company_invoice_reference": null, + "is_internal_supplier": 0, + "is_opening": "No", + "is_paid": 0, + "is_return": 0, + "is_subcontracted": "No", + "items": [ + { + "allow_zero_valuation_rate": 0, + "amount": 426.4, + "asset_category": null, + "asset_location": null, + "base_amount": 426.4, + "base_net_amount": 426.4, + "base_net_rate": 5.33, + "base_price_list_rate": 5.33, + "base_rate": 5.33, + "base_rate_with_margin": 0.0, + "batch_no": null, + "bom": null, + "brand": null, + "conversion_factor": 0.0, + "cost_center": "Main - _T", + "deferred_expense_account": null, + "description": "

Fluid to make widgets

", + "discount_amount": 0.0, + "discount_percentage": 0.0, + "enable_deferred_expense": 0, + "expense_account": "Cost of Goods Sold - _T", + "from_warehouse": null, + "image": null, + "include_exploded_items": 0, + "is_fixed_asset": 0, + "is_free_item": 0, + "item_code": null, + "item_group": null, + "item_name": "Widget Fluid 1Litre", + "item_tax_amount": 0.0, + "item_tax_rate": "{\"VAT on Purchases - _T\": 20.0}", + "item_tax_template": null, + "landed_cost_voucher_amount": 0.0, + "manufacturer": null, + "manufacturer_part_no": null, + "margin_rate_or_amount": 0.0, + "margin_type": "", + "net_amount": 426.4, + "net_rate": 5.33, + "page_break": 0, + "parent": null, + "parentfield": "items", + "parenttype": "Purchase Invoice", + "po_detail": null, + "pr_detail": null, + "price_list_rate": 5.33, + "pricing_rules": null, + "project": null, + "purchase_invoice_item": null, + "purchase_order": null, + "purchase_receipt": null, + "qty": 80.0, + "quality_inspection": null, + "rate": 5.33, + "rate_with_margin": 0.0, + "received_qty": 0.0, + "rejected_qty": 0.0, + "rejected_serial_no": null, + "rejected_warehouse": null, + "rm_supp_cost": 0.0, + "sales_invoice_item": null, + "serial_no": null, + "service_end_date": null, + "service_start_date": null, + "service_stop_date": null, + "stock_qty": 0.0, + "stock_uom": "Nos", + "stock_uom_rate": 0.0, + "total_weight": 0.0, + "uom": "Nos", + "valuation_rate": 0.0, + "warehouse": null, + "weight_per_unit": 0.0, + "weight_uom": null + } + ], + "language": "en", + "letter_head": null, + "mode_of_payment": null, + "modified": "2021-04-03 03:33:09.180453", + "name": null, + "naming_series": "ACC-PINV-.YYYY.-", + "net_total": 426.4, + "on_hold": 0, + "other_charges_calculation": "
\n\t\n\t\t\n\t\t\t\n\t\t\t\t\n\t\t\t\t\t\n\t\t\t\t\t\t\n\t\t\t\t\t\n\t\t\t\t\n\t\t\t\t\t\n\t\t\t\t\t\t\n\t\t\t\t\t\n\t\t\t\t\n\t\t\t\t\t\n\t\t\t\t\t\t\n\t\t\t\t\t\n\t\t\t\t\n\t\t\t\n\t\t\n\t\t\n\t\t\t\n\t\t\t\t\n\t\t\t\t\t\n\t\t\t\t\t\n\t\t\t\t\t\n\t\t\t\t\t\t\n\t\t\t\t\t\t\n\t\t\t\t\t\t\t\n\t\t\t\t\t\t\n\t\t\t\t\t\n\t\t\t\t\n\t\t\t\n\t\t\n\t
ItemTaxable AmountVAT on Purchases
Widget Fluid 1Litre\n\t\t\t\t\t\t\n\t\t\t\t\t\t\t\u00a3 426.40\n\t\t\t\t\t\t\n\t\t\t\t\t\n\t\t\t\t\t\t\t\t\n\t\t\t\t\t\t\t\t\t(20.0%)\n\t\t\t\t\t\t\t\t\n\t\t\t\t\t\t\t\t\n\t\t\t\t\t\t\t\t\t\u00a3 85.28\n\t\t\t\t\t\t\t\t\n\t\t\t\t\t\t\t
\n
", + "outstanding_amount": 511.68, + "paid_amount": 0.0, + "parent": null, + "parentfield": null, + "parenttype": null, + "party_account_currency": "GBP", + "payment_schedule": [], + "payment_terms_template": null, + "plc_conversion_rate": 1.0, + "posting_date": null, + "posting_time": "16:59:56.789522", + "price_list_currency": "GBP", + "pricing_rules": [], + "project": null, + "rejected_warehouse": null, + "release_date": null, + "remarks": "No Remarks", + "represents_company": null, + "return_against": null, + "rounded_total": 511.68, + "rounding_adjustment": 0.0, + "scan_barcode": null, + "select_print_heading": null, + "set_from_warehouse": null, + "set_posting_time": 0, + "set_warehouse": null, + "shipping_address": null, + "shipping_address_display": "", + "shipping_rule": null, + "status": "Unpaid", + "supplied_items": [], + "supplier": "_Test Supplier", + "supplier_address": null, + "supplier_name": "_Test Supplier", + "supplier_warehouse": "Stores - _T", + "tax_category": null, + "tax_id": null, + "tax_withholding_category": null, + "taxes": [ + { + "account_head": "VAT on Purchases - _T", + "add_deduct_tax": "Add", + "base_tax_amount": 85.28, + "base_tax_amount_after_discount_amount": 85.28, + "base_total": 511.68, + "category": "Total", + "charge_type": "On Net Total", + "cost_center": "Main - _T", + "description": "VAT on Purchases", + "included_in_print_rate": 0, + "item_wise_tax_detail": "{\"Widget Fluid 1Litre\":[20.0,85.28]}", + "parent": null, + "parentfield": "taxes", + "parenttype": "Purchase Invoice", + "rate": 0.0, + "row_id": null, + "tax_amount": 85.28, + "tax_amount_after_discount_amount": 85.28, + "total": 511.68 + } + ], + "taxes_and_charges": null, + "taxes_and_charges_added": 85.28, + "taxes_and_charges_deducted": 0.0, + "tc_name": null, + "terms": null, + "title": "_Purchase Invoice", + "to_date": null, + "total": 426.4, + "total_advance": 0.0, + "total_net_weight": 0.0, + "total_qty": 80.0, + "total_taxes_and_charges": 85.28, + "unrealized_profit_loss_account": null, + "update_stock": 0, + "write_off_account": null, + "write_off_amount": 0.0, + "write_off_cost_center": null + },{ + "account_for_change_amount": null, + "additional_discount_percentage": 0.0, + "address_display": null, + "advances": [], + "against_income_account": "Sales - _T", + "allocate_advances_automatically": 0, + "amended_from": null, + "apply_discount_on": "Grand Total", + "auto_repeat": null, + "base_change_amount": 0.0, + "base_discount_amount": 0.0, + "base_grand_total": 868.25, + "base_in_words": "GBP Eight Hundred And Sixty Eight and Twenty Five Pence only.", + "base_net_total": 825.0, + "base_paid_amount": 0.0, + "base_rounded_total": 868.25, + "base_rounding_adjustment": 0.0, + "base_total": 825.0, + "base_total_taxes_and_charges": 43.25, + "base_write_off_amount": 0.0, + "c_form_applicable": "No", + "c_form_no": null, + "campaign": null, + "cash_bank_account": null, + "change_amount": 0.0, + "commission_rate": 0.0, + "company": "_T", + "company_address": null, + "company_address_display": null, + "company_tax_id": null, + "contact_display": null, + "contact_email": null, + "contact_mobile": null, + "contact_person": null, + "conversion_rate": 1.0, + "cost_center": null, + "currency": "GBP", + "customer": "_Test Customer", + "customer_address": null, + "customer_group": "All Customer Groups", + "customer_name": "_Test Customer", + "debit_to": "Debtors - _T", + "discount_amount": 0.0, + "docstatus": 0, + "doctype": "Sales Invoice", + "due_date": null, + "from_date": null, + "grand_total": 868.25, + "group_same_items": 0, + "ignore_pricing_rule": 0, + "in_words": "GBP Eight Hundred And Sixty Eight and Twenty Five Pence only.", + "inter_company_invoice_reference": null, + "is_consolidated": 0, + "is_discounted": 0, + "is_internal_customer": 0, + "is_opening": "No", + "is_pos": 0, + "is_return": 0, + "items": [ + { + "actual_batch_qty": 0.0, + "actual_qty": 0.0, + "allow_zero_valuation_rate": 0, + "amount": 200.0, + "asset": null, + "barcode": null, + "base_amount": 200.0, + "base_net_amount": 200.0, + "base_net_rate": 50.0, + "base_price_list_rate": 0.0, + "base_rate": 50.0, + "base_rate_with_margin": 0.0, + "batch_no": null, + "brand": null, + "conversion_factor": 1.0, + "cost_center": "Main - _T", + "customer_item_code": null, + "deferred_revenue_account": null, + "delivered_by_supplier": 0, + "delivered_qty": 0.0, + "delivery_note": null, + "description": "

Used

", + "discount_amount": 0.0, + "discount_percentage": 0.0, + "dn_detail": null, + "enable_deferred_revenue": 0, + "expense_account": null, + "finance_book": null, + "image": null, + "income_account": "Sales - _T", + "incoming_rate": 0.0, + "is_fixed_asset": 0, + "is_free_item": 0, + "item_code": null, + "item_group": null, + "item_name": "Dunlop tyres", + "item_tax_rate": "{\"VAT on Sales - _T\": 20.0}", + "item_tax_template": null, + "margin_rate_or_amount": 0.0, + "margin_type": "", + "net_amount": 200.0, + "net_rate": 50.0, + "page_break": 0, + "parent": null, + "parentfield": "items", + "parenttype": "Sales Invoice", + "price_list_rate": 0.0, + "pricing_rules": null, + "project": null, + "qty": 4.0, + "quality_inspection": null, + "rate": 50.0, + "rate_with_margin": 0.0, + "sales_invoice_item": null, + "sales_order": null, + "serial_no": null, + "service_end_date": null, + "service_start_date": null, + "service_stop_date": null, + "so_detail": null, + "stock_qty": 4.0, + "stock_uom": "Nos", + "stock_uom_rate": 50.0, + "target_warehouse": null, + "total_weight": 0.0, + "uom": "Nos", + "warehouse": null, + "weight_per_unit": 0.0, + "weight_uom": null + }, + { + "actual_batch_qty": 0.0, + "actual_qty": 0.0, + "allow_zero_valuation_rate": 0, + "amount": 65.0, + "asset": null, + "barcode": null, + "base_amount": 65.0, + "base_net_amount": 65.0, + "base_net_rate": 65.0, + "base_price_list_rate": 0.0, + "base_rate": 65.0, + "base_rate_with_margin": 0.0, + "batch_no": null, + "brand": null, + "conversion_factor": 1.0, + "cost_center": "Main - _T", + "customer_item_code": null, + "deferred_revenue_account": null, + "delivered_by_supplier": 0, + "delivered_qty": 0.0, + "delivery_note": null, + "description": "

Used

", + "discount_amount": 0.0, + "discount_percentage": 0.0, + "dn_detail": null, + "enable_deferred_revenue": 0, + "expense_account": null, + "finance_book": null, + "image": null, + "income_account": "Sales - _T", + "incoming_rate": 0.0, + "is_fixed_asset": 0, + "is_free_item": 0, + "item_code": "", + "item_group": null, + "item_name": "Continental tyres", + "item_tax_rate": "{\"VAT on Sales - _T\": 5.0}", + "item_tax_template": null, + "margin_rate_or_amount": 0.0, + "margin_type": "", + "net_amount": 65.0, + "net_rate": 65.0, + "page_break": 0, + "parent": null, + "parentfield": "items", + "parenttype": "Sales Invoice", + "price_list_rate": 0.0, + "pricing_rules": null, + "project": null, + "qty": 1.0, + "quality_inspection": null, + "rate": 65.0, + "rate_with_margin": 0.0, + "sales_invoice_item": null, + "sales_order": null, + "serial_no": null, + "service_end_date": null, + "service_start_date": null, + "service_stop_date": null, + "so_detail": null, + "stock_qty": 1.0, + "stock_uom": null, + "stock_uom_rate": 65.0, + "target_warehouse": null, + "total_weight": 0.0, + "uom": "Nos", + "warehouse": null, + "weight_per_unit": 0.0, + "weight_uom": null + }, + { + "actual_batch_qty": 0.0, + "actual_qty": 0.0, + "allow_zero_valuation_rate": 0, + "amount": 560.0, + "asset": null, + "barcode": null, + "base_amount": 560.0, + "base_net_amount": 560.0, + "base_net_rate": 70.0, + "base_price_list_rate": 0.0, + "base_rate": 70.0, + "base_rate_with_margin": 0.0, + "batch_no": null, + "brand": null, + "conversion_factor": 1.0, + "cost_center": "Main - _T", + "customer_item_code": null, + "deferred_revenue_account": null, + "delivered_by_supplier": 0, + "delivered_qty": 0.0, + "delivery_note": null, + "description": "

New

", + "discount_amount": 0.0, + "discount_percentage": 0.0, + "dn_detail": null, + "enable_deferred_revenue": 0, + "expense_account": null, + "finance_book": null, + "image": null, + "income_account": "Sales - _T", + "incoming_rate": 0.0, + "is_fixed_asset": 0, + "is_free_item": 0, + "item_code": null, + "item_group": null, + "item_name": "Toyo tyres", + "item_tax_rate": "{\"VAT on Sales - _T\": 0.0}", + "item_tax_template": null, + "margin_rate_or_amount": 0.0, + "margin_type": "", + "net_amount": 560.0, + "net_rate": 70.0, + "page_break": 0, + "parent": null, + "parentfield": "items", + "parenttype": "Sales Invoice", + "price_list_rate": 0.0, + "pricing_rules": null, + "project": null, + "qty": 8.0, + "quality_inspection": null, + "rate": 70.0, + "rate_with_margin": 0.0, + "sales_invoice_item": null, + "sales_order": null, + "serial_no": null, + "service_end_date": null, + "service_start_date": null, + "service_stop_date": null, + "so_detail": null, + "stock_qty": 8.0, + "stock_uom": null, + "stock_uom_rate": 70.0, + "target_warehouse": null, + "total_weight": 0.0, + "uom": "Nos", + "warehouse": null, + "weight_per_unit": 0.0, + "weight_uom": null + } + ], + "language": "en", + "letter_head": null, + "loyalty_amount": 0.0, + "loyalty_points": 0, + "loyalty_program": null, + "loyalty_redemption_account": null, + "loyalty_redemption_cost_center": null, + "modified": "2021-02-16 05:18:59.755144", + "name": null, + "naming_series": "ACC-SINV-.YYYY.-", + "net_total": 825.0, + "other_charges_calculation": "
\n\t\n\t\t\n\t\t\t\n\t\t\t\t\n\t\t\t\t\t\n\t\t\t\t\t\t\n\t\t\t\t\t\n\t\t\t\t\n\t\t\t\t\t\n\t\t\t\t\t\t\n\t\t\t\t\t\n\t\t\t\t\n\t\t\t\t\t\n\t\t\t\t\t\t\n\t\t\t\t\t\n\t\t\t\t\n\t\t\t\n\t\t\n\t\t\n\t\t\t\n\t\t\t\t\n\t\t\t\t\t\n\t\t\t\t\t\n\t\t\t\t\t\n\t\t\t\t\t\t\n\t\t\t\t\t\t\n\t\t\t\t\t\t\t\n\t\t\t\t\t\t\n\t\t\t\t\t\n\t\t\t\t\n\t\t\t\n\t\t\t\t\n\t\t\t\t\t\n\t\t\t\t\t\n\t\t\t\t\t\n\t\t\t\t\t\t\n\t\t\t\t\t\t\n\t\t\t\t\t\t\t\n\t\t\t\t\t\t\n\t\t\t\t\t\n\t\t\t\t\n\t\t\t\n\t\t\t\t\n\t\t\t\t\t\n\t\t\t\t\t\n\t\t\t\t\t\n\t\t\t\t\t\t\n\t\t\t\t\t\t\n\t\t\t\t\t\t\t\n\t\t\t\t\t\t\n\t\t\t\t\t\n\t\t\t\t\n\t\t\t\n\t\t\n\t
ItemTaxable AmountVAT on Sales
Dunlop tyres\n\t\t\t\t\t\t\n\t\t\t\t\t\t\t\u00a3 200.00\n\t\t\t\t\t\t\n\t\t\t\t\t\n\t\t\t\t\t\t\t\t\n\t\t\t\t\t\t\t\t\t(20.0%)\n\t\t\t\t\t\t\t\t\n\t\t\t\t\t\t\t\t\n\t\t\t\t\t\t\t\t\t\u00a3 40.00\n\t\t\t\t\t\t\t\t\n\t\t\t\t\t\t\t
Continental tyres\n\t\t\t\t\t\t\n\t\t\t\t\t\t\t\u00a3 65.00\n\t\t\t\t\t\t\n\t\t\t\t\t\n\t\t\t\t\t\t\t\t\n\t\t\t\t\t\t\t\t\t(5.0%)\n\t\t\t\t\t\t\t\t\n\t\t\t\t\t\t\t\t\n\t\t\t\t\t\t\t\t\t\u00a3 3.25\n\t\t\t\t\t\t\t\t\n\t\t\t\t\t\t\t
Toyo tyres\n\t\t\t\t\t\t\n\t\t\t\t\t\t\t\u00a3 560.00\n\t\t\t\t\t\t\n\t\t\t\t\t\n\t\t\t\t\t\t\t\t\n\t\t\t\t\t\t\t\t\t(0.0%)\n\t\t\t\t\t\t\t\t\n\t\t\t\t\t\t\t\t\n\t\t\t\t\t\t\t\t\t\u00a3 0.00\n\t\t\t\t\t\t\t\t\n\t\t\t\t\t\t\t
\n
", + "outstanding_amount": 868.25, + "packed_items": [], + "paid_amount": 0.0, + "parent": null, + "parentfield": null, + "parenttype": null, + "party_account_currency": "GBP", + "payment_schedule": [], + "payment_terms_template": null, + "payments": [], + "plc_conversion_rate": 1.0, + "po_date": null, + "po_no": "", + "pos_profile": null, + "posting_date": null, + "posting_time": "5:19:02.994077", + "price_list_currency": "GBP", + "pricing_rules": [], + "project": null, + "redeem_loyalty_points": 0, + "remarks": "No Remarks", + "represents_company": "", + "return_against": null, + "rounded_total": 868.25, + "rounding_adjustment": 0.0, + "sales_partner": null, + "sales_team": [], + "scan_barcode": null, + "select_print_heading": null, + "selling_price_list": "Standard Selling", + "set_posting_time": 0, + "set_target_warehouse": null, + "set_warehouse": null, + "shipping_address": null, + "shipping_address_name": "", + "shipping_rule": null, + "source": null, + "status": "Overdue", + "tax_category": "", + "tax_id": null, + "taxes": [ + { + "account_head": "VAT on Sales - _T", + "base_tax_amount": 43.25, + "base_tax_amount_after_discount_amount": 43.25, + "base_total": 868.25, + "charge_type": "On Net Total", + "cost_center": "Main - _T", + "description": "VAT on Sales", + "included_in_print_rate": 0, + "item_wise_tax_detail": "{\"Dunlop tyres\":[20.0,40.0],\"Continental tyres\":[5.0,3.25],\"Toyo tyres\":[0.0,0.0]}", + "parent": null, + "parentfield": "taxes", + "parenttype": "Sales Invoice", + "rate": 0.0, + "row_id": null, + "tax_amount": 43.25, + "tax_amount_after_discount_amount": 43.25, + "total": 868.25 + } + ], + "taxes_and_charges": null, + "tc_name": null, + "terms": null, + "territory": "All Territories", + "timesheets": [], + "title": "_Sales Invoice", + "to_date": null, + "total": 825.0, + "total_advance": 0.0, + "total_billing_amount": 0.0, + "total_commission": 0.0, + "total_net_weight": 0.0, + "total_qty": 13.0, + "total_taxes_and_charges": 43.25, + "unrealized_profit_loss_account": null, + "update_billed_amount_in_sales_order": 0, + "update_stock": 0, + "write_off_account": null, + "write_off_amount": 0.0, + "write_off_cost_center": null, + "write_off_outstanding_amount_automatically": 0 + } +] diff --git a/erpnext/accounts/report/tax_detail/test_tax_detail.py b/erpnext/accounts/report/tax_detail/test_tax_detail.py new file mode 100644 index 00000000000..743ddba0240 --- /dev/null +++ b/erpnext/accounts/report/tax_detail/test_tax_detail.py @@ -0,0 +1,176 @@ +from __future__ import unicode_literals + +import frappe +import unittest +import datetime +import json +import os +from frappe.utils import getdate, add_to_date, get_first_day, get_last_day, get_year_start, get_year_ending +from .tax_detail import filter_match, save_custom_report + +class TestTaxDetail(unittest.TestCase): + def load_testdocs(self): + from erpnext.accounts.utils import get_fiscal_year, FiscalYearError + datapath, _ = os.path.splitext(os.path.realpath(__file__)) + with open(datapath + '.json', 'r') as fp: + docs = json.load(fp) + + now = getdate() + self.from_date = get_first_day(now) + self.to_date = get_last_day(now) + + try: + get_fiscal_year(now, company="_T") + except FiscalYearError: + docs = [{ + "companies": [{ + "company": "_T", + "parent": "_Test Fiscal", + "parentfield": "companies", + "parenttype": "Fiscal Year" + }], + "doctype": "Fiscal Year", + "year": "_Test Fiscal", + "year_end_date": get_year_ending(now), + "year_start_date": get_year_start(now) + }] + docs + + docs = [{ + "abbr": "_T", + "company_name": "_T", + "country": "United Kingdom", + "default_currency": "GBP", + "doctype": "Company", + "name": "_T" + }] + docs + + for doc in docs: + try: + db_doc = frappe.get_doc(doc) + if 'Invoice' in db_doc.doctype: + db_doc.due_date = add_to_date(now, days=1) + db_doc.insert() + # Create GL Entries: + db_doc.submit() + else: + db_doc.insert() + except frappe.exceptions.DuplicateEntryError: + pass + + def load_defcols(self): + self.company = frappe.get_doc('Company', '_T') + custom_report = frappe.get_doc('Report', 'Tax Detail') + self.default_columns, _ = custom_report.run_query_report( + filters={ + 'from_date': '2021-03-01', + 'to_date': '2021-03-31', + 'company': self.company.name, + 'mode': 'run', + 'report_name': 'Tax Detail' + }, user=frappe.session.user) + + def rm_testdocs(self): + "Remove the Company and all data" + from erpnext.setup.doctype.company.company import create_transaction_deletion_request + create_transaction_deletion_request(self.company.name) + + def test_report(self): + self.load_testdocs() + self.load_defcols() + report_name = save_custom_report( + 'Tax Detail', + '_Test Tax Detail', + json.dumps({ + 'columns': self.default_columns, + 'sections': { + 'Box1':{'Filter0':{'type':'filter','filters':{'4':'VAT on Sales'}}}, + 'Box2':{'Filter0':{'type':'filter','filters':{'4':'Acquisition'}}}, + 'Box3':{'Box1':{'type':'section'},'Box2':{'type':'section'}}, + 'Box4':{'Filter0':{'type':'filter','filters':{'4':'VAT on Purchases'}}}, + 'Box5':{'Box3':{'type':'section'},'Box4':{'type':'section'}}, + 'Box6':{'Filter0':{'type':'filter','filters':{'3':'!=Tax','4':'Sales'}}}, + 'Box7':{'Filter0':{'type':'filter','filters':{'2':'Expense','3':'!=Tax'}}}, + 'Box8':{'Filter0':{'type':'filter','filters':{'3':'!=Tax','4':'Sales','12':'EU'}}}, + 'Box9':{'Filter0':{'type':'filter','filters':{'2':'Expense','3':'!=Tax','12':'EU'}}} + }, + 'show_detail': 1 + })) + data = frappe.desk.query_report.run(report_name, + filters={ + 'from_date': self.from_date, + 'to_date': self.to_date, + 'company': self.company.name, + 'mode': 'run', + 'report_name': report_name + }, user=frappe.session.user) + + self.assertListEqual(data.get('columns'), self.default_columns) + expected = (('Box1', 43.25), ('Box2', 0.0), ('Box3', 43.25), ('Box4', -85.28), ('Box5', -42.03), + ('Box6', 825.0), ('Box7', -426.40), ('Box8', 0.0), ('Box9', 0.0)) + exrow = iter(expected) + for row in data.get('result'): + if row.get('voucher_no') and not row.get('posting_date'): + label, value = next(exrow) + self.assertDictEqual(row, {'voucher_no': label, 'amount': value}) + self.assertListEqual(data.get('report_summary'), + [{'label': label, 'datatype': 'Currency', 'value': value} for label, value in expected]) + + self.rm_testdocs() + + def test_filter_match(self): + # None - treated as -inf number except range + self.assertTrue(filter_match(None, '!=')) + self.assertTrue(filter_match(None, '<')) + self.assertTrue(filter_match(None, '3.4')) + self.assertFalse(filter_match(None, ' <')) + self.assertFalse(filter_match(None, 'ew')) + self.assertFalse(filter_match(None, ' ')) + self.assertFalse(filter_match(None, ' f :')) + + # Numbers + self.assertTrue(filter_match(3.4, '3.4')) + self.assertTrue(filter_match(3.4, '.4')) + self.assertTrue(filter_match(3.4, '3')) + self.assertTrue(filter_match(-3.4, '< -3')) + self.assertTrue(filter_match(-3.4, '> -4')) + self.assertTrue(filter_match(3.4, '= 3.4 ')) + self.assertTrue(filter_match(3.4, '!=4.5')) + self.assertTrue(filter_match(3.4, ' 3 : 4 ')) + self.assertTrue(filter_match(0.0, ' : ')) + self.assertFalse(filter_match(3.4, '=4.5')) + self.assertFalse(filter_match(3.4, ' = 3.4 ')) + self.assertFalse(filter_match(3.4, '!=3.4')) + self.assertFalse(filter_match(3.4, '>6')) + self.assertFalse(filter_match(3.4, '<-4.5')) + self.assertFalse(filter_match(3.4, '4.5')) + self.assertFalse(filter_match(3.4, '5:9')) + + # Strings + self.assertTrue(filter_match('ACC-SINV-2021-00001', 'SINV')) + self.assertTrue(filter_match('ACC-SINV-2021-00001', 'sinv')) + self.assertTrue(filter_match('ACC-SINV-2021-00001', '-2021')) + self.assertTrue(filter_match(' ACC-SINV-2021-00001', ' acc')) + self.assertTrue(filter_match('ACC-SINV-2021-00001', '=2021')) + self.assertTrue(filter_match('ACC-SINV-2021-00001', '!=zz')) + self.assertTrue(filter_match('ACC-SINV-2021-00001', '< zzz ')) + self.assertTrue(filter_match('ACC-SINV-2021-00001', ' : sinv ')) + self.assertFalse(filter_match('ACC-SINV-2021-00001', ' sinv :')) + self.assertFalse(filter_match('ACC-SINV-2021-00001', ' acc')) + self.assertFalse(filter_match('ACC-SINV-2021-00001', '= 2021 ')) + self.assertFalse(filter_match('ACC-SINV-2021-00001', '!=sinv')) + self.assertFalse(filter_match('ACC-SINV-2021-00001', ' >')) + self.assertFalse(filter_match('ACC-SINV-2021-00001', '>aa')) + self.assertFalse(filter_match('ACC-SINV-2021-00001', ' <')) + self.assertFalse(filter_match('ACC-SINV-2021-00001', '< ')) + self.assertFalse(filter_match('ACC-SINV-2021-00001', ' =')) + self.assertFalse(filter_match('ACC-SINV-2021-00001', '=')) + + # Date - always match + self.assertTrue(filter_match(datetime.date(2021, 3, 19), ' kdsjkldfs ')) diff --git a/erpnext/accounts/workspace/accounting/accounting.json b/erpnext/accounts/workspace/accounting/accounting.json index 10a4001502f..821fa4d2af4 100644 --- a/erpnext/accounts/workspace/accounting/accounting.json +++ b/erpnext/accounts/workspace/accounting/accounting.json @@ -434,6 +434,16 @@ "onboard": 0, "type": "Link" }, + { + "dependencies": "GL Entry", + "hidden": 0, + "is_query_report": 1, + "label": "Tax Detail", + "link_to": "Tax Detail", + "link_type": "Report", + "onboard": 0, + "type": "Link" + }, { "dependencies": "GL Entry", "hidden": 0, @@ -442,6 +452,7 @@ "link_to": "DATEV", "link_type": "Report", "onboard": 0, + "only_for": "Germany", "type": "Link" }, { @@ -452,6 +463,7 @@ "link_to": "UAE VAT 201", "link_type": "Report", "onboard": 0, + "only_for": "United Arab Emirates", "type": "Link" }, { diff --git a/erpnext/buying/doctype/purchase_order/purchase_order.js b/erpnext/buying/doctype/purchase_order/purchase_order.js index 233a9c87e59..521432d296b 100644 --- a/erpnext/buying/doctype/purchase_order/purchase_order.js +++ b/erpnext/buying/doctype/purchase_order/purchase_order.js @@ -102,8 +102,8 @@ frappe.ui.form.on("Purchase Order Item", { } }); -erpnext.buying.PurchaseOrderController = erpnext.buying.BuyingController.extend({ - setup: function() { +erpnext.buying.PurchaseOrderController = class PurchaseOrderController extends erpnext.buying.BuyingController { + setup() { this.frm.custom_make_buttons = { 'Purchase Receipt': 'Purchase Receipt', 'Purchase Invoice': 'Purchase Invoice', @@ -111,13 +111,13 @@ erpnext.buying.PurchaseOrderController = erpnext.buying.BuyingController.extend( 'Payment Entry': 'Payment', } - this._super(); + super.setup(); - }, + } - refresh: function(doc, cdt, cdn) { + refresh(doc, cdt, cdn) { var me = this; - this._super(); + super.refresh(); var allow_receipt = false; var is_drop_ship = false; @@ -223,9 +223,9 @@ erpnext.buying.PurchaseOrderController = erpnext.buying.BuyingController.extend( } else if(doc.docstatus===0) { cur_frm.cscript.add_from_mappers(); } - }, + } - get_items_from_open_material_requests: function() { + get_items_from_open_material_requests() { erpnext.utils.map_current_doc({ method: "erpnext.stock.doctype.material_request.material_request.make_purchase_order_based_on_supplier", args: { @@ -243,17 +243,17 @@ erpnext.buying.PurchaseOrderController = erpnext.buying.BuyingController.extend( }, get_query_method: "erpnext.stock.doctype.material_request.material_request.get_material_requests_based_on_supplier" }); - }, + } - validate: function() { + validate() { set_schedule_date(this.frm); - }, + } - has_unsupplied_items: function() { - return this.frm.doc['supplied_items'].some(item => item.required_qty > item.supplied_qty) - }, + has_unsupplied_items() { + return this.frm.doc['supplied_items'].some(item => item.required_qty > item.supplied_qty); + } - make_stock_entry: function() { + make_stock_entry() { var items = $.map(cur_frm.doc.items, function(d) { return d.bom ? d.item_code : false; }); var me = this; @@ -368,9 +368,9 @@ erpnext.buying.PurchaseOrderController = erpnext.buying.BuyingController.extend( me.dialog.hide(); }); - }, + } - _make_rm_stock_entry: function(rm_items) { + _make_rm_stock_entry(rm_items) { frappe.call({ method:"erpnext.buying.doctype.purchase_order.purchase_order.make_rm_stock_entry", args: { @@ -383,31 +383,31 @@ erpnext.buying.PurchaseOrderController = erpnext.buying.BuyingController.extend( frappe.set_route("Form", doclist[0].doctype, doclist[0].name); } }); - }, + } - make_inter_company_order: function(frm) { + make_inter_company_order(frm) { frappe.model.open_mapped_doc({ method: "erpnext.buying.doctype.purchase_order.purchase_order.make_inter_company_sales_order", frm: frm }); - }, + } - make_purchase_receipt: function() { + make_purchase_receipt() { frappe.model.open_mapped_doc({ method: "erpnext.buying.doctype.purchase_order.purchase_order.make_purchase_receipt", frm: cur_frm, freeze_message: __("Creating Purchase Receipt ...") }) - }, + } - make_purchase_invoice: function() { + make_purchase_invoice() { frappe.model.open_mapped_doc({ method: "erpnext.buying.doctype.purchase_order.purchase_order.make_purchase_invoice", frm: cur_frm }) - }, + } - add_from_mappers: function() { + add_from_mappers() { var me = this; this.frm.add_custom_button(__('Material Request'), function() { @@ -513,13 +513,13 @@ erpnext.buying.PurchaseOrderController = erpnext.buying.BuyingController.extend( } }); }, __("Tools")); - }, + } - tc_name: function() { + tc_name() { this.get_terms(); - }, + } - items_add: function(doc, cdt, cdn) { + items_add(doc, cdt, cdn) { var row = frappe.get_doc(cdt, cdn); if(doc.schedule_date) { row.schedule_date = doc.schedule_date; @@ -527,13 +527,13 @@ erpnext.buying.PurchaseOrderController = erpnext.buying.BuyingController.extend( } else { this.frm.script_manager.copy_from_first_row("items", row, ["schedule_date"]); } - }, + } - unhold_purchase_order: function(){ + unhold_purchase_order(){ cur_frm.cscript.update_status("Resume", "Draft") - }, + } - hold_purchase_order: function(){ + hold_purchase_order(){ var me = this; var d = new frappe.ui.Dialog({ title: __('Reason for Hold'), @@ -567,31 +567,31 @@ erpnext.buying.PurchaseOrderController = erpnext.buying.BuyingController.extend( } }); d.show(); - }, + } - unclose_purchase_order: function(){ + unclose_purchase_order(){ cur_frm.cscript.update_status('Re-open', 'Submitted') - }, + } - close_purchase_order: function(){ + close_purchase_order(){ cur_frm.cscript.update_status('Close', 'Closed') - }, + } - delivered_by_supplier: function(){ + delivered_by_supplier(){ cur_frm.cscript.update_status('Deliver', 'Delivered') - }, + } - items_on_form_rendered: function() { - set_schedule_date(this.frm); - }, - - schedule_date: function() { + items_on_form_rendered() { set_schedule_date(this.frm); } -}); + + schedule_date() { + set_schedule_date(this.frm); + } +}; // for backward compatibility: combine new and previous states -$.extend(cur_frm.cscript, new erpnext.buying.PurchaseOrderController({frm: cur_frm})); +extend_cscript(cur_frm.cscript, new erpnext.buying.PurchaseOrderController({frm: cur_frm})); cur_frm.cscript.update_status= function(label, status){ frappe.call({ diff --git a/erpnext/buying/doctype/request_for_quotation/request_for_quotation.js b/erpnext/buying/doctype/request_for_quotation/request_for_quotation.js index b76c3784a47..bde00cbd94e 100644 --- a/erpnext/buying/doctype/request_for_quotation/request_for_quotation.js +++ b/erpnext/buying/doctype/request_for_quotation/request_for_quotation.js @@ -205,10 +205,10 @@ frappe.ui.form.on("Request for Quotation Supplier",{ }) -erpnext.buying.RequestforQuotationController = erpnext.buying.BuyingController.extend({ - refresh: function() { +erpnext.buying.RequestforQuotationController = class RequestforQuotationController extends erpnext.buying.BuyingController { + refresh() { var me = this; - this._super(); + super.refresh(); if (this.frm.doc.docstatus===0) { this.frm.add_custom_button(__('Material Request'), function() { @@ -302,17 +302,17 @@ erpnext.buying.RequestforQuotationController = erpnext.buying.BuyingController.e me.get_suppliers_button(me.frm); }, __("Tools")); } - }, + } - calculate_taxes_and_totals: function() { + calculate_taxes_and_totals() { return; - }, + } - tc_name: function() { + tc_name() { this.get_terms(); - }, + } - get_suppliers_button: function (frm) { + get_suppliers_button (frm) { var doc = frm.doc; var dialog = new frappe.ui.Dialog({ title: __("Get Suppliers"), @@ -410,8 +410,8 @@ erpnext.buying.RequestforQuotationController = erpnext.buying.BuyingController.e }); dialog.show(); - }, -}); + } +}; // for backward compatibility: combine new and previous states -$.extend(cur_frm.cscript, new erpnext.buying.RequestforQuotationController({frm: cur_frm})); +extend_cscript(cur_frm.cscript, new erpnext.buying.RequestforQuotationController({frm: cur_frm})); diff --git a/erpnext/buying/doctype/supplier_quotation/supplier_quotation.js b/erpnext/buying/doctype/supplier_quotation/supplier_quotation.js index a0187b0a824..dc9c590dc5e 100644 --- a/erpnext/buying/doctype/supplier_quotation/supplier_quotation.js +++ b/erpnext/buying/doctype/supplier_quotation/supplier_quotation.js @@ -4,19 +4,19 @@ // attach required files {% include 'erpnext/public/js/controllers/buying.js' %}; -erpnext.buying.SupplierQuotationController = erpnext.buying.BuyingController.extend({ - setup: function() { +erpnext.buying.SupplierQuotationController = class SupplierQuotationController extends erpnext.buying.BuyingController { + setup() { this.frm.custom_make_buttons = { 'Purchase Order': 'Purchase Order', 'Quotation': 'Quotation' } - this._super(); - }, + super.setup(); + } - refresh: function() { + refresh() { var me = this; - this._super(); + super.refresh(); if (this.frm.doc.__islocal && !this.frm.doc.valid_till) { this.frm.set_value('valid_till', frappe.datetime.add_months(this.frm.doc.transaction_date, 1)); @@ -77,25 +77,25 @@ erpnext.buying.SupplierQuotationController = erpnext.buying.BuyingController.ext }) }, __("Get Items From")); } - }, + } - make_purchase_order: function() { + make_purchase_order() { frappe.model.open_mapped_doc({ method: "erpnext.buying.doctype.supplier_quotation.supplier_quotation.make_purchase_order", frm: cur_frm }) - }, - make_quotation: function() { + } + make_quotation() { frappe.model.open_mapped_doc({ method: "erpnext.buying.doctype.supplier_quotation.supplier_quotation.make_quotation", frm: cur_frm }) } -}); +}; // for backward compatibility: combine new and previous states -$.extend(cur_frm.cscript, new erpnext.buying.SupplierQuotationController({frm: cur_frm})); +extend_cscript(cur_frm.cscript, new erpnext.buying.SupplierQuotationController({frm: cur_frm})); cur_frm.fields_dict['items'].grid.get_field('project').get_query = function(doc, cdt, cdn) { diff --git a/erpnext/change_log/v13/v13.0.2.md b/erpnext/change_log/v13/v13_0_2.md similarity index 100% rename from erpnext/change_log/v13/v13.0.2.md rename to erpnext/change_log/v13/v13_0_2.md diff --git a/erpnext/change_log/v13/v13_3_0.md b/erpnext/change_log/v13/v13_3_0.md new file mode 100644 index 00000000000..016dbb01f4d --- /dev/null +++ b/erpnext/change_log/v13/v13_3_0.md @@ -0,0 +1,73 @@ +# Version 13.3.0 Release Notes + +### Features & Enhancements + +- Purchase receipt creation from purchase invoice ([#25126](https://github.com/frappe/erpnext/pull/25126)) +- New Document Transaction Deletion ([#25354](https://github.com/frappe/erpnext/pull/25354)) +- Employee Referral ([#24997](https://github.com/frappe/erpnext/pull/24997)) +- Add Create Expense Claim button in Delivery Trip ([#25526](https://github.com/frappe/erpnext/pull/25526)) +- Reduced rate of asset depreciation as per IT Act ([#25648](https://github.com/frappe/erpnext/pull/25648)) +- Improve DATEV export ([#25238](https://github.com/frappe/erpnext/pull/25238)) +- Add pick batch button ([#25413](https://github.com/frappe/erpnext/pull/25413)) +- Enable custom field search on POS ([#25421](https://github.com/frappe/erpnext/pull/25421)) +- New check field in subscriptions for (not) submitting invoices ([#25394](https://github.com/frappe/erpnext/pull/25394)) +- Show POS reserved stock in stock projected qty report ([#25593](https://github.com/frappe/erpnext/pull/25593)) +- e-way bill validity field ([#25555](https://github.com/frappe/erpnext/pull/25555)) +- Significant reduction in time taken to save sales documents ([#25475](https://github.com/frappe/erpnext/pull/25475)) + +### Fixes + +- Bank statement import via google sheet ([#25677](https://github.com/frappe/erpnext/pull/25677)) +- Invoices not getting fetched during payment reconciliation ([#25598](https://github.com/frappe/erpnext/pull/25598)) +- Error on applying TDS without party ([#25632](https://github.com/frappe/erpnext/pull/25632)) +- Allow to cancel loan with cancelled repayment entry ([#25507](https://github.com/frappe/erpnext/pull/25507)) +- Can't open general ledger from consolidated financial report ([#25542](https://github.com/frappe/erpnext/pull/25542)) +- Add 'Partially Received' to Status drop-down list in Material Request ([#24857](https://github.com/frappe/erpnext/pull/24857)) +- Updated item filters for material request ([#25531](https://github.com/frappe/erpnext/pull/25531)) +- Added validation in stock entry to check duplicate serial nos ([#25611](https://github.com/frappe/erpnext/pull/25611)) +- Update shopify api version ([#25600](https://github.com/frappe/erpnext/pull/25600)) +- Dialog variable assignment after definition in POS ([#25680](https://github.com/frappe/erpnext/pull/25680)) +- Added tax_types list ([#25587](https://github.com/frappe/erpnext/pull/25587)) +- Include search fields in Project Link field query ([#25505](https://github.com/frappe/erpnext/pull/25505)) +- Item stock levels displaying inconsistently ([#25506](https://github.com/frappe/erpnext/pull/25506)) +- Change today to now to get data for reposting ([#25703](https://github.com/frappe/erpnext/pull/25703)) +- Parameter for get_filtered_list_for_consolidated_report in consolidated balance sheet ([#25700](https://github.com/frappe/erpnext/pull/25700)) +- Minor fixes in loan ([#25546](https://github.com/frappe/erpnext/pull/25546)) +- Fieldname when updating docfield property ([#25516](https://github.com/frappe/erpnext/pull/25516)) +- Use get_serial_nos for splitting ([#25590](https://github.com/frappe/erpnext/pull/25590)) +- Show item's full name on hover over item in POS ([#25554](https://github.com/frappe/erpnext/pull/25554)) +- Stock ledger entry created against draft stock entry ([#25540](https://github.com/frappe/erpnext/pull/25540)) +- Incorrect expense account set in pos invoice ([#25543](https://github.com/frappe/erpnext/pull/25543)) +- Stock balance and batch-wise balance history report showing different closing stock ([#25575](https://github.com/frappe/erpnext/pull/25575)) +- Make strings translatable ([#25521](https://github.com/frappe/erpnext/pull/25521)) +- Serial no changed after saving stock reconciliation ([#25541](https://github.com/frappe/erpnext/pull/25541)) +- Ignore fraction difference while making round off gl entry ([#25438](https://github.com/frappe/erpnext/pull/25438)) +- Sync shopify customer addresses ([#25481](https://github.com/frappe/erpnext/pull/25481)) +- Total stock summary report not working ([#25551](https://github.com/frappe/erpnext/pull/25551)) +- Rename field has not updated value of deposit and withdrawal fields ([#25545](https://github.com/frappe/erpnext/pull/25545)) +- Unexpected keyword argument 'merge_logs' ([#25489](https://github.com/frappe/erpnext/pull/25489)) +- Validation message of quality inspection in purchase receipt ([#25667](https://github.com/frappe/erpnext/pull/25667)) +- Added is_stock_item filter ([#25530](https://github.com/frappe/erpnext/pull/25530)) +- Fetch total stock at company in PO ([#25532](https://github.com/frappe/erpnext/pull/25532)) +- Updated filters for process statement of accounts ([#25384](https://github.com/frappe/erpnext/pull/25384)) +- Incorrect expense account set in pos invoice ([#25571](https://github.com/frappe/erpnext/pull/25571)) +- Client script breaking while settings tax labels ([#25653](https://github.com/frappe/erpnext/pull/25653)) +- Empty payment term column in accounts receivable report ([#25556](https://github.com/frappe/erpnext/pull/25556)) +- Designation insufficient permission on lead doctype. ([#25331](https://github.com/frappe/erpnext/pull/25331)) +- Force https for shopify webhook registration ([#25630](https://github.com/frappe/erpnext/pull/25630)) +- Patch regional fields for old companies ([#25673](https://github.com/frappe/erpnext/pull/25673)) +- Woocommerce order sync issue ([#25692](https://github.com/frappe/erpnext/pull/25692)) +- Allow to receive same serial numbers multiple times ([#25471](https://github.com/frappe/erpnext/pull/25471)) +- Update Allocated amount after Paid Amount is changed in PE ([#25515](https://github.com/frappe/erpnext/pull/25515)) +- Updating Standard Notification's channel field ([#25564](https://github.com/frappe/erpnext/pull/25564)) +- Report summary showing inflated values when values are accumulated in Group Company ([#25577](https://github.com/frappe/erpnext/pull/25577)) +- UI fixes related to overflowing payment section ([#25652](https://github.com/frappe/erpnext/pull/25652)) +- List invoices in Payment Reconciliation Payment ([#25524](https://github.com/frappe/erpnext/pull/25524)) +- Ageing errors in PSOA ([#25490](https://github.com/frappe/erpnext/pull/25490)) +- Prevent spurious defaults for items when making prec from dnote ([#25559](https://github.com/frappe/erpnext/pull/25559)) +- Stock reconciliation getting time out error during submission ([#25557](https://github.com/frappe/erpnext/pull/25557)) +- Timesheet filter date exclusive issue ([#25626](https://github.com/frappe/erpnext/pull/25626)) +- Update cost center in the item table fetched from POS Profile ([#25609](https://github.com/frappe/erpnext/pull/25609)) +- Updated modified time in purchase invoice to pull new fields ([#25678](https://github.com/frappe/erpnext/pull/25678)) +- Stock and Accounts Settings form refactor ([#25534](https://github.com/frappe/erpnext/pull/25534)) +- Payment amount showing in foreign currency ([#25292](https://github.com/frappe/erpnext/pull/25292)) \ No newline at end of file diff --git a/erpnext/change_log/v13/v13_4_0.md b/erpnext/change_log/v13/v13_4_0.md new file mode 100644 index 00000000000..eaf4f762d49 --- /dev/null +++ b/erpnext/change_log/v13/v13_4_0.md @@ -0,0 +1,54 @@ +# Version 13.4.0 Release Notes + +### Features & Enhancements + +- Multiple GST enhancement and fixes ([#25249](https://github.com/frappe/erpnext/pull/25249)) +- Linking supplier with an item group for filtering items ([#25683](https://github.com/frappe/erpnext/pull/25683)) +- Leave Policy Assignment Refactor ([#24327](https://github.com/frappe/erpnext/pull/24327)) +- Dimension-wise Accounts Balance Report ([#25260](https://github.com/frappe/erpnext/pull/25260)) +- Show net values in Party Accounts ([#25714](https://github.com/frappe/erpnext/pull/25714)) +- Add pending qty section to batch/serial selector dialog ([#25519](https://github.com/frappe/erpnext/pull/25519)) +- enhancements in Training Event ([#25782](https://github.com/frappe/erpnext/pull/25782)) +- Refactored timesheet ([#25701](https://github.com/frappe/erpnext/pull/25701)) + +### Fixes + +- Process Statement of Accounts formatting ([#25777](https://github.com/frappe/erpnext/pull/25777)) +- Removed serial no validation for sales invoice ([#25817](https://github.com/frappe/erpnext/pull/25817)) +- Fetch email id from dialog box in pos past order summary ([#25808](https://github.com/frappe/erpnext/pull/25808)) +- Don't map set warehouse from delivery note to purchase receipt ([#25672](https://github.com/frappe/erpnext/pull/25672)) +- Apply permission while selecting projects ([#25765](https://github.com/frappe/erpnext/pull/25765)) +- Error on adding bank account to plaid ([#25658](https://github.com/frappe/erpnext/pull/25658)) +- Set disable rounded total if it is globally enabled ([#25789](https://github.com/frappe/erpnext/pull/25789)) +- Wrong amount on CR side in general ledger report for customer when different account currencies are involved ([#25654](https://github.com/frappe/erpnext/pull/25654)) +- Stock move dialog duplicate submit actions (V13) ([#25486](https://github.com/frappe/erpnext/pull/25486)) +- Cashflow mapper not showing data ([#25815](https://github.com/frappe/erpnext/pull/25815)) +- Ignore rounding diff while importing JV using data import ([#25816](https://github.com/frappe/erpnext/pull/25816)) +- Woocommerce order sync issue ([#25688](https://github.com/frappe/erpnext/pull/25688)) +- Expected amount in pos closing payments table ([#25737](https://github.com/frappe/erpnext/pull/25737)) +- Show only company addresses for ITC reversal entry ([#25867](https://github.com/frappe/erpnext/pull/25867)) +- Timeout error while loading warehouse tree ([#25694](https://github.com/frappe/erpnext/pull/25694)) +- Plaid Withdrawals and Deposits are recorded incorrectly ([#25784](https://github.com/frappe/erpnext/pull/25784)) +- Return case for item with available qty equal to one ([#25760](https://github.com/frappe/erpnext/pull/25760)) +- The status of repost item valuation showing In Progress since long time ([#25754](https://github.com/frappe/erpnext/pull/25754)) +- Updated applicable charges form in landed cost voucher ([#25732](https://github.com/frappe/erpnext/pull/25732)) +- Rearrange buttons for Company DocType ([#25617](https://github.com/frappe/erpnext/pull/25617)) +- Show uom for item in selector dialog ([#25697](https://github.com/frappe/erpnext/pull/25697)) +- Warehouse not found in stock entry ([#25776](https://github.com/frappe/erpnext/pull/25776)) +- Use dictionary filter instead of list (bp #25874 pre-release) ([#25875](https://github.com/frappe/erpnext/pull/25875)) +- Send emails on rfq submit ([#25695](https://github.com/frappe/erpnext/pull/25695)) +- Cannot bypass e-invoicing for non gst item invoices ([#25759](https://github.com/frappe/erpnext/pull/25759)) +- Validation message of quality inspection in purchase receipt ([#25666](https://github.com/frappe/erpnext/pull/25666)) +- Dialog variable assignment after definition in POS ([#25681](https://github.com/frappe/erpnext/pull/25681)) +- Wrong quantity after transaction for parallel stock transactions ([#25779](https://github.com/frappe/erpnext/pull/25779)) +- Item Variant Details Report ([#25797](https://github.com/frappe/erpnext/pull/25797)) +- Duplicate stock entry on multiple click ([#25742](https://github.com/frappe/erpnext/pull/25742)) +- Bank statement import via google sheet ([#25676](https://github.com/frappe/erpnext/pull/25676)) +- Change today to now to get data for reposting ([#25702](https://github.com/frappe/erpnext/pull/25702)) +- Parameter for get_filtered_list_for_consolidated_report in consolidated balance sheet ([#25698](https://github.com/frappe/erpnext/pull/25698)) +- Ageing error in PSOA ([#25857](https://github.com/frappe/erpnext/pull/25857)) +- Breaking cost center validation ([#25660](https://github.com/frappe/erpnext/pull/25660)) +- Project filter for Kanban Board ([#25744](https://github.com/frappe/erpnext/pull/25744)) +- Show allow zero valuation only when auto checked ([#25778](https://github.com/frappe/erpnext/pull/25778)) +- Missing cost center message on creating gl entries ([#25755](https://github.com/frappe/erpnext/pull/25755)) +- Address template with upper filter throws jinja error ([#25756](https://github.com/frappe/erpnext/pull/25756)) diff --git a/erpnext/change_log/v13/v13_5_0.md b/erpnext/change_log/v13/v13_5_0.md new file mode 100644 index 00000000000..64c323a23e5 --- /dev/null +++ b/erpnext/change_log/v13/v13_5_0.md @@ -0,0 +1,54 @@ +# Version 13.5.0 Release Notes + +### Features & Enhancements + +- Tax deduction against advance payments ([#25831](https://github.com/frappe/erpnext/pull/25831)) +- Cost-center wise period closing entry ([#25766](https://github.com/frappe/erpnext/pull/25766)) +- Create Quality Inspections from account and stock documents ([#25221](https://github.com/frappe/erpnext/pull/25221)) +- Item Taxes based on net rate ([#25961](https://github.com/frappe/erpnext/pull/25961)) +- Enable/disable gl entry posting for change given in pos ([#25822](https://github.com/frappe/erpnext/pull/25822)) +- Add Inactive status to Employee ([#26029](https://github.com/frappe/erpnext/pull/26029)) +- Added check box to combine items with same BOM ([#25478](https://github.com/frappe/erpnext/pull/25478)) +- Item Tax Templates for Germany ([#25858](https://github.com/frappe/erpnext/pull/25858)) +- Refactored leave balance report ([#25771](https://github.com/frappe/erpnext/pull/25771)) +- Refactored Vehicle Expenses Report ([#25727](https://github.com/frappe/erpnext/pull/25727)) +- Refactored maintenance schedule and visit document ([#25358](https://github.com/frappe/erpnext/pull/25358)) + +### Fixes + +- Cannot add same item with different rates ([#25849](https://github.com/frappe/erpnext/pull/25849)) +- Show only company addresses for ITC reversal entry ([#25866](https://github.com/frappe/erpnext/pull/25866)) +- Hiding Rounding Adjustment field ([#25380](https://github.com/frappe/erpnext/pull/25380)) +- Auto tax calculations in Payment Entry ([#26055](https://github.com/frappe/erpnext/pull/26055)) +- Not able to select the item code in work order ([#25915](https://github.com/frappe/erpnext/pull/25915)) +- Cannot reset plaid link for a bank account ([#25869](https://github.com/frappe/erpnext/pull/25869)) +- Student invalid password reset link ([#25826](https://github.com/frappe/erpnext/pull/25826)) +- Multiple pos issues ([#25928](https://github.com/frappe/erpnext/pull/25928)) +- Add Product Bundles to POS ([#25860](https://github.com/frappe/erpnext/pull/25860)) +- Enable Parallel tests ([#25862](https://github.com/frappe/erpnext/pull/25862)) +- Service item check on e-Invoicing ([#25986](https://github.com/frappe/erpnext/pull/25986)) +- Choose correct Salary Structure Assignment when getting data for formula eval ([#25981](https://github.com/frappe/erpnext/pull/25981)) +- Ignore internal transfer invoices from GST Reports ([#25969](https://github.com/frappe/erpnext/pull/25969)) +- Taxable value for invoices with additional discount ([#26056](https://github.com/frappe/erpnext/pull/26056)) +- Validate negative allocated amount in Payment Entry ([#25799](https://github.com/frappe/erpnext/pull/25799)) +- Allow all System Managers to delete company transactions ([#25834](https://github.com/frappe/erpnext/pull/25834)) +- Wrong round off gl entry posted in case of purchase invoice ([#25775](https://github.com/frappe/erpnext/pull/25775)) +- Use dictionary filter instead of list ([#25874](https://github.com/frappe/erpnext/pull/25874)) +- Ageing error in PSOA ([#25855](https://github.com/frappe/erpnext/pull/25855)) +- On click of duplicate button system has not copied the difference account ([#25988](https://github.com/frappe/erpnext/pull/25988)) +- Assign Product Bundle's conversion_factor to Pack… ([#25840](https://github.com/frappe/erpnext/pull/25840)) +- Rename Loan Management workspace to Loans ([#25856](https://github.com/frappe/erpnext/pull/25856)) +- Fix stock quantity calculation when negative_stock_allowe… ([#25859](https://github.com/frappe/erpnext/pull/25859)) +- Update cost center from pos profile ([#25971](https://github.com/frappe/erpnext/pull/25971)) +- Ensure website theme is applied correctly ([#25863](https://github.com/frappe/erpnext/pull/25863)) +- Only display GST card in Accounting Workspace if it's in India ([#26000](https://github.com/frappe/erpnext/pull/26000)) +- Incorrect gstin fetched incase of branch company address ([#25841](https://github.com/frappe/erpnext/pull/25841)) +- Sort account balances by account name ([#26009](https://github.com/frappe/erpnext/pull/26009)) +- Custom conversion factor field not mapped from job card to stock entry ([#25956](https://github.com/frappe/erpnext/pull/25956)) +- Chart of accounts importer always error ([#25882](https://github.com/frappe/erpnext/pull/25882)) +- Create POS Invoice for Product Bundles ([#25847](https://github.com/frappe/erpnext/pull/25847)) +- Wrap dates in getdate for leave application ([#25899](https://github.com/frappe/erpnext/pull/25899)) +- Closing entry shows incorrect expected amount ([#25868](https://github.com/frappe/erpnext/pull/25868)) +- Add Hold status column in the Issue Summary Report ([#25828](https://github.com/frappe/erpnext/pull/25828)) +- Rendering of broken image on pos ([#25872](https://github.com/frappe/erpnext/pull/25872)) +- Timeout error in the repost item valuation ([#25854](https://github.com/frappe/erpnext/pull/25854)) \ No newline at end of file diff --git a/erpnext/change_log/v13/v13_6_0.md b/erpnext/change_log/v13/v13_6_0.md new file mode 100644 index 00000000000..d881b279e3f --- /dev/null +++ b/erpnext/change_log/v13/v13_6_0.md @@ -0,0 +1,72 @@ +# Version 13.6.0 Release Notes + +### Features & Enhancements + +- Job Card Enhancements ([#24523](https://github.com/frappe/erpnext/pull/24523)) +- Implement multi-account selection in General Ledger([#26044](https://github.com/frappe/erpnext/pull/26044)) +- Fetching of qty as per received qty from PR to PI ([#26184](https://github.com/frappe/erpnext/pull/26184)) +- Subcontract code refactor and enhancement ([#25878](https://github.com/frappe/erpnext/pull/25878)) +- Employee Grievance ([#25705](https://github.com/frappe/erpnext/pull/25705)) +- Add Inactive status to Employee ([#26030](https://github.com/frappe/erpnext/pull/26030)) +- Incorrect valuation rate report for serialized items ([#25696](https://github.com/frappe/erpnext/pull/25696)) +- Update cost updates operation time and hour rates in BOM ([#25891](https://github.com/frappe/erpnext/pull/25891)) + +### Fixes + +- Precision rate for packed items in internal transfers ([#26046](https://github.com/frappe/erpnext/pull/26046)) +- User is not able to change item tax template ([#26176](https://github.com/frappe/erpnext/pull/26176)) +- Insufficient permission for Dunning error ([#26092](https://github.com/frappe/erpnext/pull/26092)) +- Validate Product Bundle for existing transactions before deletion ([#25978](https://github.com/frappe/erpnext/pull/25978)) +- Auto unlink warehouse from item on delete ([#26073](https://github.com/frappe/erpnext/pull/26073)) +- Employee Inactive status implications ([#26245](https://github.com/frappe/erpnext/pull/26245)) +- Fetch batch items in stock reconciliation ([#26230](https://github.com/frappe/erpnext/pull/26230)) +- Disabled cancellation for sales order if linked to drafted sales invoice ([#26125](https://github.com/frappe/erpnext/pull/26125)) +- Sort website products by weightage mentioned in Item master ([#26134](https://github.com/frappe/erpnext/pull/26134)) +- Added freeze when trying to stop work order (#26192) ([#26196](https://github.com/frappe/erpnext/pull/26196)) +- Accounting Dimensions for payroll entry accrual Journal Entry ([#26083](https://github.com/frappe/erpnext/pull/26083)) +- Staffing plan vacancies data type issue ([#25941](https://github.com/frappe/erpnext/pull/25941)) +- Unable to enter score in Assessment Result details grid ([#25945](https://github.com/frappe/erpnext/pull/25945)) +- Report Subcontracted Raw Materials to be Transferred ([#26011](https://github.com/frappe/erpnext/pull/26011)) +- Label for enabling ledger posting of change amount ([#26070](https://github.com/frappe/erpnext/pull/26070)) +- Training event ([#26071](https://github.com/frappe/erpnext/pull/26071)) +- Rate not able to change in purchase order ([#26122](https://github.com/frappe/erpnext/pull/26122)) +- Error while fetching item taxes ([#26220](https://github.com/frappe/erpnext/pull/26220)) +- Check for duplicate payment terms in Payment Term Template ([#26003](https://github.com/frappe/erpnext/pull/26003)) +- Removed values out of sync validation from stock transactions ([#26229](https://github.com/frappe/erpnext/pull/26229)) +- Fetching employee in payroll entry ([#26269](https://github.com/frappe/erpnext/pull/26269)) +- Filter Cost Center and Project drop-down lists by Company ([#26045](https://github.com/frappe/erpnext/pull/26045)) +- Website item group logic for product listing in Item Group pages ([#26170](https://github.com/frappe/erpnext/pull/26170)) +- Chart not visible for First Response Time reports ([#26032](https://github.com/frappe/erpnext/pull/26032)) +- Incorrect billed qty in Sales Order analytics ([#26095](https://github.com/frappe/erpnext/pull/26095)) +- Material request and supplier quotation not linked if supplier quotation created from supplier portal ([#26023](https://github.com/frappe/erpnext/pull/26023)) +- Update leave allocation after submit ([#26191](https://github.com/frappe/erpnext/pull/26191)) +- Taxes on Internal Transfer payment entry ([#26188](https://github.com/frappe/erpnext/pull/26188)) +- Precision rate for packed items (bp #26046) ([#26217](https://github.com/frappe/erpnext/pull/26217)) +- Fixed rounding off ordered percent to 100 in condition ([#26152](https://github.com/frappe/erpnext/pull/26152)) +- Sanctioned loan amount limit check ([#26108](https://github.com/frappe/erpnext/pull/26108)) +- Purchase receipt gl entries with same item code ([#26202](https://github.com/frappe/erpnext/pull/26202)) +- Taxable value for invoices with additional discount ([#25906](https://github.com/frappe/erpnext/pull/25906)) +- Correct South Africa VAT Rate (Updated) ([#25894](https://github.com/frappe/erpnext/pull/25894)) +- Remove response_by and resolution_by if sla is removed ([#25997](https://github.com/frappe/erpnext/pull/25997)) +- POS loyalty card alignment ([#26051](https://github.com/frappe/erpnext/pull/26051)) +- Flaky test for Report Subcontracted Raw materials to be transferred ([#26043](https://github.com/frappe/erpnext/pull/26043)) +- Export invoices not visible in GSTR-1 report ([#26143](https://github.com/frappe/erpnext/pull/26143)) +- Account filter not working with accounting dimension filter ([#26211](https://github.com/frappe/erpnext/pull/26211)) +- Allow to select group warehouse while downloading materials from production plan ([#26126](https://github.com/frappe/erpnext/pull/26126)) +- Added freeze when trying to stop work order ([#26192](https://github.com/frappe/erpnext/pull/26192)) +- Time out while submit / cancel the stock transactions with more than 50 Items ([#26081](https://github.com/frappe/erpnext/pull/26081)) +- Address Card issues in e-commerce ([#26187](https://github.com/frappe/erpnext/pull/26187)) +- Error while booking deferred revenue ([#26195](https://github.com/frappe/erpnext/pull/26195)) +- Eliminate repeat creation of HSN codes ([#25947](https://github.com/frappe/erpnext/pull/25947)) +- Opening invoices can alter profit and loss of a closed year ([#25951](https://github.com/frappe/erpnext/pull/25951)) +- Payroll entry employee detail issue ([#25968](https://github.com/frappe/erpnext/pull/25968)) +- Auto tax calculations in Payment Entry ([#26037](https://github.com/frappe/erpnext/pull/26037)) +- Use pos invoice item name as unique identifier ([#26198](https://github.com/frappe/erpnext/pull/26198)) +- Billing address not fetched in Purchase Invoice ([#26100](https://github.com/frappe/erpnext/pull/26100)) +- Timeout while cancelling stock reconciliation ([#26098](https://github.com/frappe/erpnext/pull/26098)) +- Status indicator for delivery notes ([#26062](https://github.com/frappe/erpnext/pull/26062)) +- Unable to enter score in Assessment Result details grid ([#26031](https://github.com/frappe/erpnext/pull/26031)) +- Too many writes while renaming company abbreviation ([#26203](https://github.com/frappe/erpnext/pull/26203)) +- Chart not visible for First Response Time reports ([#26185](https://github.com/frappe/erpnext/pull/26185)) +- Job applicant link issue ([#25934](https://github.com/frappe/erpnext/pull/25934)) +- Fetch preferred shipping address (bp #26132) ([#26201](https://github.com/frappe/erpnext/pull/26201)) diff --git a/erpnext/controllers/selling_controller.py b/erpnext/controllers/selling_controller.py index 7f28289760c..da2765deded 100644 --- a/erpnext/controllers/selling_controller.py +++ b/erpnext/controllers/selling_controller.py @@ -330,9 +330,15 @@ class SellingController(StockController): # For internal transfers use incoming rate as the valuation rate if self.is_internal_transfer(): - rate = flt(d.incoming_rate * d.conversion_factor, d.precision('rate')) - if d.rate != rate: - d.rate = rate + if d.doctype == "Packed Item": + incoming_rate = flt(d.incoming_rate * d.conversion_factor, d.precision('incoming_rate')) + if d.incoming_rate != incoming_rate: + d.incoming_rate = incoming_rate + else: + rate = flt(d.incoming_rate * d.conversion_factor, d.precision('rate')) + if d.rate != rate: + d.rate = rate + d.discount_percentage = 0 d.discount_amount = 0 frappe.msgprint(_("Row {0}: Item rate has been updated as per valuation rate since its an internal stock transfer") diff --git a/erpnext/controllers/stock_controller.py b/erpnext/controllers/stock_controller.py index 35097b97b99..8196cff849d 100644 --- a/erpnext/controllers/stock_controller.py +++ b/erpnext/controllers/stock_controller.py @@ -11,7 +11,7 @@ from frappe.utils import cint, cstr, flt, get_link_to_form, getdate import erpnext from erpnext.accounts.general_ledger import make_gl_entries, make_reverse_gl_entries, process_gl_map -from erpnext.accounts.utils import check_if_stock_and_account_balance_synced, get_fiscal_year +from erpnext.accounts.utils import get_fiscal_year from erpnext.controllers.accounts_controller import AccountsController from erpnext.stock import get_warehouse_account_map from erpnext.stock.stock_ledger import get_valuation_rate @@ -497,9 +497,6 @@ class StockController(AccountsController): }) if future_sle_exists(args): create_repost_item_valuation_entry(args) - elif not is_reposting_pending(): - check_if_stock_and_account_balance_synced(self.posting_date, - self.company, self.doctype, self.name) @frappe.whitelist() def make_quality_inspections(doctype, docname, items): diff --git a/erpnext/crm/doctype/lead/lead.js b/erpnext/crm/doctype/lead/lead.js index 0c88d2826f7..ebe85241d28 100644 --- a/erpnext/crm/doctype/lead/lead.js +++ b/erpnext/crm/doctype/lead/lead.js @@ -4,8 +4,8 @@ frappe.provide("erpnext"); cur_frm.email_field = "email_id"; -erpnext.LeadController = frappe.ui.form.Controller.extend({ - setup: function () { +erpnext.LeadController = class LeadController extends frappe.ui.form.Controller { + setup () { this.frm.make_methods = { 'Customer': this.make_customer, 'Quotation': this.make_quotation, @@ -13,9 +13,9 @@ erpnext.LeadController = frappe.ui.form.Controller.extend({ }; this.frm.toggle_reqd("lead_name", !this.frm.doc.organization_lead); - }, + } - onload: function () { + onload () { this.frm.set_query("customer", function (doc, cdt, cdn) { return { query: "erpnext.controllers.queries.customer_query" } }); @@ -27,9 +27,9 @@ erpnext.LeadController = frappe.ui.form.Controller.extend({ this.frm.set_query("contact_by", function (doc, cdt, cdn) { return { query: "frappe.core.doctype.user.user.user_query" } }); - }, + } - refresh: function () { + refresh () { let doc = this.frm.doc; erpnext.toggle_naming_series(); frappe.dynamic_link = { doc: doc, fieldname: 'name', doctype: 'Lead' } @@ -45,47 +45,47 @@ erpnext.LeadController = frappe.ui.form.Controller.extend({ } else { frappe.contacts.clear_address_and_contact(this.frm); } - }, + } - make_customer: function () { + make_customer () { frappe.model.open_mapped_doc({ method: "erpnext.crm.doctype.lead.lead.make_customer", frm: cur_frm }) - }, + } - make_opportunity: function () { + make_opportunity () { frappe.model.open_mapped_doc({ method: "erpnext.crm.doctype.lead.lead.make_opportunity", frm: cur_frm }) - }, + } - make_quotation: function () { + make_quotation () { frappe.model.open_mapped_doc({ method: "erpnext.crm.doctype.lead.lead.make_quotation", frm: cur_frm }) - }, + } - organization_lead: function () { + organization_lead () { this.frm.toggle_reqd("lead_name", !this.frm.doc.organization_lead); this.frm.toggle_reqd("company_name", this.frm.doc.organization_lead); - }, + } - company_name: function () { + company_name () { if (this.frm.doc.organization_lead && !this.frm.doc.lead_name) { this.frm.set_value("lead_name", this.frm.doc.company_name); } - }, + } - contact_date: function () { + contact_date () { if (this.frm.doc.contact_date) { let d = moment(this.frm.doc.contact_date); d.add(1, "day"); this.frm.set_value("ends_on", d.format(frappe.defaultDatetimeFormat)); } } -}); +}; -$.extend(cur_frm.cscript, new erpnext.LeadController({ frm: cur_frm })); +extend_cscript(cur_frm.cscript, new erpnext.LeadController({ frm: cur_frm })); diff --git a/erpnext/crm/doctype/opportunity/opportunity.js b/erpnext/crm/doctype/opportunity/opportunity.js index ac374a95f4e..43e1b99f3ad 100644 --- a/erpnext/crm/doctype/opportunity/opportunity.js +++ b/erpnext/crm/doctype/opportunity/opportunity.js @@ -145,8 +145,8 @@ frappe.ui.form.on("Opportunity", { }) // TODO commonify this code -erpnext.crm.Opportunity = frappe.ui.form.Controller.extend({ - onload: function() { +erpnext.crm.Opportunity = class Opportunity extends frappe.ui.form.Controller { + onload() { if(!this.frm.doc.status) { frm.set_value('status', 'Open'); @@ -159,9 +159,9 @@ erpnext.crm.Opportunity = frappe.ui.form.Controller.extend({ } this.setup_queries(); - }, + } - setup_queries: function() { + setup_queries() { var me = this; if(this.frm.fields_dict.contact_by.df.options.match(/^User/)) { @@ -185,17 +185,17 @@ erpnext.crm.Opportunity = frappe.ui.form.Controller.extend({ else if (me.frm.doc.opportunity_from == "Customer") { me.frm.set_query('party_name', erpnext.queries['customer']); } - }, + } - create_quotation: function() { + create_quotation() { frappe.model.open_mapped_doc({ method: "erpnext.crm.doctype.opportunity.opportunity.make_quotation", frm: cur_frm }) } -}); +}; -$.extend(cur_frm.cscript, new erpnext.crm.Opportunity({frm: cur_frm})); +extend_cscript(cur_frm.cscript, new erpnext.crm.Opportunity({frm: cur_frm})); cur_frm.cscript.item_code = function(doc, cdt, cdn) { var d = locals[cdt][cdn]; @@ -213,4 +213,4 @@ cur_frm.cscript.item_code = function(doc, cdt, cdn) { } }) } -} \ No newline at end of file +} diff --git a/erpnext/education/doctype/course_enrollment/course_enrollment.py b/erpnext/education/doctype/course_enrollment/course_enrollment.py index 2b3acf1b93b..ce88990a70d 100644 --- a/erpnext/education/doctype/course_enrollment/course_enrollment.py +++ b/erpnext/education/doctype/course_enrollment/course_enrollment.py @@ -91,4 +91,4 @@ def check_activity_exists(enrollment, content_type, content): if activity: return activity[0].name else: - return None \ No newline at end of file + return None diff --git a/erpnext/education/doctype/student_attendance_tool/student_attendance_tool.js b/erpnext/education/doctype/student_attendance_tool/student_attendance_tool.js index b59d8488285..68e7780039b 100644 --- a/erpnext/education/doctype/student_attendance_tool/student_attendance_tool.js +++ b/erpnext/education/doctype/student_attendance_tool/student_attendance_tool.js @@ -72,8 +72,8 @@ frappe.ui.form.on('Student Attendance Tool', { }); -education.StudentsEditor = Class.extend({ - init: function(frm, wrapper, students) { +education.StudentsEditor = class StudentsEditor { + constructor(frm, wrapper, students) { this.wrapper = wrapper; this.frm = frm; if(students.length > 0) { @@ -81,8 +81,8 @@ education.StudentsEditor = Class.extend({ } else { this.show_empty_state(); } - }, - make: function(frm, students) { + } + make(frm, students) { var me = this; $(this.wrapper).empty(); @@ -173,13 +173,13 @@ education.StudentsEditor = Class.extend({ }); $(htmls.join("")).appendTo(me.wrapper); - }, + } - show_empty_state: function() { + show_empty_state() { $(this.wrapper).html( `
${__("No Students in")} ${this.frm.doc.student_group}
` ); } -}); +}; diff --git a/erpnext/healthcare/doctype/exercise_type/exercise_type.js b/erpnext/healthcare/doctype/exercise_type/exercise_type.js index b49b00e219b..06146047eb3 100644 --- a/erpnext/healthcare/doctype/exercise_type/exercise_type.js +++ b/erpnext/healthcare/doctype/exercise_type/exercise_type.js @@ -9,14 +9,14 @@ frappe.ui.form.on('Exercise Type', { } }); -erpnext.ExerciseEditor = Class.extend({ - init: function(frm, wrapper) { +erpnext.ExerciseEditor = class ExerciseEditor { + constructor(frm, wrapper) { this.wrapper = wrapper; this.frm = frm; this.make(frm, wrapper); - }, + } - make: function(frm, wrapper) { + make(frm, wrapper) { $(this.wrapper).empty(); this.exercise_toolbar = $('

\ @@ -38,9 +38,9 @@ erpnext.ExerciseEditor = Class.extend({ this.make_cards(frm); this.make_buttons(frm); } - }, + } - make_cards: function(frm) { + make_cards(frm) { var me = this; $(me.exercise_cards).empty(); @@ -60,9 +60,9 @@ erpnext.ExerciseEditor = Class.extend({ `, {image_src: step.image, title: step.title, description: step.description, col_id: "col-"+i, card_id: "card-"+i, id: i})).appendTo(me.row); }); - }, + } - make_buttons: function(frm) { + make_buttons(frm) { let me = this; $('.btn-edit').on('click', function() { let id = $(this).attr('data-id'); @@ -82,9 +82,9 @@ erpnext.ExerciseEditor = Class.extend({ frm.dirty(); }, 300); }); - }, + } - show_add_card_dialog: function(frm) { + show_add_card_dialog(frm) { let me = this; let d = new frappe.ui.Dialog({ title: __('Add Exercise Step'), @@ -137,9 +137,9 @@ erpnext.ExerciseEditor = Class.extend({ primary_action_label: __('Add') }); d.show(); - }, + } - show_edit_card_dialog: function(frm, id) { + show_edit_card_dialog(frm, id) { let new_dialog = new frappe.ui.Dialog({ title: __("Edit Exercise Step"), fields: [ @@ -183,4 +183,4 @@ erpnext.ExerciseEditor = Class.extend({ }); new_dialog.show(); } -}); +}; diff --git a/erpnext/healthcare/doctype/patient/patient.py b/erpnext/healthcare/doctype/patient/patient.py index cebcb2068ea..56a34007ffb 100644 --- a/erpnext/healthcare/doctype/patient/patient.py +++ b/erpnext/healthcare/doctype/patient/patient.py @@ -40,7 +40,6 @@ class Patient(Document): customer.customer_group = self.customer_group if self.territory: customer.territory = self.territory - customer.customer_name = self.patient_name customer.default_price_list = self.default_price_list customer.default_currency = self.default_currency diff --git a/erpnext/healthcare/doctype/patient_history_settings/test_patient_history_settings.py b/erpnext/healthcare/doctype/patient_history_settings/test_patient_history_settings.py index c93b788aed7..33119d8185f 100644 --- a/erpnext/healthcare/doctype/patient_history_settings/test_patient_history_settings.py +++ b/erpnext/healthcare/doctype/patient_history_settings/test_patient_history_settings.py @@ -6,7 +6,7 @@ from __future__ import unicode_literals import frappe import unittest import json -from frappe.utils import getdate +from frappe.utils import getdate, strip_html from erpnext.healthcare.doctype.patient_appointment.test_patient_appointment import create_patient class TestPatientHistorySettings(unittest.TestCase): @@ -44,9 +44,9 @@ class TestPatientHistorySettings(unittest.TestCase): self.assertTrue(medical_rec) medical_rec = frappe.get_doc("Patient Medical Record", medical_rec) - expected_subject = "Date: {0}
Rating: 3
Feedback: Test Patient History Settings
".format( + expected_subject = "Date: {0}Rating: 3Feedback: Test Patient History Settings".format( frappe.utils.format_date(getdate())) - self.assertEqual(medical_rec.subject, expected_subject) + self.assertEqual(strip_html(medical_rec.subject), expected_subject) self.assertEqual(medical_rec.patient, patient) self.assertEqual(medical_rec.communication_date, getdate()) @@ -101,4 +101,4 @@ def create_doc(patient): }).insert() doc.submit() - return doc \ No newline at end of file + return doc diff --git a/erpnext/hooks.py b/erpnext/hooks.py index 8ad77a1524d..3da606b68b8 100644 --- a/erpnext/hooks.py +++ b/erpnext/hooks.py @@ -15,10 +15,11 @@ app_logo_url = "/assets/erpnext/images/erpnext-logo.svg" develop_version = '13.x.x-develop' -app_include_js = "/assets/js/erpnext.min.js" -app_include_css = "/assets/css/erpnext.css" -web_include_js = "/assets/js/erpnext-web.min.js" -web_include_css = "/assets/css/erpnext-web.css" +app_include_js = "erpnext.bundle.js" +app_include_css = "erpnext.bundle.css" +web_include_js = "erpnext-web.bundle.js" +web_include_css = "erpnext-web.bundle.css" +email_css = "email_erpnext.bundle.css" doctype_js = { "Address": "public/js/address.js", @@ -227,6 +228,7 @@ standard_queries = { doc_events = { "*": { + "validate": "erpnext.support.doctype.service_level_agreement.service_level_agreement.apply", "on_submit": "erpnext.healthcare.doctype.patient_history_settings.patient_history_settings.create_medical_record", "on_update_after_submit": "erpnext.healthcare.doctype.patient_history_settings.patient_history_settings.update_medical_record", "on_cancel": "erpnext.healthcare.doctype.patient_history_settings.patient_history_settings.delete_medical_record" @@ -241,6 +243,9 @@ doc_events = { "on_update": ["erpnext.hr.doctype.employee.employee.update_user_permissions", "erpnext.portal.utils.set_default_role"] }, + "Communication": { + "on_update": "erpnext.support.doctype.service_level_agreement.service_level_agreement.update_hold_time" + }, ("Sales Taxes and Charges Template", 'Price List'): { "on_update": "erpnext.shopping_cart.doctype.shopping_cart_settings.shopping_cart_settings.validate_cart_settings" }, @@ -331,8 +336,8 @@ scheduler_events = { "erpnext.projects.doctype.project.project.hourly_reminder", "erpnext.projects.doctype.project.project.collect_project_status", "erpnext.hr.doctype.shift_type.shift_type.process_auto_attendance_for_all_shifts", - "erpnext.support.doctype.issue.issue.set_service_level_agreement_variance", - "erpnext.erpnext_integrations.connectors.shopify_connection.sync_old_orders" + "erpnext.erpnext_integrations.connectors.shopify_connection.sync_old_orders", + "erpnext.support.doctype.service_level_agreement.service_level_agreement.set_service_level_agreement_variance" ], "hourly_long": [ "erpnext.stock.doctype.repost_item_valuation.repost_item_valuation.repost_entries" diff --git a/erpnext/hr/doctype/attendance/attendance.js b/erpnext/hr/doctype/attendance/attendance.js index c3c3cb82f94..7964078c7f0 100644 --- a/erpnext/hr/doctype/attendance/attendance.js +++ b/erpnext/hr/doctype/attendance/attendance.js @@ -11,5 +11,5 @@ cur_frm.cscript.onload = function(doc, cdt, cdn) { cur_frm.fields_dict.employee.get_query = function(doc,cdt,cdn) { return{ query: "erpnext.controllers.queries.employee_query" - } + } } diff --git a/erpnext/hr/doctype/attendance/attendance.py b/erpnext/hr/doctype/attendance/attendance.py index f3b8a799b3c..3412675d811 100644 --- a/erpnext/hr/doctype/attendance/attendance.py +++ b/erpnext/hr/doctype/attendance/attendance.py @@ -15,6 +15,7 @@ class Attendance(Document): validate_status(self.status, ["Present", "Absent", "On Leave", "Half Day", "Work From Home"]) self.validate_attendance_date() self.validate_duplicate_record() + self.validate_employee_status() self.check_leave_record() def validate_attendance_date(self): @@ -38,6 +39,10 @@ class Attendance(Document): frappe.throw(_("Attendance for employee {0} is already marked for the date {1}").format( frappe.bold(self.employee), frappe.bold(self.attendance_date))) + def validate_employee_status(self): + if frappe.db.get_value("Employee", self.employee, "status") == "Inactive": + frappe.throw(_("Cannot mark attendance for an Inactive employee {0}").format(self.employee)) + def check_leave_record(self): leave_record = frappe.db.sql(""" select leave_type, half_day, half_day_date diff --git a/erpnext/hr/doctype/attendance/attendance_list.js b/erpnext/hr/doctype/attendance/attendance_list.js index 0c7eafe9c61..9a3bac0eb23 100644 --- a/erpnext/hr/doctype/attendance/attendance_list.js +++ b/erpnext/hr/doctype/attendance/attendance_list.js @@ -21,6 +21,9 @@ frappe.listview_settings['Attendance'] = { label: __('For Employee'), fieldtype: 'Link', options: 'Employee', + get_query: () => { + return {query: "erpnext.controllers.queries.employee_query"} + }, reqd: 1, onchange: function() { dialog.set_df_property("unmarked_days", "hidden", 1); diff --git a/erpnext/hr/doctype/employee/employee.js b/erpnext/hr/doctype/employee/employee.js index c21d4b893cc..5639cc9ea46 100755 --- a/erpnext/hr/doctype/employee/employee.js +++ b/erpnext/hr/doctype/employee/employee.js @@ -2,8 +2,8 @@ // License: GNU General Public License v3. See license.txt frappe.provide("erpnext.hr"); -erpnext.hr.EmployeeController = frappe.ui.form.Controller.extend({ - setup: function() { +erpnext.hr.EmployeeController = class EmployeeController extends frappe.ui.form.Controller { + setup() { this.frm.fields_dict.user_id.get_query = function(doc, cdt, cdn) { return { query: "frappe.core.doctype.user.user.user_query", @@ -12,30 +12,30 @@ erpnext.hr.EmployeeController = frappe.ui.form.Controller.extend({ } this.frm.fields_dict.reports_to.get_query = function(doc, cdt, cdn) { return { query: "erpnext.controllers.queries.employee_query"} } - }, + } - refresh: function() { + refresh() { var me = this; erpnext.toggle_naming_series(); - }, + } - date_of_birth: function() { + date_of_birth() { return cur_frm.call({ method: "get_retirement_date", args: {date_of_birth: this.frm.doc.date_of_birth} }); - }, + } - salutation: function() { + salutation() { if(this.frm.doc.salutation) { this.frm.set_value("gender", { "Mr": "Male", "Ms": "Female" }[this.frm.doc.salutation]); } - }, + } -}); +}; frappe.ui.form.on('Employee',{ setup: function(frm) { frm.set_query("leave_policy", function() { diff --git a/erpnext/hr/doctype/employee_attendance_tool/employee_attendance_tool.js b/erpnext/hr/doctype/employee_attendance_tool/employee_attendance_tool.js index 3205a92b1b6..ab965d54e3b 100644 --- a/erpnext/hr/doctype/employee_attendance_tool/employee_attendance_tool.js +++ b/erpnext/hr/doctype/employee_attendance_tool/employee_attendance_tool.js @@ -68,13 +68,13 @@ erpnext.employee_attendance_tool = { } } -erpnext.MarkedEmployee = Class.extend({ - init: function(frm, wrapper, employee) { +erpnext.MarkedEmployee = class MarkedEmployee { + constructor(frm, wrapper, employee) { this.wrapper = wrapper; this.frm = frm; this.make(frm, employee); - }, - make: function(frm, employee) { + } + make(frm, employee) { var me = this; $(this.wrapper).empty(); @@ -104,16 +104,16 @@ erpnext.MarkedEmployee = Class.extend({ })).appendTo(row); }); } -}); +}; -erpnext.EmployeeSelector = Class.extend({ - init: function(frm, wrapper, employee) { +erpnext.EmployeeSelector = class EmployeeSelector { + constructor(frm, wrapper, employee) { this.wrapper = wrapper; this.frm = frm; this.make(frm, employee); - }, - make: function(frm, employee) { + } + make(frm, employee) { var me = this; $(this.wrapper).empty(); @@ -266,6 +266,6 @@ erpnext.EmployeeSelector = Class.extend({ mark_employee_toolbar.appendTo($(this.wrapper)); } -}); +}; diff --git a/erpnext/hr/doctype/employee_referral/employee_referral.json b/erpnext/hr/doctype/employee_referral/employee_referral.json index bfd404b4352..3ae73a9e4d9 100644 --- a/erpnext/hr/doctype/employee_referral/employee_referral.json +++ b/erpnext/hr/doctype/employee_referral/employee_referral.json @@ -9,16 +9,18 @@ "first_name", "last_name", "full_name", - "email", - "contact_no", - "resume", - "resume_link", "column_break_6", "date", "status", "for_designation", + "referral_details_section", + "email", + "contact_no", + "resume_link", + "column_break_12", "current_employer", "current_job_title", + "resume", "referrer_details_section", "referrer", "referrer_name", @@ -189,12 +191,21 @@ "label": "Referral Bonus Payment Status", "options": "\nUnpaid\nPaid", "read_only": 1 + }, + { + "fieldname": "referral_details_section", + "fieldtype": "Section Break", + "label": "Referral Details" + }, + { + "fieldname": "column_break_12", + "fieldtype": "Column Break" } ], "index_web_pages_for_search": 1, "is_submittable": 1, "links": [], - "modified": "2021-04-26 21:21:38.094086", + "modified": "2021-05-04 17:03:26.134560", "modified_by": "Administrator", "module": "HR", "name": "Employee Referral", diff --git a/erpnext/hr/doctype/holiday_list/holiday_list.py b/erpnext/hr/doctype/holiday_list/holiday_list.py index 8af8cea605d..f65e6e12074 100644 --- a/erpnext/hr/doctype/holiday_list/holiday_list.py +++ b/erpnext/hr/doctype/holiday_list/holiday_list.py @@ -23,7 +23,7 @@ class HolidayList(Document): last_idx = max([cint(d.idx) for d in self.get("holidays")] or [0,]) for i, d in enumerate(date_list): ch = self.append('holidays', {}) - ch.description = self.weekly_off + ch.description = _(self.weekly_off) ch.holiday_date = d ch.weekly_off = 1 ch.idx = last_idx + i + 1 diff --git a/erpnext/hr/doctype/leave_allocation/test_leave_allocation.py b/erpnext/hr/doctype/leave_allocation/test_leave_allocation.py index bff06e6a91c..fdcd533660b 100644 --- a/erpnext/hr/doctype/leave_allocation/test_leave_allocation.py +++ b/erpnext/hr/doctype/leave_allocation/test_leave_allocation.py @@ -5,7 +5,6 @@ import unittest from frappe.utils import nowdate, add_months, getdate, add_days from erpnext.hr.doctype.leave_type.test_leave_type import create_leave_type from erpnext.hr.doctype.leave_ledger_entry.leave_ledger_entry import process_expired_allocation, expire_allocation - class TestLeaveAllocation(unittest.TestCase): @classmethod def setUpClass(cls): diff --git a/erpnext/hr/doctype/staffing_plan/staffing_plan.js b/erpnext/hr/doctype/staffing_plan/staffing_plan.js index 04af2323c72..228391ba001 100644 --- a/erpnext/hr/doctype/staffing_plan/staffing_plan.js +++ b/erpnext/hr/doctype/staffing_plan/staffing_plan.js @@ -103,4 +103,4 @@ var set_total_estimated_budget = function(frm) { }) frm.set_value('total_estimated_budget', estimated_budget); } -} \ No newline at end of file +}; diff --git a/erpnext/hr/doctype/upload_attendance/upload_attendance.js b/erpnext/hr/doctype/upload_attendance/upload_attendance.js index 29aa85484a8..bbafc820764 100644 --- a/erpnext/hr/doctype/upload_attendance/upload_attendance.js +++ b/erpnext/hr/doctype/upload_attendance/upload_attendance.js @@ -5,19 +5,19 @@ frappe.provide("erpnext.hr"); -erpnext.hr.AttendanceControlPanel = frappe.ui.form.Controller.extend({ - onload: function() { +erpnext.hr.AttendanceControlPanel = class AttendanceControlPanel extends frappe.ui.form.Controller { + onload() { this.frm.set_value("att_fr_date", frappe.datetime.get_today()); this.frm.set_value("att_to_date", frappe.datetime.get_today()); - }, + } - refresh: function() { + refresh() { this.frm.disable_save(); this.show_upload(); this.setup_import_progress(); - }, + } - get_template:function() { + get_template() { if(!this.frm.doc.att_fr_date || !this.frm.doc.att_to_date) { frappe.msgprint(__("Attendance From Date and Attendance To Date is mandatory")); return; @@ -28,7 +28,7 @@ erpnext.hr.AttendanceControlPanel = frappe.ui.form.Controller.extend({ from_date: this.frm.doc.att_fr_date, to_date: this.frm.doc.att_to_date, }); - }, + } show_upload() { var $wrapper = $(cur_frm.fields_dict.upload_html.wrapper).empty(); @@ -36,7 +36,7 @@ erpnext.hr.AttendanceControlPanel = frappe.ui.form.Controller.extend({ wrapper: $wrapper, method: 'erpnext.hr.doctype.upload_attendance.upload_attendance.upload' }); - }, + } setup_import_progress() { var $log_wrapper = $(this.frm.fields_dict.import_log.wrapper).empty(); @@ -64,6 +64,6 @@ erpnext.hr.AttendanceControlPanel = frappe.ui.form.Controller.extend({ } }); } -}) +} cur_frm.cscript = new erpnext.hr.AttendanceControlPanel({frm: cur_frm}); diff --git a/erpnext/hr/report/employee_leave_balance_summary/employee_leave_balance_summary.py b/erpnext/hr/report/employee_leave_balance_summary/employee_leave_balance_summary.py index 92715d34453..e86fa2b1c42 100644 --- a/erpnext/hr/report/employee_leave_balance_summary/employee_leave_balance_summary.py +++ b/erpnext/hr/report/employee_leave_balance_summary/employee_leave_balance_summary.py @@ -47,7 +47,7 @@ def get_data(filters, leave_types): user = frappe.session.user conditions = get_conditions(filters) - active_employees = frappe.get_all("Employee", + active_employees = frappe.get_list("Employee", filters=conditions, fields=["name", "employee_name", "department", "user_id", "leave_approver"]) @@ -72,4 +72,4 @@ def get_data(filters, leave_types): data.append(row) - return data \ No newline at end of file + return data diff --git a/erpnext/hr/report/monthly_attendance_sheet/monthly_attendance_sheet.py b/erpnext/hr/report/monthly_attendance_sheet/monthly_attendance_sheet.py index c5929c6bf99..bcb0ee4d0da 100644 --- a/erpnext/hr/report/monthly_attendance_sheet/monthly_attendance_sheet.py +++ b/erpnext/hr/report/monthly_attendance_sheet/monthly_attendance_sheet.py @@ -57,10 +57,10 @@ def execute(filters=None): data = [] + leave_types = frappe.db.get_list("Leave Type") leave_list = None if filters.summarized_view: - leave_types = frappe.db.sql("""select name from `tabLeave Type`""", as_list=True) - leave_list = [d[0] + ":Float:120" for d in leave_types] + leave_list = [d.name + ":Float:120" for d in leave_types] columns.extend(leave_list) columns.extend([_("Total Late Entries") + ":Float:120", _("Total Early Exits") + ":Float:120"]) @@ -72,11 +72,11 @@ def execute(filters=None): if (att_map_set & emp_map_set): parameter_row = [""+ parameter + ""] + ['' for day in range(filters["total_days_in_month"] + 2)] data.append(parameter_row) - record, emp_att_data = add_data(emp_map[parameter], att_map, filters, holiday_map, conditions, default_holiday_list, leave_list=leave_list) + record, emp_att_data = add_data(emp_map[parameter], att_map, filters, holiday_map, conditions, default_holiday_list, leave_types=leave_types) emp_att_map.update(emp_att_data) data += record else: - record, emp_att_map = add_data(emp_map, att_map, filters, holiday_map, conditions, default_holiday_list, leave_list=leave_list) + record, emp_att_map = add_data(emp_map, att_map, filters, holiday_map, conditions, default_holiday_list, leave_types=leave_types) data += record chart_data = get_chart_data(emp_att_map, days) @@ -126,7 +126,7 @@ def get_chart_data(emp_att_map, days): return chart -def add_data(employee_map, att_map, filters, holiday_map, conditions, default_holiday_list, leave_list=None): +def add_data(employee_map, att_map, filters, holiday_map, conditions, default_holiday_list, leave_types=None): record = [] emp_att_map = {} @@ -204,9 +204,9 @@ def add_data(employee_map, att_map, filters, holiday_map, conditions, default_ho else: leaves[d.leave_type] = d.count - for d in leave_list: - if d in leaves: - row.append(leaves[d]) + for d in leave_types: + if d.name in leaves: + row.append(leaves[d.name]) else: row.append("0.0") diff --git a/erpnext/maintenance/doctype/maintenance_schedule/maintenance_schedule.js b/erpnext/maintenance/doctype/maintenance_schedule/maintenance_schedule.js index 44712d543b7..546a68f268b 100644 --- a/erpnext/maintenance/doctype/maintenance_schedule/maintenance_schedule.js +++ b/erpnext/maintenance/doctype/maintenance_schedule/maintenance_schedule.js @@ -41,9 +41,9 @@ frappe.ui.form.on('Maintenance Schedule', { }) // TODO commonify this code -erpnext.maintenance.MaintenanceSchedule = frappe.ui.form.Controller.extend({ - refresh: function () { - frappe.dynamic_link = { doc: this.frm.doc, fieldname: 'customer', doctype: 'Customer' }; +erpnext.maintenance.MaintenanceSchedule = class MaintenanceSchedule extends frappe.ui.form.Controller { + refresh() { + frappe.dynamic_link = {doc: this.frm.doc, fieldname: 'customer', doctype: 'Customer'} var me = this; @@ -138,33 +138,29 @@ erpnext.maintenance.MaintenanceSchedule = frappe.ui.form.Controller.extend({ }, __('Create')); } } - }, + } - start_date: function (doc, cdt, cdn) { + start_date(doc, cdt, cdn) { this.set_no_of_visits(doc, cdt, cdn); - }, + } - end_date: function (doc, cdt, cdn) { + end_date(doc, cdt, cdn) { this.set_no_of_visits(doc, cdt, cdn); - }, + } - periodicity: function (doc, cdt, cdn) { + periodicity(doc, cdt, cdn) { this.set_no_of_visits(doc, cdt, cdn); + } - }, - no_of_visits: function (doc, cdt, cdn) { - this.set_no_of_visits(doc, cdt, cdn); - }, - - set_no_of_visits: function (doc, cdt, cdn) { + set_no_of_visits(doc, cdt, cdn) { var item = frappe.get_doc(cdt, cdn); let me = this; if (item.start_date && item.periodicity) { me.frm.call('validate_end_date_visits'); } - }, -}); + } +}; -$.extend(cur_frm.cscript, new erpnext.maintenance.MaintenanceSchedule({ frm: cur_frm })); +extend_cscript(cur_frm.cscript, new erpnext.maintenance.MaintenanceSchedule({frm: cur_frm})); diff --git a/erpnext/maintenance/doctype/maintenance_visit/maintenance_visit.js b/erpnext/maintenance/doctype/maintenance_visit/maintenance_visit.js index d6105c657ef..53ecdf5a61f 100644 --- a/erpnext/maintenance/doctype/maintenance_visit/maintenance_visit.js +++ b/erpnext/maintenance/doctype/maintenance_visit/maintenance_visit.js @@ -64,9 +64,9 @@ frappe.ui.form.on('Maintenance Visit', { }) // TODO commonify this code -erpnext.maintenance.MaintenanceVisit = frappe.ui.form.Controller.extend({ - refresh: function () { - frappe.dynamic_link = { doc: this.frm.doc, fieldname: 'customer', doctype: 'Customer' }; +erpnext.maintenance.MaintenanceVisit = class MaintenanceVisit extends frappe.ui.form.Controller { + refresh() { + frappe.dynamic_link = {doc: this.frm.doc, fieldname: 'customer', doctype: 'Customer'} var me = this; @@ -119,7 +119,7 @@ erpnext.maintenance.MaintenanceVisit = frappe.ui.form.Controller.extend({ }) }, __("Get Items From")); } - }, -}); + } +}; -$.extend(cur_frm.cscript, new erpnext.maintenance.MaintenanceVisit({ frm: cur_frm })); \ No newline at end of file +extend_cscript(cur_frm.cscript, new erpnext.maintenance.MaintenanceVisit({frm: cur_frm})); diff --git a/erpnext/manufacturing/doctype/bom/bom.js b/erpnext/manufacturing/doctype/bom/bom.js index 27019dbbae2..c56668840e5 100644 --- a/erpnext/manufacturing/doctype/bom/bom.js +++ b/erpnext/manufacturing/doctype/bom/bom.js @@ -325,8 +325,7 @@ frappe.ui.form.on("BOM", { freeze: true, args: { update_parent: true, - from_child_bom:false, - save: frm.doc.docstatus === 1 ? true : false + from_child_bom:false }, callback: function(r) { refresh_field("items"); @@ -359,16 +358,16 @@ frappe.ui.form.on("BOM", { } }); -erpnext.bom.BomController = erpnext.TransactionController.extend({ - conversion_rate: function(doc) { +erpnext.bom.BomController = class BomController extends erpnext.TransactionController { + conversion_rate(doc) { if(this.frm.doc.currency === this.get_company_currency()) { this.frm.set_value("conversion_rate", 1.0); } else { erpnext.bom.update_cost(doc); } - }, + } - item_code: function(doc, cdt, cdn){ + item_code(doc, cdt, cdn){ var scrap_items = false; var child = locals[cdt][cdn]; if (child.doctype == 'BOM Scrap Item') { @@ -380,19 +379,19 @@ erpnext.bom.BomController = erpnext.TransactionController.extend({ } get_bom_material_detail(doc, cdt, cdn, scrap_items); - }, + } - buying_price_list: function(doc) { + buying_price_list(doc) { this.apply_price_list(); - }, + } - plc_conversion_rate: function(doc) { + plc_conversion_rate(doc) { if (!this.in_apply_price_list) { this.apply_price_list(null, true); } - }, + } - conversion_factor: function(doc, cdt, cdn) { + conversion_factor(doc, cdt, cdn) { if (frappe.meta.get_docfield(cdt, "stock_qty", cdn)) { var item = frappe.get_doc(cdt, cdn); frappe.model.round_floats_in(item, ["qty", "conversion_factor"]); @@ -401,10 +400,10 @@ erpnext.bom.BomController = erpnext.TransactionController.extend({ this.toggle_conversion_factor(item); this.frm.events.update_cost(this.frm); } - }, -}); + } +}; -$.extend(cur_frm.cscript, new erpnext.bom.BomController({frm: cur_frm})); +extend_cscript(cur_frm.cscript, new erpnext.bom.BomController({frm: cur_frm})); cur_frm.cscript.hour_rate = function(doc) { erpnext.bom.calculate_op_cost(doc); @@ -654,4 +653,4 @@ frappe.ui.form.on("BOM", "with_operations", function(frm) { if(!cint(frm.doc.with_operations)) { frm.set_value("operations", []); } -}); \ No newline at end of file +}); diff --git a/erpnext/manufacturing/doctype/bom/bom.py b/erpnext/manufacturing/doctype/bom/bom.py index 3e855603b48..c58f017258e 100644 --- a/erpnext/manufacturing/doctype/bom/bom.py +++ b/erpnext/manufacturing/doctype/bom/bom.py @@ -1,7 +1,8 @@ # Copyright (c) 2015, Frappe Technologies Pvt. Ltd. and Contributors # License: GNU General Public License v3. See license.txt -from __future__ import unicode_literals +from typing import List +from collections import deque import frappe, erpnext from frappe.utils import cint, cstr, flt, today from frappe import _ @@ -16,14 +17,85 @@ from frappe.model.mapper import get_mapped_doc import functools -from six import string_types - from operator import itemgetter form_grid_templates = { "items": "templates/form_grid/item_grid.html" } + +class BOMTree: + """Full tree representation of a BOM""" + + # specifying the attributes to save resources + # ref: https://docs.python.org/3/reference/datamodel.html#slots + __slots__ = ["name", "child_items", "is_bom", "item_code", "exploded_qty", "qty"] + + def __init__(self, name: str, is_bom: bool = True, exploded_qty: float = 1.0, qty: float = 1) -> None: + self.name = name # name of node, BOM number if is_bom else item_code + self.child_items: List["BOMTree"] = [] # list of child items + self.is_bom = is_bom # true if the node is a BOM and not a leaf item + self.item_code: str = None # item_code associated with node + self.qty = qty # required unit quantity to make one unit of parent item. + self.exploded_qty = exploded_qty # total exploded qty required for making root of tree. + if not self.is_bom: + self.item_code = self.name + else: + self.__create_tree() + + def __create_tree(self): + bom = frappe.get_cached_doc("BOM", self.name) + self.item_code = bom.item + + for item in bom.get("items", []): + qty = item.qty / bom.quantity # quantity per unit + exploded_qty = self.exploded_qty * qty + if item.bom_no: + child = BOMTree(item.bom_no, exploded_qty=exploded_qty, qty=qty) + self.child_items.append(child) + else: + self.child_items.append( + BOMTree(item.item_code, is_bom=False, exploded_qty=exploded_qty, qty=qty) + ) + + def level_order_traversal(self) -> List["BOMTree"]: + """Get level order traversal of tree. + E.g. for following tree the traversal will return list of nodes in order from top to bottom. + BOM: + - SubAssy1 + - item1 + - item2 + - SubAssy2 + - item3 + - item4 + + returns = [SubAssy1, item1, item2, SubAssy2, item3, item4] + """ + traversal = [] + q = deque() + q.append(self) + + while q: + node = q.popleft() + + for child in node.child_items: + traversal.append(child) + q.append(child) + + return traversal + + def __str__(self) -> str: + return ( + f"{self.item_code}{' - ' + self.name if self.is_bom else ''} qty(per unit): {self.qty}" + f" exploded_qty: {self.exploded_qty}" + ) + + def __repr__(self, level: int = 0) -> str: + rep = "┃ " * (level - 1) + "┣━ " * (level > 0) + str(self) + "\n" + for child in self.child_items: + rep += child.__repr__(level=level + 1) + return rep + class BOM(WebsiteGenerator): website = frappe._dict( # page_title_field = "item_name", @@ -152,7 +224,7 @@ class BOM(WebsiteGenerator): if not args: args = frappe.form_dict.get('args') - if isinstance(args, string_types): + if isinstance(args, str): import json args = json.loads(args) @@ -600,6 +672,11 @@ class BOM(WebsiteGenerator): if not d.batch_size or d.batch_size <= 0: d.batch_size = 1 + def get_tree_representation(self) -> BOMTree: + """Get a complete tree representation preserving order of child items.""" + return BOMTree(self.name) + + def get_bom_item_rate(args, bom_doc): if bom_doc.rm_cost_as_per == 'Valuation Rate': rate = get_valuation_rate(args) * (args.get("conversion_factor") or 1) diff --git a/erpnext/manufacturing/doctype/bom/test_bom.py b/erpnext/manufacturing/doctype/bom/test_bom.py index 1f443fb95ae..57a54587269 100644 --- a/erpnext/manufacturing/doctype/bom/test_bom.py +++ b/erpnext/manufacturing/doctype/bom/test_bom.py @@ -2,14 +2,13 @@ # License: GNU General Public License v3. See license.txt -from __future__ import unicode_literals +from collections import deque import unittest import frappe from frappe.utils import cstr, flt from frappe.test_runner import make_test_records from erpnext.stock.doctype.stock_reconciliation.test_stock_reconciliation import create_stock_reconciliation from erpnext.manufacturing.doctype.bom_update_tool.bom_update_tool import update_cost -from six import string_types from erpnext.stock.doctype.item.test_item import make_item from erpnext.buying.doctype.purchase_order.test_purchase_order import create_purchase_order from erpnext.tests.test_subcontracting import set_backflush_based_on @@ -227,11 +226,88 @@ class TestBOM(unittest.TestCase): supplied_items = sorted([d.rm_item_code for d in po.supplied_items]) self.assertEqual(bom_items, supplied_items) + def test_bom_tree_representation(self): + bom_tree = { + "Assembly": { + "SubAssembly1": {"ChildPart1": {}, "ChildPart2": {},}, + "SubAssembly2": {"ChildPart3": {}}, + "SubAssembly3": {"SubSubAssy1": {"ChildPart4": {}}}, + "ChildPart5": {}, + "ChildPart6": {}, + "SubAssembly4": {"SubSubAssy2": {"ChildPart7": {}}}, + } + } + parent_bom = create_nested_bom(bom_tree, prefix="") + created_tree = parent_bom.get_tree_representation() + + reqd_order = level_order_traversal(bom_tree)[1:] # skip first item + created_order = created_tree.level_order_traversal() + + self.assertEqual(len(reqd_order), len(created_order)) + + for reqd_item, created_item in zip(reqd_order, created_order): + self.assertEqual(reqd_item, created_item.item_code) + + def get_default_bom(item_code="_Test FG Item 2"): return frappe.db.get_value("BOM", {"item": item_code, "is_active": 1, "is_default": 1}) + + + +def level_order_traversal(node): + traversal = [] + q = deque() + q.append(node) + + while q: + node = q.popleft() + + for node_name, subtree in node.items(): + traversal.append(node_name) + q.append(subtree) + + return traversal + +def create_nested_bom(tree, prefix="_Test bom "): + """ Helper function to create a simple nested bom from tree describing item names. (along with required items) + """ + + def create_items(bom_tree): + for item_code, subtree in bom_tree.items(): + bom_item_code = prefix + item_code + if not frappe.db.exists("Item", bom_item_code): + frappe.get_doc(doctype="Item", item_code=bom_item_code, item_group="_Test Item Group").insert() + create_items(subtree) + create_items(tree) + + def dfs(tree, node): + """naive implementation for searching right subtree""" + for node_name, subtree in tree.items(): + if node_name == node: + return subtree + else: + result = dfs(subtree, node) + if result is not None: + return result + + order_of_creating_bom = reversed(level_order_traversal(tree)) + + for item in order_of_creating_bom: + child_items = dfs(tree, item) + if child_items: + bom_item_code = prefix + item + bom = frappe.get_doc(doctype="BOM", item=bom_item_code) + for child_item in child_items.keys(): + bom.append("items", {"item_code": prefix + child_item}) + bom.insert() + bom.submit() + + return bom # parent bom is last bom + + def reset_item_valuation_rate(item_code, warehouse_list=None, qty=None, rate=None): - if warehouse_list and isinstance(warehouse_list, string_types): + if warehouse_list and isinstance(warehouse_list, str): warehouse_list = [warehouse_list] if not warehouse_list: diff --git a/erpnext/manufacturing/doctype/work_order/test_work_order.py b/erpnext/manufacturing/doctype/work_order/test_work_order.py index cb1ee92196f..68de0b29d3e 100644 --- a/erpnext/manufacturing/doctype/work_order/test_work_order.py +++ b/erpnext/manufacturing/doctype/work_order/test_work_order.py @@ -389,17 +389,12 @@ class TestWorkOrder(unittest.TestCase): ste.submit() stock_entries.append(ste) - job_cards = frappe.get_all('Job Card', filters = {'work_order': work_order.name}) + job_cards = frappe.get_all('Job Card', filters = {'work_order': work_order.name}, order_by='creation asc') self.assertEqual(len(job_cards), len(bom.operations)) for i, job_card in enumerate(job_cards): doc = frappe.get_doc("Job Card", job_card) - doc.append("time_logs", { - "from_time": add_to_date(None, i), - "hours": 1, - "to_time": add_to_date(None, i + 1), - "completed_qty": doc.for_quantity - }) + doc.time_logs[0].completed_qty = 1 doc.submit() ste1 = frappe.get_doc(make_stock_entry(work_order.name, "Manufacture", 1)) diff --git a/erpnext/manufacturing/doctype/work_order/work_order.py b/erpnext/manufacturing/doctype/work_order/work_order.py index e343ed2dd38..180815d80e4 100644 --- a/erpnext/manufacturing/doctype/work_order/work_order.py +++ b/erpnext/manufacturing/doctype/work_order/work_order.py @@ -1,7 +1,6 @@ -# Copyright (c) 2015, Frappe Technologies Pvt. Ltd. and Contributors +# Copyright (c) 2021, Frappe Technologies Pvt. Ltd. and Contributors # License: GNU General Public License v3. See license.txt -from __future__ import unicode_literals import frappe import json import math @@ -30,9 +29,6 @@ class ItemHasVariantError(frappe.ValidationError): pass class SerialNoQtyError(frappe.ValidationError): pass -form_grid_templates = { - "operations": "templates/form_grid/work_order_grid.html" -} class WorkOrder(Document): def onload(self): @@ -472,46 +468,47 @@ class WorkOrder(Document): def set_work_order_operations(self): """Fetch operations from BOM and set in 'Work Order'""" - self.set('operations', []) + def _get_operations(bom_no, qty=1): + return frappe.db.sql( + f"""select + operation, description, workstation, idx, + base_hour_rate as hour_rate, time_in_mins * {qty} as time_in_mins, + "Pending" as status, parent as bom, batch_size, sequence_id + from + `tabBOM Operation` + where + parent = %s order by idx + """, bom_no, as_dict=1) + + + self.set('operations', []) if not self.bom_no: return - if self.use_multi_level_bom: - bom_list = frappe.get_doc("BOM", self.bom_no).traverse_tree() + operations = [] + if not self.use_multi_level_bom: + bom_qty = frappe.db.get_value("BOM", self.bom_no, "quantity") + operations.extend(_get_operations(self.bom_no, qty=1.0/bom_qty)) else: - bom_list = [self.bom_no] + bom_tree = frappe.get_doc("BOM", self.bom_no).get_tree_representation() + bom_traversal = list(reversed(bom_tree.level_order_traversal())) + bom_traversal.append(bom_tree) # add operation on top level item last + + for d in bom_traversal: + if d.is_bom: + operations.extend(_get_operations(d.name, qty=d.exploded_qty)) + + for correct_index, operation in enumerate(operations, start=1): + operation.idx = correct_index - operations = frappe.db.sql(""" - select - operation, description, workstation, idx, - base_hour_rate as hour_rate, time_in_mins, - "Pending" as status, parent as bom, batch_size, sequence_id - from - `tabBOM Operation` - where - parent in (%s) order by idx - """ % ", ".join(["%s"]*len(bom_list)), tuple(bom_list), as_dict=1) self.set('operations', operations) - - if self.use_multi_level_bom and self.get('operations') and self.get('items'): - raw_material_operations = [d.operation for d in self.get('items')] - operations = [d.operation for d in self.get('operations')] - - for operation in raw_material_operations: - if operation not in operations: - self.append('operations', { - 'operation': operation - }) - self.calculate_time() def calculate_time(self): - bom_qty = frappe.db.get_value("BOM", self.bom_no, "quantity") - for d in self.get("operations"): - d.time_in_mins = flt(d.time_in_mins) / flt(bom_qty) * (flt(self.qty) / flt(d.batch_size)) + d.time_in_mins = flt(d.time_in_mins) * (flt(self.qty) / flt(d.batch_size)) self.calculate_operating_cost() diff --git a/erpnext/manufacturing/doctype/work_order_operation/work_order_operation.json b/erpnext/manufacturing/doctype/work_order_operation/work_order_operation.json index 6d8fb80e319..f7b8787a0b3 100644 --- a/erpnext/manufacturing/doctype/work_order_operation/work_order_operation.json +++ b/erpnext/manufacturing/doctype/work_order_operation/work_order_operation.json @@ -2,7 +2,6 @@ "actions": [], "creation": "2014-10-16 14:35:41.950175", "doctype": "DocType", - "editable_grid": 1, "engine": "InnoDB", "field_order": [ "details", @@ -49,6 +48,7 @@ { "fieldname": "bom", "fieldtype": "Link", + "in_list_view": 1, "label": "BOM", "no_copy": 1, "options": "BOM", @@ -68,6 +68,7 @@ "fieldtype": "Column Break" }, { + "columns": 1, "description": "Operation completed for how many finished goods?", "fieldname": "completed_qty", "fieldtype": "Float", @@ -77,6 +78,7 @@ "read_only": 1 }, { + "columns": 1, "default": "Pending", "fieldname": "status", "fieldtype": "Select", @@ -119,6 +121,7 @@ "fieldtype": "Column Break" }, { + "columns": 1, "description": "in Minutes", "fieldname": "time_in_mins", "fieldtype": "Float", @@ -205,7 +208,7 @@ "index_web_pages_for_search": 1, "istable": 1, "links": [], - "modified": "2021-01-12 14:48:31.061286", + "modified": "2021-06-24 14:36:12.835543", "modified_by": "Administrator", "module": "Manufacturing", "name": "Work Order Operation", @@ -214,4 +217,4 @@ "sort_field": "modified", "sort_order": "DESC", "track_changes": 1 -} \ No newline at end of file +} diff --git a/erpnext/patches.txt b/erpnext/patches.txt index 2b1fc43a1c0..986b0c5711e 100644 --- a/erpnext/patches.txt +++ b/erpnext/patches.txt @@ -286,7 +286,9 @@ erpnext.patches.v13_0.germany_fill_debtor_creditor_number erpnext.patches.v13_0.set_pos_closing_as_failed execute:frappe.rename_doc("Workspace", "Loan Management", "Loans", force=True) erpnext.patches.v13_0.update_timesheet_changes +erpnext.patches.v13_0.add_doctype_to_sla #14-06-2021 erpnext.patches.v13_0.set_training_event_attendance +erpnext.patches.v13_0.bill_for_rejected_quantity_in_purchase_invoice erpnext.patches.v13_0.rename_issue_status_hold_to_on_hold erpnext.patches.v13_0.bill_for_rejected_quantity_in_purchase_invoice erpnext.patches.v13_0.update_job_card_details diff --git a/erpnext/patches/v13_0/add_doctype_to_sla.py b/erpnext/patches/v13_0/add_doctype_to_sla.py new file mode 100644 index 00000000000..e2c7fd268aa --- /dev/null +++ b/erpnext/patches/v13_0/add_doctype_to_sla.py @@ -0,0 +1,21 @@ +# Copyright (c) 2020, Frappe and Contributors +# License: GNU General Public License v3. See license.txt + +from __future__ import unicode_literals + +import frappe +from frappe.model.utils.rename_field import rename_field + +def execute(): + frappe.reload_doc('support', 'doctype', 'sla_fulfilled_on_status') + frappe.reload_doc('support', 'doctype', 'service_level_agreement') + if frappe.db.has_column('Service Level Agreement', 'enable'): + rename_field('Service Level Agreement', 'enable', 'enabled') + + for sla in frappe.get_all('Service Level Agreement'): + agreement = frappe.get_doc('Service Level Agreement', sla.name) + agreement.document_type = 'Issue' + agreement.apply_sla_for_resolution = 1 + agreement.append('sla_fulfilled_on', {'status': 'Resolved'}) + agreement.append('sla_fulfilled_on', {'status': 'Closed'}) + agreement.save() \ No newline at end of file diff --git a/erpnext/patches/v13_0/bill_for_rejected_quantity_in_purchase_invoice.py b/erpnext/patches/v13_0/bill_for_rejected_quantity_in_purchase_invoice.py index be85cfdeeff..7de9fa1e23e 100644 --- a/erpnext/patches/v13_0/bill_for_rejected_quantity_in_purchase_invoice.py +++ b/erpnext/patches/v13_0/bill_for_rejected_quantity_in_purchase_invoice.py @@ -5,4 +5,4 @@ def execute(): frappe.reload_doctype("Buying Settings") buying_settings = frappe.get_single("Buying Settings") buying_settings.bill_for_rejected_quantity_in_purchase_invoice = 0 - buying_settings.save() \ No newline at end of file + buying_settings.save() diff --git a/erpnext/payroll/doctype/payroll_entry/payroll_entry.js b/erpnext/payroll/doctype/payroll_entry/payroll_entry.js index f2892600d12..496c37b2fad 100644 --- a/erpnext/payroll/doctype/payroll_entry/payroll_entry.js +++ b/erpnext/payroll/doctype/payroll_entry/payroll_entry.js @@ -135,10 +135,26 @@ frappe.ui.form.on('Payroll Entry', { }); frm.set_query('employee', 'employees', () => { - if (!frm.doc.company) { - frappe.msgprint(__("Please set a Company")); - return []; + let error_fields = []; + let mandatory_fields = ['company', 'payroll_frequency', 'start_date', 'end_date']; + + let message = __('Mandatory fields required in {0}', [__(frm.doc.doctype)]); + + mandatory_fields.forEach(field => { + if (!frm.doc[field]) { + error_fields.push(frappe.unscrub(field)); + } + }); + + if (error_fields && error_fields.length) { + message = message + '

"; + frappe.throw({ + message: message, + indicator: 'red', + title: __('Missing Fields') + }); } + return { query: "erpnext.payroll.doctype.payroll_entry.payroll_entry.employee_query", filters: frm.events.get_employee_filters(frm) @@ -148,25 +164,22 @@ frappe.ui.form.on('Payroll Entry', { get_employee_filters: function (frm) { let filters = {}; - filters['company'] = frm.doc.company; - filters['start_date'] = frm.doc.start_date; - filters['end_date'] = frm.doc.end_date; filters['salary_slip_based_on_timesheet'] = frm.doc.salary_slip_based_on_timesheet; - filters['payroll_frequency'] = frm.doc.payroll_frequency; - filters['payroll_payable_account'] = frm.doc.payroll_payable_account; - filters['currency'] = frm.doc.currency; - if (frm.doc.department) { - filters['department'] = frm.doc.department; - } - if (frm.doc.branch) { - filters['branch'] = frm.doc.branch; - } - if (frm.doc.designation) { - filters['designation'] = frm.doc.designation; - } + let fields = ['company', 'start_date', 'end_date', 'payroll_frequency', 'payroll_payable_account', + 'currency', 'department', 'branch', 'designation']; + + fields.forEach(field => { + if (frm.doc[field]) { + filters[field] = frm.doc[field]; + } + }); + if (frm.doc.employees) { - filters['employees'] = frm.doc.employees.filter(d => d.employee).map(d => d.employee); + let employees = frm.doc.employees.filter(d => d.employee).map(d => d.employee); + if (employees && employees.length) { + filters['employees'] = employees; + } } return filters; }, diff --git a/erpnext/payroll/doctype/payroll_entry/payroll_entry.py b/erpnext/payroll/doctype/payroll_entry/payroll_entry.py index e71d81f323a..36e728fc992 100644 --- a/erpnext/payroll/doctype/payroll_entry/payroll_entry.py +++ b/erpnext/payroll/doctype/payroll_entry/payroll_entry.py @@ -459,6 +459,7 @@ def get_emp_list(sal_struct, cond, end_date, payroll_payable_account): where t1.name = t2.employee and t2.docstatus = 1 + and t1.status != 'Inactive' %s order by t2.from_date desc """ % cond, {"sal_struct": tuple(sal_struct), "from_date": end_date, "payroll_payable_account": payroll_payable_account}, as_dict=True) @@ -679,6 +680,10 @@ def employee_query(doctype, txt, searchfield, start, page_len, filters): conditions = [] include_employees = [] emp_cond = '' + + if not filters.payroll_frequency: + frappe.throw(_('Select Payroll Frequency.')) + if filters.start_date and filters.end_date: employee_list = get_employee_list(filters) emp = filters.get('employees') diff --git a/erpnext/payroll/doctype/salary_slip/salary_slip.py b/erpnext/payroll/doctype/salary_slip/salary_slip.py index 877503b41cb..c55bec89be8 100644 --- a/erpnext/payroll/doctype/salary_slip/salary_slip.py +++ b/erpnext/payroll/doctype/salary_slip/salary_slip.py @@ -667,16 +667,13 @@ class SalarySlip(TransactionBase): component_row = self.append(component_type) for attr in ( - 'depends_on_payment_days', 'salary_component', + 'depends_on_payment_days', 'salary_component', 'abbr', 'do_not_include_in_total', 'is_tax_applicable', 'is_flexible_benefit', 'variable_based_on_taxable_salary', 'exempted_from_income_tax' ): component_row.set(attr, component_data.get(attr)) - abbr = component_data.get('abbr') or component_data.get('salary_component_abbr') - component_row.set('abbr', abbr) - if additional_salary: component_row.default_amount = 0 component_row.additional_amount = amount diff --git a/erpnext/portal/doctype/homepage/test_homepage.py b/erpnext/portal/doctype/homepage/test_homepage.py index b717491a821..e646775ab32 100644 --- a/erpnext/portal/doctype/homepage/test_homepage.py +++ b/erpnext/portal/doctype/homepage/test_homepage.py @@ -6,12 +6,12 @@ from __future__ import unicode_literals import frappe import unittest from frappe.utils import set_request -from frappe.website.render import render +from frappe.website.serve import get_response class TestHomepage(unittest.TestCase): def test_homepage_load(self): set_request(method='GET', path='home') - response = render() + response = get_response() self.assertEqual(response.status_code, 200) diff --git a/erpnext/portal/doctype/homepage_section/test_homepage_section.py b/erpnext/portal/doctype/homepage_section/test_homepage_section.py index f0aa554858a..5bb9682bc56 100644 --- a/erpnext/portal/doctype/homepage_section/test_homepage_section.py +++ b/erpnext/portal/doctype/homepage_section/test_homepage_section.py @@ -7,7 +7,7 @@ import frappe import unittest from bs4 import BeautifulSoup from frappe.utils import set_request -from frappe.website.render import render +from frappe.website.serve import get_response class TestHomepageSection(unittest.TestCase): def test_homepage_section_card(self): @@ -26,7 +26,7 @@ class TestHomepageSection(unittest.TestCase): pass set_request(method='GET', path='home') - response = render() + response = get_response() self.assertEqual(response.status_code, 200) @@ -59,7 +59,7 @@ class TestHomepageSection(unittest.TestCase): }).insert() set_request(method='GET', path='home') - response = render() + response = get_response() self.assertEqual(response.status_code, 200) diff --git a/erpnext/portal/product_configurator/test_product_configurator.py b/erpnext/portal/product_configurator/test_product_configurator.py index daaba671736..8aa073402ac 100644 --- a/erpnext/portal/product_configurator/test_product_configurator.py +++ b/erpnext/portal/product_configurator/test_product_configurator.py @@ -2,10 +2,8 @@ from __future__ import unicode_literals from bs4 import BeautifulSoup import frappe, unittest -from frappe.utils import set_request, get_html_for_route -from frappe.website.render import render +from frappe.utils import get_html_for_route from erpnext.portal.product_configurator.utils import get_products_for_website -from erpnext.stock.doctype.item.test_item import make_item_variant test_dependencies = ["Item"] diff --git a/erpnext/public/css/email.css b/erpnext/public/css/email.css deleted file mode 100644 index 8cf1a31ad6d..00000000000 --- a/erpnext/public/css/email.css +++ /dev/null @@ -1,29 +0,0 @@ -.panel-header { - background-color: #fafbfc; - border: 1px solid #d1d8dd; - border-radius: 3px 3px 0 0; -} -.panel-body { - background-color: #fff; - border: 1px solid #d1d8dd; - border-top: none; - border-radius: 0 0 3px 3px; - overflow-wrap: break-word; -} -.sender-avatar { - width: 24px; - height: 24px; - border-radius: 3px; - vertical-align: middle; -} -.sender-avatar-placeholder { - width: 24px; - height: 24px; - border-radius: 3px; - vertical-align: middle; - line-height: 24px; - text-align: center; - color: #d1d8dd; - border: 1px solid #d1d8dd; - background-color: #fff; -} diff --git a/erpnext/public/css/erpnext.css b/erpnext/public/css/erpnext.css deleted file mode 100644 index 6e4efcb6685..00000000000 --- a/erpnext/public/css/erpnext.css +++ /dev/null @@ -1,408 +0,0 @@ -.erpnext-footer { - margin: 11px auto; - text-align: center; -} -.show-all-reports { - margin-top: 5px; - font-size: 11px; -} -/* toolbar */ -.toolbar-splash { - width: 32px; - height: 32px; - margin: -10px auto; -} -.erpnext-icon { - width: 24px; - margin-right: 0px; - margin-top: -3px; -} -.dashboard-list-item { - background-color: inherit; - padding: 5px 0px; - border-bottom: 1px solid #d1d8dd; -} -#page-stock-balance .dashboard-list-item { - padding: 5px 15px; -} -.dashboard-list-item:last-child { - border-bottom: none; -} -.frappe-control[data-fieldname='result_html'] { - overflow: scroll; -} -.assessment-result-tool { - table-layout: fixed; -} -.assessment-result-tool input { - width: 100%; - border: 0; - outline: none; - text-align: right; -} -.assessment-result-tool th { - white-space: nowrap; - overflow: hidden; - text-overflow: ellipsis; -} -.assessment-result-tool .total-score, -.assessment-result-tool .grade, -.assessment-result-tool .score { - text-align: right; -} -/* pos */ -body[data-route="pos"] .pos-bill-toolbar { - padding: 10px 0px; - height: 51px; -} -body[data-route="pos"] .pos-bill-item:hover, -body[data-route="pos"] .list-customers-table > .pos-list-row:hover { - background-color: #f5f7fa; - cursor: pointer; -} -body[data-route="pos"] .pos-item-qty { - display: inline-block; -} -body[data-route="pos"] .pos-qty-row > div { - padding: 5px 0px; -} -body[data-route="pos"] .pos-qty-btn { - margin-top: 3px; - cursor: pointer; - font-size: 120%; -} -body[data-route="pos"] .search-area .form-group { - max-width: 100% !important; -} -body[data-route="pos"] .tax-table { - margin-bottom: 10px; -} -body[data-route="pos"] .discount-field-col { - padding-left: 24px; -} -body[data-route="pos"] .discount-amount-area .input-group:first-child { - margin-bottom: 2px; -} -body[data-route="pos"] .payment-toolbar .row { - width: 323px; - margin: 0 auto; -} -body[data-route="pos"] .payment-mode { - cursor: pointer; - font-family: sans-serif; - font-size: 15px; -} -body[data-route="pos"] .pos-payment-row .col-xs-6 { - padding: 15px; -} -body[data-route="pos"] .pos-payment-row { - border-bottom: 1px solid #d1d8dd; - margin: 2px 0px 5px 0px; - height: 60px; - margin-top: 0px; - margin-bottom: 0px; -} -body[data-route="pos"] .pos-payment-row:hover, -body[data-route="pos"] .pos-keyboard-key:hover { - background-color: #fafbfc; - cursor: pointer; -} -body[data-route="pos"] .pos-keyboard-key, -body[data-route="pos"] .delete-btn { - border: 1px solid #d1d8dd; - height: 85px; - width: 85px; - margin: 10px 10px; - font-size: 24px; - font-weight: 200; - background-color: #FDFDFD; - border-color: #e8e8e8; -} -body[data-route="pos"] .numeric-keypad { - border: 1px solid #d1d8dd; - height: 69px; - width: 69px; - font-size: 20px; - font-weight: 200; - background-color: #FDFDFD; - border-color: #e8e8e8; - margin-left: -4px; -} -body[data-route="pos"] .pos-pay { - height: 69px; - width: 69px; - font-size: 17px; - font-weight: 200; - margin-left: -4px; -} -body[data-route="pos"] .numeric-keypad { - height: 60px; - width: 60px; - font-size: 20px; - font-weight: 200; - border-radius: 0; - background-color: #fff; - margin-left: -4px; -} -@media (max-width: 1199px) { - body[data-route="pos"] .numeric-keypad { - height: 45px; - width: 45px; - font-size: 14px; - } -} -@media (max-width: 991px) { - body[data-route="pos"] .numeric-keypad { - height: 40px; - width: 40px; - } -} -body[data-route="pos"] .numeric_keypad { - margin-left: -15px; -} -body[data-route="pos"] .numeric_keypad > .row > button { - border: none; - border-right: 1px solid #d1d8dd; - border-bottom: 1px solid #d1d8dd; -} -body[data-route="pos"] .numeric_keypad > .row > button:first-child { - border-left: 1px solid #d1d8dd; -} -body[data-route="pos"] .numeric_keypad > .row:first-child > button { - border-top: 1px solid #d1d8dd; -} -body[data-route="pos"] .pos-pay { - background-color: #5E64FF; - border: none; -} -body[data-route="pos"] .multimode-payments { - padding-left: 30px; -} -body[data-route="pos"] .payment-toolbar { - padding-right: 30px; -} -body[data-route="pos"] .list-row-head.pos-invoice-list { - border-top: 1px solid #d1d8dd; -} -body[data-route="pos"] .modal-dialog { - width: 750px; -} -@media (max-width: 767px) { - body[data-route="pos"] .modal-dialog { - width: auto; - } - body[data-route="pos"] .modal-dialog .modal-content { - height: auto; - } -} -@media (max-width: 767px) { - body[data-route="pos"] .amount-row h3 { - font-size: 15px; - } - body[data-route="pos"] .pos-keyboard-key, - body[data-route="pos"] .delete-btn { - height: 50px; - } - body[data-route="pos"] .multimode-payments { - padding-left: 15px; - } - body[data-route="pos"] .payment-toolbar { - padding-right: 15px; - } -} -body[data-route="pos"] .amount-label { - font-size: 16px; -} -body[data-route="pos"] .selected-payment-mode { - background-color: #fafbfc; - cursor: pointer; -} -body[data-route="pos"] .pos-invoice-list { - padding: 15px 10px; -} -body[data-route="pos"] .write_off_amount, -body[data-route="pos"] .change_amount { - margin: 15px; - width: 130px; -} -body[data-route="pos"] .pos-list-row { - display: table; - table-layout: fixed; - width: 100%; - padding: 9px 15px; - font-size: 12px; - margin: 0px; - border-bottom: 1px solid #d1d8dd; -} -body[data-route="pos"] .pos-list-row .cell { - display: table-cell; - vertical-align: middle; -} -body[data-route="pos"] .pos-list-row .cell.price-cell { - width: 50%; -} -body[data-route="pos"] .pos-list-row .subject { - width: 40%; -} -body[data-route="pos"] .pos-list-row .list-row-checkbox, -body[data-route="pos"] .pos-list-row .list-select-all { - margin-right: 7px; -} -body[data-route="pos"] .pos-bill-header { - background-color: #f5f7fa; - border: 1px solid #d1d8dd; - padding: 13px 15px; -} -body[data-route="pos"] .pos-list-row.active { - background-color: #fffce7; -} -body[data-route="pos"] .totals-area { - border-right: 1px solid #d1d8dd; - border-left: 1px solid #d1d8dd; - margin-bottom: 15px; -} -body[data-route="pos"] .tax-area .pos-list-row { - border: none; -} -body[data-route="pos"] .item-cart-items { - height: calc(100vh - 526px); - overflow: auto; - border: 1px solid #d1d8dd; - border-top: none; -} -@media (max-width: 767px) { - body[data-route="pos"] .item-cart-items { - height: 30vh; - } -} -body[data-route="pos"] .no-items-message { - min-height: 200px; - display: flex; - align-items: center; - justify-content: center; - height: 100%; -} -body[data-route="pos"] .pos-list-row:last-child { - border-bottom: none; -} -body[data-route="pos"] .form-section-heading { - padding: 0; -} -body[data-route="pos"] .item-list { - border: 1px solid #d1d8dd; - border-top: none; - max-height: calc(100vh - 190px); - overflow: auto; -} -@media (max-width: 767px) { - body[data-route="pos"] .item-list { - max-height: initial; - } -} -body[data-route="pos"] .item-list .image-field { - height: 140px; -} -body[data-route="pos"] .item-list .image-field .placeholder-text { - font-size: 50px; -} -body[data-route="pos"] .item-list .pos-item-wrapper { - position: relative; -} -body[data-route="pos"] .pos-bill-toolbar { - margin-top: 10px; -} -body[data-route="pos"] .search-item .form-group { - margin: 0; -} -body[data-route="pos"] .item-list-area .pos-bill-header { - padding: 5px; - padding-left: 15px; -} -body[data-route="pos"] .pos-selected-item-action .pos-list-row:first-child { - padding-top: 0; -} -body[data-route="pos"] .pos-selected-item-action > .pos-list-row { - border: none; -} -@media (max-width: 1199px) { - body[data-route="pos"] .pos-selected-item-action > .pos-list-row { - padding: 5px 15px; - } -} -body[data-route="pos"] .edit-customer-btn { - position: absolute; - right: 57px; - top: 15px; - z-index: 100; -} -body[data-route="pos"] .btn-more { - display: flex; - justify-content: center; - align-items: center; - cursor: pointer; - background-color: #fafbfc; - min-height: 200px; -} -body[data-route="pos"] .collapse-btn { - cursor: pointer; -} -@media (max-width: 767px) { - body[data-route="pos"] .page-actions { - max-width: 110px; - } -} -.price-info { - position: absolute; - left: 0; - bottom: 0; - margin: 0 0 15px 15px; - background-color: rgba(141, 153, 166, 0.6); - padding: 5px 9px; - border-radius: 3px; - color: #fff; -} -.leaderboard .result { - border-top: 1px solid #d1d8dd; -} -.leaderboard .list-item { - padding-left: 45px; -} -.leaderboard .list-item_content { - padding-right: 45px; -} -.exercise-card { - box-shadow: 0 1px 3px rgba(0,0,0,0.30); - border-radius: 2px; - padding: 6px 6px 6px 8px; - margin-top: 10px; - height: 100% !important; -} -.exercise-card .card-img-top { - width: 100%; - height: 15vw; - object-fit: cover; -} -.exercise-card .btn-edit { - position: absolute; - bottom: 10px; - left: 20px; -} -.exercise-card .btn-del { - position: absolute; - bottom: 10px; - left: 50px; -} -.exercise-card .card-body { - margin-bottom: 10px; -} -.exercise-card .card-footer { - padding: 10px; -} -.exercise-row { - height: 100% !important; - display: flex; - flex-wrap: wrap; -} -.exercise-col { - padding: 10px; -} diff --git a/erpnext/public/css/leaflet/leaflet.css b/erpnext/public/css/leaflet/leaflet.css deleted file mode 100755 index 979a8bd712b..00000000000 --- a/erpnext/public/css/leaflet/leaflet.css +++ /dev/null @@ -1,611 +0,0 @@ -/* required styles */ - -.leaflet-pane, -.leaflet-tile, -.leaflet-marker-icon, -.leaflet-marker-shadow, -.leaflet-tile-container, -.leaflet-map-pane svg, -.leaflet-map-pane canvas, -.leaflet-zoom-box, -.leaflet-image-layer, -.leaflet-layer { - position: absolute; - left: 0; - top: 0; -} - -.leaflet-container { - overflow: hidden; - -ms-touch-action: none; - touch-action: none; -} - -.leaflet-tile, -.leaflet-marker-icon, -.leaflet-marker-shadow { - -webkit-user-select: none; - -moz-user-select: none; - user-select: none; - -webkit-user-drag: none; -} - - -/* Safari renders non-retina tile on retina better with this, but Chrome is worse */ - -.leaflet-safari .leaflet-tile { - image-rendering: -webkit-optimize-contrast; -} - - -/* hack that prevents hw layers "stretching" when loading new tiles */ - -.leaflet-safari .leaflet-tile-container { - width: 1600px; - height: 1600px; - -webkit-transform-origin: 0 0; -} - -.leaflet-marker-icon, -.leaflet-marker-shadow { - display: block; -} - - -/* .leaflet-container svg: reset svg max-width decleration shipped in Joomla! (joomla.org) 3.x */ - - -/* .leaflet-container img: map is broken in FF if you have max-width: 100% on tiles */ - -.leaflet-container .leaflet-overlay-pane svg, -.leaflet-container .leaflet-marker-pane img, -.leaflet-container .leaflet-tile-pane img, -.leaflet-container img.leaflet-image-layer { - max-width: none !important; -} - -.leaflet-tile { - filter: inherit; - visibility: hidden; -} - -.leaflet-tile-loaded { - visibility: inherit; -} - -.leaflet-zoom-box { - width: 0; - height: 0; - -moz-box-sizing: border-box; - box-sizing: border-box; - z-index: 800; -} - - -/* workaround for https://bugzilla.mozilla.org/show_bug.cgi?id=888319 */ - -.leaflet-overlay-pane svg { - -moz-user-select: none; -} - -.leaflet-pane { - z-index: 400; -} - -.leaflet-tile-pane { - z-index: 200; -} - -.leaflet-overlay-pane { - z-index: 400; -} - -.leaflet-shadow-pane { - z-index: 500; -} - -.leaflet-marker-pane { - z-index: 600; -} - -.leaflet-popup-pane { - z-index: 700; -} - -.leaflet-map-pane canvas { - z-index: 100; -} - -.leaflet-map-pane svg { - z-index: 200; -} - -.leaflet-vml-shape { - width: 1px; - height: 1px; -} - -.lvml { - behavior: url(#default#VML); - display: inline-block; - position: absolute; -} - - -/* control positioning */ - -.leaflet-control { - position: relative; - z-index: 800; - pointer-events: auto; -} - -.leaflet-top, -.leaflet-bottom { - position: absolute; - z-index: 1000; - pointer-events: none; -} - -.leaflet-top { - top: 0; -} - -.leaflet-right { - right: 0; -} - -.leaflet-bottom { - bottom: 0; -} - -.leaflet-left { - left: 0; -} - -.leaflet-control { - float: left; - clear: both; -} - -.leaflet-right .leaflet-control { - float: right; -} - -.leaflet-top .leaflet-control { - margin-top: 10px; -} - -.leaflet-bottom .leaflet-control { - margin-bottom: 10px; -} - -.leaflet-left .leaflet-control { - margin-left: 10px; -} - -.leaflet-right .leaflet-control { - margin-right: 10px; -} - - -/* zoom and fade animations */ - -.leaflet-fade-anim .leaflet-tile { - will-change: opacity; -} - -.leaflet-fade-anim .leaflet-popup { - opacity: 0; - -webkit-transition: opacity 0.2s linear; - -moz-transition: opacity 0.2s linear; - -o-transition: opacity 0.2s linear; - transition: opacity 0.2s linear; -} - -.leaflet-fade-anim .leaflet-map-pane .leaflet-popup { - opacity: 1; -} - -.leaflet-zoom-animated { - -webkit-transform-origin: 0 0; - -ms-transform-origin: 0 0; - transform-origin: 0 0; -} - -.leaflet-zoom-anim .leaflet-zoom-animated { - will-change: transform; -} - -.leaflet-zoom-anim .leaflet-zoom-animated { - -webkit-transition: -webkit-transform 0.25s cubic-bezier(0, 0, 0.25, 1); - -moz-transition: -moz-transform 0.25s cubic-bezier(0, 0, 0.25, 1); - -o-transition: -o-transform 0.25s cubic-bezier(0, 0, 0.25, 1); - transition: transform 0.25s cubic-bezier(0, 0, 0.25, 1); -} - -.leaflet-zoom-anim .leaflet-tile, -.leaflet-pan-anim .leaflet-tile { - -webkit-transition: none; - -moz-transition: none; - -o-transition: none; - transition: none; -} - -.leaflet-zoom-anim .leaflet-zoom-hide { - visibility: hidden; -} - - -/* cursors */ - -.leaflet-interactive { - cursor: pointer; -} - -.leaflet-grab { - cursor: -webkit-grab; - cursor: -moz-grab; -} - -.leaflet-crosshair, -.leaflet-crosshair .leaflet-interactive { - cursor: crosshair; -} - -.leaflet-popup-pane, -.leaflet-control { - cursor: auto; -} - -.leaflet-dragging .leaflet-grab, -.leaflet-dragging .leaflet-grab .leaflet-interactive, -.leaflet-dragging .leaflet-marker-draggable { - cursor: move; - cursor: -webkit-grabbing; - cursor: -moz-grabbing; -} - - -/* visual tweaks */ - -.leaflet-container { - background: #ddd; - outline: 0; -} - -.leaflet-container a { - color: #0078A8; -} - -.leaflet-container a.leaflet-active { - outline: 2px solid orange; -} - -.leaflet-zoom-box { - border: 2px dotted #38f; - background: rgba(255, 255, 255, 0.5); -} - - -/* general typography */ - -.leaflet-container { - font: 12px/1.5 "Helvetica Neue", Arial, Helvetica, sans-serif; -} - - -/* general toolbar styles */ - -.leaflet-bar { - box-shadow: 0 1px 5px rgba(0, 0, 0, 0.65); - border-radius: 4px; -} - -.leaflet-bar a, -.leaflet-bar a:hover { - background-color: #fff; - border-bottom: 1px solid #ccc; - width: 26px; - height: 26px; - line-height: 26px; - display: block; - text-align: center; - text-decoration: none; - color: black; -} - -.leaflet-bar a, -.leaflet-control-layers-toggle { - background-position: 50% 50%; - background-repeat: no-repeat; - display: block; -} - -.leaflet-bar a:hover { - background-color: #f4f4f4; -} - -.leaflet-bar a:first-child { - border-top-left-radius: 4px; - border-top-right-radius: 4px; -} - -.leaflet-bar a:last-child { - border-bottom-left-radius: 4px; - border-bottom-right-radius: 4px; - border-bottom: none; -} - -.leaflet-bar a.leaflet-disabled { - cursor: default; - background-color: #f4f4f4; - color: #bbb; -} - -.leaflet-touch .leaflet-bar a { - width: 30px; - height: 30px; - line-height: 30px; -} - - -/* zoom control */ - -.leaflet-control-zoom-in, -.leaflet-control-zoom-out { - font: bold 18px 'Lucida Console', Monaco, monospace; - text-indent: 1px; -} - -.leaflet-control-zoom-out { - font-size: 20px; -} - -.leaflet-touch .leaflet-control-zoom-in { - font-size: 22px; -} - -.leaflet-touch .leaflet-control-zoom-out { - font-size: 24px; -} - - -/* layers control */ - -.leaflet-control-layers { - box-shadow: 0 1px 5px rgba(0, 0, 0, 0.4); - background: #fff; - border-radius: 5px; -} - -.leaflet-control-layers-toggle { - background-image: url('assets/erpnext/images/leaflet/layers.png'); - width: 36px; - height: 36px; -} - -.leaflet-retina .leaflet-control-layers-toggle { - background-image: url('assets/erpnext/images/leaflet/layers-2x.png'); - background-size: 26px 26px; -} - -.leaflet-touch .leaflet-control-layers-toggle { - width: 44px; - height: 44px; -} - -.leaflet-control-layers .leaflet-control-layers-list, -.leaflet-control-layers-expanded .leaflet-control-layers-toggle { - display: none; -} - -.leaflet-control-layers-expanded .leaflet-control-layers-list { - display: block; - position: relative; -} - -.leaflet-control-layers-expanded { - padding: 6px 10px 6px 6px; - color: #333; - background: #fff; -} - -.leaflet-control-layers-scrollbar { - overflow-y: scroll; - padding-right: 5px; -} - -.leaflet-control-layers-selector { - margin-top: 2px; - position: relative; - top: 1px; -} - -.leaflet-control-layers label { - display: block; -} - -.leaflet-control-layers-separator { - height: 0; - border-top: 1px solid #ddd; - margin: 5px -10px 5px -6px; -} - - -/* attribution and scale controls */ - -.leaflet-container .leaflet-control-attribution { - background: #fff; - background: rgba(255, 255, 255, 0.7); - margin: 0; -} - -.leaflet-control-attribution, -.leaflet-control-scale-line { - padding: 0 5px; - color: #333; -} - -.leaflet-control-attribution a { - text-decoration: none; -} - -.leaflet-control-attribution a:hover { - text-decoration: underline; -} - -.leaflet-container .leaflet-control-attribution, -.leaflet-container .leaflet-control-scale { - font-size: 11px; -} - -.leaflet-left .leaflet-control-scale { - margin-left: 5px; -} - -.leaflet-bottom .leaflet-control-scale { - margin-bottom: 5px; -} - -.leaflet-control-scale-line { - border: 2px solid #777; - border-top: none; - line-height: 1.1; - padding: 2px 5px 1px; - font-size: 11px; - white-space: nowrap; - overflow: hidden; - -moz-box-sizing: border-box; - box-sizing: border-box; - background: #fff; - background: rgba(255, 255, 255, 0.5); -} - -.leaflet-control-scale-line:not(:first-child) { - border-top: 2px solid #777; - border-bottom: none; - margin-top: -2px; -} - -.leaflet-control-scale-line:not(:first-child):not(:last-child) { - border-bottom: 2px solid #777; -} - -.leaflet-touch .leaflet-control-attribution, -.leaflet-touch .leaflet-control-layers, -.leaflet-touch .leaflet-bar { - box-shadow: none; -} - -.leaflet-touch .leaflet-control-layers, -.leaflet-touch .leaflet-bar { - border: 2px solid rgba(0, 0, 0, 0.2); - background-clip: padding-box; -} - - -/* popup */ - -.leaflet-popup { - position: absolute; - text-align: center; -} - -.leaflet-popup-content-wrapper { - padding: 1px; - text-align: left; - border-radius: 12px; -} - -.leaflet-popup-content { - margin: 13px 19px; - line-height: 1.4; -} - -.leaflet-popup-content p { - margin: 18px 0; -} - -.leaflet-popup-tip-container { - margin: 0 auto; - width: 40px; - height: 20px; - position: relative; - overflow: hidden; -} - -.leaflet-popup-tip { - width: 17px; - height: 17px; - padding: 1px; - margin: -10px auto 0; - -webkit-transform: rotate(45deg); - -moz-transform: rotate(45deg); - -ms-transform: rotate(45deg); - -o-transform: rotate(45deg); - transform: rotate(45deg); -} - -.leaflet-popup-content-wrapper, -.leaflet-popup-tip { - background: white; - color: #333; - box-shadow: 0 3px 14px rgba(0, 0, 0, 0.4); -} - -.leaflet-container a.leaflet-popup-close-button { - position: absolute; - top: 0; - right: 0; - padding: 4px 4px 0 0; - border: none; - text-align: center; - width: 18px; - height: 14px; - font: 16px/14px Tahoma, Verdana, sans-serif; - color: #c3c3c3; - text-decoration: none; - font-weight: bold; - background: transparent; -} - -.leaflet-container a.leaflet-popup-close-button:hover { - color: #999; -} - -.leaflet-popup-scrolled { - overflow: auto; - border-bottom: 1px solid #ddd; - border-top: 1px solid #ddd; -} - -.leaflet-oldie .leaflet-popup-content-wrapper { - zoom: 1; -} - -.leaflet-oldie .leaflet-popup-tip { - width: 24px; - margin: 0 auto; - -ms-filter: "progid:DXImageTransform.Microsoft.Matrix(M11=0.70710678, M12=0.70710678, M21=-0.70710678, M22=0.70710678)"; - filter: progid: DXImageTransform.Microsoft.Matrix(M11=0.70710678, M12=0.70710678, M21=-0.70710678, M22=0.70710678); -} - -.leaflet-oldie .leaflet-popup-tip-container { - margin-top: -1px; -} - -.leaflet-oldie .leaflet-control-zoom, -.leaflet-oldie .leaflet-control-layers, -.leaflet-oldie .leaflet-popup-content-wrapper, -.leaflet-oldie .leaflet-popup-tip { - border: 1px solid #999; -} - - -/* div icon */ - -.leaflet-div-icon { - background: #fff; - border: 1px solid #666; -} \ No newline at end of file diff --git a/erpnext/public/css/leaflet/leaflet.draw.css b/erpnext/public/css/leaflet/leaflet.draw.css deleted file mode 100755 index 6fb7db0e64a..00000000000 --- a/erpnext/public/css/leaflet/leaflet.draw.css +++ /dev/null @@ -1,316 +0,0 @@ -/* ================================================================== */ - - -/* Toolbars -/* ================================================================== */ - -.leaflet-draw-section { - position: relative; -} - -.leaflet-draw-toolbar { - margin-top: 12px; -} - -.leaflet-draw-toolbar-top { - margin-top: 0; -} - -.leaflet-draw-toolbar-notop a:first-child { - border-top-right-radius: 0; -} - -.leaflet-draw-toolbar-nobottom a:last-child { - border-bottom-right-radius: 0; -} - -.leaflet-draw-toolbar a { - background-image: url('assets/erpnext/images/leaflet/spritesheet.png'); - background-repeat: no-repeat; -} - -.leaflet-retina .leaflet-draw-toolbar a { - background-image: url('assets/erpnext/images/leaflet/spritesheet-2x.png'); - background-size: 270px 30px; -} - -.leaflet-draw a { - display: block; - text-align: center; - text-decoration: none; -} - - -/* ================================================================== */ - - -/* Toolbar actions menu -/* ================================================================== */ - -.leaflet-draw-actions { - display: none; - list-style: none; - margin: 0; - padding: 0; - position: absolute; - left: 26px; - /* leaflet-draw-toolbar.left + leaflet-draw-toolbar.width */ - top: 0; - white-space: nowrap; -} - -.leaflet-right .leaflet-draw-actions { - right: 26px; - left: auto; -} - -.leaflet-draw-actions li { - display: inline-block; -} - -.leaflet-draw-actions li:first-child a { - border-left: none; -} - -.leaflet-draw-actions li:last-child a { - -webkit-border-radius: 0 4px 4px 0; - border-radius: 0 4px 4px 0; -} - -.leaflet-right .leaflet-draw-actions li:last-child a { - -webkit-border-radius: 0; - border-radius: 0; -} - -.leaflet-right .leaflet-draw-actions li:first-child a { - -webkit-border-radius: 4px 0 0 4px; - border-radius: 4px 0 0 4px; -} - -.leaflet-draw-actions a { - background-color: #919187; - border-left: 1px solid #AAA; - color: #FFF; - font: 11px/19px "Helvetica Neue", Arial, Helvetica, sans-serif; - line-height: 28px; - text-decoration: none; - padding-left: 10px; - padding-right: 10px; - height: 28px; -} - -.leaflet-draw-actions-bottom { - margin-top: 0; -} - -.leaflet-draw-actions-top { - margin-top: 1px; -} - -.leaflet-draw-actions-top a, -.leaflet-draw-actions-bottom a { - height: 27px; - line-height: 27px; -} - -.leaflet-draw-actions a:hover { - background-color: #A0A098; -} - -.leaflet-draw-actions-top.leaflet-draw-actions-bottom a { - height: 26px; - line-height: 26px; -} - - -/* ================================================================== */ - - -/* Draw toolbar -/* ================================================================== */ - -.leaflet-draw-toolbar .leaflet-draw-draw-polyline { - background-position: -2px -2px; -} - -.leaflet-draw-toolbar .leaflet-draw-draw-polygon { - background-position: -31px -2px; -} - -.leaflet-draw-toolbar .leaflet-draw-draw-rectangle { - background-position: -62px -2px; -} - -.leaflet-draw-toolbar .leaflet-draw-draw-circle { - background-position: -92px -2px; -} - -.leaflet-draw-toolbar .leaflet-draw-draw-marker { - background-position: -122px -2px; -} - - -/* ================================================================== */ - - -/* Edit toolbar -/* ================================================================== */ - -.leaflet-draw-toolbar .leaflet-draw-edit-edit { - background-position: -152px -2px; -} - -.leaflet-draw-toolbar .leaflet-draw-edit-remove { - background-position: -182px -2px; -} - -.leaflet-draw-toolbar .leaflet-draw-edit-edit.leaflet-disabled { - background-position: -212px -2px; -} - -.leaflet-draw-toolbar .leaflet-draw-edit-remove.leaflet-disabled { - background-position: -242px -2px; -} - - -/* ================================================================== */ - - -/* Drawing styles -/* ================================================================== */ - -.leaflet-mouse-marker { - background-color: #fff; - cursor: crosshair; -} - -.leaflet-draw-tooltip { - background: rgb(54, 54, 54); - background: rgba(0, 0, 0, 0.5); - border: 1px solid transparent; - -webkit-border-radius: 4px; - border-radius: 4px; - color: #fff; - font: 12px/18px "Helvetica Neue", Arial, Helvetica, sans-serif; - margin-left: 20px; - margin-top: -21px; - padding: 4px 8px; - position: absolute; - visibility: hidden; - white-space: nowrap; - z-index: 6; -} - -.leaflet-draw-tooltip:before { - border-right: 6px solid black; - border-right-color: rgba(0, 0, 0, 0.5); - border-top: 6px solid transparent; - border-bottom: 6px solid transparent; - content: ""; - position: absolute; - top: 7px; - left: -7px; -} - -.leaflet-error-draw-tooltip { - background-color: #F2DEDE; - border: 1px solid #E6B6BD; - color: #B94A48; -} - -.leaflet-error-draw-tooltip:before { - border-right-color: #E6B6BD; -} - -.leaflet-draw-tooltip-single { - margin-top: -12px -} - -.leaflet-draw-tooltip-subtext { - color: #f8d5e4; -} - -.leaflet-draw-guide-dash { - font-size: 1%; - opacity: 0.6; - position: absolute; - width: 5px; - height: 5px; -} - - -/* ================================================================== */ - - -/* Edit styles -/* ================================================================== */ - -.leaflet-edit-marker-selected { - background: rgba(254, 87, 161, 0.1); - border: 4px dashed rgba(254, 87, 161, 0.6); - -webkit-border-radius: 4px; - border-radius: 4px; -} - -.leaflet-edit-move { - cursor: move; -} - -.leaflet-edit-resize { - cursor: pointer; -} - - -/* ================================================================== */ - - -/* Old IE styles -/* ================================================================== */ - -.leaflet-oldie .leaflet-draw-toolbar { - border: 3px solid #999; -} - -.leaflet-oldie .leaflet-draw-toolbar a { - background-color: #eee; -} - -.leaflet-oldie .leaflet-draw-toolbar a:hover { - background-color: #fff; -} - -.leaflet-oldie .leaflet-draw-actions { - left: 32px; - margin-top: 3px; -} - -.leaflet-oldie .leaflet-draw-actions li { - display: inline; - zoom: 1; -} - -.leaflet-oldie .leaflet-edit-marker-selected { - border: 4px dashed #fe93c2; -} - -.leaflet-oldie .leaflet-draw-actions a { - background-color: #999; -} - -.leaflet-oldie .leaflet-draw-actions a:hover { - background-color: #a5a5a5; -} - -.leaflet-oldie .leaflet-draw-actions-top a { - margin-top: 1px; -} - -.leaflet-oldie .leaflet-draw-actions-bottom a { - height: 28px; - line-height: 28px; -} - -.leaflet-oldie .leaflet-draw-actions-top.leaflet-draw-actions-bottom a { - height: 27px; - line-height: 27px; -} \ No newline at end of file diff --git a/erpnext/public/js/account_tree_grid.js b/erpnext/public/js/account_tree_grid.js index 757f33eecce..413a5ee9719 100644 --- a/erpnext/public/js/account_tree_grid.js +++ b/erpnext/public/js/account_tree_grid.js @@ -14,9 +14,9 @@ // You should have received a copy of the GNU General Public License // along with this program. If not, see . -erpnext.AccountTreeGrid = frappe.views.TreeGridReport.extend({ - init: function(wrapper, title) { - this._super({ +erpnext.AccountTreeGrid = class AccountTreeGrid extends frappe.views.TreeGridReport { + constructor(wrapper, title) { + super({ title: title, parent: $(wrapper).find('.layout-main'), page: wrapper.page, @@ -33,8 +33,24 @@ erpnext.AccountTreeGrid = frappe.views.TreeGridReport.extend({ } }, }); - }, - setup_columns: function() { + + this.filters = [ + {fieldtype: "Select", label: __("Company"), link:"Company", fieldname: "company", + default_value: __("Select Company..."), + filter: function(val, item, opts, me) { + if (item.company == val || val == opts.default_value) { + return me.apply_zero_filter(val, item, opts, me); + } + return false; + }}, + {fieldtype: "Select", label: "Fiscal Year", link:"Fiscal Year", fieldname: "fiscal_year", + default_value: __("Select Fiscal Year...")}, + {fieldtype: "Date", label: __("From Date"), fieldname: "from_date"}, + {fieldtype: "Label", label: __("To")}, + {fieldtype: "Date", label: __("To Date"), fieldname: "to_date"} + ] + } + setup_columns() { this.columns = [ {id: "name", name: __("Account"), field: "name", width: 300, cssClass: "cell-title"}, {id: "opening_dr", name: __("Opening (Dr)"), field: "opening_dr", width: 100, @@ -50,25 +66,10 @@ erpnext.AccountTreeGrid = frappe.views.TreeGridReport.extend({ {id: "closing_cr", name: __("Closing (Cr)"), field: "closing_cr", width: 100, formatter: this.currency_formatter} ]; + } - }, - filters: [ - {fieldtype: "Select", label: __("Company"), link:"Company", fieldname: "company", - default_value: __("Select Company..."), - filter: function(val, item, opts, me) { - if (item.company == val || val == opts.default_value) { - return me.apply_zero_filter(val, item, opts, me); - } - return false; - }}, - {fieldtype: "Select", label: "Fiscal Year", link:"Fiscal Year", fieldname: "fiscal_year", - default_value: __("Select Fiscal Year...")}, - {fieldtype: "Date", label: __("From Date"), fieldname: "from_date"}, - {fieldtype: "Label", label: __("To")}, - {fieldtype: "Date", label: __("To Date"), fieldname: "to_date"} - ], - setup_filters: function() { - this._super(); + setup_filters() { + super.setup_filters(); var me = this; // default filters this.filter_inputs.fiscal_year.change(function() { @@ -83,8 +84,8 @@ erpnext.AccountTreeGrid = frappe.views.TreeGridReport.extend({ }); me.show_zero_check() if(me.ignore_closing_entry) me.ignore_closing_entry(); - }, - prepare_data: function() { + } + prepare_data() { var me = this; if(!this.primary_data) { // make accounts list @@ -113,12 +114,12 @@ erpnext.AccountTreeGrid = frappe.views.TreeGridReport.extend({ this.set_indent(); this.prepare_balances(); - }, - init_account: function(d) { + } + init_account(d) { this.reset_item_values(d); - }, + } - prepare_balances: function() { + prepare_balances() { var gl = frappe.report_dump.data['GL Entry']; var me = this; @@ -139,8 +140,8 @@ erpnext.AccountTreeGrid = frappe.views.TreeGridReport.extend({ }); this.update_groups(); - }, - update_balances: function(account, posting_date, v) { + } + update_balances(account, posting_date, v) { // opening if (posting_date < this.opening_date || v.is_opening === "Yes") { if (account.report_type === "Profit and Loss" && @@ -161,8 +162,8 @@ erpnext.AccountTreeGrid = frappe.views.TreeGridReport.extend({ var closing_bal = flt(account.opening_dr) - flt(account.opening_cr) + flt(account.debit) - flt(account.credit); this.set_debit_or_credit(account, "closing", closing_bal); - }, - set_debit_or_credit: function(account, field, balance) { + } + set_debit_or_credit(account, field, balance) { if(balance > 0) { account[field+"_dr"] = balance; account[field+"_cr"] = 0; @@ -170,8 +171,8 @@ erpnext.AccountTreeGrid = frappe.views.TreeGridReport.extend({ account[field+"_cr"] = Math.abs(balance); account[field+"_dr"] = 0; } - }, - update_groups: function() { + } + update_groups() { // update groups var me= this; $.each(this.data, function(i, account) { @@ -202,9 +203,9 @@ erpnext.AccountTreeGrid = frappe.views.TreeGridReport.extend({ } } }); - }, + } - set_fiscal_year: function() { + set_fiscal_year() { if (this.opening_date > this.closing_date) { frappe.msgprint(__("Opening Date should be before Closing Date")); return; @@ -223,9 +224,9 @@ erpnext.AccountTreeGrid = frappe.views.TreeGridReport.extend({ frappe.msgprint(__("Opening Date and Closing Date should be within same Fiscal Year")); return; } - }, + } - show_general_ledger: function(account) { + show_general_ledger(account) { frappe.route_options = { account: account, company: this.company, @@ -234,4 +235,4 @@ erpnext.AccountTreeGrid = frappe.views.TreeGridReport.extend({ }; frappe.set_route("query-report", "General Ledger"); } -}); +}; diff --git a/erpnext/public/js/bank-reconciliation-tool.bundle.js b/erpnext/public/js/bank-reconciliation-tool.bundle.js new file mode 100644 index 00000000000..636ef18a518 --- /dev/null +++ b/erpnext/public/js/bank-reconciliation-tool.bundle.js @@ -0,0 +1,3 @@ +import "./bank_reconciliation_tool/data_table_manager"; +import "./bank_reconciliation_tool/number_card"; +import "./bank_reconciliation_tool/dialog_manager"; diff --git a/erpnext/public/js/controllers/buying.js b/erpnext/public/js/controllers/buying.js index 5c9f5d7da43..86dadd36d6e 100644 --- a/erpnext/public/js/controllers/buying.js +++ b/erpnext/public/js/controllers/buying.js @@ -9,14 +9,14 @@ cur_frm.cscript.tax_table = "Purchase Taxes and Charges"; cur_frm.email_field = "contact_email"; -erpnext.buying.BuyingController = erpnext.TransactionController.extend({ - setup: function() { - this._super(); - }, +erpnext.buying.BuyingController = class BuyingController extends erpnext.TransactionController { + setup() { + super.setup(); + } - onload: function(doc, cdt, cdn) { + onload(doc, cdt, cdn) { this.setup_queries(doc, cdt, cdn); - this._super(); + super.onload(); this.frm.set_query('shipping_rule', function() { return { @@ -48,9 +48,9 @@ erpnext.buying.BuyingController = erpnext.TransactionController.extend({ }); } /* eslint-enable */ - }, + } - setup_queries: function(doc, cdt, cdn) { + setup_queries(doc, cdt, cdn) { var me = this; if(this.frm.fields_dict.buying_price_list) { @@ -109,9 +109,9 @@ erpnext.buying.BuyingController = erpnext.TransactionController.extend({ return me.set_query_for_item_tax_template(doc, cdt, cdn) }); } - }, + } - refresh: function(doc) { + refresh(doc) { frappe.dynamic_link = {doc: this.frm.doc, fieldname: 'supplier', doctype: 'Supplier'}; this.frm.toggle_display("supplier_name", @@ -123,10 +123,10 @@ erpnext.buying.BuyingController = erpnext.TransactionController.extend({ } this.toggle_subcontracting_fields(); - this._super(); - }, + super.refresh(); + } - toggle_subcontracting_fields: function() { + toggle_subcontracting_fields() { if (in_list(['Purchase Receipt', 'Purchase Invoice'], this.frm.doc.doctype)) { this.frm.fields_dict.supplied_items.grid.update_docfield_property('consumed_qty', 'read_only', this.frm.doc.__onload && this.frm.doc.__onload.backflush_based_on === 'BOM'); @@ -134,37 +134,37 @@ erpnext.buying.BuyingController = erpnext.TransactionController.extend({ this.frm.set_df_property('supplied_items', 'cannot_add_rows', 1); this.frm.set_df_property('supplied_items', 'cannot_delete_rows', 1); } - }, + } - supplier: function() { + supplier() { var me = this; erpnext.utils.get_party_details(this.frm, null, null, function(){ me.apply_price_list(); }); - }, + } - supplier_address: function() { + supplier_address() { erpnext.utils.get_address_display(this.frm); erpnext.utils.set_taxes_from_address(this.frm, "supplier_address", "supplier_address", "supplier_address"); - }, + } - buying_price_list: function() { + buying_price_list() { this.apply_price_list(); - }, + } - discount_percentage: function(doc, cdt, cdn) { + discount_percentage(doc, cdt, cdn) { var item = frappe.get_doc(cdt, cdn); item.discount_amount = 0.0; this.price_list_rate(doc, cdt, cdn); - }, + } - discount_amount: function(doc, cdt, cdn) { + discount_amount(doc, cdt, cdn) { var item = frappe.get_doc(cdt, cdn); item.discount_percentage = 0.0; this.price_list_rate(doc, cdt, cdn); - }, + } - qty: function(doc, cdt, cdn) { + qty(doc, cdt, cdn) { var item = frappe.get_doc(cdt, cdn); if ((doc.doctype == "Purchase Receipt") || (doc.doctype == "Purchase Invoice" && (doc.update_stock || doc.is_return))) { frappe.model.round_floats_in(item, ["qty", "received_qty"]); @@ -179,22 +179,22 @@ erpnext.buying.BuyingController = erpnext.TransactionController.extend({ item.rejected_qty = flt(item.received_qty - item.qty, precision("rejected_qty", item)); item.received_stock_qty = flt(item.conversion_factor, precision("conversion_factor", item)) * flt(item.received_qty); } - this._super(doc, cdt, cdn); - }, + super.qty(doc, cdt, cdn); + } - batch_no: function(doc, cdt, cdn) { - this._super(doc, cdt, cdn); - }, + batch_no(doc, cdt, cdn) { + super.batch_no(doc, cdt, cdn); + } - received_qty: function(doc, cdt, cdn) { + received_qty(doc, cdt, cdn) { this.calculate_accepted_qty(doc, cdt, cdn) - }, + } - rejected_qty: function(doc, cdt, cdn) { + rejected_qty(doc, cdt, cdn) { this.calculate_accepted_qty(doc, cdt, cdn) - }, + } - calculate_accepted_qty: function(doc, cdt, cdn){ + calculate_accepted_qty(doc, cdt, cdn){ var item = frappe.get_doc(cdt, cdn); frappe.model.round_floats_in(item, ["received_qty", "rejected_qty"]); @@ -202,9 +202,9 @@ erpnext.buying.BuyingController = erpnext.TransactionController.extend({ item.qty = flt(item.received_qty - item.rejected_qty, precision("qty", item)); this.qty(doc, cdt, cdn); - }, + } - validate_negative_quantity: function(cdt, cdn, item, fieldnames){ + validate_negative_quantity(cdt, cdn, item, fieldnames){ if(!item || !fieldnames) { return } var is_negative_qty = false; @@ -217,9 +217,9 @@ erpnext.buying.BuyingController = erpnext.TransactionController.extend({ } return is_negative_qty - }, + } - warehouse: function(doc, cdt, cdn) { + warehouse(doc, cdt, cdn) { var item = frappe.get_doc(cdt, cdn); if(item.item_code && item.warehouse) { return this.frm.call({ @@ -232,9 +232,9 @@ erpnext.buying.BuyingController = erpnext.TransactionController.extend({ } }); } - }, + } - project: function(doc, cdt, cdn) { + project(doc, cdt, cdn) { var item = frappe.get_doc(cdt, cdn); if(item.project) { $.each(this.frm.doc["items"] || [], @@ -245,48 +245,48 @@ erpnext.buying.BuyingController = erpnext.TransactionController.extend({ } }); } - }, + } - rejected_warehouse: function(doc, cdt) { + rejected_warehouse(doc, cdt) { // trigger autofill_warehouse only if parent rejected_warehouse field is triggered if (["Purchase Invoice", "Purchase Receipt"].includes(cdt)) { this.autofill_warehouse(doc.items, "rejected_warehouse", doc.rejected_warehouse); } - }, + } - category: function(doc, cdt, cdn) { + category(doc, cdt, cdn) { // should be the category field of tax table if(cdt != doc.doctype) { this.calculate_taxes_and_totals(); } - }, - add_deduct_tax: function(doc, cdt, cdn) { + } + add_deduct_tax(doc, cdt, cdn) { this.calculate_taxes_and_totals(); - }, + } - set_from_product_bundle: function() { + set_from_product_bundle() { var me = this; this.frm.add_custom_button(__("Product Bundle"), function() { erpnext.buying.get_items_from_product_bundle(me.frm); }, __("Get Items From")); - }, + } - shipping_address: function(){ + shipping_address(){ var me = this; erpnext.utils.get_address_display(this.frm, "shipping_address", "shipping_address_display", true); - }, + } - billing_address: function() { + billing_address() { erpnext.utils.get_address_display(this.frm, "billing_address", "billing_address_display", true); - }, + } - tc_name: function() { + tc_name() { this.get_terms(); - }, + } - update_auto_repeat_reference: function(doc) { + update_auto_repeat_reference(doc) { if (doc.auto_repeat) { frappe.call({ method:"frappe.automation.doctype.auto_repeat.auto_repeat.update_reference", @@ -303,9 +303,9 @@ erpnext.buying.BuyingController = erpnext.TransactionController.extend({ } }) } - }, + } - manufacturer: function(doc, cdt, cdn) { + manufacturer(doc, cdt, cdn) { const row = locals[cdt][cdn]; if(row.manufacturer) { @@ -322,9 +322,9 @@ erpnext.buying.BuyingController = erpnext.TransactionController.extend({ } }); } - }, + } - manufacturer_part_no: function(doc, cdt, cdn) { + manufacturer_part_no(doc, cdt, cdn) { const row = locals[cdt][cdn]; if (row.manufacturer_part_no) { @@ -347,7 +347,7 @@ erpnext.buying.BuyingController = erpnext.TransactionController.extend({ } } -}); +}; cur_frm.add_fetch('project', 'cost_center', 'cost_center'); @@ -508,4 +508,4 @@ erpnext.buying.get_items_from_product_bundle = function(frm) { }); dialog.show(); -} \ No newline at end of file +} diff --git a/erpnext/public/js/controllers/stock_controller.js b/erpnext/public/js/controllers/stock_controller.js index 87b21b78de8..d346357a8f8 100644 --- a/erpnext/public/js/controllers/stock_controller.js +++ b/erpnext/public/js/controllers/stock_controller.js @@ -3,22 +3,22 @@ frappe.provide("erpnext.stock"); -erpnext.stock.StockController = frappe.ui.form.Controller.extend({ - onload: function() { +erpnext.stock.StockController = class StockController extends frappe.ui.form.Controller { + onload() { // warehouse query if company if (this.frm.fields_dict.company) { this.setup_warehouse_query(); } - }, + } - setup_warehouse_query: function() { + setup_warehouse_query() { var me = this; erpnext.queries.setup_queries(this.frm, "Warehouse", function() { return erpnext.queries.warehouse(me.frm.doc); }); - }, + } - setup_posting_date_time_check: function() { + setup_posting_date_time_check() { // make posting date default and read only unless explictly checked frappe.ui.form.on(this.frm.doctype, 'set_posting_date_and_time_read_only', function(frm) { if(frm.doc.docstatus == 0 && frm.doc.set_posting_time) { @@ -46,9 +46,9 @@ erpnext.stock.StockController = frappe.ui.form.Controller.extend({ frm.trigger('set_posting_date_and_time_read_only'); } }); - }, + } - show_stock_ledger: function() { + show_stock_ledger() { var me = this; if(this.frm.doc.docstatus > 0) { cur_frm.add_custom_button(__("Stock Ledger"), function() { @@ -63,9 +63,9 @@ erpnext.stock.StockController = frappe.ui.form.Controller.extend({ }, __("View")); } - }, + } - show_general_ledger: function() { + show_general_ledger() { var me = this; if(this.frm.doc.docstatus > 0) { cur_frm.add_custom_button(__('Accounting Ledger'), function() { @@ -81,4 +81,4 @@ erpnext.stock.StockController = frappe.ui.form.Controller.extend({ }, __("View")); } } -}); +}; diff --git a/erpnext/public/js/controllers/taxes_and_totals.js b/erpnext/public/js/controllers/taxes_and_totals.js index 1de9ec1a7df..0471704c015 100644 --- a/erpnext/public/js/controllers/taxes_and_totals.js +++ b/erpnext/public/js/controllers/taxes_and_totals.js @@ -1,12 +1,12 @@ // Copyright (c) 2015, Frappe Technologies Pvt. Ltd. and Contributors // License: GNU General Public License v3. See license.txt -erpnext.taxes_and_totals = erpnext.payments.extend({ - setup: function() { +erpnext.taxes_and_totals = class TaxesAndTotals extends erpnext.payments { + setup() { this.fetch_round_off_accounts(); - }, + } - apply_pricing_rule_on_item: function(item) { + apply_pricing_rule_on_item(item) { let effective_item_rate = item.price_list_rate; let item_rate = item.rate; if (in_list(["Sales Order", "Quotation"], item.parenttype) && item.blanket_order_rate) { @@ -32,9 +32,9 @@ erpnext.taxes_and_totals = erpnext.payments.extend({ } frappe.model.set_value(item.doctype, item.name, "rate", item_rate); - }, + } - calculate_taxes_and_totals: function(update_paid_amount) { + calculate_taxes_and_totals(update_paid_amount) { this.discount_amount_applied = false; this._calculate_taxes_and_totals(); this.calculate_discount_amount(); @@ -63,16 +63,16 @@ erpnext.taxes_and_totals = erpnext.payments.extend({ } this.frm.refresh_fields(); - }, + } - calculate_discount_amount: function(){ + calculate_discount_amount(){ if (frappe.meta.get_docfield(this.frm.doc.doctype, "discount_amount")) { this.set_discount_amount(); this.apply_discount_amount(); } - }, + } - _calculate_taxes_and_totals: function() { + _calculate_taxes_and_totals() { frappe.run_serially([ () => this.validate_conversion_rate(), () => this.calculate_item_values(), @@ -85,9 +85,9 @@ erpnext.taxes_and_totals = erpnext.payments.extend({ () => this.calculate_totals(), () => this._cleanup() ]); - }, + } - validate_conversion_rate: function() { + validate_conversion_rate() { this.frm.doc.conversion_rate = flt(this.frm.doc.conversion_rate, (cur_frm) ? precision("conversion_rate") : 9); var conversion_rate_label = frappe.meta.get_label(this.frm.doc.doctype, "conversion_rate", this.frm.doc.name); @@ -102,9 +102,9 @@ erpnext.taxes_and_totals = erpnext.payments.extend({ frappe.throw(err_message); } } - }, + } - calculate_item_values: function() { + calculate_item_values() { var me = this; if (!this.discount_amount_applied) { $.each(this.frm.doc["items"] || [], function(i, item) { @@ -124,16 +124,16 @@ erpnext.taxes_and_totals = erpnext.payments.extend({ me.set_in_company_currency(item, ["price_list_rate", "rate", "amount", "net_rate", "net_amount"]); }); } - }, + } - set_in_company_currency: function(doc, fields) { + set_in_company_currency(doc, fields) { var me = this; $.each(fields, function(i, f) { doc["base_"+f] = flt(flt(doc[f], precision(f, doc)) * me.frm.doc.conversion_rate, precision("base_" + f, doc)); }); - }, + } - initialize_taxes: function() { + initialize_taxes() { var me = this; $.each(this.frm.doc["taxes"] || [], function(i, tax) { @@ -155,9 +155,9 @@ erpnext.taxes_and_totals = erpnext.payments.extend({ } frappe.model.round_floats_in(tax); }); - }, + } - fetch_round_off_accounts: function() { + fetch_round_off_accounts() { let me = this; frappe.flags.round_off_applicable_accounts = []; @@ -168,14 +168,16 @@ erpnext.taxes_and_totals = erpnext.payments.extend({ "company": me.frm.doc.company, "account_list": frappe.flags.round_off_applicable_accounts }, - callback: function(r) { - frappe.flags.round_off_applicable_accounts.push(...r.message); + callback(r) { + if (r.message) { + frappe.flags.round_off_applicable_accounts.push(...r.message); + } } }); } - }, + } - determine_exclusive_rate: function() { + determine_exclusive_rate() { var me = this; var has_inclusive_tax = false; @@ -213,9 +215,9 @@ erpnext.taxes_and_totals = erpnext.payments.extend({ me.set_in_company_currency(item, ["net_rate", "net_amount"]); } }); - }, + } - get_current_tax_fraction: function(tax, item_tax_map) { + get_current_tax_fraction(tax, item_tax_map) { // Get tax fraction for calculating tax exclusive amount // from tax inclusive amount var current_tax_fraction = 0.0; @@ -244,14 +246,14 @@ erpnext.taxes_and_totals = erpnext.payments.extend({ inclusive_tax_amount_per_qty *= -1; } return [current_tax_fraction, inclusive_tax_amount_per_qty]; - }, + } - _get_tax_rate: function(tax, item_tax_map) { + _get_tax_rate(tax, item_tax_map) { return (Object.keys(item_tax_map).indexOf(tax.account_head) != -1) ? flt(item_tax_map[tax.account_head], precision("rate", tax)) : tax.rate; - }, + } - calculate_net_total: function() { + calculate_net_total() { var me = this; this.frm.doc.total_qty = this.frm.doc.total = this.frm.doc.base_total = this.frm.doc.net_total = this.frm.doc.base_net_total = 0.0; @@ -264,9 +266,9 @@ erpnext.taxes_and_totals = erpnext.payments.extend({ }); frappe.model.round_floats_in(this.frm.doc, ["total", "base_total", "net_total", "base_net_total"]); - }, + } - update_item_tax_map: function() { + update_item_tax_map() { let me = this; let item_codes = []; let item_rates = {}; @@ -304,9 +306,9 @@ erpnext.taxes_and_totals = erpnext.payments.extend({ } }); } - }, + } - add_taxes_from_item_tax_template: function(item_tax_map) { + add_taxes_from_item_tax_template(item_tax_map) { let me = this; if (item_tax_map && cint(frappe.defaults.get_default("add_taxes_from_item_tax_template"))) { @@ -324,9 +326,9 @@ erpnext.taxes_and_totals = erpnext.payments.extend({ } }); } - }, + } - calculate_taxes: function() { + calculate_taxes() { var me = this; this.frm.doc.rounding_adjustment = 0; var actual_tax_dict = {}; @@ -405,9 +407,9 @@ erpnext.taxes_and_totals = erpnext.payments.extend({ } }); }); - }, + } - set_cumulative_total: function(row_idx, tax) { + set_cumulative_total(row_idx, tax) { var tax_amount = tax.tax_amount_after_discount_amount; if (tax.category == 'Valuation') { tax_amount = 0; @@ -420,13 +422,13 @@ erpnext.taxes_and_totals = erpnext.payments.extend({ } else { tax.total = flt(this.frm.doc["taxes"][row_idx-1].total + tax_amount, precision("total", tax)); } - }, + } - _load_item_tax_rate: function(item_tax_rate) { + _load_item_tax_rate(item_tax_rate) { return item_tax_rate ? JSON.parse(item_tax_rate) : {}; - }, + } - get_current_tax_amount: function(item, tax, item_tax_map) { + get_current_tax_amount(item, tax, item_tax_map) { var tax_rate = this._get_tax_rate(tax, item_tax_map); var current_tax_amount = 0.0; @@ -462,9 +464,9 @@ erpnext.taxes_and_totals = erpnext.payments.extend({ this.set_item_wise_tax(item, tax, tax_rate, current_tax_amount); return current_tax_amount; - }, + } - set_item_wise_tax: function(item, tax, tax_rate, current_tax_amount) { + set_item_wise_tax(item, tax, tax_rate, current_tax_amount) { // store tax breakup for each item let tax_detail = tax.item_wise_tax_detail; let key = item.item_code || item.item_name; @@ -479,9 +481,9 @@ erpnext.taxes_and_totals = erpnext.payments.extend({ item_wise_tax_amount += tax_detail[key][1]; tax_detail[key] = [tax_rate, flt(item_wise_tax_amount, precision("base_tax_amount", tax))]; - }, + } - round_off_totals: function(tax) { + round_off_totals(tax) { if (frappe.flags.round_off_applicable_accounts.includes(tax.account_head)) { tax.tax_amount= Math.round(tax.tax_amount); tax.tax_amount_after_discount_amount = Math.round(tax.tax_amount_after_discount_amount); @@ -489,16 +491,16 @@ erpnext.taxes_and_totals = erpnext.payments.extend({ tax.tax_amount = flt(tax.tax_amount, precision("tax_amount", tax)); tax.tax_amount_after_discount_amount = flt(tax.tax_amount_after_discount_amount, precision("tax_amount", tax)); - }, + } - round_off_base_values: function(tax) { + round_off_base_values(tax) { if (frappe.flags.round_off_applicable_accounts.includes(tax.account_head)) { tax.base_tax_amount= Math.round(tax.base_tax_amount); tax.base_tax_amount_after_discount_amount = Math.round(tax.base_tax_amount_after_discount_amount); } - }, + } - manipulate_grand_total_for_inclusive_tax: function() { + manipulate_grand_total_for_inclusive_tax() { var me = this; // if fully inclusive taxes and diff if (this.frm.doc["taxes"] && this.frm.doc["taxes"].length) { @@ -529,10 +531,10 @@ erpnext.taxes_and_totals = erpnext.payments.extend({ } } } - }, + } - calculate_totals: function() { - // Changing sequence can because of rounding adjustment issue and on-screen discrepancy + calculate_totals() { + // Changing sequence can cause rounding_adjustmentng issue and on-screen discrepency var me = this; var tax_count = this.frm.doc["taxes"] ? this.frm.doc["taxes"].length : 0; this.frm.doc.grand_total = flt(tax_count @@ -577,9 +579,9 @@ erpnext.taxes_and_totals = erpnext.payments.extend({ // rounded totals this.set_rounded_total(); - }, + } - set_rounded_total: function() { + set_rounded_total() { var disable_rounded_total = 0; if(frappe.meta.get_docfield(this.frm.doc.doctype, "disable_rounded_total", this.frm.doc.name)) { disable_rounded_total = this.frm.doc.disable_rounded_total; @@ -601,9 +603,9 @@ erpnext.taxes_and_totals = erpnext.payments.extend({ this.set_in_company_currency(this.frm.doc, ["rounding_adjustment", "rounded_total"]); } - }, + } - _cleanup: function() { + _cleanup() { this.frm.doc.base_in_words = this.frm.doc.in_words = ""; if(this.frm.doc["items"] && this.frm.doc["items"].length) { @@ -632,16 +634,16 @@ erpnext.taxes_and_totals = erpnext.payments.extend({ } this.frm.refresh_fields(); - }, + } - set_discount_amount: function() { + set_discount_amount() { if(this.frm.doc.additional_discount_percentage) { this.frm.doc.discount_amount = flt(flt(this.frm.doc[frappe.scrub(this.frm.doc.apply_discount_on)]) * this.frm.doc.additional_discount_percentage / 100, precision("discount_amount")); } - }, + } - apply_discount_amount: function() { + apply_discount_amount() { var me = this; var distributed_amount = 0.0; this.frm.doc.base_discount_amount = 0.0; @@ -679,9 +681,9 @@ erpnext.taxes_and_totals = erpnext.payments.extend({ this._calculate_taxes_and_totals(); } } - }, + } - get_total_for_discount_amount: function() { + get_total_for_discount_amount() { if(this.frm.doc.apply_discount_on == "Net Total") { return this.frm.doc.net_total; } else { @@ -705,27 +707,27 @@ erpnext.taxes_and_totals = erpnext.payments.extend({ return flt(this.frm.doc.grand_total - total_actual_tax, precision("grand_total")); } - }, + } - calculate_total_advance: function(update_paid_amount) { + calculate_total_advance(update_paid_amount) { var total_allocated_amount = frappe.utils.sum($.map(this.frm.doc["advances"] || [], function(adv) { return flt(adv.allocated_amount, precision("allocated_amount", adv)); })); this.frm.doc.total_advance = flt(total_allocated_amount, precision("total_advance")); this.calculate_outstanding_amount(update_paid_amount); - }, + } - is_internal_invoice: function() { + is_internal_invoice() { if (['Sales Invoice', 'Purchase Invoice'].includes(this.frm.doc.doctype)) { if (this.frm.doc.company === this.frm.doc.represents_company) { return true; } } return false; - }, + } - calculate_outstanding_amount: function(update_paid_amount) { + calculate_outstanding_amount(update_paid_amount) { // NOTE: // paid_amount and write_off_amount is only for POS/Loyalty Point Redemption Invoice // total_advance is only for non POS Invoice @@ -773,9 +775,9 @@ erpnext.taxes_and_totals = erpnext.payments.extend({ this.frm.doc.outstanding_amount = flt(total_amount_to_pay - flt(paid_amount) + flt(this.frm.doc.change_amount * this.frm.doc.conversion_rate), precision("outstanding_amount")); } - }, + } - update_paid_amount_for_return: function() { + update_paid_amount_for_return() { var grand_total = this.frm.doc.rounded_total || this.frm.doc.grand_total; if(this.frm.doc.party_account_currency == this.frm.doc.currency) { @@ -799,9 +801,9 @@ erpnext.taxes_and_totals = erpnext.payments.extend({ this.frm.refresh_fields(); this.calculate_paid_amount(); - }, + } - set_default_payment: function(total_amount_to_pay, update_paid_amount) { + set_default_payment(total_amount_to_pay, update_paid_amount) { var me = this; var payment_status = true; if(this.frm.doc.is_pos && (update_paid_amount===undefined || update_paid_amount)) { @@ -817,9 +819,9 @@ erpnext.taxes_and_totals = erpnext.payments.extend({ } }); } - }, + } - calculate_paid_amount: function() { + calculate_paid_amount() { var me = this; var paid_amount = 0.0; var base_paid_amount = 0.0; @@ -839,9 +841,9 @@ erpnext.taxes_and_totals = erpnext.payments.extend({ this.frm.set_value('paid_amount', flt(paid_amount, precision("paid_amount"))); this.frm.set_value('base_paid_amount', flt(base_paid_amount, precision("base_paid_amount"))); - }, + } - calculate_change_amount: function(){ + calculate_change_amount(){ this.frm.doc.change_amount = 0.0; this.frm.doc.base_change_amount = 0.0; if(in_list(["Sales Invoice", "POS Invoice"], this.frm.doc.doctype) @@ -860,9 +862,9 @@ erpnext.taxes_and_totals = erpnext.payments.extend({ precision("base_change_amount")); } } - }, + } - calculate_write_off_amount: function(){ + calculate_write_off_amount(){ if(this.frm.doc.paid_amount > this.frm.doc.grand_total){ this.frm.doc.write_off_amount = flt(this.frm.doc.grand_total - this.frm.doc.paid_amount + this.frm.doc.change_amount, precision("write_off_amount")); @@ -874,4 +876,4 @@ erpnext.taxes_and_totals = erpnext.payments.extend({ } this.calculate_outstanding_amount(false); } -}); +}; diff --git a/erpnext/public/js/controllers/transaction.js b/erpnext/public/js/controllers/transaction.js index b3af3d67eaa..8360337ef73 100644 --- a/erpnext/public/js/controllers/transaction.js +++ b/erpnext/public/js/controllers/transaction.js @@ -3,9 +3,9 @@ frappe.provide('erpnext.accounts.dimensions'); -erpnext.TransactionController = erpnext.taxes_and_totals.extend({ - setup: function() { - this._super(); +erpnext.TransactionController = class TransactionController extends erpnext.taxes_and_totals { + setup() { + super.setup(); let me = this; frappe.flags.hide_serial_batch_dialog = true; frappe.ui.form.on(this.frm.doctype + " Item", "rate", function(frm, cdt, cdn) { @@ -220,8 +220,8 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ }); } - }, - onload: function() { + } + onload() { var me = this; if(this.frm.doc.__islocal) { @@ -247,15 +247,15 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ } ]); } - }, + } - is_return: function() { + is_return() { if(!this.frm.doc.is_return && this.frm.doc.return_against) { this.frm.set_value('return_against', ''); } - }, + } - setup_quality_inspection: function() { + setup_quality_inspection() { if(!in_list(["Delivery Note", "Sales Invoice", "Purchase Receipt", "Purchase Invoice"], this.frm.doc.doctype)) { return; } @@ -296,9 +296,9 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ } } }); - }, + } - make_payment_request: function() { + make_payment_request() { var me = this; const payment_request_type = (in_list(['Sales Order', 'Sales Invoice'], this.frm.doc.doctype)) ? "Inward" : "Outward"; @@ -320,9 +320,9 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ } } }) - }, + } - onload_post_render: function() { + onload_post_render() { if(this.frm.doc.__islocal && !(this.frm.doc.taxes || []).length && !(this.frm.doc.__onload ? this.frm.doc.__onload.load_after_mapping : false)) { frappe.after_ajax(() => this.apply_default_taxes()); @@ -334,9 +334,9 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ this.setup_item_selector(); this.frm.get_field("items").grid.set_multiple_add("item_code", "qty"); } - }, + } - refresh: function() { + refresh() { erpnext.toggle_naming_series(); erpnext.hide_company(); this.set_dynamic_labels(); @@ -366,9 +366,9 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ .appendTo($input_group); } } - }, + } - scan_barcode: function() { + scan_barcode() { let scan_barcode_field = this.frm.fields_dict["scan_barcode"]; let show_description = function(idx, exist = null) { @@ -440,9 +440,9 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ }); } return false; - }, + } - apply_default_taxes: function() { + apply_default_taxes() { var me = this; var taxes_and_charges_field = frappe.meta.get_docfield(me.frm.doc.doctype, "taxes_and_charges", me.frm.doc.name); @@ -481,22 +481,22 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ } }); } - }, + } - setup_sms: function() { + setup_sms() { var me = this; let blacklist = ['Purchase Invoice', 'BOM']; if(this.frm.doc.docstatus===1 && !in_list(["Lost", "Stopped", "Closed"], this.frm.doc.status) && !blacklist.includes(this.frm.doctype)) { this.frm.page.add_menu_item(__('Send SMS'), function() { me.send_sms(); }); } - }, + } - send_sms: function() { + send_sms() { var sms_man = new erpnext.SMSManager(this.frm.doc); - }, + } - barcode: function(doc, cdt, cdn) { + barcode(doc, cdt, cdn) { var d = locals[cdt][cdn]; if(d.barcode=="" || d.barcode==null) { // barcode cleared, remove item @@ -505,9 +505,9 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ this.frm.from_barcode = this.frm.from_barcode ? this.frm.from_barcode + 1 : 1; this.item_code(doc, cdt, cdn); - }, + } - item_code: function(doc, cdt, cdn) { + item_code(doc, cdt, cdn) { var me = this; var item = frappe.get_doc(cdt, cdn); var update_stock = 0, show_batch_dialog = 0; @@ -658,9 +658,9 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ }); } } - }, + } - price_list_rate: function(doc, cdt, cdn) { + price_list_rate(doc, cdt, cdn) { var item = frappe.get_doc(cdt, cdn); frappe.model.round_floats_in(item, ["price_list_rate", "discount_percentage"]); @@ -672,17 +672,17 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ precision("rate", item)); this.calculate_taxes_and_totals(); - }, + } - margin_rate_or_amount: function(doc, cdt, cdn) { + margin_rate_or_amount(doc, cdt, cdn) { // calculated the revised total margin and rate on margin rate changes let item = frappe.get_doc(cdt, cdn); this.apply_pricing_rule_on_item(item); this.calculate_taxes_and_totals(); cur_frm.refresh_fields(); - }, + } - margin_type: function(doc, cdt, cdn) { + margin_type(doc, cdt, cdn) { // calculate the revised total margin and rate on margin type changes let item = frappe.get_doc(cdt, cdn); if (!item.margin_type) { @@ -692,9 +692,9 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ this.calculate_taxes_and_totals(); cur_frm.refresh_fields(); } - }, + } - get_incoming_rate: function(item, posting_date, posting_time, voucher_type, company) { + get_incoming_rate(item, posting_date, posting_time, voucher_type, company) { let item_args = { 'item_code': item.item_code, @@ -717,9 +717,29 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ frappe.model.set_value(item.doctype, item.name, 'rate', r.message * item.conversion_factor); } }); - }, + } - serial_no: function(doc, cdt, cdn) { + add_taxes_from_item_tax_template(item_tax_map) { + let me = this; + + if(item_tax_map && cint(frappe.defaults.get_default("add_taxes_from_item_tax_template"))) { + if(typeof (item_tax_map) == "string") { + item_tax_map = JSON.parse(item_tax_map); + } + + $.each(item_tax_map, function(tax, rate) { + let found = (me.frm.doc.taxes || []).find(d => d.account_head === tax); + if(!found) { + let child = frappe.model.add_child(me.frm.doc, "taxes"); + child.charge_type = "On Net Total"; + child.account_head = tax; + child.rate = 0; + } + }); + } + } + + serial_no(doc, cdt, cdn) { var me = this; var item = frappe.get_doc(cdt, cdn); @@ -743,9 +763,9 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ } } } - }, + } - update_qty: function(cdt, cdn) { + update_qty(cdt, cdn) { var valid_serial_nos = []; var serialnos = []; var item = frappe.get_doc(cdt, cdn); @@ -758,17 +778,17 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ frappe.model.set_value(item.doctype, item.name, "qty", valid_serial_nos.length / item.conversion_factor); frappe.model.set_value(item.doctype, item.name, "stock_qty", valid_serial_nos.length); - }, + } - validate: function() { + validate() { this.calculate_taxes_and_totals(false); - }, + } - update_stock: function() { + update_stock() { this.frm.trigger('set_default_internal_warehouse'); - }, + } - set_default_internal_warehouse: function() { + set_default_internal_warehouse() { let me = this; if ((this.frm.doc.doctype === 'Sales Invoice' && me.frm.doc.update_stock) || this.frm.doc.doctype == 'Delivery Note') { @@ -787,9 +807,9 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ }); } } - }, + } - company: function() { + company() { var me = this; var set_pricing = function() { if(me.frm.doc.company && me.frm.fields_dict.currency) { @@ -893,16 +913,16 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ if(this.frm.doc.company) { erpnext.last_selected_company = this.frm.doc.company; } - }, + } - transaction_date: function() { + transaction_date() { if (this.frm.doc.transaction_date) { this.frm.transaction_date = this.frm.doc.transaction_date; frappe.ui.form.trigger(this.frm.doc.doctype, "currency"); } - }, + } - posting_date: function() { + posting_date() { var me = this; if (this.frm.doc.posting_date) { this.frm.posting_date = this.frm.doc.posting_date; @@ -931,9 +951,9 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ frappe.ui.form.trigger(me.frm.doc.doctype, "currency"); } } - }, + } - due_date: function() { + due_date() { // due_date is to be changed, payment terms template and/or payment schedule must // be removed as due_date is automatically changed based on payment terms if (this.frm.doc.due_date && !this.frm.updating_party_details && !this.frm.doc.is_pos) { @@ -956,13 +976,13 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ frappe.msgprint(final_message); } } - }, + } - bill_date: function() { + bill_date() { this.posting_date(); - }, + } - recalculate_terms: function() { + recalculate_terms() { const doc = this.frm.doc; if (doc.payment_terms_template) { this.payment_terms_template(); @@ -981,17 +1001,17 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ } ); } - }, + } - get_company_currency: function() { + get_company_currency() { return erpnext.get_currency(this.frm.doc.company); - }, + } - contact_person: function() { + contact_person() { erpnext.utils.get_contact_details(this.frm); - }, + } - currency: function() { + currency() { /* manqala 19/09/2016: let the translation date be whichever of the transaction_date or posting_date is available */ var transaction_date = this.frm.doc.transaction_date || this.frm.doc.posting_date; /* end manqala */ @@ -1013,9 +1033,9 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ } else { this.conversion_rate(); } - }, + } - conversion_rate: function() { + conversion_rate() { const me = this.frm; if(this.frm.doc.currency === this.get_company_currency()) { this.frm.set_value("conversion_rate", 1.0); @@ -1035,9 +1055,9 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ } // Make read only if Accounts Settings doesn't allow stale rates this.frm.set_df_property("conversion_rate", "read_only", erpnext.stale_rate_allowed() ? 0 : 1); - }, + } - shipping_rule: function() { + shipping_rule() { var me = this; if(this.frm.doc.shipping_rule) { return this.frm.call({ @@ -1053,9 +1073,9 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ else { me.calculate_taxes_and_totals(); } - }, + } - set_margin_amount_based_on_currency: function(exchange_rate) { + set_margin_amount_based_on_currency(exchange_rate) { if (in_list(["Quotation", "Sales Order", "Delivery Note", "Sales Invoice", "Purchase Invoice", "Purchase Order", "Purchase Receipt"]), this.frm.doc.doctype) { var me = this; $.each(this.frm.doc.items || [], function(i, d) { @@ -1065,9 +1085,9 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ } }); } - }, + } - set_actual_charges_based_on_currency: function(exchange_rate) { + set_actual_charges_based_on_currency(exchange_rate) { var me = this; $.each(this.frm.doc.taxes || [], function(i, d) { if(d.charge_type == "Actual") { @@ -1075,9 +1095,9 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ flt(d.tax_amount) / flt(exchange_rate)); } }); - }, + } - get_exchange_rate: function(transaction_date, from_currency, to_currency, callback) { + get_exchange_rate(transaction_date, from_currency, to_currency, callback) { var args; if (["Quotation", "Sales Order", "Delivery Note", "Sales Invoice"].includes(this.frm.doctype)) { args = "for_selling"; @@ -1101,9 +1121,9 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ callback(flt(r.message)); } }); - }, + } - price_list_currency: function() { + price_list_currency() { var me=this; this.set_dynamic_labels(); @@ -1117,9 +1137,9 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ } else { this.plc_conversion_rate(); } - }, + } - plc_conversion_rate: function() { + plc_conversion_rate() { if(this.frm.doc.price_list_currency === this.get_company_currency()) { this.frm.set_value("plc_conversion_rate", 1.0); } else if(this.frm.doc.price_list_currency === this.frm.doc.currency @@ -1131,9 +1151,9 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ if(!this.in_apply_price_list) { this.apply_price_list(null, true); } - }, + } - uom: function(doc, cdt, cdn) { + uom(doc, cdt, cdn) { var me = this; var item = frappe.get_doc(cdt, cdn); if(item.item_code && item.uom) { @@ -1151,9 +1171,9 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ }); } me.calculate_stock_uom_rate(doc, cdt, cdn); - }, + } - conversion_factor: function(doc, cdt, cdn, dont_fetch_price_list_rate) { + conversion_factor(doc, cdt, cdn, dont_fetch_price_list_rate) { if(frappe.meta.get_docfield(cdt, "stock_qty", cdn)) { var item = frappe.get_doc(cdt, cdn); frappe.model.round_floats_in(item, ["qty", "conversion_factor"]); @@ -1178,35 +1198,35 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ } this.calculate_stock_uom_rate(doc, cdt, cdn); } - }, + } - batch_no: function(doc, cdt, cdn) { + batch_no(doc, cdt, cdn) { let item = frappe.get_doc(cdt, cdn); this.apply_price_list(item, true); - }, + } - toggle_conversion_factor: function(item) { + toggle_conversion_factor(item) { // toggle read only property for conversion factor field if the uom and stock uom are same if(this.frm.get_field('items').grid.fields_map.conversion_factor) { this.frm.fields_dict.items.grid.toggle_enable("conversion_factor", ((item.uom != item.stock_uom) && !frappe.meta.get_docfield(cur_frm.fields_dict.items.grid.doctype, "conversion_factor").read_only)? true: false); } - }, + } - qty: function(doc, cdt, cdn) { + qty(doc, cdt, cdn) { let item = frappe.get_doc(cdt, cdn); this.conversion_factor(doc, cdt, cdn, true); this.calculate_stock_uom_rate(doc, cdt, cdn); this.apply_pricing_rule(item, true); - }, + } - calculate_stock_uom_rate: function(doc, cdt, cdn) { + calculate_stock_uom_rate(doc, cdt, cdn) { let item = frappe.get_doc(cdt, cdn); item.stock_uom_rate = flt(item.rate)/flt(item.conversion_factor); refresh_field("stock_uom_rate", item.name, item.parentfield); - }, - service_stop_date: function(frm, cdt, cdn) { + } + service_stop_date(frm, cdt, cdn) { var child = locals[cdt][cdn]; if(child.service_stop_date) { @@ -1222,9 +1242,9 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ frappe.throw(__("Service Stop Date cannot be after Service End Date")); } } - }, + } - service_start_date: function(frm, cdt, cdn) { + service_start_date(frm, cdt, cdn) { var child = locals[cdt][cdn]; if(child.service_start_date) { @@ -1236,9 +1256,9 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ } }) } - }, + } - calculate_net_weight: function(){ + calculate_net_weight(){ /* Calculate Total Net Weight then further applied shipping rule to calculate shipping charges.*/ var me = this; this.frm.doc.total_net_weight= 0.0; @@ -1248,9 +1268,9 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ }); refresh_field("total_net_weight"); this.shipping_rule(); - }, + } - set_dynamic_labels: function() { + set_dynamic_labels() { // What TODO? should we make price list system non-mandatory? this.frm.toggle_reqd("plc_conversion_rate", !!(this.frm.doc.price_list_name && this.frm.doc.price_list_currency)); @@ -1259,9 +1279,9 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ this.change_form_labels(company_currency); this.change_grid_labels(company_currency); this.frm.refresh_fields(); - }, + } - change_form_labels: function(company_currency) { + change_form_labels(company_currency) { var me = this; this.frm.set_currency_labels(["base_total", "base_net_total", "base_total_taxes_and_charges", @@ -1308,9 +1328,9 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ if(frappe.meta.get_docfield(cur_frm.doctype, "base_net_total")) cur_frm.toggle_display("base_net_total", (show && (me.frm.doc.currency != company_currency))); - }, + } - change_grid_labels: function(company_currency) { + change_grid_labels(company_currency) { var me = this; this.update_item_grid_labels(company_currency); @@ -1351,9 +1371,9 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ } this.update_payment_schedule_grid_labels(company_currency); - }, + } - update_item_grid_labels: function(company_currency) { + update_item_grid_labels(company_currency) { this.frm.set_currency_labels([ "base_rate", "base_net_rate", "base_price_list_rate", "base_amount", "base_net_amount", "base_rate_with_margin" @@ -1363,9 +1383,9 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ "rate", "net_rate", "price_list_rate", "amount", "net_amount", "stock_uom_rate", "rate_with_margin" ], this.frm.doc.currency, "items"); - }, + } - update_payment_schedule_grid_labels: function(company_currency) { + update_payment_schedule_grid_labels(company_currency) { const me = this; if (this.frm.doc.payment_schedule && this.frm.doc.payment_schedule.length > 0) { this.frm.set_currency_labels(["base_payment_amount", "base_outstanding", "base_paid_amount"], @@ -1379,9 +1399,9 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ schedule_grid.set_column_disp(fname, me.frm.doc.currency != company_currency); }); } - }, + } - toggle_item_grid_columns: function(company_currency) { + toggle_item_grid_columns(company_currency) { const me = this; // toggle columns var item_grid = this.frm.fields_dict["items"].grid; @@ -1402,21 +1422,21 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ if(frappe.meta.get_docfield(item_grid.doctype, fname)) item_grid.set_column_disp(fname, (show && (me.frm.doc.currency != company_currency))); }); - }, + } - recalculate: function() { + recalculate() { this.calculate_taxes_and_totals(); - }, + } - recalculate_values: function() { + recalculate_values() { this.calculate_taxes_and_totals(); - }, + } - calculate_charges: function() { + calculate_charges() { this.calculate_taxes_and_totals(); - }, + } - ignore_pricing_rule: function() { + ignore_pricing_rule() { if(this.frm.doc.ignore_pricing_rule) { var me = this; var item_list = []; @@ -1450,9 +1470,9 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ } else { this.apply_pricing_rule(); } - }, + } - apply_pricing_rule: function(item, calculate_taxes_and_totals) { + apply_pricing_rule(item, calculate_taxes_and_totals) { var me = this; var args = this._get_args(item); if (!(args.items && args.items.length)) { @@ -1471,9 +1491,9 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ } } }); - }, + } - _get_args: function(item) { + _get_args(item) { var me = this; return { "items": this._get_item_list(item), @@ -1501,9 +1521,9 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ "pos_profile": me.frm.doc.doctype == 'Sales Invoice' ? me.frm.doc.pos_profile : '', "coupon_code": me.frm.doc.coupon_code }; - }, + } - _get_item_list: function(item) { + _get_item_list(item) { var item_list = []; var append_item = function(d) { if (d.item_code) { @@ -1544,9 +1564,9 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ }); } return item_list; - }, + } - _set_values_for_item_list: function(children) { + _set_values_for_item_list(children) { var me = this; var price_list_rate_changed = false; var items_rule_dict = {}; @@ -1586,9 +1606,9 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ me.apply_rule_on_other_items(items_rule_dict); if(!price_list_rate_changed) me.calculate_taxes_and_totals(); - }, + } - apply_rule_on_other_items: function(args) { + apply_rule_on_other_items(args) { const me = this; const fields = ["discount_percentage", "pricing_rules", "discount_amount", "rate"]; @@ -1607,9 +1627,9 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ }); } } - }, + } - apply_product_discount: function(args) { + apply_product_discount(args) { const items = this.frm.doc.items.filter(d => (d.is_free_item)) || []; const exist_items = items.map(row => (row.item_code, row.pricing_rules)); @@ -1634,9 +1654,9 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ // free_item_data is a temporary variable args.free_item_data = ''; refresh_field('items'); - }, + } - apply_price_list: function(item, reset_plc_conversion) { + apply_price_list(item, reset_plc_conversion) { // We need to reset plc_conversion_rate sometimes because the call to // `erpnext.stock.get_item_details.apply_price_list` is sensitive to its value if (!reset_plc_conversion) { @@ -1675,9 +1695,9 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ }).always(() => { me.in_apply_price_list = false; }); - }, + } - remove_pricing_rule: function(item) { + remove_pricing_rule(item) { let me = this; const fields = ["discount_percentage", "discount_amount", "margin_rate_or_amount", "rate_with_margin"]; @@ -1711,18 +1731,18 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ me.trigger_price_list_rate(); } - }, + } - trigger_price_list_rate: function() { + trigger_price_list_rate() { var me = this; this.frm.doc.items.forEach(child_row => { me.frm.script_manager.trigger("price_list_rate", child_row.doctype, child_row.name); }) - }, + } - validate_company_and_party: function() { + validate_company_and_party() { var me = this; var valid = true; @@ -1737,9 +1757,9 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ } }); return valid; - }, + } - get_terms: function() { + get_terms() { var me = this; erpnext.utils.get_terms(this.frm.doc.tc_name, this.frm.doc, function(r) { @@ -1747,9 +1767,9 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ me.frm.set_value("terms", r.message); } }); - }, + } - taxes_and_charges: function() { + taxes_and_charges() { var me = this; if(this.frm.doc.taxes_and_charges) { return this.frm.call({ @@ -1775,9 +1795,9 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ } }); } - }, + } - tax_category: function() { + tax_category() { var me = this; if(me.frm.updating_party_details) return; @@ -1785,9 +1805,9 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ () => this.update_item_tax_map(), () => erpnext.utils.set_taxes(this.frm, "tax_category"), ]); - }, + } - item_tax_template: function(doc, cdt, cdn) { + item_tax_template(doc, cdt, cdn) { var me = this; if(me.frm.updating_party_details) return; @@ -1812,11 +1832,10 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ item.item_tax_rate = "{}"; me.calculate_taxes_and_totals(); } - }, + } - - is_recurring: function() { + is_recurring() { // set default values for recurring documents if(this.frm.doc.is_recurring && this.frm.doc.__islocal) { frappe.msgprint(__("Please set recurring after saving")); @@ -1839,9 +1858,9 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ } refresh_many(["notification_email_address", "repeat_on_day_of_month"]); - }, + } - from_date: function() { + from_date() { // set to_date if(this.frm.doc.from_date) { var recurring_type_map = {'Monthly': 1, 'Quarterly': 3, 'Half-yearly': 6, @@ -1855,25 +1874,25 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ refresh_field('to_date'); } } - }, + } - set_gross_profit: function(item) { + set_gross_profit(item) { if (["Sales Order", "Quotation"].includes(this.frm.doc.doctype) && item.valuation_rate) { var rate = flt(item.rate) * flt(this.frm.doc.conversion_rate || 1); item.gross_profit = flt(((rate - item.valuation_rate) * item.stock_qty), precision("amount", item)); } - }, + } - setup_item_selector: function() { + setup_item_selector() { // TODO: remove item selector return; // if(!this.item_selector) { // this.item_selector = new erpnext.ItemSelector({frm: this.frm}); // } - }, + } - get_advances: function() { + get_advances() { if(!this.frm.is_return) { return this.frm.call({ method: "set_advances", @@ -1883,9 +1902,9 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ } }) } - }, + } - make_payment_entry: function() { + make_payment_entry() { return frappe.call({ method: cur_frm.cscript.get_method_for_payment(), args: { @@ -1898,9 +1917,9 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ // cur_frm.refresh_fields() } }); - }, + } - make_quality_inspection: function () { + make_quality_inspection() { let data = []; const fields = [ { @@ -2022,9 +2041,9 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ } else { dialog.show(); } - }, + } - get_method_for_payment: function(){ + get_method_for_payment() { var method = "erpnext.accounts.doctype.payment_entry.payment_entry.get_payment_entry"; if(cur_frm.doc.__onload && cur_frm.doc.__onload.make_payment_via_journal_entry){ if(in_list(['Sales Invoice', 'Purchase Invoice'], cur_frm.doc.doctype)){ @@ -2035,9 +2054,9 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ } return method - }, + } - set_query_for_batch: function(doc, cdt, cdn) { + set_query_for_batch(doc, cdt, cdn) { // Show item's batches in the dropdown of batch no var me = this; @@ -2067,9 +2086,9 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ filters: filters } } - }, + } - set_query_for_item_tax_template: function(doc, cdt, cdn) { + set_query_for_item_tax_template(doc, cdt, cdn) { var item = frappe.get_doc(cdt, cdn); if(!item.item_code) { return doc.company ? {filters: {company: doc.company}} : {}; @@ -2089,9 +2108,9 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ filters: filters } } - }, + } - payment_terms_template: function() { + payment_terms_template() { var me = this; const doc = this.frm.doc; if(doc.payment_terms_template && doc.doctype !== 'Delivery Note') { @@ -2114,9 +2133,9 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ } }) } - }, + } - payment_term: function(doc, cdt, cdn) { + payment_term(doc, cdt, cdn) { const me = this; var row = locals[cdt][cdn]; if(row.payment_term) { @@ -2140,17 +2159,17 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ } }) } - }, + } - against_blanket_order: function(doc, cdt, cdn) { + against_blanket_order(doc, cdt, cdn) { var item = locals[cdt][cdn]; if(!item.against_blanket_order) { frappe.model.set_value(this.frm.doctype + " Item", item.name, "blanket_order", null); frappe.model.set_value(this.frm.doctype + " Item", item.name, "blanket_order_rate", 0.00); } - }, + } - blanket_order: function(doc, cdt, cdn) { + blanket_order(doc, cdt, cdn) { var me = this; var item = locals[cdt][cdn]; if (item.blanket_order && (item.parenttype=="Sales Order" || item.parenttype=="Purchase Order")) { @@ -2178,34 +2197,34 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ } }) } - }, + } - set_reserve_warehouse: function() { + set_reserve_warehouse() { this.autofill_warehouse(this.frm.doc.supplied_items, "reserve_warehouse", this.frm.doc.set_reserve_warehouse); - }, + } - set_warehouse: function() { + set_warehouse() { this.autofill_warehouse(this.frm.doc.items, "warehouse", this.frm.doc.set_warehouse); - }, + } - set_target_warehouse: function() { + set_target_warehouse() { this.autofill_warehouse(this.frm.doc.items, "target_warehouse", this.frm.doc.set_target_warehouse); - }, + } - set_from_warehouse: function() { + set_from_warehouse() { this.autofill_warehouse(this.frm.doc.items, "from_warehouse", this.frm.doc.set_from_warehouse); - }, + } - autofill_warehouse : function (child_table, warehouse_field, warehouse) { + autofill_warehouse(child_table, warehouse_field, warehouse) { if (warehouse && child_table && child_table.length) { let doctype = child_table[0].doctype; $.each(child_table || [], function(i, item) { frappe.model.set_value(doctype, item.name, warehouse_field, warehouse); }); } - }, + } - coupon_code: function() { + coupon_code() { var me = this; frappe.run_serially([ () => this.frm.doc.ignore_pricing_rule=1, @@ -2214,7 +2233,7 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ () => me.apply_pricing_rule() ]); } -}); +}; erpnext.show_serial_batch_selector = function (frm, d, callback, on_close, show_dialog) { let warehouse, receiving_stock, existing_stock; diff --git a/erpnext/public/js/erpnext-web.bundle.js b/erpnext/public/js/erpnext-web.bundle.js new file mode 100644 index 00000000000..7db69679236 --- /dev/null +++ b/erpnext/public/js/erpnext-web.bundle.js @@ -0,0 +1,2 @@ +import "./website_utils"; +import "./shopping_cart"; diff --git a/erpnext/public/js/erpnext.bundle.js b/erpnext/public/js/erpnext.bundle.js new file mode 100644 index 00000000000..519cfcac72b --- /dev/null +++ b/erpnext/public/js/erpnext.bundle.js @@ -0,0 +1,27 @@ +import "./conf"; +import "./utils"; +import "./queries"; +import "./sms_manager"; +import "./utils/party"; +import "./controllers/stock_controller"; +import "./payment/payments"; +import "./controllers/taxes_and_totals"; +import "./controllers/transaction"; +import "./templates/item_selector.html"; +import "./templates/employees_to_mark_attendance.html"; +import "./utils/item_selector"; +import "./help_links"; +import "./agriculture/ternary_plot"; +import "./templates/item_quick_entry.html"; +import "./utils/item_quick_entry"; +import "./utils/customer_quick_entry"; +import "./education/student_button.html"; +import "./education/assessment_result_tool.html"; +import "./hub/hub_factory"; +import "./call_popup/call_popup"; +import "./utils/dimension_tree_filter"; +import "./telephony"; +import "./templates/call_link.html"; + +// import { sum } from 'frappe/public/utils/util.js' + diff --git a/erpnext/public/js/hub/hub_factory.js b/erpnext/public/js/hub/hub_factory.js index 8dab2d62510..9c67c1cf9f0 100644 --- a/erpnext/public/js/hub/hub_factory.js +++ b/erpnext/public/js/hub/hub_factory.js @@ -19,11 +19,7 @@ frappe.views.MarketplaceFactory = class MarketplaceFactory extends frappe.views. } make(page_name) { - const assets = [ - '/assets/js/marketplace.min.js' - ]; - - frappe.require(assets, () => { + frappe.require('marketplace.bundle.js', () => { erpnext.hub.marketplace = new erpnext.hub.Marketplace({ parent: this.make_page(true, page_name) }); diff --git a/erpnext/public/js/hub/marketplace.js b/erpnext/public/js/hub/marketplace.bundle.js similarity index 100% rename from erpnext/public/js/hub/marketplace.js rename to erpnext/public/js/hub/marketplace.bundle.js diff --git a/erpnext/public/js/item-dashboard.bundle.js b/erpnext/public/js/item-dashboard.bundle.js new file mode 100644 index 00000000000..2d329e26aa0 --- /dev/null +++ b/erpnext/public/js/item-dashboard.bundle.js @@ -0,0 +1,5 @@ +import "../../stock/dashboard/item_dashboard.html"; +import "../../stock/dashboard/item_dashboard_list.html"; +import "../../stock/dashboard/item_dashboard.js"; +import "../../stock/page/warehouse_capacity_summary/warehouse_capacity_summary.html"; +import "../../stock/page/warehouse_capacity_summary/warehouse_capacity_summary_header.html"; diff --git a/erpnext/public/js/payment/payments.js b/erpnext/public/js/payment/payments.js index ddf87068097..4c23669dbbb 100644 --- a/erpnext/public/js/payment/payments.js +++ b/erpnext/public/js/payment/payments.js @@ -1,8 +1,8 @@ // Copyright (c) 2015, Frappe Technologies Pvt. Ltd. and Contributors // License: GNU General Public License v3. See license.txt -erpnext.payments = erpnext.stock.StockController.extend({ - make_payment: function() { +erpnext.payments = class payments extends erpnext.stock.StockController { + make_payment() { var me = this; this.dialog = new frappe.ui.Dialog({ @@ -14,15 +14,15 @@ erpnext.payments = erpnext.stock.StockController.extend({ this.set_payment_primary_action(); this.make_keyboard(); this.select_text(); - }, + } select_text() { $(this.$body).find('.form-control').click(function() { $(this).select(); }); - }, + } - set_payment_primary_action: function() { + set_payment_primary_action() { var me = this; this.dialog.set_primary_action(__("Submit"), function() { @@ -35,18 +35,18 @@ erpnext.payments = erpnext.stock.StockController.extend({ } }); }) - }, + } - make_keyboard: function() { + make_keyboard(){ var me = this; $(this.$body).empty(); $(this.$body).html(frappe.render_template('pos_payment', this.frm.doc)) this.show_payment_details(); - this.bind_keyboard_event(); - this.clear_amount(); - }, + this.bind_keyboard_event() + this.clear_amount() + } - make_multimode_payment: function() { + make_multimode_payment(){ var me = this; if (this.frm.doc.change_amount > 0) { @@ -56,9 +56,9 @@ erpnext.payments = erpnext.stock.StockController.extend({ this.payments = frappe.model.add_child(this.frm.doc, 'Multi Mode Payment', "payments"); this.payments.mode_of_payment = this.dialog.fields_dict.mode_of_payment.get_value(); this.payments.amount = flt(this.payment_val); - }, + } - show_payment_details: function() { + show_payment_details(){ var me = this; var multimode_payments = $(this.$body).find('.multimode-payments').empty(); if (this.frm.doc.payments.length) { @@ -81,9 +81,9 @@ erpnext.payments = erpnext.stock.StockController.extend({ }else{ $("

No payment mode selected in pos profile

").appendTo(multimode_payments) } - }, + } - set_outstanding_amount: function() { + set_outstanding_amount(){ this.selected_mode = $(this.$body).find(repl("input[idx='%(idx)s']",{'idx': this.idx})); this.highlight_selected_row(); this.payment_val = 0.0; @@ -98,15 +98,16 @@ erpnext.payments = erpnext.stock.StockController.extend({ } this.selected_mode.select() this.bind_amount_change_event(); - }, + } - bind_keyboard_event() { + bind_keyboard_event(){ + var me = this; this.payment_val = ''; this.bind_form_control_event(); this.bind_numeric_keys_event(); - }, + } - bind_form_control_event: function() { + bind_form_control_event() { var me = this; $(this.$body).find('.pos-payment-row').click(function() { me.idx = $(this).attr("idx"); @@ -126,7 +127,7 @@ erpnext.payments = erpnext.stock.StockController.extend({ $(this.$body).find('.change_amount').change(function() { me.change_amount(flt($(this).val()), precision("change_amount")); }); - }, + } highlight_selected_row() { var selected_row = $(this.$body).find(repl(".pos-payment-row[idx='%(idx)s']", {'idx': this.idx})); @@ -134,9 +135,9 @@ erpnext.payments = erpnext.stock.StockController.extend({ selected_row.addClass('selected-payment-mode'); $(this.$body).find('.amount').attr('disabled', true); this.selected_mode.attr('disabled', false); - }, + } - bind_numeric_keys_event: function() { + bind_numeric_keys_event() { var me = this; $(this.$body).find('.pos-keyboard-key').click(function(){ me.payment_val += $(this).text(); @@ -152,7 +153,7 @@ erpnext.payments = erpnext.stock.StockController.extend({ me.update_paid_amount(); }) - }, + } bind_amount_change_event() { var me = this; @@ -162,9 +163,9 @@ erpnext.payments = erpnext.stock.StockController.extend({ me.idx = me.selected_mode.attr("idx"); me.update_payment_amount(); }); - }, + } - clear_amount: function() { + clear_amount() { var me = this; $(this.$body).find('.clr').click(function(e) { e.stopPropagation(); @@ -175,7 +176,7 @@ erpnext.payments = erpnext.stock.StockController.extend({ me.highlight_selected_row(); me.update_payment_amount(); }); - }, + } write_off_amount(write_off_amount) { this.frm.doc.write_off_amount = flt(write_off_amount, precision("write_off_amount")); @@ -183,17 +184,17 @@ erpnext.payments = erpnext.stock.StockController.extend({ precision("base_write_off_amount")); this.calculate_outstanding_amount(false); this.show_amounts(); - }, + } - change_amount: function(change_amount) { + change_amount(change_amount) { var me = this; this.frm.doc.change_amount = flt(change_amount, precision("change_amount")); this.calculate_write_off_amount(); this.show_amounts(); - }, + } - update_paid_amount: function(update_write_off) { + update_paid_amount(update_write_off) { var me = this; if (in_list(['change_amount', 'write_off_amount'], this.idx)) { var value = me.selected_mode.val(); @@ -208,9 +209,9 @@ erpnext.payments = erpnext.stock.StockController.extend({ } else { this.update_payment_amount(); } - }, + } - update_payment_amount: function() { + update_payment_amount(){ var me = this; $.each(this.frm.doc.payments, function(index, data) { @@ -221,9 +222,9 @@ erpnext.payments = erpnext.stock.StockController.extend({ this.calculate_outstanding_amount(false); this.show_amounts(); - }, + } - show_amounts: function() { + show_amounts(){ var me = this; $(this.$body).find(".write_off_amount").val(format_currency(this.frm.doc.write_off_amount, this.frm.doc.currency)); $(this.$body).find('.paid_amount').text(format_currency(this.frm.doc.paid_amount, this.frm.doc.currency)); @@ -231,4 +232,4 @@ erpnext.payments = erpnext.stock.StockController.extend({ $(this.$body).find('.outstanding_amount').text(format_currency(this.frm.doc.outstanding_amount, frappe.get_doc(":Company", this.frm.doc.company).default_currency)); this.update_invoice(); } -}) \ No newline at end of file +} diff --git a/erpnext/public/js/point-of-sale.bundle.js b/erpnext/public/js/point-of-sale.bundle.js new file mode 100644 index 00000000000..fbc4bbbbb36 --- /dev/null +++ b/erpnext/public/js/point-of-sale.bundle.js @@ -0,0 +1,8 @@ +import "../../selling/page/point_of_sale/pos_item_selector.js"; +import "../../selling/page/point_of_sale/pos_item_cart.js"; +import "../../selling/page/point_of_sale/pos_item_details.js"; +import "../../selling/page/point_of_sale/pos_number_pad.js"; +import "../../selling/page/point_of_sale/pos_payment.js"; +import "../../selling/page/point_of_sale/pos_past_order_list.js"; +import "../../selling/page/point_of_sale/pos_past_order_summary.js"; +import "../../selling/page/point_of_sale/pos_controller.js"; diff --git a/erpnext/public/js/stock_analytics.js b/erpnext/public/js/stock_analytics.js index 140c9dc90b6..dfe2c88ea82 100644 --- a/erpnext/public/js/stock_analytics.js +++ b/erpnext/public/js/stock_analytics.js @@ -2,8 +2,8 @@ // License: GNU General Public License v3. See license.txt -erpnext.StockAnalytics = erpnext.StockGridReport.extend({ - init: function(wrapper, opts) { +erpnext.StockAnalytics = class StockAnalytics extends erpnext.StockGridReport { + constructor(wrapper, opts) { var args = { title: __("Stock Analytics"), parent: $(wrapper).find('.layout-main'), @@ -30,9 +30,33 @@ erpnext.StockAnalytics = erpnext.StockGridReport.extend({ if(opts) $.extend(args, opts); - this._super(args); - }, - setup_columns: function() { + super(args); + + this.filters = [ + {fieldtype:"Select", label: __("Value or Qty"), fieldname: "value_or_qty", + options:[{label:__("Value"), value:"Value"}, {label:__("Quantity"), value:"Quantity"}], + filter: function(val, item, opts, me) { + return me.apply_zero_filter(val, item, opts, me); + }}, + {fieldtype:"Select", label: __("Brand"), link:"Brand", fieldname: "brand", + default_value: __("Select Brand..."), filter: function(val, item, opts) { + return val == opts.default_value || item.brand == val || item._show; + }, link_formatter: {filter_input: "brand"}}, + {fieldtype:"Select", label: __("Warehouse"), link:"Warehouse", fieldname: "warehouse", + default_value: __("Select Warehouse...")}, + {fieldtype:"Date", label: __("From Date"), fieldname: "from_date"}, + {fieldtype:"Date", label: __("To Date"), fieldname: "to_date"}, + {fieldtype:"Select", label: __("Range"), fieldname: "range", + options:[ + {label:__("Daily"), value:"Daily"}, + {label:__("Weekly"), value:"Weekly"}, + {label:__("Monthly"), value:"Monthly"}, + {label:__("Quarterly"), value:"Quarterly"}, + {label:__("Yearly"), value:"Yearly"}, + ]} + ]; + } + setup_columns() { var std_columns = [ {id: "name", name: __("Item"), field: "name", width: 300}, {id: "brand", name: __("Brand"), field: "brand", width: 100}, @@ -43,43 +67,21 @@ erpnext.StockAnalytics = erpnext.StockGridReport.extend({ this.make_date_range_columns(); this.columns = std_columns.concat(this.columns); - }, - filters: [ - {fieldtype:"Select", label: __("Value or Qty"), fieldname: "value_or_qty", - options:[{label:__("Value"), value:"Value"}, {label:__("Quantity"), value:"Quantity"}], - filter: function(val, item, opts, me) { - return me.apply_zero_filter(val, item, opts, me); - }}, - {fieldtype:"Select", label: __("Brand"), link:"Brand", fieldname: "brand", - default_value: __("Select Brand..."), filter: function(val, item, opts) { - return val == opts.default_value || item.brand == val || item._show; - }, link_formatter: {filter_input: "brand"}}, - {fieldtype:"Select", label: __("Warehouse"), link:"Warehouse", fieldname: "warehouse", - default_value: __("Select Warehouse...")}, - {fieldtype:"Date", label: __("From Date"), fieldname: "from_date"}, - {fieldtype:"Date", label: __("To Date"), fieldname: "to_date"}, - {fieldtype:"Select", label: __("Range"), fieldname: "range", - options:[ - {label:__("Daily"), value:"Daily"}, - {label:__("Weekly"), value:"Weekly"}, - {label:__("Monthly"), value:"Monthly"}, - {label:__("Quarterly"), value:"Quarterly"}, - {label:__("Yearly"), value:"Yearly"}, - ]} - ], - setup_filters: function() { + } + + setup_filters() { var me = this; - this._super(); + super.setup_filters(); this.trigger_refresh_on_change(["value_or_qty", "brand", "warehouse", "range"]); this.show_zero_check(); - }, - init_filter_values: function() { - this._super(); + } + init_filter_values() { + super.init_filter_values(); this.filter_inputs.range && this.filter_inputs.range.val('Monthly'); - }, - prepare_data: function() { + } + prepare_data() { var me = this; if(!this.data) { @@ -112,8 +114,8 @@ erpnext.StockAnalytics = erpnext.StockGridReport.extend({ this.prepare_balances(); this.update_groups(); - }, - prepare_balances: function() { + } + prepare_balances() { var me = this; var from_date = frappe.datetime.str_to_obj(this.from_date); var to_date = frappe.datetime.str_to_obj(this.to_date); @@ -164,8 +166,8 @@ erpnext.StockAnalytics = erpnext.StockGridReport.extend({ item.closing_qty_value += diff; } } - }, - update_groups: function() { + } + update_groups() { var me = this; $.each(this.data, function(i, item) { // update groups @@ -192,8 +194,8 @@ erpnext.StockAnalytics = erpnext.StockGridReport.extend({ } } }); - }, - show_stock_ledger: function(item_code) { + } + show_stock_ledger(item_code) { frappe.route_options = { item_code: item_code, from_date: this.from_date, @@ -201,5 +203,5 @@ erpnext.StockAnalytics = erpnext.StockGridReport.extend({ }; frappe.set_route("query-report", "Stock Ledger"); } -}); +}; diff --git a/erpnext/public/js/stock_grid_report.js b/erpnext/public/js/stock_grid_report.js index 832fd3eccf6..752fafdb971 100644 --- a/erpnext/public/js/stock_grid_report.js +++ b/erpnext/public/js/stock_grid_report.js @@ -1,16 +1,16 @@ // Copyright (c) 2015, Frappe Technologies Pvt. Ltd. and Contributors // License: GNU General Public License v3. See license.txt -erpnext.StockGridReport = frappe.views.TreeGridReport.extend({ - get_item_warehouse: function(warehouse, item) { +erpnext.StockGridReport = class StockGridReport extends frappe.views.TreeGridReport { + get_item_warehouse(warehouse, item) { if(!this.item_warehouse[item]) this.item_warehouse[item] = {}; if(!this.item_warehouse[item][warehouse]) this.item_warehouse[item][warehouse] = { balance_qty: 0.0, balance_value: 0.0, fifo_stack: [] }; return this.item_warehouse[item][warehouse]; - }, + } - get_value_diff: function(wh, sl, is_fifo) { + get_value_diff(wh, sl, is_fifo) { // value if(sl.qty > 0) { // incoming - rate is given @@ -59,8 +59,8 @@ erpnext.StockGridReport = frappe.views.TreeGridReport.extend({ wh.balance_qty += sl.qty; wh.balance_value += value_diff; return value_diff; - }, - get_fifo_value_diff: function(wh, sl) { + } + get_fifo_value_diff(wh, sl) { // get exact rate from fifo stack var fifo_stack = (wh.fifo_stack || []).reverse(); var fifo_value_diff = 0.0; @@ -89,9 +89,9 @@ erpnext.StockGridReport = frappe.views.TreeGridReport.extend({ // reset the updated stack wh.fifo_stack = fifo_stack.reverse(); return -fifo_value_diff; - }, + } - get_serialized_value_diff: function(sl) { + get_serialized_value_diff(sl) { var me = this; var value_diff = 0.0; @@ -103,9 +103,9 @@ erpnext.StockGridReport = frappe.views.TreeGridReport.extend({ }); return value_diff; - }, + } - get_serialized_buying_rates: function() { + get_serialized_buying_rates() { var serialized_buying_rates = {}; if (frappe.report_dump.data["Serial No"]) { @@ -115,5 +115,5 @@ erpnext.StockGridReport = frappe.views.TreeGridReport.extend({ } return serialized_buying_rates; - }, -}); + } +}; diff --git a/erpnext/public/js/telephony.js b/erpnext/public/js/telephony.js index 9548d6c5f36..1c3e3147976 100644 --- a/erpnext/public/js/telephony.js +++ b/erpnext/public/js/telephony.js @@ -1,19 +1,19 @@ -frappe.ui.form.ControlData = frappe.ui.form.ControlData.extend( { +frappe.ui.form.ControlData = class ControlData extends frappe.ui.form.ControlData { make_input() { - this._super(); + super.make_input(); if (this.df.options == 'Phone') { this.setup_phone(); } if (this.frm && this.frm.fields_dict) { Object.values(this.frm.fields_dict).forEach(function(field) { - if (field.df.read_only === 1 && field.df.options === 'Phone' + if (field.df.read_only === 1 && field.df.options === 'Phone' && field.disp_area.style[0] != 'display' && !field.has_icon) { field.setup_phone(); field.has_icon = true; } }); } - }, + } setup_phone() { if (frappe.phone_call.handler) { let control = this.df.read_only ? '.control-value' : '.control-input'; @@ -30,4 +30,4 @@ frappe.ui.form.ControlData = frappe.ui.form.ControlData.extend( { }); } } -}); +}; diff --git a/erpnext/public/js/utils.js b/erpnext/public/js/utils.js index ce40ced11f2..db7c034596a 100755 --- a/erpnext/public/js/utils.js +++ b/erpnext/public/js/utils.js @@ -749,6 +749,151 @@ $(document).on('app_ready', function() { } }); +// Show SLA dashboard +$(document).on('app_ready', function() { + frappe.call({ + method: 'erpnext.support.doctype.service_level_agreement.service_level_agreement.get_sla_doctypes', + callback: function(r) { + if (!r.message) + return; + + $.each(r.message, function(_i, d) { + frappe.ui.form.on(d, { + onload: function(frm) { + if (!frm.doc.service_level_agreement) + return; + + frappe.call({ + method: 'erpnext.support.doctype.service_level_agreement.service_level_agreement.get_service_level_agreement_filters', + args: { + doctype: frm.doc.doctype, + name: frm.doc.service_level_agreement, + customer: frm.doc.customer + }, + callback: function (r) { + if (r && r.message) { + frm.set_query('priority', function() { + return { + filters: { + 'name': ['in', r.message.priority], + } + }; + }); + frm.set_query('service_level_agreement', function() { + return { + filters: { + 'name': ['in', r.message.service_level_agreements], + } + }; + }); + } + } + }); + }, + + refresh: function(frm) { + if (frm.doc.status !== 'Closed' && frm.doc.service_level_agreement + && frm.doc.agreement_status === 'Ongoing') { + frappe.call({ + 'method': 'frappe.client.get', + args: { + doctype: 'Service Level Agreement', + name: frm.doc.service_level_agreement + }, + callback: function(data) { + let statuses = data.message.pause_sla_on; + const hold_statuses = []; + $.each(statuses, (_i, entry) => { + hold_statuses.push(entry.status); + }); + if (hold_statuses.includes(frm.doc.status)) { + frm.dashboard.clear_headline(); + let message = {'indicator': 'orange', 'msg': __('SLA is on hold since {0}', [moment(frm.doc.on_hold_since).fromNow(true)])}; + frm.dashboard.set_headline_alert( + '
' + + '
' + + ''+ message.msg +' ' + + '
' + + '
' + ); + } else { + set_time_to_resolve_and_response(frm, data.message.apply_sla_for_resolution); + } + } + }); + } else if (frm.doc.service_level_agreement) { + frm.dashboard.clear_headline(); + + let agreement_status = (frm.doc.agreement_status == 'Fulfilled') ? + {'indicator': 'green', 'msg': 'Service Level Agreement has been fulfilled'} : + {'indicator': 'red', 'msg': 'Service Level Agreement Failed'}; + + frm.dashboard.set_headline_alert( + '
' + + '
' + + ' ' + + '
' + + '
' + ); + } + }, + }); + }); + } + }); +}); + +function set_time_to_resolve_and_response(frm, apply_sla_for_resolution) { + frm.dashboard.clear_headline(); + + let time_to_respond = get_status(frm.doc.response_by_variance); + if (!frm.doc.first_responded_on && frm.doc.agreement_status === 'Ongoing') { + time_to_respond = get_time_left(frm.doc.response_by, frm.doc.agreement_status); + } + + let alert = ` +
+
+ + Time to Respond: ${time_to_respond.diff_display} + +
`; + + + if (apply_sla_for_resolution) { + let time_to_resolve = get_status(frm.doc.resolution_by_variance); + if (!frm.doc.resolution_date && frm.doc.agreement_status === 'Ongoing') { + time_to_resolve = get_time_left(frm.doc.resolution_by, frm.doc.agreement_status); + } + + alert += ` +
+ + Time to Resolve: ${time_to_resolve.diff_display} + +
`; + } + + alert += '
'; + + frm.dashboard.set_headline_alert(alert); +} + +function get_time_left(timestamp, agreement_status) { + const diff = moment(timestamp).diff(moment()); + const diff_display = diff >= 44500 ? moment.duration(diff).humanize() : 'Failed'; + let indicator = (diff_display == 'Failed' && agreement_status != 'Fulfilled') ? 'red' : 'green'; + return {'diff_display': diff_display, 'indicator': indicator}; +} + +function get_status(variance) { + if (variance > 0) { + return {'diff_display': 'Fulfilled', 'indicator': 'green'}; + } else { + return {'diff_display': 'Failed', 'indicator': 'red'}; + } +} + function attach_selector_button(inner_text, append_loction, context, grid_row) { let $btn_div = $("
").css({"margin-bottom": "10px", "margin-top": "10px"}) .appendTo(append_loction); diff --git a/erpnext/public/js/utils/customer_quick_entry.js b/erpnext/public/js/utils/customer_quick_entry.js index ebe6cd98f81..efb8dd9d5ca 100644 --- a/erpnext/public/js/utils/customer_quick_entry.js +++ b/erpnext/public/js/utils/customer_quick_entry.js @@ -1,17 +1,17 @@ frappe.provide('frappe.ui.form'); -frappe.ui.form.CustomerQuickEntryForm = frappe.ui.form.QuickEntryForm.extend({ - init: function(doctype, after_insert) { +frappe.ui.form.CustomerQuickEntryForm = class CustomerQuickEntryForm extends frappe.ui.form.QuickEntryForm { + constructor(doctype, after_insert) { + super(doctype, after_insert); this.skip_redirect_on_error = true; - this._super(doctype, after_insert); - }, + } - render_dialog: function() { + render_dialog() { this.mandatory = this.mandatory.concat(this.get_variant_fields()); - this._super(); - }, + super.render_dialog(); + } - get_variant_fields: function() { + get_variant_fields() { var variant_fields = [{ fieldtype: "Section Break", label: __("Primary Contact Details"), @@ -77,5 +77,5 @@ frappe.ui.form.CustomerQuickEntryForm = frappe.ui.form.QuickEntryForm.extend({ }]; return variant_fields; - }, -}) \ No newline at end of file + } +} diff --git a/erpnext/public/js/utils/item_quick_entry.js b/erpnext/public/js/utils/item_quick_entry.js index 27ef107acef..7e0198d33b3 100644 --- a/erpnext/public/js/utils/item_quick_entry.js +++ b/erpnext/public/js/utils/item_quick_entry.js @@ -1,27 +1,27 @@ frappe.provide('frappe.ui.form'); -frappe.ui.form.ItemQuickEntryForm = frappe.ui.form.QuickEntryForm.extend({ - init: function(doctype, after_insert) { - this._super(doctype, after_insert); - }, +frappe.ui.form.ItemQuickEntryForm = class ItemQuickEntryForm extends frappe.ui.form.QuickEntryForm { + constructor(doctype, after_insert) { + super(doctype, after_insert); + } - render_dialog: function() { + render_dialog() { this.mandatory = this.get_variant_fields().concat(this.mandatory); this.mandatory = this.mandatory.concat(this.get_attributes_fields()); this.check_naming_series_based_on(); - this._super(); + super.render_dialog(); this.init_post_render_dialog_operations(); this.preset_fields_for_template(); this.dialog.$wrapper.find('.edit-full').text(__('Edit in full page for more options like assets, serial nos, batches etc.')) - }, + } - check_naming_series_based_on: function() { + check_naming_series_based_on() { if (frappe.defaults.get_default("item_naming_by") === "Naming Series") { this.mandatory = this.mandatory.filter(d => d.fieldname !== "item_code"); } - }, + } - init_post_render_dialog_operations: function() { + init_post_render_dialog_operations() { this.dialog.fields_dict.attribute_html.$wrapper.append(frappe.render_template("item_quick_entry")); this.init_for_create_variant_trigger(); this.init_for_item_template_trigger(); @@ -29,9 +29,9 @@ frappe.ui.form.ItemQuickEntryForm = frappe.ui.form.QuickEntryForm.extend({ this.toggle_manufacturer_fields(); this.dialog.get_field("item_template").df.hidden = 1; this.dialog.get_field("item_template").refresh(); - }, + } - register_primary_action: function() { + register_primary_action() { var me = this; this.dialog.set_primary_action(__('Save'), function() { if (me.dialog.working) return; @@ -59,9 +59,9 @@ frappe.ui.form.ItemQuickEntryForm = frappe.ui.form.QuickEntryForm.extend({ me.insert(variant_values); } }); - }, + } - insert: function(variant_values) { + insert(variant_values) { let me = this; return new Promise(resolve => { frappe.call({ @@ -94,9 +94,9 @@ frappe.ui.form.ItemQuickEntryForm = frappe.ui.form.QuickEntryForm.extend({ freeze: true }); }); - }, + } - open_doc: function() { + open_doc() { this.dialog.hide(); this.update_doc(); if (this.dialog.fields_dict.create_variant.$input.prop("checked")) { @@ -106,9 +106,9 @@ frappe.ui.form.ItemQuickEntryForm = frappe.ui.form.QuickEntryForm.extend({ } else { frappe.set_route('Form', this.doctype, this.doc.name); } - }, + } - get_variant_fields: function() { + get_variant_fields() { var variant_fields = [{ fieldname: "create_variant", fieldtype: "Check", @@ -130,9 +130,9 @@ frappe.ui.form.ItemQuickEntryForm = frappe.ui.form.QuickEntryForm.extend({ }]; return variant_fields; - }, + } - get_manufacturing_fields: function() { + get_manufacturing_fields() { this.manufacturer_fields = [{ fieldtype: 'Link', options: 'Manufacturer', @@ -148,9 +148,9 @@ frappe.ui.form.ItemQuickEntryForm = frappe.ui.form.QuickEntryForm.extend({ reqd: 0 }]; return this.manufacturer_fields; - }, + } - get_attributes_fields: function() { + get_attributes_fields() { var attribute_fields = [{ fieldname: 'attribute_html', fieldtype: 'HTML' @@ -158,18 +158,18 @@ frappe.ui.form.ItemQuickEntryForm = frappe.ui.form.QuickEntryForm.extend({ attribute_fields = attribute_fields.concat(this.get_manufacturing_fields()); return attribute_fields; - }, + } - init_for_create_variant_trigger: function() { + init_for_create_variant_trigger() { var me = this; this.dialog.fields_dict.create_variant.$input.on("click", function() { me.preset_fields_for_template(); me.init_post_template_trigger_operations(false, [], true); }); - }, + } - preset_fields_for_template: function() { + preset_fields_for_template() { var for_variant = this.dialog.get_value('create_variant'); // setup template field, seen and mandatory if variant @@ -195,9 +195,9 @@ frappe.ui.form.ItemQuickEntryForm = frappe.ui.form.QuickEntryForm.extend({ f.refresh(); }); - }, + } - init_for_item_template_trigger: function() { + init_for_item_template_trigger() { var me = this; me.dialog.fields_dict["item_template"].df.onchange = () => { @@ -228,9 +228,9 @@ frappe.ui.form.ItemQuickEntryForm = frappe.ui.form.QuickEntryForm.extend({ me.init_post_template_trigger_operations(false, [], true); } } - }, + } - init_post_template_trigger_operations: function(is_manufacturer, attributes, attributes_flag) { + init_post_template_trigger_operations(is_manufacturer, attributes, attributes_flag) { this.attributes = attributes; this.attribute_values = {}; this.attributes_count = attributes.length; @@ -240,23 +240,23 @@ frappe.ui.form.ItemQuickEntryForm = frappe.ui.form.QuickEntryForm.extend({ this.toggle_manufacturer_fields(); this.dialog.fields_dict.attribute_html.$wrapper.find(".attributes").toggleClass("hide-control", attributes_flag); this.dialog.fields_dict.attribute_html.$wrapper.find(".attributes-header").toggleClass("hide-control", attributes_flag); - }, + } - toggle_manufacturer_fields: function() { + toggle_manufacturer_fields() { var me = this; $.each(this.manufacturer_fields, function(i, dialog_field) { me.dialog.get_field(dialog_field.fieldname).df.hidden = !me.is_manufacturer; me.dialog.get_field(dialog_field.fieldname).df.reqd = dialog_field.fieldname == 'manufacturer' ? me.is_manufacturer : false; me.dialog.get_field(dialog_field.fieldname).refresh(); }); - }, + } - initiate_render_attributes: function() { + initiate_render_attributes() { this.dialog.fields_dict.attribute_html.$wrapper.find(".attributes").empty(); this.render_attributes(this.attributes); - }, + } - render_attributes: function(attributes) { + render_attributes(attributes) { var me = this; this.dialog.get_field('attribute_html').toggle(true); @@ -291,9 +291,9 @@ frappe.ui.form.ItemQuickEntryForm = frappe.ui.form.QuickEntryForm.extend({ }); } }); - }, + } - init_make_control: function(fieldtype, row) { + init_make_control(fieldtype, row) { this[row.attribute] = frappe.ui.form.make_control({ df: { "fieldtype": fieldtype, @@ -305,9 +305,9 @@ frappe.ui.form.ItemQuickEntryForm = frappe.ui.form.QuickEntryForm.extend({ only_input: false }); this[row.attribute].make_input(); - }, + } - init_awesomplete_for_attribute: function(row) { + init_awesomplete_for_attribute(row) { var me = this; this[row.attribute].input.awesomplete = new Awesomplete(this[row.attribute].input, { @@ -343,9 +343,9 @@ frappe.ui.form.ItemQuickEntryForm = frappe.ui.form.QuickEntryForm.extend({ me.attribute_values[$(e.target).attr("data-fieldname")] = e.target.value; $(e.target).closest(".frappe-control").toggleClass("has-error", e.target.value ? false : true); }); - }, + } - get_variant_doc: function() { + get_variant_doc() { var me = this; var variant_doc = {}; var attribute = this.validate_mandatory_attributes(); @@ -381,9 +381,9 @@ frappe.ui.form.ItemQuickEntryForm = frappe.ui.form.QuickEntryForm.extend({ }) } return variant_doc; - }, + } - validate_mandatory_attributes: function() { + validate_mandatory_attributes() { var me = this; var attribute = {}; var mandatory = []; @@ -404,4 +404,4 @@ frappe.ui.form.ItemQuickEntryForm = frappe.ui.form.QuickEntryForm.extend({ } return attribute; } -}); \ No newline at end of file +}; diff --git a/erpnext/public/js/utils/item_selector.js b/erpnext/public/js/utils/item_selector.js index d04c488a59d..9fc264086a3 100644 --- a/erpnext/public/js/utils/item_selector.js +++ b/erpnext/public/js/utils/item_selector.js @@ -1,5 +1,5 @@ -erpnext.ItemSelector = Class.extend({ - init: function(opts) { +erpnext.ItemSelector = class ItemSelector { + constructor(opts) { $.extend(this, opts); if (!this.item_field) { @@ -12,9 +12,9 @@ erpnext.ItemSelector = Class.extend({ this.grid = this.frm.get_field("items").grid; this.setup(); - }, + } - setup: function() { + setup() { var me = this; if(!this.grid.add_items_button) { this.grid.add_items_button = this.grid.add_custom_button(__('Add Items'), function() { @@ -26,9 +26,9 @@ erpnext.ItemSelector = Class.extend({ setTimeout(function() { me.dialog.input.focus(); }, 1000); }); } - }, + } - make_dialog: function() { + make_dialog() { this.dialog = new frappe.ui.Dialog({ title: __('Add Items') }); @@ -53,9 +53,9 @@ erpnext.ItemSelector = Class.extend({ me.timeout_id = undefined; }, 500); }); - }, + } - add_item: function(item_code) { + add_item(item_code) { // add row or update qty var added = false; @@ -82,9 +82,9 @@ erpnext.ItemSelector = Class.extend({ ]); } - }, + } - render_items: function() { + render_items() { let args = { query: this.item_query, filters: {} @@ -107,4 +107,4 @@ erpnext.ItemSelector = Class.extend({ me.dialog.results.html(frappe.render_template('item_selector', {'data':r.values})); }); } -}); \ No newline at end of file +}; diff --git a/erpnext/public/js/utils/serial_no_batch_selector.js b/erpnext/public/js/utils/serial_no_batch_selector.js index b5d3981ba7f..597d77c6e9f 100644 --- a/erpnext/public/js/utils/serial_no_batch_selector.js +++ b/erpnext/public/js/utils/serial_no_batch_selector.js @@ -1,6 +1,6 @@ -erpnext.SerialNoBatchSelector = Class.extend({ - init: function(opts, show_dialog) { +erpnext.SerialNoBatchSelector = class SerialNoBatchSelector { + constructor(opts, show_dialog) { $.extend(this, opts); this.show_dialog = show_dialog; // frm, item, warehouse_details, has_batch, oldest @@ -12,16 +12,16 @@ erpnext.SerialNoBatchSelector = Class.extend({ if(d && d.has_serial_no && !(this.show_dialog == false)) this.has_serial_no = 1; this.setup(); - }, + } - setup: function() { + setup() { this.item_code = this.item.item_code; this.qty = this.item.qty; this.make_dialog(); this.on_close_dialog(); - }, + } - make_dialog: function() { + make_dialog() { var me = this; this.data = this.oldest ? this.oldest : []; @@ -186,15 +186,15 @@ erpnext.SerialNoBatchSelector = Class.extend({ } this.dialog.show(); - }, + } - on_close_dialog: function() { + on_close_dialog() { this.dialog.get_close_btn().on('click', () => { this.on_close && this.on_close(this.item); }); - }, + } - validate: function() { + validate() { let values = this.values; if(!values.warehouse) { frappe.throw(__("Please select a warehouse")); @@ -220,7 +220,7 @@ erpnext.SerialNoBatchSelector = Class.extend({ } return true; } - }, + } update_batch_items() { // clones an items if muliple batches are selected. @@ -243,14 +243,14 @@ erpnext.SerialNoBatchSelector = Class.extend({ 'selected_qty', this.values.warehouse); }); } - }, + } update_serial_no_item() { // just updates serial no for the item if(this.has_serial_no && !this.has_batch) { this.map_row_values(this.item, this.values, 'serial_no', 'qty'); } - }, + } update_batch_serial_no_items() { // if serial no selected is from different batches, adds new rows for each batch. @@ -291,14 +291,14 @@ erpnext.SerialNoBatchSelector = Class.extend({ }); }) } - }, + } - batch_exists: function(batch) { + batch_exists(batch) { const batches = this.frm.doc.items.map(data => data.batch_no); return (batches && in_list(batches, batch)) ? true : false; - }, + } - map_row_values: function(row, values, number, qty_field, warehouse) { + map_row_values(row, values, number, qty_field, warehouse) { row.qty = values[qty_field]; row.transfer_qty = flt(values[qty_field]) * flt(row.conversion_factor); row[number] = values[number]; @@ -311,9 +311,9 @@ erpnext.SerialNoBatchSelector = Class.extend({ } this.frm.dirty(); - }, + } - update_total_qty: function() { + update_total_qty() { let qty_field = this.dialog.fields_dict.qty; let total_qty = 0; @@ -322,8 +322,9 @@ erpnext.SerialNoBatchSelector = Class.extend({ }); qty_field.set_input(total_qty); - }, - update_pending_qtys: function() { + } + + update_pending_qtys() { const pending_qty_field = this.dialog.fields_dict.pending_qty; const total_selected_qty_field = this.dialog.fields_dict.total_selected_qty; @@ -337,8 +338,9 @@ erpnext.SerialNoBatchSelector = Class.extend({ pending_qty_field.set_input(pending_qty); total_selected_qty_field.set_input(total_selected_qty); - }, - get_batch_fields: function() { + } + + get_batch_fields() { var me = this; return [ @@ -450,9 +452,9 @@ erpnext.SerialNoBatchSelector = Class.extend({ }, } ]; - }, + } - get_serial_no_fields: function() { + get_serial_no_fields() { var me = this; this.serial_list = []; @@ -535,7 +537,7 @@ erpnext.SerialNoBatchSelector = Class.extend({ } ]; } -}); +}; function get_pending_qty_fields(me) { if (!check_can_calculate_pending_qty(me)) return []; diff --git a/erpnext/public/less/hub.less b/erpnext/public/less/hub.less deleted file mode 100644 index 29deada8a41..00000000000 --- a/erpnext/public/less/hub.less +++ /dev/null @@ -1,375 +0,0 @@ -@import "variables.less"; -@import (reference) "desk.less"; - -body[data-route*="marketplace"] { - .layout-side-section { - padding-top: 25px; - padding-left: 5px; - padding-right: 25px; - } - - [data-route], [data-action] { - cursor: pointer; - } - - .layout-main-section { - border: none; - font-size: @text-medium; - padding-top: 25px; - - @media (max-width: @screen-xs) { - padding-left: 20px; - padding-right: 20px; - } - } - - input, textarea { - font-size: @text-medium; - } - - .hub-image { - height: 200px; - } - - .hub-image-loading, .hub-image-broken { - content: " "; - position: absolute; - left: 0; - height: 100%; - width: 100%; - background-color: var(--bg-light-gray); - display: flex; - align-items: center; - justify-content: center; - - span { - font-size: 32px; - color: @text-extra-muted; - } - } - - .progress-bar { - background-color: #89da28; - } - - .subpage-title.flex { - align-items: flex-start; - justify-content: space-between; - } - - .hub-card { - margin-bottom: 25px; - position: relative; - border: 1px solid @border-color; - border-radius: 4px; - overflow: hidden; - - &:hover .hub-card-overlay { - display: block; - } - } - - .hub-card.is-local { - &.active { - .hub-card-header { - background-color: #f4ffe5; - } - - .octicon-check { - display: inline; - } - } - - .octicon-check { - display: none; - position: absolute; - font-size: 20px; - right: 15px; - top: 50%; - transform: translateY(-50%); - } - } - - .hub-card-header { - position: relative; - padding: 12px 15px; - height: 60px; - border-bottom: 1px solid @border-color; - } - - .hub-card-body { - position: relative; - height: 200px; - } - - .hub-card-overlay { - display: none; - position: absolute; - top: 0; - width: 100%; - height: 100%; - background-color: rgba(0, 0, 0, 0.05); - } - - .hub-card-overlay-body { - position: relative; - height: 100%; - } - - .hub-card-overlay-button { - position: absolute; - right: 15px; - bottom: 15px; - } - - .hub-card-image { - position: relative; - width: 100%; - height: 100%; - object-fit: contain; - } - - .hub-search-container { - margin-bottom: 20px; - - input { - height: 32px; - } - } - - .hub-sidebar { - padding-top: 25px; - padding-right: 15px; - } - - .hub-sidebar-group { - margin-bottom: 10px; - } - - .hub-sidebar-item { - padding: 5px 8px; - margin-bottom: 3px; - border-radius: 4px; - border: 1px solid transparent; - - &.active, &:hover:not(.is-title) { - border-color: @border-color; - } - } - - .hub-item-image { - position: relative; - border: 1px solid @border-color; - border-radius: 4px; - overflow: hidden; - height: 200px; - width: 200px; - display: flex; - align-items: center; - } - - .hub-item-skeleton-image { - border-radius: 4px; - background-color: @light-bg; - overflow: hidden; - height: 200px; - width: 200px; - } - - .hub-skeleton { - background-color: @light-bg; - color: @light-bg; - max-width: 500px; - } - - .hub-item-seller img { - width: 50px; - height: 50px; - border-radius: 4px; - border: 1px solid @border-color; - } - - .register-title { - font-size: @text-regular; - } - - .register-form { - border: 1px solid @border-color; - border-radius: 4px; - padding: 15px 25px; - } - - .publish-area.filled { - .empty-items-container { - display: none; - } - } - - .publish-area.empty { - .hub-items-container { - display: none; - } - } - - .publish-area-head { - display: flex; - justify-content: space-between; - margin-bottom: 20px; - } - - .hub-list-item { - display: flex; - justify-content: space-between; - align-items: center; - border: 1px solid @border-color; - margin-bottom: -1px; - overflow: hidden; - } - - .hub-list-item:first-child { - border-top-left-radius: 4px; - border-top-right-radius: 4px; - } - .hub-list-item:last-child { - border-bottom-left-radius: 4px; - border-bottom-right-radius: 4px; - } - - .hub-list-left { - display: flex; - align-items: center; - max-width: 90%; - } - - .hub-list-right { - padding-right: 15px; - } - - .hub-list-image { - position: relative; - width: 58px; - height: 58px; - border-right: 1px solid @border-color; - - &::after { - font-size: 12px; - } - } - - .hub-list-body { - padding: 12px 15px; - } - - .hub-list-title { - font-weight: bold; - } - - .hub-list-subtitle { - color: @text-muted; - } - - .selling-item-message-card { - max-width: 500px; - margin-bottom: 15px; - border-radius: 3px; - border: 1px solid @border-color; - .selling-item-detail { - overflow: auto; - .item-image { - float: left; - height: 80px; - width: 80px; - object-fit: contain; - margin: 5px; - } - .item-name { - margin-left: 10px; - } - } - .received-message-container { - clear: left; - background-color: @light-bg; - .received-message { - border-top: 1px solid @border-color; - padding: 10px; - } - .frappe-timestamp { - float: right; - } - } - } - - .form-container { - .frappe-control { - max-width: 100% !important; - } - } - - .form-message { - padding-top: 0; - padding-bottom: 0; - border-bottom: none; - } - - .hub-items-container { - .hub-items-header { - justify-content: space-between; - align-items: baseline; - } - } - - .hub-item-container { - overflow: hidden; - } - - .hub-item-review-container { - margin-top: calc(30vh); - } - - .hub-item-dropdown { - margin-top: 20px; - } - - /* messages page */ - - .message-list-item { - display: flex; - align-items: center; - padding: 8px 12px; - - &:not(.active) { - filter: grayscale(1); - color: @text-muted; - } - - &:hover { - background-color: @light-bg; - } - - .list-item-left { - width: 30px; - border-radius: 4px; - overflow: hidden; - margin-right: 15px; - } - - .list-item-body { - font-weight: bold; - padding-bottom: 1px; - } - } - - .message-container { - display: flex; - flex-direction: column; - border: 1px solid @border-color; - border-radius: 3px; - height: calc(100vh - 300px); - justify-content: space-between; - padding: 15px; - } - - .message-list { - overflow: scroll; - } -} diff --git a/erpnext/public/less/pos.less b/erpnext/public/less/pos.less deleted file mode 100644 index b081ed4414b..00000000000 --- a/erpnext/public/less/pos.less +++ /dev/null @@ -1,229 +0,0 @@ -@import "../../../../frappe/frappe/public/less/variables.less"; - -[data-route="point-of-sale"] { - .layout-main-section-wrapper { - margin-bottom: 0; - } - - .pos-items-wrapper { - max-height: ~"calc(100vh - 210px)"; - } -} - -.pos { - // display: flex; - padding: 15px; -} - -.list-item { - min-height: 40px; - height: auto; -} - -.cart-container { - padding: 0 15px; - // flex: 2; - display: inline-block; - width: 39%; - vertical-align: top; -} - -.item-container { - padding: 0 15px; - // flex: 3; - display: inline-block; - width: 60%; - vertical-align: top; -} - -.search-field { - width: 60%; - - input::placeholder { - font-size: @text-medium; - } -} - -.item-group-field { - width: 40%; - margin-left: 15px; -} - -.cart-wrapper { - margin-bottom: 12px; - .list-item__content:not(:first-child) { - justify-content: flex-end; - } - - .list-item--head .list-item__content:nth-child(2) { - flex: 1.5; - } -} - -.cart-items { - height: 150px; - overflow: auto; - - .list-item.current-item { - background-color: @light-yellow; - } - - .list-item.current-item.qty input { - border: 1px solid @brand-primary; - font-weight: bold; - } - - .list-item.current-item.disc .discount { - font-weight: bold; - } - - .list-item.current-item.rate .rate { - font-weight: bold; - } - - .list-item .quantity { - flex: 1.5; - } - - input { - text-align: right; - height: 22px; - font-size: @text-medium; - } -} - -.fields { - display: flex; -} - -.pos-items-wrapper { - max-height: 480px; - overflow-y: auto; -} - -.pos-items { - overflow: hidden; -} - -.pos-item-wrapper { - display: flex; - flex-direction: column; - position: relative; - width: 25%; -} - -.image-view-container { - display: block; -} - -.image-view-container .image-field { - height: auto; -} - -.empty-state { - height: 100%; - position: relative; - - span { - position: absolute; - color: @text-muted; - font-size: @text-medium; - top: 50%; - left: 50%; - transform: translate(-50%, -50%); - } -} - -@keyframes yellow-fade { - 0% {background-color: @light-yellow;} - 100% {background-color: transparent;} -} - -.highlight { - animation: yellow-fade 1s ease-in 1; -} - -input[type=number]::-webkit-inner-spin-button, -input[type=number]::-webkit-outer-spin-button { - -webkit-appearance: none; - margin: 0; -} - -// number pad - -.number-pad { - border-collapse: collapse; - cursor: pointer; - display: table; -} -.num-row { - display: table-row; -} -.num-col { - display: table-cell; - border: 1px solid @border-color; - - & > div { - width: 50px; - height: 50px; - text-align: center; - line-height: 50px; - } - - &.active { - background-color: @light-yellow; - } - - &.brand-primary { - background-color: @brand-primary; - color: #ffffff; - } -} - -// taxes, totals and discount area -.discount-amount { - .discount-inputs { - display: flex; - flex-direction: column; - padding: 15px 0; - } - - input:first-child { - margin-bottom: 10px; - } -} - -.taxes-and-totals { - border-top: 1px solid @border-color; - - .taxes { - display: flex; - flex-direction: column; - padding: 15px 0; - align-items: flex-end; - - & > div:first-child { - margin-bottom: 10px; - } - } -} - -.grand-total { - border-top: 1px solid @border-color; - - .list-item { - height: 60px; - } - - .grand-total-value { - font-size: 18px; - } -} - -.rounded-total-value { - font-size: 18px; -} - -.quantity-total { - font-size: 18px; -} \ No newline at end of file diff --git a/erpnext/public/less/products.less b/erpnext/public/less/products.less deleted file mode 100644 index 5e744ceac5b..00000000000 --- a/erpnext/public/less/products.less +++ /dev/null @@ -1,71 +0,0 @@ -@import "variables.less"; - -.products-list .product-image { - display: inline-block; - width: 160px; - height: 160px; - object-fit: contain; - margin-right: 1rem; -} - -.product-image.no-image { - display: flex; - justify-content: center; - align-items: center; - font-size: 3rem; - color: var(--gray); - background: var(--light); -} - -.product-image a { - text-decoration: none; -} - -.filter-options { - margin-left: -5px; - padding-left: 5px; - max-height: 300px; - overflow: auto; -} - -.item-slideshow-image { - height: 3rem; - width: 3rem; - object-fit: contain; - padding: 0.5rem; - border: 1px solid @border-color; - border-radius: 4px; - cursor: pointer; - - &:hover, &.active { - border-color: var(--primary); - } -} - -.address-card { - cursor: pointer; - position: relative; - - .check { - display: none; - } - - &.active { - border-color: var(--primary); - - .check { - display: inline-flex; - } - } -} - -.check { - display: inline-flex; - padding: 0.25rem; - background: var(--primary); - color: white; - border-radius: 50%; - font-size: 12px; - width: 24px; - height: 24px; -} \ No newline at end of file diff --git a/erpnext/public/less/website.less b/erpnext/public/less/website.less deleted file mode 100644 index ac878de105b..00000000000 --- a/erpnext/public/less/website.less +++ /dev/null @@ -1,388 +0,0 @@ -@import "variables.less"; - -.web-long-description { - font-size: 18px; - line-height: 200%; -} - -.web-page-content { - margin-bottom: 30px; -} - -.item-stock { - margin-bottom: 10px !important; -} - -.product-link { - display: block; - text-align: center; -} - - -.product-image img { - max-height: 500px; - margin: 0 auto; -} - -@media (max-width: 767px) { - .product-image { - height: 0px; - padding: 0px 0px 100%; - overflow: hidden; - } -} - -.product-image-square { - width: 100%; - height: 0; - padding: 50% 0px; - background-size: cover; - background-repeat: no-repeat; - background-position: center top; -} - -.product-image.missing-image { - .product-image-square; - position: relative; - background-color: @light-border-color; -} - -.product-image.missing-image .octicon { - font-size: 32px; - color: @border-color; -} - -.product-search { - margin-bottom: 15px; -} - - -@media (max-width: 767px) { - .product-search { - width: 100%; - } -} - -.borderless td, .borderless th { - border-bottom: 1px solid @light-border-color; - padding-left:0px !important; - line-height: 1.8em !important; -} - -.item-desc { - border-top: 2px solid @light-border-color; - padding-top:10px; -} - -.featured-products { - border-top: 1px solid @light-border-color; -} - -.transaction-list-item { - .indicator { - font-weight: inherit; - color: @text-muted; - } - - .transaction-time { - margin-top: 5px; - } - -} - -// order.html -.transaction-subheading { - .indicator { - font-weight: inherit; - color: @text-muted; - } -} - -.order-container { - margin: 50px 0px; - - .order-item-header .h6 { - padding: 7px 15px; - } - - .order-items { - margin: 30px 0px 0px; - } - - .order-item-table { - margin: 0px -15px; - } - - .order-item-header { - border-bottom: 1px solid #d1d8dd; - } - - .order-image-col { - padding-right: 0px; - } - - .order-image { - max-width: 55px; - max-height: 55px; - margin-top: -5px; - } - - .order-taxes { - margin-top: 30px; - - .row { - margin-top: 15px; - } - } - - .tax-grand-total-row { - padding-top: 15px; - padding-bottom: 30px; - } - - .tax-grand-total { - display: inline-block; - font-size: 16px; - font-weight: bold; - margin-top: 5px; - } -} - -.cart-container { - margin: 50px 0px; - - .checkout { - margin-bottom:15px; - } - - .cart-item-header .h6 { - padding: 7px 15px; - } - - .cart-items { - margin: 30px 0px 0px; - } - - .cart-item-table { - margin: 0px -15px; - } - - .cart-item-header { - border-bottom: 1px solid #d1d8dd; - } - - .cart-image-col { - padding-right: 0px; - } - - .cart-image { - max-width: 55px; - max-height: 55px; - margin-top: -5px; - } - - .cart-taxes { - margin-top: 30px; - - .row { - margin-top: 15px; - } - } - - .tax-grand-total-row { - border-top: 1px solid @border-color; - padding-top: 15px; - } - - .cart-addresses { - margin-top: 50px; - } -} - -.cart-items-dropdown .cart-dropdown, -.item_name_dropdown { - display: none; - -} - -.cart-dropdown-container { - width: 400px; - padding: 15px; - - .item-price { - display: block !important; - padding-bottom: 10px; - } - - .cart-item-header { - border-bottom: 1px solid #d1d8dd; - } - - .cart-items-dropdown { - max-height: 350px; - } - - .cart-items-dropdown .cart-dropdown { - display:block; - margin-top:15px; - } - - .item_name_dropdown { - display:block; - } - - .item-description, - .cart-items .checkout, - .item_name_and_description { - display: none; - } - - .checkout-btn { - padding-bottom:25px; - } - .col-name-description { - margin-bottom:8px; - } -} - -// .number-spinner { -// width:100px; -// margin-top:5px; -// } - -.cart-btn { - border-color: #ccc; -} -.cart-qty { - text-align:center; -} - -.product-list-link { - .row { - border-bottom: 1px solid @light-border-color; - } - - .row:hover { - background-color: @light-bg; - } - - .row > div { - padding-top: 15px; - padding-bottom: 15px; - } -} - -.product-list-link:first-child .row { - border-top: 1px solid @light-border-color; -} - -.item-group-nav-buttons { - margin-top: 15px; -} - -.footer-subscribe { - .btn-default { - background-color: transparent; - border: 1px solid @border-color; - } -} - -@media (min-width: 992px) { - .footer-subscribe { - max-width: 350px; - } -} - -.item-group-content { - margin-top: 30px; -} - -.item-group-slideshow { - margin-bottom: 1rem; -} - -.product-image-img { - border: 1px solid @light-border-color; - border-radius: 3px; -} - -.product-text { - word-wrap: break-word; - height: 75px; - display: block; /* Fallback for non-webkit */ - display: -webkit-box; - max-width: 100%; - margin: 0 auto; - -webkit-line-clamp: 3; - -webkit-box-orient: vertical; - overflow: hidden; - text-overflow: ellipsis; -} - -.product-image-wrapper { - padding-bottom: 40px; -} - -.duration-bar { - display: inline-block; - color: white; - background: #8FD288; - padding: 3px; -} - -.duration-invisible { - visibility: hidden; -} - -.duration-value { - float: right; -} - -.bar-outer-text { - color: #8FD288; - background: none; - float: none; - border: none; -} - -.bom-spec { - margin-bottom: 20px; -} - -.modal-title { - margin-top: 5px; -} - -.modal-header { - padding: 10px 15px; -} -// For Item Alternate Image -.item-alternative-image { - padding: 5px; - margin-bottom: 5px; - - &:hover { - border-color: @brand-primary; - } -} - -.item-slideshow-image { - height: 3rem; - width: 3rem; - object-fit: contain; - padding: 0.5rem; - border: 1px solid @border-color; - border-radius: 4px; - cursor: pointer; - - &:hover, &.active { - border-color: @brand-primary; - } -} - -.section-products { - .card-img-top { - max-height: 300px; - object-fit: contain; - } -} \ No newline at end of file diff --git a/erpnext/public/scss/erpnext-web.bundle.scss b/erpnext/public/scss/erpnext-web.bundle.scss new file mode 100644 index 00000000000..6ef1892a3df --- /dev/null +++ b/erpnext/public/scss/erpnext-web.bundle.scss @@ -0,0 +1,2 @@ +@import "./shopping_cart"; +@import "./website"; diff --git a/erpnext/public/scss/erpnext.bundle.scss b/erpnext/public/scss/erpnext.bundle.scss new file mode 100644 index 00000000000..d3313c7cee2 --- /dev/null +++ b/erpnext/public/scss/erpnext.bundle.scss @@ -0,0 +1,3 @@ +@import "./erpnext"; +@import "./call_popup"; +@import "./point-of-sale"; diff --git a/erpnext/public/less/erpnext.less b/erpnext/public/scss/erpnext.scss similarity index 83% rename from erpnext/public/less/erpnext.less rename to erpnext/public/scss/erpnext.scss index 4076ebec1fd..8ab5973debd 100644 --- a/erpnext/public/less/erpnext.less +++ b/erpnext/public/scss/erpnext.scss @@ -1,5 +1,3 @@ -@import "variables.less"; - .erpnext-footer { margin: 11px auto; text-align: center; @@ -141,7 +139,7 @@ body[data-route="pos"] { } .pos-payment-row { - border-bottom:1px solid @border-color; + border-bottom:1px solid var(--border-color); margin: 2px 0px 5px 0px; height: 60px; margin-top: 0px; @@ -149,12 +147,12 @@ body[data-route="pos"] { } .pos-payment-row:hover, .pos-keyboard-key:hover{ - background-color: @light-bg; + background-color: var(--bg-color); cursor: pointer; } .pos-keyboard-key, .delete-btn { - border: 1px solid @border-color; + border: 1px solid var(--border-color); height:85px; width:85px; margin:10px 10px; @@ -165,7 +163,7 @@ body[data-route="pos"] { } .numeric-keypad { - border: 1px solid @border-color; + border: 1px solid var(--border-color); height:69px; width:69px; font-size:20px; @@ -192,13 +190,13 @@ body[data-route="pos"] { background-color: #fff; margin-left:-4px; - @media (max-width: @screen-md) { + @media (max-width: var(--xl-width)) { height: 45px; width: 45px; font-size: 14px; } - @media (max-width: @screen-sm) { + @media (max-width: var(--lg-width)) { height: 40px; width: 40px; } @@ -209,21 +207,21 @@ body[data-route="pos"] { & > .row > button { border: none; - border-right: 1px solid @border-color; - border-bottom: 1px solid @border-color; + border-right: 1px solid var(--border-color); + border-bottom: 1px solid var(--border-color); &:first-child { - border-left: 1px solid @border-color; + border-left: 1px solid var(--border-color); } } & > .row:first-child > button { - border-top: 1px solid @border-color; + border-top: 1px solid var(--border-color); } } .pos-pay { - background-color: @brand-primary; + background-color: var(--primary); border: none; } @@ -236,13 +234,13 @@ body[data-route="pos"] { } .list-row-head.pos-invoice-list { - border-top: 1px solid @border-color; + border-top: 1px solid var(--border-color); } .modal-dialog { width: 750px; - @media (max-width: @screen-xs) { + @media (max-width: var(--md-width)) { width: auto; .modal-content { @@ -251,7 +249,7 @@ body[data-route="pos"] { } } - @media (max-width: @screen-xs) { + @media (max-width: var(--md-width)) { .amount-row h3 { font-size: 15px; } @@ -271,7 +269,7 @@ body[data-route="pos"] { } .selected-payment-mode { - background-color: @light-bg; + background-color: var(--bg-color); cursor: pointer; } @@ -291,7 +289,7 @@ body[data-route="pos"] { padding: 9px 15px; font-size: 12px; margin: 0px; - border-bottom: 1px solid @border-color; + border-bottom: 1px solid var(--border-color); .cell { display: table-cell; @@ -313,17 +311,17 @@ body[data-route="pos"] { .pos-bill-header { background-color: #f5f7fa; - border: 1px solid @border-color; + border: 1px solid var(--border-color); padding: 13px 15px; } .pos-list-row.active { - background-color: @light-yellow; + background-color: var(--fg-hover-color); } .totals-area { - border-right: 1px solid @border-color; - border-left: 1px solid @border-color; + border-right: 1px solid var(--border-color); + border-left: 1px solid var(--border-color); margin-bottom: 15px; } @@ -332,12 +330,12 @@ body[data-route="pos"] { } .item-cart-items { - height: ~"calc(100vh - 526px)"; + height: calc(100vh - 526px); overflow: auto; - border: 1px solid @border-color; + border: 1px solid var(--border-color); border-top: none; - @media (max-width: @screen-xs) { + @media (max-width: var(--md-width)) { height: 30vh; } } @@ -359,12 +357,12 @@ body[data-route="pos"] { } .item-list { - border: 1px solid @border-color; + border: 1px solid var(--border-color); border-top: none; - max-height: ~"calc(100vh - 190px)"; + max-height: calc(100vh - 190px); overflow: auto; - @media (max-width: @screen-xs) { + @media (max-width: var(--md-width)) { max-height: initial; } @@ -402,7 +400,7 @@ body[data-route="pos"] { &> .pos-list-row { border: none; - @media (max-width: @screen-md) { + @media (max-width: var(--xl-width)) { padding: 5px 15px; } } @@ -420,7 +418,7 @@ body[data-route="pos"] { justify-content: center; align-items: center; cursor: pointer; - background-color: @light-bg; + background-color: var(--bg-color); min-height: 200px; } @@ -428,7 +426,7 @@ body[data-route="pos"] { cursor: pointer; } - @media (max-width: @screen-xs) { + @media (max-width: var(--md-width)) { .page-actions { max-width: 110px; } @@ -491,4 +489,4 @@ body[data-route="pos"] { .exercise-col { padding: 10px; -} \ No newline at end of file +} diff --git a/erpnext/public/less/email.less b/erpnext/public/scss/erpnext_email.bundle.scss similarity index 51% rename from erpnext/public/less/email.less rename to erpnext/public/scss/erpnext_email.bundle.scss index 4077c4940d1..d94e74a3ae2 100644 --- a/erpnext/public/less/email.less +++ b/erpnext/public/scss/erpnext_email.bundle.scss @@ -1,14 +1,12 @@ -@import "../../../../frappe/frappe/public/less/variables.less"; - .panel-header { - background-color: @light-bg; - border: 1px solid @border-color; + background-color: var(--bg-color); + border: 1px solid var(--border-color); border-radius: 3px 3px 0 0; } .panel-body { - background-color: #fff; - border: 1px solid @border-color; + background-color: white; + border: 1px solid var(--border-color); border-top: none; border-radius: 0 0 3px 3px; overflow-wrap: break-word; @@ -22,11 +20,11 @@ } .sender-avatar-placeholder { - .sender-avatar; + @extend .sender-avatar; line-height: 24px; text-align: center; - color: @border-color; - border: 1px solid @border-color; - background-color: #fff; -} \ No newline at end of file + color: var(--border-color); + border: 1px solid var(--border-color); + background-color: white; +} diff --git a/erpnext/regional/india/e_invoice/utils.py b/erpnext/regional/india/e_invoice/utils.py index 11ebef724c4..5d33c1b100a 100644 --- a/erpnext/regional/india/e_invoice/utils.py +++ b/erpnext/regional/india/e_invoice/utils.py @@ -385,13 +385,16 @@ def validate_totals(einvoice): if abs(flt(value_details['AssVal']) - total_item_ass_value) > 1: frappe.throw(_('Total Taxable Value of the items is not equal to the Invoice Net Total. Please check item taxes / discounts for any correction.')) - if abs(flt(value_details['TotInvVal']) + flt(value_details['Discount']) - flt(value_details['OthChrg']) - total_item_value) > 1: + if abs( + flt(value_details['TotInvVal']) + flt(value_details['Discount']) - + flt(value_details['OthChrg']) - flt(value_details['RndOffAmt']) - + total_item_value) > 1: frappe.throw(_('Total Value of the items is not equal to the Invoice Grand Total. Please check item taxes / discounts for any correction.')) calculated_invoice_value = \ flt(value_details['AssVal']) + flt(value_details['CgstVal']) \ + flt(value_details['SgstVal']) + flt(value_details['IgstVal']) \ - + flt(value_details['OthChrg']) - flt(value_details['Discount']) + + flt(value_details['OthChrg']) + flt(value_details['RndOffAmt']) - flt(value_details['Discount']) if abs(flt(value_details['TotInvVal']) - calculated_invoice_value) > 1: frappe.throw(_('Total Item Value + Taxes - Discount is not equal to the Invoice Grand Total. Please check taxes / discounts for any correction.')) diff --git a/erpnext/selling/doctype/installation_note/installation_note.js b/erpnext/selling/doctype/installation_note/installation_note.js index 7fd0877d11a..27a3b35ccfb 100644 --- a/erpnext/selling/doctype/installation_note/installation_note.js +++ b/erpnext/selling/doctype/installation_note/installation_note.js @@ -30,8 +30,8 @@ frappe.ui.form.on('Installation Note', { frappe.provide("erpnext.selling"); // TODO commonify this code -erpnext.selling.InstallationNote = frappe.ui.form.Controller.extend({ - refresh: function() { +erpnext.selling.InstallationNote = class InstallationNote extends frappe.ui.form.Controller { + refresh() { var me = this; if (this.frm.doc.docstatus===0) { this.frm.add_custom_button(__('From Delivery Note'), @@ -54,7 +54,7 @@ erpnext.selling.InstallationNote = frappe.ui.form.Controller.extend({ }, "fa fa-download", "btn-default" ); } - }, -}); + } +}; -$.extend(cur_frm.cscript, new erpnext.selling.InstallationNote({frm: cur_frm})); \ No newline at end of file +extend_cscript(cur_frm.cscript, new erpnext.selling.InstallationNote({frm: cur_frm})); diff --git a/erpnext/selling/doctype/quotation/quotation.js b/erpnext/selling/doctype/quotation/quotation.js index 5a0d9c90655..12234495493 100644 --- a/erpnext/selling/doctype/quotation/quotation.js +++ b/erpnext/selling/doctype/quotation/quotation.js @@ -36,13 +36,12 @@ frappe.ui.form.on('Quotation', { } }); -erpnext.selling.QuotationController = erpnext.selling.SellingController.extend({ - onload: function(doc, dt, dn) { +erpnext.selling.QuotationController = class QuotationController extends erpnext.selling.SellingController { + onload(doc, dt, dn) { var me = this; - this._super(doc, dt, dn); - - }, - party_name: function() { + super.onload(doc, dt, dn); + } + party_name() { var me = this; erpnext.utils.get_party_details(this.frm, null, null, function() { me.apply_price_list(); @@ -51,11 +50,14 @@ erpnext.selling.QuotationController = erpnext.selling.SellingController.extend({ if(me.frm.doc.quotation_to=="Lead" && me.frm.doc.party_name) { me.frm.trigger("get_lead_details"); } - }, - refresh: function(doc, dt, dn) { - this._super(doc, dt, dn); - doctype = doc.quotation_to == 'Customer' ? 'Customer':'Lead'; - frappe.dynamic_link = {doc: this.frm.doc, fieldname: 'party_name', doctype: doctype} + } + refresh(doc, dt, dn) { + super.refresh(doc, dt, dn); + frappe.dynamic_link = { + doc: this.frm.doc, + fieldname: 'party_name', + doctype: doc.quotation_to == 'Customer' ? 'Customer' : 'Lead', + }; var me = this; @@ -121,9 +123,9 @@ erpnext.selling.QuotationController = erpnext.selling.SellingController.extend({ this.toggle_reqd_lead_customer(); - }, + } - set_dynamic_field_label: function(){ + set_dynamic_field_label(){ if (this.frm.doc.quotation_to == "Customer") { this.frm.set_df_property("party_name", "label", "Customer"); @@ -138,22 +140,22 @@ erpnext.selling.QuotationController = erpnext.selling.SellingController.extend({ return{ query: "erpnext.controllers.queries.lead_query" } } } - }, + } - toggle_reqd_lead_customer: function() { + toggle_reqd_lead_customer() { var me = this; // to overwrite the customer_filter trigger from queries.js this.frm.toggle_reqd("party_name", this.frm.doc.quotation_to); this.frm.set_query('customer_address', this.address_query); this.frm.set_query('shipping_address_name', this.address_query); - }, + } - tc_name: function() { + tc_name() { this.get_terms(); - }, + } - address_query: function(doc) { + address_query(doc) { return { query: 'frappe.contacts.doctype.address.address.address_query', filters: { @@ -161,20 +163,20 @@ erpnext.selling.QuotationController = erpnext.selling.SellingController.extend({ link_name: doc.party_name } }; - }, + } - validate_company_and_party: function(party_field) { + validate_company_and_party(party_field) { if(!this.frm.doc.quotation_to) { frappe.msgprint(__("Please select a value for {0} quotation_to {1}", [this.frm.doc.doctype, this.frm.doc.name])); return false; } else if (this.frm.doc.quotation_to == "Lead") { return true; } else { - return this._super(party_field); + return super.validate_company_and_party(party_field); } - }, + } - get_lead_details: function() { + get_lead_details() { var me = this; if(!this.frm.doc.quotation_to === "Lead") { return; @@ -198,7 +200,7 @@ erpnext.selling.QuotationController = erpnext.selling.SellingController.extend({ } }) } -}); +}; cur_frm.script_manager.make(erpnext.selling.QuotationController); diff --git a/erpnext/selling/doctype/sales_order/sales_order.js b/erpnext/selling/doctype/sales_order/sales_order.js index e3b41e66fbc..b42c6153129 100644 --- a/erpnext/selling/doctype/sales_order/sales_order.js +++ b/erpnext/selling/doctype/sales_order/sales_order.js @@ -102,14 +102,14 @@ frappe.ui.form.on("Sales Order Item", { } }); -erpnext.selling.SalesOrderController = erpnext.selling.SellingController.extend({ - onload: function(doc, dt, dn) { - this._super(); - }, +erpnext.selling.SalesOrderController = class SalesOrderController extends erpnext.selling.SellingController { + onload(doc, dt, dn) { + super.onload(doc, dt, dn); + } - refresh: function(doc, dt, dn) { + refresh(doc, dt, dn) { var me = this; - this._super(); + super.refresh(); let allow_delivery = false; if (doc.docstatus==1) { @@ -241,14 +241,14 @@ erpnext.selling.SalesOrderController = erpnext.selling.SellingController.extend( } this.order_type(doc); - }, + } create_pick_list() { frappe.model.open_mapped_doc({ method: "erpnext.selling.doctype.sales_order.sales_order.create_pick_list", frm: this.frm }) - }, + } make_work_order() { var me = this; @@ -343,33 +343,33 @@ erpnext.selling.SalesOrderController = erpnext.selling.SellingController.extend( } } }); - }, + } - order_type: function() { + order_type() { this.toggle_delivery_date(); - }, + } - tc_name: function() { + tc_name() { this.get_terms(); - }, + } - make_material_request: function() { + make_material_request() { frappe.model.open_mapped_doc({ method: "erpnext.selling.doctype.sales_order.sales_order.make_material_request", frm: this.frm }) - }, + } - skip_delivery_note: function() { + skip_delivery_note() { this.toggle_delivery_date(); - }, + } - toggle_delivery_date: function() { + toggle_delivery_date() { this.frm.fields_dict.items.grid.toggle_reqd("delivery_date", (this.frm.doc.order_type == "Sales" && !this.frm.doc.skip_delivery_note)); - }, + } - make_raw_material_request: function() { + make_raw_material_request() { var me = this; this.frm.call({ doc: this.frm.doc, @@ -390,9 +390,9 @@ erpnext.selling.SalesOrderController = erpnext.selling.SellingController.extend( } } }); - }, + } - make_raw_material_request_dialog: function(r) { + make_raw_material_request_dialog(r) { var fields = [ {fieldtype:'Check', fieldname:'include_exploded_items', label: __('Include Exploded Items')}, @@ -447,9 +447,9 @@ erpnext.selling.SalesOrderController = erpnext.selling.SellingController.extend( primary_action_label: __('Create') }); d.show(); - }, + } - make_delivery_note_based_on_delivery_date: function() { + make_delivery_note_based_on_delivery_date() { var me = this; var delivery_dates = []; @@ -509,51 +509,51 @@ erpnext.selling.SalesOrderController = erpnext.selling.SellingController.extend( } else { this.make_delivery_note(); } - }, + } - make_delivery_note: function() { + make_delivery_note() { frappe.model.open_mapped_doc({ method: "erpnext.selling.doctype.sales_order.sales_order.make_delivery_note", frm: this.frm }) - }, + } - make_sales_invoice: function() { + make_sales_invoice() { frappe.model.open_mapped_doc({ method: "erpnext.selling.doctype.sales_order.sales_order.make_sales_invoice", frm: this.frm }) - }, + } - make_maintenance_schedule: function() { + make_maintenance_schedule() { frappe.model.open_mapped_doc({ method: "erpnext.selling.doctype.sales_order.sales_order.make_maintenance_schedule", frm: this.frm }) - }, + } - make_project: function() { + make_project() { frappe.model.open_mapped_doc({ method: "erpnext.selling.doctype.sales_order.sales_order.make_project", frm: this.frm }) - }, + } - make_inter_company_order: function() { + make_inter_company_order() { frappe.model.open_mapped_doc({ method: "erpnext.selling.doctype.sales_order.sales_order.make_inter_company_purchase_order", frm: this.frm }); - }, + } - make_maintenance_visit: function() { + make_maintenance_visit() { frappe.model.open_mapped_doc({ method: "erpnext.selling.doctype.sales_order.sales_order.make_maintenance_visit", frm: this.frm }) - }, + } - make_purchase_order: function(){ + make_purchase_order(){ let pending_items = this.frm.doc.items.some((item) =>{ let pending_qty = flt(item.stock_qty) - flt(item.ordered_qty); return pending_qty > 0; @@ -690,9 +690,9 @@ erpnext.selling.SalesOrderController = erpnext.selling.SellingController.extend( dialog.get_field("items_for_po").refresh(); dialog.wrapper.find('.grid-heading-row .grid-row-check').click(); dialog.show(); - }, + } - hold_sales_order: function(){ + hold_sales_order(){ var me = this; var d = new frappe.ui.Dialog({ title: __('Reason for Hold'), @@ -724,11 +724,11 @@ erpnext.selling.SalesOrderController = erpnext.selling.SellingController.extend( } }); d.show(); - }, - close_sales_order: function(){ + } + close_sales_order(){ this.frm.cscript.update_status("Close", "Closed") - }, - update_status: function(label, status){ + } + update_status(label, status){ var doc = this.frm.doc; var me = this; frappe.ui.form.is_saving = true; @@ -743,5 +743,6 @@ erpnext.selling.SalesOrderController = erpnext.selling.SellingController.extend( } }); } -}); -$.extend(cur_frm.cscript, new erpnext.selling.SalesOrderController({frm: cur_frm})); +}; + +extend_cscript(cur_frm.cscript, new erpnext.selling.SalesOrderController({frm: cur_frm})); diff --git a/erpnext/selling/doctype/sms_center/sms_center.js b/erpnext/selling/doctype/sms_center/sms_center.js index dda28031df5..974cfc79181 100644 --- a/erpnext/selling/doctype/sms_center/sms_center.js +++ b/erpnext/selling/doctype/sms_center/sms_center.js @@ -1,7 +1,7 @@ // Copyright (c) 2015, Frappe Technologies Pvt. Ltd. and Contributors // License: GNU General Public License v3. See license.txt -$.extend(cur_frm.cscript, { +extend_cscript(cur_frm.cscript, { message: function () { var total_characters = this.frm.doc.message.length; var total_msg = 1; diff --git a/erpnext/selling/page/point_of_sale/point_of_sale.js b/erpnext/selling/page/point_of_sale/point_of_sale.js index e3405e0ce89..6db4150be94 100644 --- a/erpnext/selling/page/point_of_sale/point_of_sale.js +++ b/erpnext/selling/page/point_of_sale/point_of_sale.js @@ -7,7 +7,7 @@ frappe.pages['point-of-sale'].on_page_load = function(wrapper) { single_column: true }); - frappe.require('assets/js/point-of-sale.min.js', function() { + frappe.require('point-of-sale.bundle.js', function() { wrapper.pos = new erpnext.PointOfSale.Controller(wrapper); window.cur_pos = wrapper.pos; }); @@ -19,4 +19,4 @@ frappe.pages['point-of-sale'].refresh = function(wrapper) { wrapper.pos.wrapper.html(""); wrapper.pos.check_opening_entry(); } -}; \ No newline at end of file +}; diff --git a/erpnext/selling/page/point_of_sale/point_of_sale.py b/erpnext/selling/page/point_of_sale/point_of_sale.py index 296c8c2fd9d..8d1f112dc28 100644 --- a/erpnext/selling/page/point_of_sale/point_of_sale.py +++ b/erpnext/selling/page/point_of_sale/point_of_sale.py @@ -23,8 +23,8 @@ def search_by_term(search_term, warehouse, price_list): item_stock_qty = get_stock_availability(item_code, warehouse) price_list_rate, currency = frappe.db.get_value('Item Price', { - 'price_list': price_list, - 'item_code': item_code + 'price_list': price_list, + 'item_code': item_code }, ["price_list_rate", "currency"]) or [None, None] item_info.update({ diff --git a/erpnext/selling/sales_common.js b/erpnext/selling/sales_common.js index 04285735abd..eb02867720c 100644 --- a/erpnext/selling/sales_common.js +++ b/erpnext/selling/sales_common.js @@ -9,15 +9,15 @@ cur_frm.cscript.tax_table = "Sales Taxes and Charges"; cur_frm.email_field = "contact_email"; frappe.provide("erpnext.selling"); -erpnext.selling.SellingController = erpnext.TransactionController.extend({ - setup: function() { - this._super(); +erpnext.selling.SellingController = class SellingController extends erpnext.TransactionController { + setup() { + super.setup(); this.frm.add_fetch("sales_partner", "commission_rate", "commission_rate"); this.frm.add_fetch("sales_person", "commission_rate", "commission_rate"); - }, + } - onload: function() { - this._super(); + onload() { + super.onload(); this.setup_queries(); this.frm.set_query('shipping_rule', function() { return { @@ -26,9 +26,9 @@ erpnext.selling.SellingController = erpnext.TransactionController.extend({ } }; }); - }, + } - setup_queries: function() { + setup_queries() { var me = this; $.each([["customer", "customer"], @@ -81,10 +81,10 @@ erpnext.selling.SellingController = erpnext.TransactionController.extend({ }); } - }, + } - refresh: function() { - this._super(); + refresh() { + super.refresh(); frappe.dynamic_link = {doc: this.frm.doc, fieldname: 'customer', doctype: 'Customer'} @@ -95,45 +95,45 @@ erpnext.selling.SellingController = erpnext.TransactionController.extend({ this.frm.toggle_display("packing_list", packing_list_exists ? true : false); } this.toggle_editable_price_list_rate(); - }, + } - customer: function() { + customer() { var me = this; erpnext.utils.get_party_details(this.frm, null, null, function() { me.apply_price_list(); }); - }, + } - customer_address: function() { + customer_address() { erpnext.utils.get_address_display(this.frm, "customer_address"); erpnext.utils.set_taxes_from_address(this.frm, "customer_address", "customer_address", "shipping_address_name"); - }, + } - shipping_address_name: function() { + shipping_address_name() { erpnext.utils.get_address_display(this.frm, "shipping_address_name", "shipping_address"); erpnext.utils.set_taxes_from_address(this.frm, "shipping_address_name", "customer_address", "shipping_address_name"); - }, + } - sales_partner: function() { + sales_partner() { this.apply_pricing_rule(); - }, + } - campaign: function() { + campaign() { this.apply_pricing_rule(); - }, + } - selling_price_list: function() { + selling_price_list() { this.apply_price_list(); this.set_dynamic_labels(); - }, + } - discount_percentage: function(doc, cdt, cdn) { + discount_percentage(doc, cdt, cdn) { var item = frappe.get_doc(cdt, cdn); item.discount_amount = 0.0; this.apply_discount_on_item(doc, cdt, cdn, 'discount_percentage'); - }, + } - discount_amount: function(doc, cdt, cdn) { + discount_amount(doc, cdt, cdn) { if(doc.name === cdn) { return; @@ -142,9 +142,9 @@ erpnext.selling.SellingController = erpnext.TransactionController.extend({ var item = frappe.get_doc(cdt, cdn); item.discount_percentage = 0.0; this.apply_discount_on_item(doc, cdt, cdn, 'discount_amount'); - }, + } - apply_discount_on_item: function(doc, cdt, cdn, field) { + apply_discount_on_item(doc, cdt, cdn, field) { var item = frappe.get_doc(cdt, cdn); if(!item.price_list_rate) { item[field] = 0.0; @@ -152,14 +152,14 @@ erpnext.selling.SellingController = erpnext.TransactionController.extend({ this.price_list_rate(doc, cdt, cdn); } this.set_gross_profit(item); - }, + } - commission_rate: function() { + commission_rate() { this.calculate_commission(); refresh_field("total_commission"); - }, + } - total_commission: function() { + total_commission() { if(this.frm.doc.base_net_total) { frappe.model.round_floats_in(this.frm.doc, ["base_net_total", "total_commission"]); @@ -175,9 +175,9 @@ erpnext.selling.SellingController = erpnext.TransactionController.extend({ this.frm.set_value("commission_rate", flt(this.frm.doc.total_commission * 100.0 / this.frm.doc.base_net_total)); } - }, + } - allocated_percentage: function(doc, cdt, cdn) { + allocated_percentage(doc, cdt, cdn) { var sales_person = frappe.get_doc(cdt, cdn); if(sales_person.allocated_percentage) { @@ -193,15 +193,15 @@ erpnext.selling.SellingController = erpnext.TransactionController.extend({ refresh_field(["allocated_percentage", "allocated_amount", "commission_rate","incentives"], sales_person.name, sales_person.parentfield); } - }, + } - sales_person: function(doc, cdt, cdn) { + sales_person(doc, cdt, cdn) { var row = frappe.get_doc(cdt, cdn); this.calculate_incentive(row); refresh_field("incentives",row.name,row.parentfield); - }, + } - warehouse: function(doc, cdt, cdn) { + warehouse(doc, cdt, cdn) { var me = this; var item = frappe.get_doc(cdt, cdn); @@ -239,18 +239,18 @@ erpnext.selling.SellingController = erpnext.TransactionController.extend({ }); } }) - }, + } - toggle_editable_price_list_rate: function() { + toggle_editable_price_list_rate() { var df = frappe.meta.get_docfield(this.frm.doc.doctype + " Item", "price_list_rate", this.frm.doc.name); var editable_price_list_rate = cint(frappe.defaults.get_default("editable_price_list_rate")); if(df && editable_price_list_rate) { df.read_only = 0; } - }, + } - calculate_commission: function() { + calculate_commission() { if(this.frm.fields_dict.commission_rate) { if(this.frm.doc.commission_rate > 100) { var msg = __(frappe.meta.get_label(this.frm.doc.doctype, "commission_rate", this.frm.doc.name)) + @@ -262,9 +262,9 @@ erpnext.selling.SellingController = erpnext.TransactionController.extend({ this.frm.doc.total_commission = flt(this.frm.doc.base_net_total * this.frm.doc.commission_rate / 100.0, precision("total_commission")); } - }, + } - calculate_contribution: function() { + calculate_contribution() { var me = this; $.each(this.frm.doc.doctype.sales_team || [], function(i, sales_person) { frappe.model.round_floats_in(sales_person); @@ -274,18 +274,18 @@ erpnext.selling.SellingController = erpnext.TransactionController.extend({ precision("allocated_amount", sales_person)); } }); - }, + } - calculate_incentive: function(row) { + calculate_incentive(row) { if(row.allocated_amount) { row.incentives = flt( row.allocated_amount * row.commission_rate / 100.0, precision("incentives", row)); } - }, + } - batch_no: function(doc, cdt, cdn) { + batch_no(doc, cdt, cdn) { var me = this; var item = frappe.get_doc(cdt, cdn); @@ -312,14 +312,14 @@ erpnext.selling.SellingController = erpnext.TransactionController.extend({ }); } }) - }, + } - set_dynamic_labels: function() { - this._super(); + set_dynamic_labels() { + super.set_dynamic_labels(); this.set_product_bundle_help(this.frm.doc); - }, + } - set_product_bundle_help: function(doc) { + set_product_bundle_help(doc) { if(!cur_frm.fields_dict.packing_list) return; if ((doc.packed_items || []).length) { $(cur_frm.fields_dict.packing_list.row.wrapper).toggle(true); @@ -337,9 +337,9 @@ erpnext.selling.SellingController = erpnext.TransactionController.extend({ } } refresh_field('product_bundle_help'); - }, + } - company_address: function() { + company_address() { var me = this; if(this.frm.doc.company_address) { frappe.call({ @@ -354,42 +354,42 @@ erpnext.selling.SellingController = erpnext.TransactionController.extend({ } else { this.frm.set_value("company_address_display", ""); } - }, + } - conversion_factor: function(doc, cdt, cdn, dont_fetch_price_list_rate) { - this._super(doc, cdt, cdn, dont_fetch_price_list_rate); + conversion_factor(doc, cdt, cdn, dont_fetch_price_list_rate) { + super.conversion_factor(doc, cdt, cdn, dont_fetch_price_list_rate); if(frappe.meta.get_docfield(cdt, "stock_qty", cdn) && in_list(['Delivery Note', 'Sales Invoice'], doc.doctype)) { if (doc.doctype === 'Sales Invoice' && (!doc.update_stock)) return; this.set_batch_number(cdt, cdn); } - }, + } - batch_no: function(doc, cdt, cdn) { - this._super(doc, cdt, cdn); - }, + batch_no(doc, cdt, cdn) { + super.batch_no(doc, cdt, cdn); + } - qty: function(doc, cdt, cdn) { - this._super(doc, cdt, cdn); + qty(doc, cdt, cdn) { + super.qty(doc, cdt, cdn); if(in_list(['Delivery Note', 'Sales Invoice'], doc.doctype)) { if (doc.doctype === 'Sales Invoice' && (!doc.update_stock)) return; this.set_batch_number(cdt, cdn); } - }, + } /* Determine appropriate batch number and set it in the form. * @param {string} cdt - Document Doctype * @param {string} cdn - Document name */ - set_batch_number: function(cdt, cdn) { + set_batch_number(cdt, cdn) { const doc = frappe.get_doc(cdt, cdn); if (doc && doc.has_batch_no && doc.warehouse) { this._set_batch_number(doc); } - }, + } - _set_batch_number: function(doc) { + _set_batch_number(doc) { let args = {'item_code': doc.item_code, 'warehouse': doc.warehouse, 'qty': flt(doc.qty) * flt(doc.conversion_factor)}; if (doc.has_serial_no && doc.serial_no) { args['serial_no'] = doc.serial_no @@ -406,9 +406,9 @@ erpnext.selling.SellingController = erpnext.TransactionController.extend({ } } }); - }, + } - update_auto_repeat_reference: function(doc) { + update_auto_repeat_reference(doc) { if (doc.auto_repeat) { frappe.call({ method:"frappe.automation.doctype.auto_repeat.auto_repeat.update_reference", @@ -426,7 +426,7 @@ erpnext.selling.SellingController = erpnext.TransactionController.extend({ }) } } -}); +}; frappe.ui.form.on(cur_frm.doctype,"project", function(frm) { if(in_list(["Delivery Note", "Sales Invoice"], frm.doc.doctype)) { diff --git a/erpnext/setup/doctype/currency_exchange/currency_exchange.js b/erpnext/setup/doctype/currency_exchange/currency_exchange.js index a8ea55ca0cb..85036a163e6 100644 --- a/erpnext/setup/doctype/currency_exchange/currency_exchange.js +++ b/erpnext/setup/doctype/currency_exchange/currency_exchange.js @@ -1,30 +1,30 @@ // Copyright (c) 2015, Frappe Technologies Pvt. Ltd. and Contributors // License: GNU General Public License v3. See license.txt -$.extend(cur_frm.cscript, { +extend_cscript(cur_frm.cscript, { onload: function() { if(cur_frm.doc.__islocal) { cur_frm.set_value("to_currency", frappe.defaults.get_global_default("currency")); } }, - + refresh: function() { cur_frm.cscript.set_exchange_rate_label(); }, - + from_currency: function() { cur_frm.cscript.set_exchange_rate_label(); }, - + to_currency: function() { cur_frm.cscript.set_exchange_rate_label(); }, - + set_exchange_rate_label: function() { if(cur_frm.doc.from_currency && cur_frm.doc.to_currency) { var default_label = __(frappe.meta.docfield_map[cur_frm.doctype]["exchange_rate"].label); - cur_frm.fields_dict.exchange_rate.set_label(default_label + + cur_frm.fields_dict.exchange_rate.set_label(default_label + repl(" (1 %(from_currency)s = [?] %(to_currency)s)", cur_frm.doc)); } } -}); \ No newline at end of file +}); diff --git a/erpnext/setup/doctype/item_group/item_group.py b/erpnext/setup/doctype/item_group/item_group.py index 1c72cebfa9d..1a83cb62dd3 100644 --- a/erpnext/setup/doctype/item_group/item_group.py +++ b/erpnext/setup/doctype/item_group/item_group.py @@ -8,7 +8,7 @@ from frappe import _ from frappe.utils import nowdate, cint, cstr from frappe.utils.nestedset import NestedSet from frappe.website.website_generator import WebsiteGenerator -from frappe.website.render import clear_cache +from frappe.website.utils import clear_cache from frappe.website.doctype.website_slideshow.website_slideshow import get_slideshow from erpnext.shopping_cart.product_info import set_product_info_for_website from erpnext.utilities.product import get_qty_in_stock diff --git a/erpnext/setup/setup_wizard/operations/install_fixtures.py b/erpnext/setup/setup_wizard/operations/install_fixtures.py index 5c725d332de..7ae81d782ac 100644 --- a/erpnext/setup/setup_wizard/operations/install_fixtures.py +++ b/erpnext/setup/setup_wizard/operations/install_fixtures.py @@ -428,7 +428,6 @@ def install_post_company_fixtures(args=None): frappe.local.flags.ignore_update_nsm = True make_records(records[1:]) frappe.local.flags.ignore_update_nsm = False - rebuild_tree("Department", "parent_department") diff --git a/erpnext/shopping_cart/product_query.py b/erpnext/shopping_cart/product_query.py index d96d803416c..3eab4ffbcc9 100644 --- a/erpnext/shopping_cart/product_query.py +++ b/erpnext/shopping_cart/product_query.py @@ -71,7 +71,8 @@ class ProductQuery: ], or_filters=self.or_filters, start=start, - limit=self.page_length + limit=self.page_length, + order_by="weightage desc" ) items_dict = {item.name: item for item in items} diff --git a/erpnext/stock/dashboard/item_dashboard.js b/erpnext/stock/dashboard/item_dashboard.js index a657ecf1055..37e9e89a0a9 100644 --- a/erpnext/stock/dashboard/item_dashboard.js +++ b/erpnext/stock/dashboard/item_dashboard.js @@ -1,11 +1,11 @@ frappe.provide('erpnext.stock'); -erpnext.stock.ItemDashboard = Class.extend({ - init: function (opts) { +erpnext.stock.ItemDashboard = class ItemDashboard { + constructor(opts) { $.extend(this, opts); this.make(); - }, - make: function () { + } + make() { var me = this; this.start = 0; if (!this.sort_by) { @@ -79,9 +79,9 @@ erpnext.stock.ItemDashboard = Class.extend({ me.refresh(); }); - }, - refresh: function () { - if (this.before_refresh) { + } + refresh() { + if(this.before_refresh) { this.before_refresh(); } @@ -104,9 +104,9 @@ erpnext.stock.ItemDashboard = Class.extend({ me.render(r.message); } }); - }, - render: function (data) { - if (this.start === 0) { + } + render(data) { + if (this.start===0) { this.max_count = 0; this.result.empty(); } @@ -141,11 +141,11 @@ erpnext.stock.ItemDashboard = Class.extend({ $(`
${message}
`).appendTo(this.result); } - }, + } - get_item_dashboard_data: function (data, max_count, show_item) { - if (!max_count) max_count = 0; - if (!data) data = []; + get_item_dashboard_data(data, max_count, show_item) { + if(!max_count) max_count = 0; + if(!data) data = []; data.forEach(function (d) { d.actual_or_pending = d.projected_qty + d.reserved_qty + d.reserved_qty_for_production + d.reserved_qty_for_sub_contract; @@ -170,9 +170,9 @@ erpnext.stock.ItemDashboard = Class.extend({ can_write: can_write, show_item: show_item || false }; - }, + } - get_capacity_dashboard_data: function (data) { + get_capacity_dashboard_data(data) { if (!data) data = []; data.forEach(function (d) { @@ -189,7 +189,7 @@ erpnext.stock.ItemDashboard = Class.extend({ can_write: can_write, }; } -}); +}; erpnext.stock.move_item = function (item, source, target, actual_qty, rate, callback) { var dialog = new frappe.ui.Dialog({ diff --git a/erpnext/stock/doctype/delivery_note/delivery_note.js b/erpnext/stock/doctype/delivery_note/delivery_note.js index 74cb3fcb1f0..36dfa6d7951 100644 --- a/erpnext/stock/doctype/delivery_note/delivery_note.js +++ b/erpnext/stock/doctype/delivery_note/delivery_note.js @@ -126,17 +126,17 @@ frappe.ui.form.on("Delivery Note Item", { } }); -erpnext.stock.DeliveryNoteController = erpnext.selling.SellingController.extend({ - setup: function(doc) { +erpnext.stock.DeliveryNoteController = class DeliveryNoteController extends erpnext.selling.SellingController { + setup(doc) { this.setup_posting_date_time_check(); - this._super(doc); + super.setup(doc); this.frm.make_methods = { 'Delivery Trip': this.make_delivery_trip, }; - }, - refresh: function(doc, dt, dn) { + } + refresh(doc, dt, dn) { var me = this; - this._super(); + super.refresh(); if ((!doc.is_return) && (doc.status!="Closed" || this.frm.is_new())) { if (this.frm.doc.docstatus===0) { this.frm.add_custom_button(__('Sales Order'), @@ -234,64 +234,64 @@ erpnext.stock.DeliveryNoteController = erpnext.selling.SellingController.extend( erpnext.utils.make_subscription(doc.doctype, doc.name) }, __('Create')) } - }, + } - make_shipment: function() { + make_shipment() { frappe.model.open_mapped_doc({ method: "erpnext.stock.doctype.delivery_note.delivery_note.make_shipment", frm: this.frm }) - }, + } - make_sales_invoice: function() { + make_sales_invoice() { frappe.model.open_mapped_doc({ method: "erpnext.stock.doctype.delivery_note.delivery_note.make_sales_invoice", frm: this.frm }) - }, + } - make_installation_note: function() { + make_installation_note() { frappe.model.open_mapped_doc({ method: "erpnext.stock.doctype.delivery_note.delivery_note.make_installation_note", frm: this.frm }); - }, + } - make_sales_return: function() { + make_sales_return() { frappe.model.open_mapped_doc({ method: "erpnext.stock.doctype.delivery_note.delivery_note.make_sales_return", frm: this.frm }) - }, + } - make_delivery_trip: function() { + make_delivery_trip() { frappe.model.open_mapped_doc({ method: "erpnext.stock.doctype.delivery_note.delivery_note.make_delivery_trip", frm: cur_frm }) - }, + } - tc_name: function() { + tc_name() { this.get_terms(); - }, + } - items_on_form_rendered: function(doc, grid_row) { + items_on_form_rendered(doc, grid_row) { erpnext.setup_serial_or_batch_no(); - }, + } - packed_items_on_form_rendered: function(doc, grid_row) { + packed_items_on_form_rendered(doc, grid_row) { erpnext.setup_serial_or_batch_no(); - }, + } - close_delivery_note: function(doc){ + close_delivery_note(doc){ this.update_status("Closed") - }, + } - reopen_delivery_note : function() { + reopen_delivery_note() { this.update_status("Submitted") - }, + } - update_status: function(status) { + update_status(status) { var me = this; frappe.ui.form.is_saving = true; frappe.call({ @@ -305,10 +305,10 @@ erpnext.stock.DeliveryNoteController = erpnext.selling.SellingController.extend( frappe.ui.form.is_saving = false; } }) - }, -}); + } +}; -$.extend(cur_frm.cscript, new erpnext.stock.DeliveryNoteController({frm: cur_frm})); +extend_cscript(cur_frm.cscript, new erpnext.stock.DeliveryNoteController({frm: cur_frm})); frappe.ui.form.on('Delivery Note', { setup: function(frm) { diff --git a/erpnext/stock/doctype/item/item.js b/erpnext/stock/doctype/item/item.js index 8aec89381a1..45e3c21b27d 100644 --- a/erpnext/stock/doctype/item/item.js +++ b/erpnext/stock/doctype/item/item.js @@ -380,7 +380,7 @@ $.extend(erpnext.item, { // Show Stock Levels only if is_stock_item if (frm.doc.is_stock_item) { - frappe.require('assets/js/item-dashboard.min.js', function() { + frappe.require('item-dashboard.bundle.js', function() { const section = frm.dashboard.add_section('', __("Stock Levels")); erpnext.item.item_dashboard = new erpnext.stock.ItemDashboard({ parent: section, diff --git a/erpnext/stock/doctype/item/item.py b/erpnext/stock/doctype/item/item.py index fbd30cf6c78..42cc67c5cd4 100644 --- a/erpnext/stock/doctype/item/item.py +++ b/erpnext/stock/doctype/item/item.py @@ -16,7 +16,7 @@ from frappe.utils.html_utils import clean_html from frappe.website.doctype.website_slideshow.website_slideshow import \ get_slideshow -from frappe.website.render import clear_cache +from frappe.website.utils import clear_cache from frappe.website.website_generator import WebsiteGenerator diff --git a/erpnext/stock/doctype/landed_cost_voucher/landed_cost_voucher.js b/erpnext/stock/doctype/landed_cost_voucher/landed_cost_voucher.js index 1abbc35334f..433f78adc96 100644 --- a/erpnext/stock/doctype/landed_cost_voucher/landed_cost_voucher.js +++ b/erpnext/stock/doctype/landed_cost_voucher/landed_cost_voucher.js @@ -5,8 +5,8 @@ frappe.provide("erpnext.stock"); -erpnext.stock.LandedCostVoucher = erpnext.stock.StockController.extend({ - setup: function() { +erpnext.stock.LandedCostVoucher = class LandedCostVoucher extends erpnext.stock.StockController { + setup() { var me = this; this.frm.fields_dict.purchase_receipts.grid.get_field('receipt_document').get_query = function (doc, cdt, cdn) { @@ -30,9 +30,9 @@ erpnext.stock.LandedCostVoucher = erpnext.stock.StockController.extend({ this.frm.add_fetch("receipt_document", "supplier", "supplier"); this.frm.add_fetch("receipt_document", "posting_date", "posting_date"); this.frm.add_fetch("receipt_document", "base_grand_total", "grand_total"); - }, + } - refresh: function() { + refresh() { var help_content = `

@@ -67,9 +67,9 @@ erpnext.stock.LandedCostVoucher = erpnext.stock.StockController.extend({ let company_currency = frappe.get_doc(":Company", this.frm.doc.company).default_currency; this.frm.set_currency_labels(["total_taxes_and_charges"], company_currency); } - }, + } - get_items_from_purchase_receipts: function() { + get_items_from_purchase_receipts() { var me = this; if(!this.frm.doc.purchase_receipts.length) { frappe.msgprint(__("Please enter Purchase Receipt first")); @@ -82,22 +82,22 @@ erpnext.stock.LandedCostVoucher = erpnext.stock.StockController.extend({ } }); } - }, + } - amount: function(frm) { + amount(frm) { this.set_total_taxes_and_charges(); this.set_applicable_charges_for_item(); - }, + } - set_total_taxes_and_charges: function() { + set_total_taxes_and_charges() { var total_taxes_and_charges = 0.0; $.each(this.frm.doc.taxes || [], function(i, d) { total_taxes_and_charges += flt(d.base_amount); }); this.frm.set_value("total_taxes_and_charges", total_taxes_and_charges); - }, + } - set_applicable_charges_for_item: function() { + set_applicable_charges_for_item() { var me = this; if(this.frm.doc.taxes.length) { @@ -123,15 +123,15 @@ erpnext.stock.LandedCostVoucher = erpnext.stock.StockController.extend({ refresh_field("items"); } } - }, - distribute_charges_based_on: function (frm) { + } + distribute_charges_based_on (frm) { this.set_applicable_charges_for_item(); - }, + } - items_remove: () => { + items_remove() { this.trigger('set_applicable_charges_for_item'); } -}); +}; cur_frm.script_manager.make(erpnext.stock.LandedCostVoucher); diff --git a/erpnext/stock/doctype/material_request/material_request.js b/erpnext/stock/doctype/material_request/material_request.js index 6e66f9869c0..5f53be0869e 100644 --- a/erpnext/stock/doctype/material_request/material_request.js +++ b/erpnext/stock/doctype/material_request/material_request.js @@ -408,33 +408,33 @@ frappe.ui.form.on("Material Request Item", { } }); -erpnext.buying.MaterialRequestController = erpnext.buying.BuyingController.extend({ - tc_name: function() { +erpnext.buying.MaterialRequestController = class MaterialRequestController extends erpnext.buying.BuyingController { + tc_name() { this.get_terms(); - }, + } - item_code: function() { + item_code() { // to override item code trigger from transaction.js - }, + } - validate_company_and_party: function() { + validate_company_and_party() { return true; - }, + } - calculate_taxes_and_totals: function() { + calculate_taxes_and_totals() { return; - }, + } - validate: function() { + validate() { set_schedule_date(this.frm); - }, + } - onload: function(doc, cdt, cdn) { + onload(doc, cdt, cdn) { this.frm.set_query("item_code", "items", function() { if (doc.material_request_type == "Customer Provided") { return{ query: "erpnext.controllers.queries.item_query", - filters:{ + filters:{ 'customer': me.frm.doc.customer, 'is_stock_item':1 } @@ -451,9 +451,9 @@ erpnext.buying.MaterialRequestController = erpnext.buying.BuyingController.exten } } }); - }, + } - items_add: function(doc, cdt, cdn) { + items_add(doc, cdt, cdn) { var row = frappe.get_doc(cdt, cdn); if(doc.schedule_date) { row.schedule_date = doc.schedule_date; @@ -461,19 +461,19 @@ erpnext.buying.MaterialRequestController = erpnext.buying.BuyingController.exten } else { this.frm.script_manager.copy_from_first_row("items", row, ["schedule_date"]); } - }, + } - items_on_form_rendered: function() { - set_schedule_date(this.frm); - }, - - schedule_date: function() { + items_on_form_rendered() { set_schedule_date(this.frm); } -}); + + schedule_date() { + set_schedule_date(this.frm); + } +}; // for backward compatibility: combine new and previous states -$.extend(cur_frm.cscript, new erpnext.buying.MaterialRequestController({frm: cur_frm})); +extend_cscript(cur_frm.cscript, new erpnext.buying.MaterialRequestController({frm: cur_frm})); function set_schedule_date(frm) { if(frm.doc.schedule_date){ diff --git a/erpnext/stock/doctype/purchase_receipt/purchase_receipt.js b/erpnext/stock/doctype/purchase_receipt/purchase_receipt.js index befdad96924..0182ed55a18 100644 --- a/erpnext/stock/doctype/purchase_receipt/purchase_receipt.js +++ b/erpnext/stock/doctype/purchase_receipt/purchase_receipt.js @@ -114,15 +114,15 @@ frappe.ui.form.on("Purchase Receipt", { } }); -erpnext.stock.PurchaseReceiptController = erpnext.buying.BuyingController.extend({ - setup: function(doc) { +erpnext.stock.PurchaseReceiptController = class PurchaseReceiptController extends erpnext.buying.BuyingController { + setup(doc) { this.setup_posting_date_time_check(); - this._super(doc); - }, + super.setup(doc); + } - refresh: function() { + refresh() { var me = this; - this._super(); + super.refresh(); if(this.frm.doc.docstatus > 0) { this.show_stock_ledger(); //removed for temporary @@ -201,31 +201,31 @@ erpnext.stock.PurchaseReceiptController = erpnext.buying.BuyingController.extend } this.frm.toggle_reqd("supplier_warehouse", this.frm.doc.is_subcontracted==="Yes"); - }, + } - make_purchase_invoice: function() { + make_purchase_invoice() { frappe.model.open_mapped_doc({ method: "erpnext.stock.doctype.purchase_receipt.purchase_receipt.make_purchase_invoice", frm: cur_frm }) - }, + } - make_purchase_return: function() { + make_purchase_return() { frappe.model.open_mapped_doc({ method: "erpnext.stock.doctype.purchase_receipt.purchase_receipt.make_purchase_return", frm: cur_frm }) - }, + } - close_purchase_receipt: function() { + close_purchase_receipt() { cur_frm.cscript.update_status("Closed"); - }, + } - reopen_purchase_receipt: function() { + reopen_purchase_receipt() { cur_frm.cscript.update_status("Submitted"); - }, + } - make_retention_stock_entry: function() { + make_retention_stock_entry() { frappe.call({ method: "erpnext.stock.doctype.stock_entry.stock_entry.move_sample_to_retention_warehouse", args:{ @@ -242,16 +242,16 @@ erpnext.stock.PurchaseReceiptController = erpnext.buying.BuyingController.extend } } }); - }, + } - apply_putaway_rule: function() { + apply_putaway_rule() { if (this.frm.doc.apply_putaway_rule) erpnext.apply_putaway_rule(this.frm); } -}); +}; // for backward compatibility: combine new and previous states -$.extend(cur_frm.cscript, new erpnext.stock.PurchaseReceiptController({frm: cur_frm})); +extend_cscript(cur_frm.cscript, new erpnext.stock.PurchaseReceiptController({frm: cur_frm})); cur_frm.cscript.update_status = function(status) { frappe.ui.form.is_saving = true; diff --git a/erpnext/stock/doctype/purchase_receipt/purchase_receipt.py b/erpnext/stock/doctype/purchase_receipt/purchase_receipt.py index e488b695b5f..5ba9c7057bb 100644 --- a/erpnext/stock/doctype/purchase_receipt/purchase_receipt.py +++ b/erpnext/stock/doctype/purchase_receipt/purchase_receipt.py @@ -254,6 +254,8 @@ class PurchaseReceipt(BuyingController): return process_gl_map(gl_entries) def make_item_gl_entries(self, gl_entries, warehouse_account=None): + from erpnext.accounts.doctype.purchase_invoice.purchase_invoice import get_purchase_document_details + stock_rbnb = self.get_company_default("stock_received_but_not_billed") landed_cost_entries = get_item_account_wise_additional_cost(self.name) expenses_included_in_valuation = self.get_company_default("expenses_included_in_valuation") @@ -262,6 +264,8 @@ class PurchaseReceipt(BuyingController): warehouse_with_no_account = [] stock_items = self.get_stock_items() + exchange_rate_map, net_rate_map = get_purchase_document_details(self) + for d in self.get("items"): if d.item_code in stock_items and flt(d.valuation_rate) and flt(d.qty): if warehouse_account.get(d.warehouse): @@ -287,7 +291,7 @@ class PurchaseReceipt(BuyingController): continue self.add_gl_entry(gl_entries, warehouse_account_name, d.cost_center, stock_value_diff, 0.0, remarks, - stock_rbnb, account_currency=warehouse_account_currency, item=d) + stock_rbnb, account_currency=warehouse_account_currency, item=d) # GL Entry for from warehouse or Stock Received but not billed # Intentionally passed negative debit amount to avoid incorrect GL Entry validation @@ -304,6 +308,23 @@ class PurchaseReceipt(BuyingController): -1 * flt(d.base_net_amount, d.precision("base_net_amount")), 0.0, remarks, warehouse_account_name, debit_in_account_currency=-1 * credit_amount, account_currency=credit_currency, item=d) + # check if the exchange rate has changed + if d.get('purchase_invoice'): + if exchange_rate_map[d.purchase_invoice] and \ + self.conversion_rate != exchange_rate_map[d.purchase_invoice] and \ + d.net_rate == net_rate_map[d.purchase_invoice_item]: + + discrepancy_caused_by_exchange_rate_difference = (d.qty * d.net_rate) * \ + (exchange_rate_map[d.purchase_invoice] - self.conversion_rate) + + self.add_gl_entry(gl_entries, account, d.cost_center, 0.0, discrepancy_caused_by_exchange_rate_difference, + remarks, self.supplier, debit_in_account_currency=-1 * discrepancy_caused_by_exchange_rate_difference, + account_currency=credit_currency, item=d) + + self.add_gl_entry(gl_entries, self.get_company_default("exchange_gain_loss_account"), d.cost_center, discrepancy_caused_by_exchange_rate_difference, 0.0, + remarks, self.supplier, debit_in_account_currency=-1 * discrepancy_caused_by_exchange_rate_difference, + account_currency=credit_currency, item=d) + # Amount added through landed-cos-voucher if d.landed_cost_voucher_amount and landed_cost_entries: for account, amount in iteritems(landed_cost_entries[(d.item_code, d.name)]): diff --git a/erpnext/stock/doctype/purchase_receipt/test_purchase_receipt.py b/erpnext/stock/doctype/purchase_receipt/test_purchase_receipt.py index 2eb8bfd5d2f..d56822a3081 100644 --- a/erpnext/stock/doctype/purchase_receipt/test_purchase_receipt.py +++ b/erpnext/stock/doctype/purchase_receipt/test_purchase_receipt.py @@ -774,8 +774,8 @@ class TestPurchaseReceipt(unittest.TestCase): pr1.items[0].purchase_receipt_item = pr.items[0].name pr1.submit() - pi = make_purchase_invoice(pr.name) - self.assertEqual(pi.items[0].qty, 3) + pi1 = make_purchase_invoice(pr.name) + self.assertEqual(pi1.items[0].qty, 3) pr1.cancel() pr.reload() @@ -1052,6 +1052,33 @@ class TestPurchaseReceipt(unittest.TestCase): frappe.db.set_value('Company', company, 'enable_perpetual_inventory_for_non_stock_items', before_test_value) + def test_purchase_receipt_with_exchange_rate_difference(self): + from erpnext.accounts.doctype.purchase_invoice.test_purchase_invoice import make_purchase_invoice as create_purchase_invoice + + pi = create_purchase_invoice(currency = "USD", conversion_rate = 70) + + create_warehouse("_Test Warehouse for Valuation", company="_Test Company with perpetual inventory", + properties={"account": '_Test Account Stock In Hand - TCP1'}) + + pr = make_purchase_receipt(warehouse = '_Test Warehouse for Valuation - TCP1', + company="_Test Company with perpetual inventory", currency = "USD", conversion_rate = 80, + do_not_save = "True") + + pr.items[0].purchase_invoice = pi.name + pr.items[0].purchase_invoice_item = pi.items[0].name + + pr.insert() + pr.submit() + + # fetching the latest GL Entry with 'Exchange Gain/Loss - TCP1' account + gl_entries = frappe.get_all('GL Entry', filters = {'account': 'Exchange Gain/Loss - TCP1'}) + voucher_no = frappe.get_value('GL Entry', gl_entries[0]['name'], 'voucher_no') + self.assertEqual(pr.name, voucher_no) + + exchange_gain_loss_amount = frappe.get_value('GL Entry', gl_entries[0]['name'], 'debit') + discrepancy_caused_by_exchange_rate_diff = abs(pi.items[0].base_net_amount - pr.items[0].base_net_amount) + self.assertEqual(exchange_gain_loss_amount, discrepancy_caused_by_exchange_rate_diff) + def get_sl_entries(voucher_type, voucher_no): return frappe.db.sql(""" select actual_qty, warehouse, stock_value_difference from `tabStock Ledger Entry` where voucher_type=%s and voucher_no=%s diff --git a/erpnext/stock/doctype/stock_entry/stock_entry.js b/erpnext/stock/doctype/stock_entry/stock_entry.js index 67083930272..908020d02ba 100644 --- a/erpnext/stock/doctype/stock_entry/stock_entry.js +++ b/erpnext/stock/doctype/stock_entry/stock_entry.js @@ -793,8 +793,8 @@ frappe.ui.form.on('Landed Cost Taxes and Charges', { } }); -erpnext.stock.StockEntry = erpnext.stock.StockController.extend({ - setup: function() { +erpnext.stock.StockEntry = class StockEntry extends erpnext.stock.StockController { + setup() { var me = this; this.setup_posting_date_time_check(); @@ -841,9 +841,9 @@ erpnext.stock.StockEntry = erpnext.stock.StockController.extend({ frappe.dynamic_link = { doc: this.frm.doc, fieldname: 'supplier', doctype: 'Supplier' } this.frm.set_query("supplier_address", erpnext.queries.address_query) - }, + } - onload_post_render: function() { + onload_post_render() { var me = this; this.set_default_account(function() { if(me.frm.doc.__islocal && me.frm.doc.company && !me.frm.doc.amended_from) { @@ -852,9 +852,9 @@ erpnext.stock.StockEntry = erpnext.stock.StockController.extend({ }); this.frm.get_field("items").grid.set_multiple_add("item_code", "qty"); - }, + } - refresh: function() { + refresh() { var me = this; erpnext.toggle_naming_series(); this.toggle_related_fields(this.frm.doc); @@ -865,22 +865,22 @@ erpnext.stock.StockEntry = erpnext.stock.StockController.extend({ } erpnext.hide_company(); erpnext.utils.add_item(this.frm); - }, + } - scan_barcode: function() { + scan_barcode() { let transaction_controller= new erpnext.TransactionController({frm:this.frm}); transaction_controller.scan_barcode(); - }, + } - on_submit: function() { + on_submit() { this.clean_up(); - }, + } - after_cancel: function() { + after_cancel() { this.clean_up(); - }, + } - set_default_account: function(callback) { + set_default_account(callback) { var me = this; if(this.frm.doc.company && erpnext.is_perpetual_inventory_enabled(this.frm.doc.company)) { @@ -900,9 +900,9 @@ erpnext.stock.StockEntry = erpnext.stock.StockController.extend({ } }); } - }, + } - clean_up: function() { + clean_up() { // Clear Work Order record from locals, because it is updated via Stock Entry if(this.frm.doc.work_order && in_list(["Manufacture", "Material Transfer for Manufacture", "Material Consumption for Manufacture"], @@ -910,13 +910,13 @@ erpnext.stock.StockEntry = erpnext.stock.StockController.extend({ frappe.model.remove_from_locals("Work Order", this.frm.doc.work_order); } - }, + } - fg_completed_qty: function() { + fg_completed_qty() { this.get_items(); - }, + } - get_items: function() { + get_items() { var me = this; if(!this.frm.doc.fg_completed_qty || !this.frm.doc.bom_no) frappe.throw(__("BOM and Manufacturing Quantity are required")); @@ -933,9 +933,9 @@ erpnext.stock.StockEntry = erpnext.stock.StockController.extend({ } }); } - }, + } - work_order: function() { + work_order() { var me = this; this.toggle_enable_bom(); if(!me.frm.doc.work_order || me.frm.doc.job_card) { @@ -968,13 +968,13 @@ erpnext.stock.StockEntry = erpnext.stock.StockController.extend({ } } }); - }, + } - toggle_enable_bom: function() { + toggle_enable_bom() { this.frm.toggle_enable("bom_no", !!!this.frm.doc.work_order); - }, + } - add_excise_button: function() { + add_excise_button() { if(frappe.boot.sysdefaults.country === "India") this.frm.add_custom_button(__("Excise Invoice"), function() { var excise = frappe.model.make_new_doc_and_get_name('Journal Entry'); @@ -982,9 +982,9 @@ erpnext.stock.StockEntry = erpnext.stock.StockController.extend({ excise.voucher_type = 'Excise Entry'; frappe.set_route('Form', 'Journal Entry', excise.name); }, __('Create')); - }, + } - items_add: function(doc, cdt, cdn) { + items_add(doc, cdt, cdn) { var row = frappe.get_doc(cdt, cdn); if (!(row.expense_account && row.cost_center)) { @@ -993,27 +993,27 @@ erpnext.stock.StockEntry = erpnext.stock.StockController.extend({ if(!row.s_warehouse) row.s_warehouse = this.frm.doc.from_warehouse; if(!row.t_warehouse) row.t_warehouse = this.frm.doc.to_warehouse; - }, + } - from_warehouse: function(doc) { + from_warehouse(doc) { this.frm.trigger('set_transit_warehouse'); this.set_warehouse_in_children(doc.items, "s_warehouse", doc.from_warehouse); - }, + } - to_warehouse: function(doc) { + to_warehouse(doc) { this.set_warehouse_in_children(doc.items, "t_warehouse", doc.to_warehouse); - }, + } - set_warehouse_in_children: function(child_table, warehouse_field, warehouse) { + set_warehouse_in_children(child_table, warehouse_field, warehouse) { let transaction_controller = new erpnext.TransactionController(); transaction_controller.autofill_warehouse(child_table, warehouse_field, warehouse); - }, + } - items_on_form_rendered: function(doc, grid_row) { + items_on_form_rendered(doc, grid_row) { erpnext.setup_serial_or_batch_no(); - }, + } - toggle_related_fields: function(doc) { + toggle_related_fields(doc) { this.frm.toggle_enable("from_warehouse", doc.purpose!='Material Receipt'); this.frm.toggle_enable("to_warehouse", doc.purpose!='Material Issue'); @@ -1040,12 +1040,12 @@ erpnext.stock.StockEntry = erpnext.stock.StockController.extend({ doc.purpose!='Material Issue'); this.frm.fields_dict["items"].grid.set_column_disp("additional_cost", doc.purpose!='Material Issue'); - }, + } - supplier: function(doc) { + supplier(doc) { erpnext.utils.get_party_details(this.frm, null, null, null); } -}); +}; erpnext.stock.select_batch_and_serial_no = (frm, item) => { let get_warehouse_type_and_name = (item) => { diff --git a/erpnext/stock/doctype/stock_reconciliation/stock_reconciliation.js b/erpnext/stock/doctype/stock_reconciliation/stock_reconciliation.js index ac4ed5e75d9..76a3f1a68dc 100644 --- a/erpnext/stock/doctype/stock_reconciliation/stock_reconciliation.js +++ b/erpnext/stock/doctype/stock_reconciliation/stock_reconciliation.js @@ -48,37 +48,54 @@ frappe.ui.form.on("Stock Reconciliation", { }, get_items: function(frm) { - frappe.prompt({label:"Warehouse", fieldname: "warehouse", fieldtype:"Link", options:"Warehouse", reqd: 1, + let fields = [{ + label: 'Warehouse', fieldname: 'warehouse', fieldtype: 'Link', options: 'Warehouse', reqd: 1, "get_query": function() { return { "filters": { "company": frm.doc.company, } - } - }}, - function(data) { - frappe.call({ - method:"erpnext.stock.doctype.stock_reconciliation.stock_reconciliation.get_items", - args: { - warehouse: data.warehouse, - posting_date: frm.doc.posting_date, - posting_time: frm.doc.posting_time, - company:frm.doc.company - }, - callback: function(r) { - var items = []; - frm.clear_table("items"); - for(var i=0; i< r.message.length; i++) { - var d = frm.add_child("items"); - $.extend(d, r.message[i]); - if(!d.qty) d.qty = null; - if(!d.valuation_rate) d.valuation_rate = null; - } - frm.refresh_field("items"); - } - }); + }; } - , __("Get Items"), __("Update")); + }, { + label: "Item Code", fieldname: "item_code", fieldtype: "Link", options: "Item", + "get_query": function() { + return { + "filters": { + "disabled": 0, + } + }; + } + }]; + + frappe.prompt(fields, function(data) { + frappe.call({ + method: "erpnext.stock.doctype.stock_reconciliation.stock_reconciliation.get_items", + args: { + warehouse: data.warehouse, + posting_date: frm.doc.posting_date, + posting_time: frm.doc.posting_time, + company: frm.doc.company, + item_code: data.item_code + }, + callback: function(r) { + frm.clear_table("items"); + for (var i=0; i 0) { this.show_stock_ledger(); if (erpnext.is_perpetual_inventory_enabled(this.frm.doc.company)) { this.show_general_ledger(); } } - }, + } -}); +}; cur_frm.cscript = new erpnext.stock.StockReconciliation({frm: cur_frm}); diff --git a/erpnext/stock/doctype/stock_reconciliation/stock_reconciliation.py b/erpnext/stock/doctype/stock_reconciliation/stock_reconciliation.py index 2b51c1a5c38..2956384a672 100644 --- a/erpnext/stock/doctype/stock_reconciliation/stock_reconciliation.py +++ b/erpnext/stock/doctype/stock_reconciliation/stock_reconciliation.py @@ -469,7 +469,7 @@ class StockReconciliation(StockController): def submit(self): if len(self.items) > 100: msgprint(_("The task has been enqueued as a background job. In case there is any issue on processing in background, the system will add a comment about the error on this Stock Reconciliation and revert to the Draft stage")) - self.queue_action('submit', timeout=2000) + self.queue_action('submit', timeout=4600) else: self._submit() @@ -481,45 +481,99 @@ class StockReconciliation(StockController): self._cancel() @frappe.whitelist() -def get_items(warehouse, posting_date, posting_time, company): +def get_items(warehouse, posting_date, posting_time, company, item_code=None): + items = [frappe._dict({ + 'item_code': item_code, + 'warehouse': warehouse + })] + + if not item_code: + items = get_items_for_stock_reco(warehouse, company) + + res = [] + itemwise_batch_data = get_itemwise_batch(warehouse, posting_date, company, item_code) + + for d in items: + if d.item_code in itemwise_batch_data: + stock_bal = get_stock_balance(d.item_code, d.warehouse, + posting_date, posting_time, with_valuation_rate=True) + + for row in itemwise_batch_data.get(d.item_code): + args = get_item_data(row, row.qty, stock_bal[1]) + res.append(args) + else: + stock_bal = get_stock_balance(d.item_code, d.warehouse, posting_date, posting_time, + with_valuation_rate=True , with_serial_no=cint(d.has_serial_no)) + + args = get_item_data(d, stock_bal[0], stock_bal[1], + stock_bal[2] if cint(d.has_serial_no) else '') + + res.append(args) + + return res + +def get_items_for_stock_reco(warehouse, company): lft, rgt = frappe.db.get_value("Warehouse", warehouse, ["lft", "rgt"]) items = frappe.db.sql(""" - select i.name, i.item_name, bin.warehouse, i.has_serial_no + select i.name as item_code, i.item_name, bin.warehouse as warehouse, i.has_serial_no, i.has_batch_no from tabBin bin, tabItem i - where i.name=bin.item_code and i.disabled=0 and i.is_stock_item = 1 - and i.has_variants = 0 and i.has_batch_no = 0 - and exists(select name from `tabWarehouse` where lft >= %s and rgt <= %s and name=bin.warehouse) - """, (lft, rgt)) + where i.name=bin.item_code and IFNULL(i.disabled, 0) = 0 and i.is_stock_item = 1 + and i.has_variants = 0 and exists( + select name from `tabWarehouse` where lft >= %s and rgt <= %s and name=bin.warehouse + ) + """, (lft, rgt), as_dict=1) items += frappe.db.sql(""" - select i.name, i.item_name, id.default_warehouse, i.has_serial_no + select i.name as item_code, i.item_name, id.default_warehouse as warehouse, i.has_serial_no, i.has_batch_no from tabItem i, `tabItem Default` id where i.name = id.parent and exists(select name from `tabWarehouse` where lft >= %s and rgt <= %s and name=id.default_warehouse) - and i.is_stock_item = 1 and i.has_batch_no = 0 - and i.has_variants = 0 and i.disabled = 0 and id.company=%s + and i.is_stock_item = 1 and i.has_variants = 0 and IFNULL(i.disabled, 0) = 0 and id.company=%s group by i.name - """, (lft, rgt, company)) + """, (lft, rgt, company), as_dict=1) - res = [] - for d in set(items): - stock_bal = get_stock_balance(d[0], d[2], posting_date, posting_time, - with_valuation_rate=True , with_serial_no=cint(d[3])) + return items - if frappe.db.get_value("Item", d[0], "disabled") == 0: - res.append({ - "item_code": d[0], - "warehouse": d[2], - "qty": stock_bal[0], - "item_name": d[1], - "valuation_rate": stock_bal[1], - "current_qty": stock_bal[0], - "current_valuation_rate": stock_bal[1], - "current_serial_no": stock_bal[2] if cint(d[3]) else '', - "serial_no": stock_bal[2] if cint(d[3]) else '' - }) +def get_item_data(row, qty, valuation_rate, serial_no=None): + return { + 'item_code': row.item_code, + 'warehouse': row.warehouse, + 'qty': qty, + 'item_name': row.item_name, + 'valuation_rate': valuation_rate, + 'current_qty': qty, + 'current_valuation_rate': valuation_rate, + 'current_serial_no': serial_no, + 'serial_no': serial_no, + 'batch_no': row.get('batch_no') + } - return res +def get_itemwise_batch(warehouse, posting_date, company, item_code=None): + from erpnext.stock.report.batch_wise_balance_history.batch_wise_balance_history import execute + itemwise_batch_data = {} + + filters = frappe._dict({ + 'warehouse': warehouse, + 'from_date': posting_date, + 'to_date': posting_date, + 'company': company + }) + + if item_code: + filters.item_code = item_code + + columns, data = execute(filters) + + for row in data: + itemwise_batch_data.setdefault(row[0], []).append(frappe._dict({ + 'item_code': row[0], + 'warehouse': warehouse, + 'qty': row[8], + 'item_name': row[1], + 'batch_no': row[4] + })) + + return itemwise_batch_data @frappe.whitelist() def get_stock_balance_for(item_code, warehouse, diff --git a/erpnext/stock/get_item_details.py b/erpnext/stock/get_item_details.py index c64084fe340..ca174a3f63c 100644 --- a/erpnext/stock/get_item_details.py +++ b/erpnext/stock/get_item_details.py @@ -438,6 +438,13 @@ def get_barcode_data(items_list): @frappe.whitelist() def get_item_tax_info(company, tax_category, item_codes, item_rates=None, item_tax_templates=None): out = {} + + if item_tax_templates is None: + item_tax_templates = {} + + if item_rates is None: + item_rates = {} + if isinstance(item_codes, (str,)): item_codes = json.loads(item_codes) @@ -453,7 +460,7 @@ def get_item_tax_info(company, tax_category, item_codes, item_rates=None, item_t out[item_code[1]] = {} item = frappe.get_cached_doc("Item", item_code[0]) - args = {"company": company, "tax_category": tax_category, "net_rate": item_rates[item_code[1]]} + args = {"company": company, "tax_category": tax_category, "net_rate": item_rates.get(item_code[1])} if item_tax_templates: args.update({"item_tax_template": item_tax_templates.get(item_code[1])}) diff --git a/erpnext/stock/page/stock_balance/stock_balance.js b/erpnext/stock/page/stock_balance/stock_balance.js index bddffd465e6..f00dd3e7912 100644 --- a/erpnext/stock/page/stock_balance/stock_balance.js +++ b/erpnext/stock/page/stock_balance/stock_balance.js @@ -62,7 +62,7 @@ frappe.pages['stock-balance'].on_page_load = function(wrapper) { // page.sort_selector.wrapper.css({'margin-right': '15px', 'margin-top': '4px'}); - frappe.require('assets/js/item-dashboard.min.js', function() { + frappe.require('item-dashboard.bundle.js', function() { page.item_dashboard = new erpnext.stock.ItemDashboard({ parent: page.main, page_length: 20, diff --git a/erpnext/stock/page/warehouse_capacity_summary/warehouse_capacity_summary.js b/erpnext/stock/page/warehouse_capacity_summary/warehouse_capacity_summary.js index b610e7dd587..c0ffdc9d519 100644 --- a/erpnext/stock/page/warehouse_capacity_summary/warehouse_capacity_summary.js +++ b/erpnext/stock/page/warehouse_capacity_summary/warehouse_capacity_summary.js @@ -79,7 +79,7 @@ frappe.pages['warehouse-capacity-summary'].on_page_load = function(wrapper) { } }); - frappe.require('assets/js/item-dashboard.min.js', function() { + frappe.require('item-dashboard.bundle.js', function() { $(frappe.render_template('warehouse_capacity_summary_header')).appendTo(page.main); page.capacity_dashboard = new erpnext.stock.ItemDashboard({ @@ -117,4 +117,4 @@ frappe.pages['warehouse-capacity-summary'].on_page_load = function(wrapper) { setup_click('Item'); setup_click('Warehouse'); }); -}; \ No newline at end of file +}; diff --git a/erpnext/stock/report/incorrect_stock_value_report/__init__.py b/erpnext/stock/report/incorrect_stock_value_report/__init__.py new file mode 100644 index 00000000000..e69de29bb2d diff --git a/erpnext/stock/report/incorrect_stock_value_report/incorrect_stock_value_report.js b/erpnext/stock/report/incorrect_stock_value_report/incorrect_stock_value_report.js new file mode 100644 index 00000000000..ff424807e3e --- /dev/null +++ b/erpnext/stock/report/incorrect_stock_value_report/incorrect_stock_value_report.js @@ -0,0 +1,36 @@ +// Copyright (c) 2016, Frappe Technologies Pvt. Ltd. and contributors +// For license information, please see license.txt +/* eslint-disable */ + +frappe.query_reports["Incorrect Stock Value Report"] = { + "filters": [ + { + "label": __("Company"), + "fieldname": "company", + "fieldtype": "Link", + "options": "Company", + "reqd": 1, + "default": frappe.defaults.get_user_default("Company") + }, + { + "label": __("Account"), + "fieldname": "account", + "fieldtype": "Link", + "options": "Account", + get_query: function() { + var company = frappe.query_report.get_filter_value('company'); + return { + filters: { + "account_type": "Stock", + "company": company + } + } + } + }, + { + "label": __("From Date"), + "fieldname": "from_date", + "fieldtype": "Date" + } + ] +}; diff --git a/erpnext/stock/report/incorrect_stock_value_report/incorrect_stock_value_report.json b/erpnext/stock/report/incorrect_stock_value_report/incorrect_stock_value_report.json new file mode 100644 index 00000000000..a7e9f203f7b --- /dev/null +++ b/erpnext/stock/report/incorrect_stock_value_report/incorrect_stock_value_report.json @@ -0,0 +1,29 @@ +{ + "add_total_row": 0, + "columns": [], + "creation": "2021-06-22 15:35:05.148177", + "disable_prepared_report": 0, + "disabled": 0, + "docstatus": 0, + "doctype": "Report", + "filters": [], + "idx": 0, + "is_standard": "Yes", + "modified": "2021-06-22 15:35:05.148177", + "modified_by": "Administrator", + "module": "Stock", + "name": "Incorrect Stock Value Report", + "owner": "Administrator", + "prepared_report": 0, + "ref_doctype": "Stock Ledger Entry", + "report_name": "Incorrect Stock Value Report", + "report_type": "Script Report", + "roles": [ + { + "role": "Stock User" + }, + { + "role": "Accounts Manager" + } + ] +} \ No newline at end of file diff --git a/erpnext/stock/report/incorrect_stock_value_report/incorrect_stock_value_report.py b/erpnext/stock/report/incorrect_stock_value_report/incorrect_stock_value_report.py new file mode 100644 index 00000000000..a7243878eb8 --- /dev/null +++ b/erpnext/stock/report/incorrect_stock_value_report/incorrect_stock_value_report.py @@ -0,0 +1,141 @@ +# Copyright (c) 2013, Frappe Technologies Pvt. Ltd. and contributors +# For license information, please see license.txt + +from __future__ import unicode_literals +import frappe +import erpnext +from frappe import _ +from six import iteritems +from frappe.utils import add_days, today, getdate +from erpnext.stock.utils import get_stock_value_on +from erpnext.accounts.utils import get_stock_and_account_balance + +def execute(filters=None): + if not erpnext.is_perpetual_inventory_enabled(filters.company): + frappe.throw(_("Perpetual inventory required for the company {0} to view this report.") + .format(filters.company)) + + data = get_data(filters) + columns = get_columns(filters) + + return columns, data + +def get_unsync_date(filters): + date = filters.from_date + if not date: + date = frappe.db.sql(""" SELECT min(posting_date) from `tabStock Ledger Entry`""") + date = date[0][0] + + if not date: + return + + while getdate(date) < getdate(today()): + account_bal, stock_bal, warehouse_list = get_stock_and_account_balance(posting_date=date, + company=filters.company, account = filters.account) + + if abs(account_bal - stock_bal) > 0.1: + return date + + date = add_days(date, 1) + +def get_data(report_filters): + from_date = get_unsync_date(report_filters) + + if not from_date: + return [] + + result = [] + + voucher_wise_dict = {} + data = frappe.db.sql(''' + SELECT + name, posting_date, posting_time, voucher_type, voucher_no, + stock_value_difference, stock_value, warehouse, item_code + FROM + `tabStock Ledger Entry` + WHERE + posting_date + = %s and company = %s + and is_cancelled = 0 + ORDER BY timestamp(posting_date, posting_time) asc, creation asc + ''', (from_date, report_filters.company), as_dict=1) + + for d in data: + voucher_wise_dict.setdefault((d.item_code, d.warehouse), []).append(d) + + closing_date = add_days(from_date, -1) + for key, stock_data in iteritems(voucher_wise_dict): + prev_stock_value = get_stock_value_on(posting_date = closing_date, item_code=key[0], warehouse =key[1]) + for data in stock_data: + expected_stock_value = prev_stock_value + data.stock_value_difference + if abs(data.stock_value - expected_stock_value) > 0.1: + data.difference_value = abs(data.stock_value - expected_stock_value) + data.expected_stock_value = expected_stock_value + result.append(data) + + return result + +def get_columns(filters): + return [ + { + "label": _("Stock Ledger ID"), + "fieldname": "name", + "fieldtype": "Link", + "options": "Stock Ledger Entry", + "width": "80" + }, + { + "label": _("Posting Date"), + "fieldname": "posting_date", + "fieldtype": "Date" + }, + { + "label": _("Posting Time"), + "fieldname": "posting_time", + "fieldtype": "Time" + }, + { + "label": _("Voucher Type"), + "fieldname": "voucher_type", + "width": "110" + }, + { + "label": _("Voucher No"), + "fieldname": "voucher_no", + "fieldtype": "Dynamic Link", + "options": "voucher_type", + "width": "110" + }, + { + "label": _("Item Code"), + "fieldname": "item_code", + "fieldtype": "Link", + "options": "Item", + "width": "110" + }, + { + "label": _("Warehouse"), + "fieldname": "warehouse", + "fieldtype": "Link", + "options": "Warehouse", + "width": "110" + }, + { + "label": _("Expected Stock Value"), + "fieldname": "expected_stock_value", + "fieldtype": "Currency", + "width": "150" + }, + { + "label": _("Stock Value"), + "fieldname": "stock_value", + "fieldtype": "Currency", + "width": "120" + }, + { + "label": _("Difference Value"), + "fieldname": "difference_value", + "fieldtype": "Currency", + "width": "150" + } + ] \ No newline at end of file diff --git a/erpnext/support/doctype/issue/issue.js b/erpnext/support/doctype/issue/issue.js index ecc9fcfe829..9ac1efa268d 100644 --- a/erpnext/support/doctype/issue/issue.js +++ b/erpnext/support/doctype/issue/issue.js @@ -17,84 +17,7 @@ frappe.ui.form.on("Issue", { if (r && r.allow_resetting_service_level_agreement == "0") { frm.set_df_property("reset_service_level_agreement", "hidden", 1); } - }); - - if (frm.doc.service_level_agreement) { - frappe.call({ - method: "erpnext.support.doctype.service_level_agreement.service_level_agreement.get_service_level_agreement_filters", - args: { - name: frm.doc.service_level_agreement, - customer: frm.doc.customer - }, - callback: function (r) { - if (r && r.message) { - frm.set_query("priority", function() { - return { - filters: { - "name": ["in", r.message.priority], - } - }; - }); - frm.set_query("service_level_agreement", function() { - return { - filters: { - "name": ["in", r.message.service_level_agreements], - } - }; - }); - } - } }); - } - }, - - refresh: function(frm) { - - // alert messages - if (frm.doc.status !== "Closed" && frm.doc.service_level_agreement - && frm.doc.agreement_status === "Ongoing") { - frappe.call({ - "method": "frappe.client.get", - args: { - doctype: "Service Level Agreement", - name: frm.doc.service_level_agreement - }, - callback: function(data) { - let statuses = data.message.pause_sla_on; - const hold_statuses = []; - $.each(statuses, (_i, entry) => { - hold_statuses.push(entry.status); - }); - if (hold_statuses.includes(frm.doc.status)) { - frm.dashboard.clear_headline(); - let message = { "indicator": "orange", "msg": __("SLA is on hold since {0}", [moment(frm.doc.on_hold_since).fromNow(true)]) }; - frm.dashboard.set_headline_alert( - '
' + - '
' + - '' + message.msg + ' ' + - '
' + - '
' - ); - } else { - set_time_to_resolve_and_response(frm); - } - } - }); - } else if (frm.doc.service_level_agreement) { - frm.dashboard.clear_headline(); - - let agreement_status = (frm.doc.agreement_status == "Fulfilled") ? - { "indicator": "green", "msg": "Service Level Agreement has been fulfilled" } : - { "indicator": "red", "msg": "Service Level Agreement Failed" }; - - frm.dashboard.set_headline_alert( - '
' + - '
' + - ' ' + - '
' + - '
' - ); - } // buttons if (frm.doc.status !== "Closed") { @@ -140,7 +63,7 @@ frappe.ui.form.on("Issue", { message: __("Resetting Service Level Agreement.") }); - frm.call("reset_service_level_agreement", { + frappe.call("erpnext.support.doctype.service_level_agreement.service_level_agreement.reset_service_level_agreement", { reason: values.reason, user: frappe.session.user_email }, () => { @@ -222,44 +145,4 @@ frappe.ui.form.on("Issue", { // frm.timeline.wrapper.data("help-article-event-attached", true); // } }, -}); - -function set_time_to_resolve_and_response(frm) { - frm.dashboard.clear_headline(); - - var time_to_respond = get_status(frm.doc.response_by_variance); - if (!frm.doc.first_responded_on && frm.doc.agreement_status === "Ongoing") { - time_to_respond = get_time_left(frm.doc.response_by, frm.doc.agreement_status); - } - - var time_to_resolve = get_status(frm.doc.resolution_by_variance); - if (!frm.doc.resolution_date && frm.doc.agreement_status === "Ongoing") { - time_to_resolve = get_time_left(frm.doc.resolution_by, frm.doc.agreement_status); - } - - frm.dashboard.set_headline_alert( - '
' + - '
' + - 'Time to Respond: '+ time_to_respond.diff_display +' ' + - '
' + - '
' + - 'Time to Resolve: '+ time_to_resolve.diff_display +' ' + - '
' + - '
' - ); -} - -function get_time_left(timestamp, agreement_status) { - const diff = moment(timestamp).diff(moment()); - const diff_display = diff >= 44500 ? moment.duration(diff).humanize() : "Failed"; - let indicator = (diff_display == "Failed" && agreement_status != "Fulfilled") ? "red" : "green"; - return {"diff_display": diff_display, "indicator": indicator}; -} - -function get_status(variance) { - if (variance > 0) { - return {"diff_display": "Fulfilled", "indicator": "green"}; - } else { - return {"diff_display": "Failed", "indicator": "red"}; - } -} +}); \ No newline at end of file diff --git a/erpnext/support/doctype/issue/issue.py b/erpnext/support/doctype/issue/issue.py index 9c69deb6a48..e092b07222c 100644 --- a/erpnext/support/doctype/issue/issue.py +++ b/erpnext/support/doctype/issue/issue.py @@ -7,11 +7,10 @@ import json from frappe import _ from frappe import utils from frappe.model.document import Document -from frappe.utils import cint, now_datetime, getdate, get_weekdays, add_to_date, get_time, get_datetime, time_diff_in_seconds +from frappe.utils import now_datetime from datetime import datetime, timedelta from frappe.model.mapper import get_mapped_doc from frappe.utils.user import is_website_user -from erpnext.support.doctype.service_level_agreement.service_level_agreement import get_active_service_level_agreement_for from frappe.email.inbox import link_communication_to_document class Issue(Document): @@ -25,8 +24,6 @@ class Issue(Document): if not self.raised_by: self.raised_by = frappe.session.user - self.change_service_level_agreement_and_priority() - self.update_status() self.set_lead_contact(self.raised_by) if not self.service_level_agreement: @@ -223,194 +220,6 @@ class Issue(Document): return replicated_issue.name - def before_insert(self): - if frappe.db.get_single_value("Support Settings", "track_service_level_agreement"): - if frappe.flags.in_test: - self.set_response_and_resolution_time(priority=self.priority, service_level_agreement=self.service_level_agreement) - else: - self.set_response_and_resolution_time() - - def set_response_and_resolution_time(self, priority=None, service_level_agreement=None): - service_level_agreement = get_active_service_level_agreement_for(priority=priority, - customer=self.customer, service_level_agreement=service_level_agreement) - - if not service_level_agreement: - if frappe.db.get_value("Issue", self.name, "service_level_agreement"): - frappe.throw(_("Couldn't Set Service Level Agreement {0}.").format(self.service_level_agreement)) - return - - if (service_level_agreement.customer and self.customer) and not (service_level_agreement.customer == self.customer): - frappe.throw(_("This Service Level Agreement is specific to Customer {0}").format(service_level_agreement.customer)) - - self.service_level_agreement = service_level_agreement.name - self.priority = service_level_agreement.default_priority if not priority else priority - - priority = get_priority(self) - - if not self.creation: - self.creation = now_datetime() - self.service_level_agreement_creation = now_datetime() - - start_date_time = get_datetime(self.service_level_agreement_creation) - self.response_by = get_expected_time_for(parameter="response", service_level=priority, start_date_time=start_date_time) - self.resolution_by = get_expected_time_for(parameter="resolution", service_level=priority, start_date_time=start_date_time) - - self.response_by_variance = round(time_diff_in_seconds(self.response_by, now_datetime())) - self.resolution_by_variance = round(time_diff_in_seconds(self.resolution_by, now_datetime())) - - def change_service_level_agreement_and_priority(self): - if self.service_level_agreement and frappe.db.exists("Issue", self.name) and \ - frappe.db.get_single_value("Support Settings", "track_service_level_agreement"): - - if not self.priority == frappe.db.get_value("Issue", self.name, "priority"): - self.set_response_and_resolution_time(priority=self.priority, service_level_agreement=self.service_level_agreement) - frappe.msgprint(_("Priority has been changed to {0}.").format(self.priority)) - - if not self.service_level_agreement == frappe.db.get_value("Issue", self.name, "service_level_agreement"): - self.set_response_and_resolution_time(priority=self.priority, service_level_agreement=self.service_level_agreement) - frappe.msgprint(_("Service Level Agreement has been changed to {0}.").format(self.service_level_agreement)) - - @frappe.whitelist() - def reset_service_level_agreement(self, reason, user): - if not frappe.db.get_single_value("Support Settings", "allow_resetting_service_level_agreement"): - frappe.throw(_("Allow Resetting Service Level Agreement from Support Settings.")) - - frappe.get_doc({ - "doctype": "Comment", - "comment_type": "Info", - "reference_doctype": self.doctype, - "reference_name": self.name, - "comment_email": user, - "content": " resetted Service Level Agreement - {0}".format(_(reason)), - }).insert(ignore_permissions=True) - - self.service_level_agreement_creation = now_datetime() - self.set_response_and_resolution_time(priority=self.priority, service_level_agreement=self.service_level_agreement) - self.agreement_status = "Ongoing" - self.save() - - def reset_issue_metrics(self): - self.db_set("resolution_time", None) - self.db_set("user_resolution_time", None) - - -def get_priority(issue): - service_level_agreement = frappe.get_doc("Service Level Agreement", issue.service_level_agreement) - priority = service_level_agreement.get_service_level_agreement_priority(issue.priority) - priority.update({ - "support_and_resolution": service_level_agreement.support_and_resolution, - "holiday_list": service_level_agreement.holiday_list - }) - return priority - - -def get_expected_time_for(parameter, service_level, start_date_time): - current_date_time = start_date_time - expected_time = current_date_time - start_time = None - end_time = None - - if parameter == "response": - allotted_seconds = service_level.get("response_time") - elif parameter == "resolution": - allotted_seconds = service_level.get("resolution_time") - else: - frappe.throw(_("{0} parameter is invalid").format(parameter)) - - expected_time_is_set = 0 - - support_days = {} - for service in service_level.get("support_and_resolution"): - support_days[service.workday] = frappe._dict({ - "start_time": service.start_time, - "end_time": service.end_time, - }) - - holidays = get_holidays(service_level.get("holiday_list")) - weekdays = get_weekdays() - - while not expected_time_is_set: - current_weekday = weekdays[current_date_time.weekday()] - - if not is_holiday(current_date_time, holidays) and current_weekday in support_days: - start_time = current_date_time - datetime(current_date_time.year, current_date_time.month, current_date_time.day) \ - if getdate(current_date_time) == getdate(start_date_time) and get_time_in_timedelta(current_date_time.time()) > support_days[current_weekday].start_time \ - else support_days[current_weekday].start_time - end_time = support_days[current_weekday].end_time - time_left_today = time_diff_in_seconds(end_time, start_time) - - # no time left for support today - if time_left_today <= 0: pass - elif allotted_seconds: - if time_left_today >= allotted_seconds: - expected_time = datetime.combine(getdate(current_date_time), get_time(start_time)) - expected_time = add_to_date(expected_time, seconds=allotted_seconds) - expected_time_is_set = 1 - else: - allotted_seconds = allotted_seconds - time_left_today - - if not expected_time_is_set: - current_date_time = add_to_date(current_date_time, days=1) - - if end_time and allotted_seconds >= 86400: - current_date_time = datetime.combine(getdate(current_date_time), get_time(end_time)) - else: - current_date_time = expected_time - - return current_date_time - -def set_service_level_agreement_variance(issue=None): - current_time = frappe.flags.current_time or now_datetime() - - filters = {"status": "Open", "agreement_status": "Ongoing"} - if issue: - filters = {"name": issue} - - for issue in frappe.get_list("Issue", filters=filters): - doc = frappe.get_doc("Issue", issue.name) - - if not doc.first_responded_on: # first_responded_on set when first reply is sent to customer - variance = round(time_diff_in_seconds(doc.response_by, current_time), 2) - frappe.db.set_value(dt="Issue", dn=doc.name, field="response_by_variance", val=variance, update_modified=False) - if variance < 0: - frappe.db.set_value(dt="Issue", dn=doc.name, field="agreement_status", val="Failed", update_modified=False) - - if not doc.resolution_date: # resolution_date set when issue has been closed - variance = round(time_diff_in_seconds(doc.resolution_by, current_time), 2) - frappe.db.set_value(dt="Issue", dn=doc.name, field="resolution_by_variance", val=variance, update_modified=False) - if variance < 0: - frappe.db.set_value(dt="Issue", dn=doc.name, field="agreement_status", val="Failed", update_modified=False) - - -def set_resolution_time(issue): - # total time taken from issue creation to closing - resolution_time = time_diff_in_seconds(issue.resolution_date, issue.creation) - issue.db_set("resolution_time", resolution_time) - - -def set_user_resolution_time(issue): - # total time taken by a user to close the issue apart from wait_time - communications = frappe.get_list("Communication", filters={ - "reference_doctype": issue.doctype, - "reference_name": issue.name - }, - fields=["sent_or_received", "name", "creation"], - order_by="creation" - ) - - pending_time = [] - for i in range(len(communications)): - if communications[i].sent_or_received == "Received" and communications[i-1].sent_or_received == "Sent": - wait_time = time_diff_in_seconds(communications[i].creation, communications[i-1].creation) - if wait_time > 0: - pending_time.append(wait_time) - - total_pending_time = sum(pending_time) - resolution_time_in_secs = time_diff_in_seconds(issue.resolution_date, issue.creation) - user_resolution_time = resolution_time_in_secs - total_pending_time - issue.db_set("user_resolution_time", user_resolution_time) - - def get_list_context(context=None): return { "title": _("Issues"), @@ -449,15 +258,13 @@ def get_issue_list(doctype, txt, filters, limit_start, limit_page_length=20, ord @frappe.whitelist() def set_multiple_status(names, status): - names = json.loads(names) - for name in names: - set_status(name, status) + + for name in json.loads(names): + frappe.db.set_value("Issue", name, "status", status) @frappe.whitelist() def set_status(name, status): - st = frappe.get_doc("Issue", name) - st.status = status - st.save() + frappe.db.set_value("Issue", name, "status", status) def auto_close_tickets(): """Auto-close replied support tickets after 7 days""" @@ -483,14 +290,6 @@ def update_issue(contact, method): """Called when Contact is deleted""" frappe.db.sql("""UPDATE `tabIssue` set contact='' where contact=%s""", contact.name) -def get_holidays(holiday_list_name): - holiday_list = frappe.get_cached_doc("Holiday List", holiday_list_name) - holidays = [holiday.holiday_date for holiday in holiday_list.holidays] - return holidays - -def is_holiday(date, holidays): - return getdate(date) in holidays - @frappe.whitelist() def make_task(source_name, target_doc=None): return get_mapped_doc("Issue", source_name, { @@ -516,9 +315,7 @@ def make_issue_from_communication(communication, ignore_communication_links=Fals return issue.name -def get_time_in_timedelta(time): - """ - Converts datetime.time(10, 36, 55, 961454) to datetime.timedelta(seconds=38215) - """ - import datetime - return datetime.timedelta(hours=time.hour, minutes=time.minute, seconds=time.second) +def get_holidays(holiday_list_name): + holiday_list = frappe.get_cached_doc("Holiday List", holiday_list_name) + holidays = [holiday.holiday_date for holiday in holiday_list.holidays] + return holidays diff --git a/erpnext/support/doctype/issue/test_issue.py b/erpnext/support/doctype/issue/test_issue.py index 7da5d7f0ed4..7b9b1446d4b 100644 --- a/erpnext/support/doctype/issue/test_issue.py +++ b/erpnext/support/doctype/issue/test_issue.py @@ -68,7 +68,7 @@ class TestIssue(unittest.TestCase): self.assertEqual(issue.resolution_by, datetime.datetime(2019, 3, 6, 12, 0)) frappe.flags.current_time = datetime.datetime(2019, 3, 4, 15, 0) - + issue.reload() issue.status = 'Closed' issue.save() diff --git a/erpnext/support/doctype/service_day/service_day.json b/erpnext/support/doctype/service_day/service_day.json index 68614b18072..966213099be 100644 --- a/erpnext/support/doctype/service_day/service_day.json +++ b/erpnext/support/doctype/service_day/service_day.json @@ -1,4 +1,5 @@ { + "actions": [], "creation": "2019-03-04 12:55:36.403035", "doctype": "DocType", "editable_grid": 1, @@ -16,7 +17,8 @@ "fieldtype": "Select", "in_list_view": 1, "label": "Workday", - "options": "Monday\nTuesday\nWednesday\nThursday\nFriday\nSaturday\nSunday" + "options": "Monday\nTuesday\nWednesday\nThursday\nFriday\nSaturday\nSunday", + "reqd": 1 }, { "fieldname": "section_break_2", @@ -26,7 +28,8 @@ "fieldname": "start_time", "fieldtype": "Time", "in_list_view": 1, - "label": "Start Time" + "label": "Start Time", + "reqd": 1 }, { "fieldname": "column_break_3", @@ -36,11 +39,13 @@ "fieldname": "end_time", "fieldtype": "Time", "in_list_view": 1, - "label": "End Time" + "label": "End Time", + "reqd": 1 } ], "istable": 1, - "modified": "2019-05-05 19:15:08.999579", + "links": [], + "modified": "2020-07-06 13:28:47.303873", "modified_by": "Administrator", "module": "Support", "name": "Service Day", diff --git a/erpnext/support/doctype/service_level_agreement/service_level_agreement.js b/erpnext/support/doctype/service_level_agreement/service_level_agreement.js index 00060b95300..308bce48dfb 100644 --- a/erpnext/support/doctype/service_level_agreement/service_level_agreement.js +++ b/erpnext/support/doctype/service_level_agreement/service_level_agreement.js @@ -3,16 +3,87 @@ frappe.ui.form.on('Service Level Agreement', { setup: function(frm) { - let allow_statuses = []; - const exclude_statuses = ['Open', 'Closed', 'Resolved']; + if (cint(frm.doc.apply_sla_for_resolution) === 1) { + frm.get_field('priorities').grid.editable_fields = [ + {fieldname: 'priority', columns: 1}, + {fieldname: 'default_priority', columns: 1}, + {fieldname: 'response_time', columns: 2}, + {fieldname: 'resolution_time', columns: 2} + ]; + } else { + frm.get_field('priorities').grid.editable_fields = [ + {fieldname: 'priority', columns: 1}, + {fieldname: 'default_priority', columns: 1}, + {fieldname: 'response_time', columns: 3}, + ]; + } + }, - frappe.model.with_doctype('Issue', () => { - let statuses = frappe.meta.get_docfield('Issue', 'status', frm.doc.name).options; - statuses = statuses.split('\n'); - allow_statuses = statuses.filter((status) => !exclude_statuses.includes(status)); - frm.fields_dict.pause_sla_on.grid.update_docfield_property( - 'status', 'options', [''].concat(allow_statuses) - ); + refresh: function(frm) { + frm.trigger('fetch_status_fields'); + frm.trigger('toggle_resolution_fields'); + }, + + document_type: function(frm) { + frm.trigger('fetch_status_fields'); + }, + + fetch_status_fields: function(frm) { + let allow_statuses = []; + let exclude_statuses = []; + + if (frm.doc.document_type) { + frappe.model.with_doctype(frm.doc.document_type, () => { + let statuses = frappe.meta.get_docfield(frm.doc.document_type, 'status', frm.doc.name).options; + statuses = statuses.split('\n'); + + exclude_statuses = ['Open', 'Closed']; + allow_statuses = statuses.filter((status) => !exclude_statuses.includes(status)); + + frm.fields_dict.pause_sla_on.grid.update_docfield_property( + 'status', 'options', [''].concat(allow_statuses) + ); + + exclude_statuses = ['Open']; + allow_statuses = statuses.filter((status) => !exclude_statuses.includes(status)); + frm.fields_dict.sla_fulfilled_on.grid.update_docfield_property( + 'status', 'options', [''].concat(allow_statuses) + ); + }); + } + + frm.refresh_field('pause_sla_on'); + }, + + apply_sla_for_resolution: function(frm) { + frm.trigger('toggle_resolution_fields'); + }, + + toggle_resolution_fields: function(frm) { + if (cint(frm.doc.apply_sla_for_resolution) === 1) { + frm.fields_dict.priorities.grid.update_docfield_property('resolution_time', 'hidden', 0); + frm.fields_dict.priorities.grid.update_docfield_property('resolution_time', 'reqd', 1); + } else { + frm.fields_dict.priorities.grid.update_docfield_property('resolution_time', 'hidden', 1); + frm.fields_dict.priorities.grid.update_docfield_property('resolution_time', 'reqd', 0); + } + + frm.refresh_field('priorities'); + }, + + onload: function(frm) { + frm.set_query("document_type", function() { + let invalid_doctypes = frappe.model.core_doctypes_list; + invalid_doctypes.push(frm.doc.doctype, 'Cost Center', 'Company'); + + return { + filters: [ + ['DocType', 'issingle', '=', 0], + ['DocType', 'istable', '=', 0], + ['DocType', 'name', 'not in', invalid_doctypes], + ['DocType', 'module', 'not in', ["Email", "Core", "Custom", "Event Streaming", "Social", "Data Migration", "Geo", "Desk"]] + ] + }; }); } }); diff --git a/erpnext/support/doctype/service_level_agreement/service_level_agreement.json b/erpnext/support/doctype/service_level_agreement/service_level_agreement.json index 939c1999828..61ca3a334e4 100644 --- a/erpnext/support/doctype/service_level_agreement/service_level_agreement.json +++ b/erpnext/support/doctype/service_level_agreement/service_level_agreement.json @@ -1,18 +1,18 @@ { "actions": [], - "autoname": "format:SLA-{service_level}-{####}", + "autoname": "format:SLA-{document_type}-{service_level}-{####}", "creation": "2018-12-26 21:08:15.448812", "doctype": "DocType", "editable_grid": 1, "engine": "InnoDB", "field_order": [ - "enable", + "enabled", "section_break_2", - "service_level", - "default_priority", + "document_type", "default_service_level_agreement", + "default_priority", "column_break_2", - "employee_group", + "service_level", "holiday_list", "entity_section", "entity_type", @@ -20,13 +20,14 @@ "entity", "agreement_details_section", "start_date", - "active", "column_break_7", "end_date", - "section_break_18", - "pause_sla_on", "response_and_resolution_time_section", + "apply_sla_for_resolution", "priorities", + "status_details", + "sla_fulfilled_on", + "pause_sla_on", "support_and_resolution_section_break", "support_and_resolution" ], @@ -36,7 +37,7 @@ "fieldtype": "Data", "in_list_view": 1, "in_standard_filter": 1, - "label": "Service Level", + "label": "Service Level Name", "reqd": 1 }, { @@ -51,20 +52,12 @@ "fieldtype": "Column Break" }, { - "fieldname": "employee_group", - "fieldtype": "Link", - "in_list_view": 1, - "in_standard_filter": 1, - "label": "Employee Group", - "options": "Employee Group" - }, - { + "depends_on": "eval: !doc.default_service_level_agreement", "fieldname": "agreement_details_section", "fieldtype": "Section Break", "label": "Agreement Details" }, { - "depends_on": "eval: !doc.default_service_level_agreement", "fieldname": "start_date", "fieldtype": "Date", "label": "Start Date" @@ -81,21 +74,18 @@ "label": "End Date" }, { - "collapsible": 1, "fieldname": "response_and_resolution_time_section", "fieldtype": "Section Break", "label": "Response and Resolution Time" }, { - "collapsible": 1, "fieldname": "support_and_resolution_section_break", "fieldtype": "Section Break", - "label": "Support Hours" + "label": "Working Hours" }, { "fieldname": "support_and_resolution", "fieldtype": "Table", - "label": "Support and Resolution", "options": "Service Day", "reqd": 1 }, @@ -106,13 +96,6 @@ "options": "Service Level Priority", "reqd": 1 }, - { - "default": "1", - "fieldname": "active", - "fieldtype": "Check", - "label": "Active", - "read_only": 1 - }, { "fieldname": "column_break_10", "fieldtype": "Column Break" @@ -138,15 +121,10 @@ "label": "Entity Type", "options": "\nCustomer\nCustomer Group\nTerritory" }, - { - "default": "1", - "fieldname": "enable", - "fieldtype": "Check", - "label": "Enable" - }, { "fieldname": "section_break_2", - "fieldtype": "Section Break" + "fieldtype": "Section Break", + "hide_border": 1 }, { "default": "0", @@ -161,20 +139,46 @@ "options": "Issue Priority", "read_only": 1 }, - { - "fieldname": "section_break_18", - "fieldtype": "Section Break", - "hide_border": 1 - }, { "fieldname": "pause_sla_on", "fieldtype": "Table", - "label": "Pause SLA On", + "label": "SLA Paused On", "options": "Pause SLA On Status" + }, + { + "fieldname": "document_type", + "fieldtype": "Link", + "label": "Document Type", + "options": "DocType", + "reqd": 1 + }, + { + "default": "1", + "fieldname": "enabled", + "fieldtype": "Check", + "label": "Enabled" + }, + { + "fieldname": "status_details", + "fieldtype": "Section Break", + "label": "Status Details" + }, + { + "fieldname": "sla_fulfilled_on", + "fieldtype": "Table", + "label": "SLA Fulfilled On", + "options": "SLA Fulfilled On Status", + "reqd": 1 + }, + { + "default": "1", + "fieldname": "apply_sla_for_resolution", + "fieldtype": "Check", + "label": "Apply SLA for Resolution Time" } ], "links": [], - "modified": "2020-06-10 12:30:15.050785", + "modified": "2021-05-29 13:35:41.956849", "modified_by": "Administrator", "module": "Support", "name": "Service Level Agreement", diff --git a/erpnext/support/doctype/service_level_agreement/service_level_agreement.py b/erpnext/support/doctype/service_level_agreement/service_level_agreement.py index 70c469663b7..60e5fbe80ee 100644 --- a/erpnext/support/doctype/service_level_agreement/service_level_agreement.py +++ b/erpnext/support/doctype/service_level_agreement/service_level_agreement.py @@ -6,44 +6,43 @@ from __future__ import unicode_literals import frappe from frappe.model.document import Document from frappe import _ -from frappe.utils import getdate, get_weekdays, get_link_to_form +from frappe.core.utils import get_parent_doc +from frappe.utils import time_diff_in_seconds, getdate, get_weekdays, add_to_date, get_time, get_datetime, \ + get_time_zone, to_timedelta, get_datetime_str, get_link_to_form, cint +from datetime import datetime +from erpnext.support.doctype.issue.issue import get_holidays class ServiceLevelAgreement(Document): - def validate(self): self.validate_doc() + self.validate_status_field() self.check_priorities() self.check_support_and_resolution() def check_priorities(self): - default_priority = [] priorities = [] for priority in self.priorities: # Check if response and resolution time is set for every priority - if not priority.response_time or not priority.resolution_time: - frappe.throw(_("Set Response Time and Resolution Time for Priority {0} in row {1}.").format(priority.priority, priority.idx)) + if not priority.response_time: + frappe.throw(_("Set Response Time for Priority {0} in row {1}.").format(priority.priority, priority.idx)) + + if self.apply_sla_for_resolution: + if not priority.resolution_time: + frappe.throw(_("Set Response Time for Priority {0} in row {1}.").format(priority.priority, priority.idx)) + + response = priority.response_time + resolution = priority.resolution_time + if response > resolution: + frappe.throw(_("Response Time for {0} priority in row {1} can't be greater than Resolution Time.").format(priority.priority, priority.idx)) priorities.append(priority.priority) - if priority.default_priority: - default_priority.append(priority.default_priority) - - response = priority.response_time - resolution = priority.resolution_time - - if response > resolution: - frappe.throw(_("Response Time for {0} priority in row {1} can't be greater than Resolution Time.").format(priority.priority, priority.idx)) - # Check if repeated priority if not len(set(priorities)) == len(priorities): repeated_priority = get_repeated(priorities) frappe.throw(_("Priority {0} has been repeated.").format(repeated_priority)) - # Check if repeated default priority - if not len(set(default_priority)) == len(default_priority): - frappe.throw(_("Select only one Priority as Default.")) - # set default priority from priorities try: self.default_priority = next(d.priority for d in self.priorities if d.default_priority) @@ -55,17 +54,12 @@ class ServiceLevelAgreement(Document): support_days = [] for support_and_resolution in self.support_and_resolution: - # Check if start and end time is set for every support day - if not (support_and_resolution.start_time or support_and_resolution.end_time): - frappe.throw(_("Set Start Time and End Time for \ - Support Day {0} at index {1}.".format(support_and_resolution.workday, support_and_resolution.idx))) - support_days.append(support_and_resolution.workday) support_and_resolution.idx = week.index(support_and_resolution.workday) + 1 - if support_and_resolution.start_time >= support_and_resolution.end_time: - frappe.throw(_("Start Time can't be greater than or equal to End Time \ - for {0}.".format(support_and_resolution.workday))) + if to_timedelta(support_and_resolution.start_time) >= to_timedelta(support_and_resolution.end_time): + frappe.throw(_("Start Time can't be greater than or equal to End Time for {0}.").format( + support_and_resolution.workday)) # Check for repeated workday if not len(set(support_days)) == len(support_days): @@ -73,24 +67,34 @@ class ServiceLevelAgreement(Document): frappe.throw(_("Workday {0} has been repeated.").format(repeated_days)) def validate_doc(self): - if not frappe.db.get_single_value("Support Settings", "track_service_level_agreement") and self.enable: + if self.enabled and self.document_type == "Issue" \ + and not frappe.db.get_single_value("Support Settings", "track_service_level_agreement"): frappe.throw(_("{0} is not enabled in {1}").format(frappe.bold("Track Service Level Agreement"), get_link_to_form("Support Settings", "Support Settings"))) - if self.default_service_level_agreement: - if frappe.db.exists("Service Level Agreement", {"default_service_level_agreement": "1", "name": ["!=", self.name]}): - frappe.throw(_("A Default Service Level Agreement already exists.")) - else: - if self.start_date and self.end_date: - if getdate(self.start_date) >= getdate(self.end_date): - frappe.throw(_("Start Date of Agreement can't be greater than or equal to End Date.")) + if self.default_service_level_agreement and frappe.db.exists("Service Level Agreement", { + "document_type": self.document_type, + "default_service_level_agreement": "1", + "name": ["!=", self.name] + }): + frappe.throw(_("Default Service Level Agreement for {0} already exists.").format(self.document_type)) - if getdate(self.end_date) < getdate(frappe.utils.getdate()): - frappe.throw(_("End Date of Agreement can't be less than today.")) + if self.start_date and self.end_date: + self.validate_from_to_dates(self.start_date, self.end_date) - if self.entity_type and self.entity: - if frappe.db.exists("Service Level Agreement", {"entity_type": self.entity_type, "entity": self.entity, "name": ["!=", self.name]}): - frappe.throw(_("Service Level Agreement with Entity Type {0} and Entity {1} already exists.").format(self.entity_type, self.entity)) + if self.entity_type and self.entity and frappe.db.exists("Service Level Agreement", { + "entity_type": self.entity_type, + "entity": self.entity, + "name": ["!=", self.name] + }): + frappe.throw(_("Service Level Agreement for {0} {1} already exists.").format( + frappe.bold(self.entity_type), frappe.bold(self.entity))) + + def validate_status_field(self): + meta = frappe.get_meta(self.document_type) + if not meta.get_field("status"): + frappe.throw(_("The Document Type {0} must have a Status field to configure Service Level Agreement").format( + frappe.bold(self.document_type))) def get_service_level_agreement_priority(self, priority): priority = frappe.get_doc("Service Level Priority", {"priority": priority, "parent": self.name}) @@ -101,78 +105,169 @@ class ServiceLevelAgreement(Document): "resolution_time": priority.resolution_time }) + def before_insert(self): + # no need to set up SLA fields for Issue dt as they are standard fields in Issue + if self.document_type == "Issue": + return + + service_level_agreement_fields = get_service_level_agreement_fields() + meta = frappe.get_meta(self.document_type, cached=False) + + if meta.custom: + self.create_docfields(meta, service_level_agreement_fields) + else: + self.create_custom_fields(meta, service_level_agreement_fields) + + def on_trash(self): + set_documents_with_active_service_level_agreement() + + def after_insert(self): + set_documents_with_active_service_level_agreement() + + def on_update(self): + set_documents_with_active_service_level_agreement() + + def create_docfields(self, meta, service_level_agreement_fields): + last_index = len(meta.fields) + + for field in service_level_agreement_fields: + if not meta.has_field(field.get("fieldname")): + last_index += 1 + + frappe.get_doc({ + "doctype": "DocField", + "idx": last_index, + "parenttype": "DocType", + "parentfield": "fields", + "parent": self.document_type, + "label": field.get("label"), + "fieldname": field.get("fieldname"), + "fieldtype": field.get("fieldtype"), + "collapsible": field.get("collapsible"), + "options": field.get("options"), + "read_only": field.get("read_only"), + "hidden": field.get("hidden"), + "description": field.get("description"), + "default": field.get("default"), + }).insert(ignore_permissions=True) + else: + existing_field = meta.get_field(field.get("fieldname")) + self.reset_field_properties(existing_field, "DocField", field) + + # to update meta and modified timestamp + frappe.get_doc('DocType', self.document_type).save(ignore_permissions=True) + + def create_custom_fields(self, meta, service_level_agreement_fields): + for field in service_level_agreement_fields: + if not meta.has_field(field.get("fieldname")): + frappe.get_doc({ + "doctype": "Custom Field", + "dt": self.document_type, + "label": field.get("label"), + "fieldname": field.get("fieldname"), + "fieldtype": field.get("fieldtype"), + "insert_after": "append", + "collapsible": field.get("collapsible"), + "options": field.get("options"), + "read_only": field.get("read_only"), + "hidden": field.get("hidden"), + "description": field.get("description"), + "default": field.get("default"), + }).insert(ignore_permissions=True) + else: + existing_field = meta.get_field(field.get("fieldname")) + self.reset_field_properties(existing_field, "Custom Field", field) + + def reset_field_properties(self, field, field_dt, sla_field): + field = frappe.get_doc(field_dt, {"fieldname": field.fieldname}) + field.label = sla_field.get("label") + field.fieldname = sla_field.get("fieldname") + field.fieldtype = sla_field.get("fieldtype") + field.collapsible = sla_field.get("collapsible") + field.hidden = sla_field.get("hidden") + field.options = sla_field.get("options") + field.read_only = sla_field.get("read_only") + field.hidden = sla_field.get("hidden") + field.description = sla_field.get("description") + field.default = sla_field.get("default") + field.save(ignore_permissions=True) + + def check_agreement_status(): - service_level_agreements = frappe.get_list("Service Level Agreement", filters=[ - {"active": 1}, + service_level_agreements = frappe.get_all("Service Level Agreement", filters=[ + {"enabled": 1}, {"default_service_level_agreement": 0} ], fields=["name"]) for service_level_agreement in service_level_agreements: doc = frappe.get_doc("Service Level Agreement", service_level_agreement.name) if doc.end_date and getdate(doc.end_date) < getdate(frappe.utils.getdate()): - frappe.db.set_value("Service Level Agreement", service_level_agreement.name, "active", 0) + frappe.db.set_value("Service Level Agreement", service_level_agreement.name, "enabled", 0) -def get_active_service_level_agreement_for(priority, customer=None, service_level_agreement=None): - if not frappe.db.get_single_value("Support Settings", "track_service_level_agreement"): + +def get_active_service_level_agreement_for(doctype, priority, customer=None, service_level_agreement=None): + if doctype == "Issue" and not frappe.db.get_single_value("Support Settings", "track_service_level_agreement"): return filters = [ - ["Service Level Agreement", "active", "=", 1], - ["Service Level Agreement", "enable", "=", 1] + ["Service Level Agreement", "document_type", "=", doctype], + ["Service Level Agreement", "enabled", "=", 1] ] - if priority: filters.append(["Service Level Priority", "priority", "=", priority]) - or_filters = [ - ["Service Level Agreement", "entity", "in", [customer, get_customer_group(customer), get_customer_territory(customer)]] - ] + or_filters = [] if service_level_agreement: or_filters = [ ["Service Level Agreement", "name", "=", service_level_agreement], ] + if customer: + or_filters.append( + ["Service Level Agreement", "entity", "in", [customer, get_customer_group(customer), get_customer_territory(customer)]] + ) or_filters.append(["Service Level Agreement", "default_service_level_agreement", "=", 1]) - agreement = frappe.get_list("Service Level Agreement", filters=filters, or_filters=or_filters, - fields=["name", "default_priority"]) + agreement = frappe.get_all("Service Level Agreement", filters=filters, or_filters=or_filters, + fields=["name", "default_priority", "apply_sla_for_resolution"]) return agreement[0] if agreement else None + def get_customer_group(customer): - if customer: - return frappe.db.get_value("Customer", customer, "customer_group") + return frappe.db.get_value("Customer", customer, "customer_group") if customer else None + def get_customer_territory(customer): - if customer: - return frappe.db.get_value("Customer", customer, "territory") + return frappe.db.get_value("Customer", customer, "territory") if customer else None + @frappe.whitelist() -def get_service_level_agreement_filters(name, customer=None): +def get_service_level_agreement_filters(doctype, name, customer=None): if not frappe.db.get_single_value("Support Settings", "track_service_level_agreement"): return filters = [ - ["Service Level Agreement", "active", "=", 1], - ["Service Level Agreement", "enable", "=", 1] + ["Service Level Agreement", "document_type", "=", doctype], + ["Service Level Agreement", "enabled", "=", 1] ] - if not customer: - or_filters = [ - ["Service Level Agreement", "default_service_level_agreement", "=", 1] - ] - else: + or_filters = [ + ["Service Level Agreement", "default_service_level_agreement", "=", 1] + ] + + if customer: # Include SLA with No Entity and Entity Type - or_filters = [ - ["Service Level Agreement", "entity", "in", [customer, get_customer_group(customer), get_customer_territory(customer), ""]], - ["Service Level Agreement", "default_service_level_agreement", "=", 1] - ] + or_filters.append( + ["Service Level Agreement", "entity", "in", [customer, get_customer_group(customer), get_customer_territory(customer), ""]] + ) return { - "priority": [priority.priority for priority in frappe.get_list("Service Level Priority", filters={"parent": name}, fields=["priority"])], - "service_level_agreements": [d.name for d in frappe.get_list("Service Level Agreement", filters=filters, or_filters=or_filters)] + "priority": [priority.priority for priority in frappe.get_all("Service Level Priority", filters={"parent": name}, fields=["priority"])], + "service_level_agreements": [d.name for d in frappe.get_all("Service Level Agreement", filters=filters, or_filters=or_filters)] } + def get_repeated(values): unique_list = [] diff = [] @@ -183,3 +278,573 @@ def get_repeated(values): if value not in diff: diff.append(str(value)) return " ".join(diff) + + +def get_documents_with_active_service_level_agreement(): + if not frappe.cache().hget("service_level_agreement", "active"): + set_documents_with_active_service_level_agreement() + + return frappe.cache().hget("service_level_agreement", "active") + + +def set_documents_with_active_service_level_agreement(): + active = [sla.document_type for sla in frappe.get_all("Service Level Agreement", fields=["document_type"])] + frappe.cache().hset("service_level_agreement", "active", active) + + +def apply(doc, method=None): + # Applies SLA to document on validate + if frappe.flags.in_patch or frappe.flags.in_install or frappe.flags.in_setup_wizard or \ + doc.doctype not in get_documents_with_active_service_level_agreement(): + return + + service_level_agreement = get_active_service_level_agreement_for(doctype=doc.get("doctype"), priority=doc.get("priority"), + customer=doc.get("customer"), service_level_agreement=doc.get("service_level_agreement")) + + if not service_level_agreement: + return + + set_sla_properties(doc, service_level_agreement) + + +def set_sla_properties(doc, service_level_agreement): + if frappe.db.exists(doc.doctype, doc.name): + from_db = frappe.get_doc(doc.doctype, doc.name) + else: + from_db = frappe._dict({}) + + meta = frappe.get_meta(doc.doctype) + + if meta.has_field("customer") and service_level_agreement.customer and doc.get("customer") and \ + not service_level_agreement.customer == doc.get("customer"): + frappe.throw(_("Service Level Agreement {0} is specific to Customer {1}").format(service_level_agreement.name, + service_level_agreement.customer)) + + doc.service_level_agreement = service_level_agreement.name + doc.priority = doc.get("priority") or service_level_agreement.default_priority + priority = get_priority(doc) + + if not doc.creation: + doc.creation = now_datetime(doc.get("owner")) + + if meta.has_field("service_level_agreement_creation"): + doc.service_level_agreement_creation = now_datetime(doc.get("owner")) + + start_date_time = get_datetime(doc.get("service_level_agreement_creation") or doc.creation) + + set_response_by_and_variance(doc, meta, start_date_time, priority) + if service_level_agreement.apply_sla_for_resolution: + set_resolution_by_and_variance(doc, meta, start_date_time, priority) + + update_status(doc, from_db, meta) + + +def update_status(doc, from_db, meta): + if meta.has_field("status"): + if meta.has_field("first_responded_on") and doc.status != "Open" and \ + from_db.status == "Open" and not doc.first_responded_on: + doc.first_responded_on = frappe.flags.current_time or now_datetime(doc.get("owner")) + + if meta.has_field("service_level_agreement") and doc.service_level_agreement: + # mark sla status as fulfilled based on the configuration + fulfillment_statuses = [entry.status for entry in frappe.db.get_all("SLA Fulfilled On Status", filters={ + "parent": doc.service_level_agreement + }, fields=["status"])] + + if doc.status in fulfillment_statuses and from_db.status not in fulfillment_statuses: + apply_sla_for_resolution = frappe.db.get_value("Service Level Agreement", doc.service_level_agreement, + "apply_sla_for_resolution") + + if apply_sla_for_resolution and meta.has_field("resolution_date"): + doc.resolution_date = frappe.flags.current_time or now_datetime(doc.get("owner")) + + if meta.has_field("agreement_status") and from_db.agreement_status == "Ongoing": + set_service_level_agreement_variance(doc.doctype, doc.name) + update_agreement_status(doc, meta) + + if apply_sla_for_resolution: + set_resolution_time(doc, meta) + set_user_resolution_time(doc, meta) + + if doc.status == "Open" and from_db.status != "Open": + # if no date, it should be set as None and not a blank string "", as per mysql strict config + # enable SLA and variance on Reopen + reset_metrics(doc, meta) + set_service_level_agreement_variance(doc.doctype, doc.name) + + handle_hold_time(doc, meta, from_db.status) + + +def get_expected_time_for(parameter, service_level, start_date_time): + current_date_time = start_date_time + expected_time = current_date_time + start_time = end_time = None + expected_time_is_set = 0 + + allotted_seconds = get_allotted_seconds(parameter, service_level) + support_days = get_support_days(service_level) + holidays = get_holidays(service_level.get("holiday_list")) + weekdays = get_weekdays() + + while not expected_time_is_set: + current_weekday = weekdays[current_date_time.weekday()] + + if not is_holiday(current_date_time, holidays) and current_weekday in support_days: + if getdate(current_date_time) == getdate(start_date_time) \ + and get_time_in_timedelta(current_date_time.time()) > support_days[current_weekday].start_time: + start_time = current_date_time - datetime(current_date_time.year, current_date_time.month, current_date_time.day) + else: + start_time = support_days[current_weekday].start_time + + end_time = support_days[current_weekday].end_time + time_left_today = time_diff_in_seconds(end_time, start_time) + # no time left for support today + if time_left_today <= 0: + pass + + elif allotted_seconds: + if time_left_today >= allotted_seconds: + expected_time = datetime.combine(getdate(current_date_time), get_time(start_time)) + expected_time = add_to_date(expected_time, seconds=allotted_seconds) + expected_time_is_set = 1 + else: + allotted_seconds = allotted_seconds - time_left_today + + if not expected_time_is_set: + current_date_time = add_to_date(current_date_time, days=1) + + if end_time and allotted_seconds >= 86400: + current_date_time = datetime.combine(getdate(current_date_time), get_time(end_time)) + else: + current_date_time = expected_time + + return current_date_time + + +def get_allotted_seconds(parameter, service_level): + allotted_seconds = 0 + if parameter == "response": + allotted_seconds = service_level.get("response_time") + elif parameter == "resolution": + allotted_seconds = service_level.get("resolution_time") + else: + frappe.throw(_("{0} parameter is invalid").format(parameter)) + + return allotted_seconds + + +def get_support_days(service_level): + support_days = {} + for service in service_level.get("support_and_resolution"): + support_days[service.workday] = frappe._dict({ + "start_time": service.start_time, + "end_time": service.end_time, + }) + return support_days + + +def set_service_level_agreement_variance(doctype, doc=None): + + filters = {"status": "Open", "agreement_status": "Ongoing"} + + if doc: + filters = {"name": doc} + + for entry in frappe.get_all(doctype, filters=filters): + current_doc = frappe.get_doc(doctype, entry.name) + current_time = frappe.flags.current_time or now_datetime(current_doc.get("owner")) + apply_sla_for_resolution = frappe.db.get_value("Service Level Agreement", current_doc.service_level_agreement, + "apply_sla_for_resolution") + + if not current_doc.first_responded_on: # first_responded_on set when first reply is sent to customer + variance = round(time_diff_in_seconds(current_doc.response_by, current_time), 2) + frappe.db.set_value(current_doc.doctype, current_doc.name, "response_by_variance", variance, update_modified=False) + + if variance < 0: + frappe.db.set_value(current_doc.doctype, current_doc.name, "agreement_status", "Failed", update_modified=False) + + if apply_sla_for_resolution and not current_doc.get("resolution_date"): # resolution_date set when issue has been closed + variance = round(time_diff_in_seconds(current_doc.resolution_by, current_time), 2) + frappe.db.set_value(current_doc.doctype, current_doc.name, "resolution_by_variance", variance, update_modified=False) + + if variance < 0: + frappe.db.set_value(current_doc.doctype, current_doc.name, "agreement_status", "Failed", update_modified=False) + + +def set_user_resolution_time(doc, meta): + # total time taken by a user to close the issue apart from wait_time + if not meta.has_field("user_resolution_time"): + return + + communications = frappe.get_all("Communication", filters={ + "reference_doctype": doc.doctype, + "reference_name": doc.name + }, fields=["sent_or_received", "name", "creation"], order_by="creation") + + pending_time = [] + for i in range(len(communications)): + if communications[i].sent_or_received == "Received" and communications[i-1].sent_or_received == "Sent": + wait_time = time_diff_in_seconds(communications[i].creation, communications[i-1].creation) + if wait_time > 0: + pending_time.append(wait_time) + + total_pending_time = sum(pending_time) + resolution_time_in_secs = time_diff_in_seconds(doc.resolution_date, doc.creation) + doc.user_resolution_time = resolution_time_in_secs - total_pending_time + + +def change_service_level_agreement_and_priority(self): + if self.service_level_agreement and frappe.db.exists("Issue", self.name) and \ + frappe.db.get_single_value("Support Settings", "track_service_level_agreement"): + + if not self.priority == frappe.db.get_value("Issue", self.name, "priority"): + self.set_response_and_resolution_time(priority=self.priority, service_level_agreement=self.service_level_agreement) + frappe.msgprint(_("Priority has been changed to {0}.").format(self.priority)) + + if not self.service_level_agreement == frappe.db.get_value("Issue", self.name, "service_level_agreement"): + self.set_response_and_resolution_time(priority=self.priority, service_level_agreement=self.service_level_agreement) + frappe.msgprint(_("Service Level Agreement has been changed to {0}.").format(self.service_level_agreement)) + + +def get_priority(doc): + service_level_agreement = frappe.get_doc("Service Level Agreement", doc.service_level_agreement) + priority = service_level_agreement.get_service_level_agreement_priority(doc.priority) + priority.update({ + "support_and_resolution": service_level_agreement.support_and_resolution, + "holiday_list": service_level_agreement.holiday_list + }) + return priority + + +def reset_service_level_agreement(doc, reason, user): + if not frappe.db.get_single_value("Support Settings", "allow_resetting_service_level_agreement"): + frappe.throw(_("Allow Resetting Service Level Agreement from Support Settings.")) + + frappe.get_doc({ + "doctype": "Comment", + "comment_type": "Info", + "reference_doctype": doc.doctype, + "reference_name": doc.name, + "comment_email": user, + "content": " resetted Service Level Agreement - {0}".format(_(reason)), + }).insert(ignore_permissions=True) + + doc.service_level_agreement_creation = now_datetime(doc.get("owner")) + doc.set_response_and_resolution_time(priority=doc.priority, service_level_agreement=doc.service_level_agreement) + doc.agreement_status = "Ongoing" + doc.save() + + +def reset_metrics(doc, meta): + if meta.has_field("resolution_date"): + doc.resolution_date = None + + if not meta.has_field("resolution_time"): + doc.resolution_time = None + + if not meta.has_field("user_resolution_time"): + doc.user_resolution_time = None + + if meta.has_field("agreement_status"): + doc.agreement_status = "Ongoing" + + +def set_resolution_time(doc, meta): + # total time taken from issue creation to closing + if not meta.has_field("resolution_time"): + return + + doc.resolution_time = time_diff_in_seconds(doc.resolution_date, doc.creation) + + +# called via hooks on communication update +def update_hold_time(doc, status): + parent = get_parent_doc(doc) + if not parent: + return + + if doc.communication_type == "Comment": + return + + status_field = parent.meta.get_field("status") + if status_field: + options = (status_field.options or "").splitlines() + + # if status has a "Replied" option, then handle hold time + if ("Replied" in options) and doc.sent_or_received == "Received": + meta = frappe.get_meta(parent.doctype) + handle_hold_time(parent, meta, 'Replied') + + +def handle_hold_time(doc, meta, status): + if meta.has_field("service_level_agreement") and doc.service_level_agreement: + # set response and resolution variance as None as the issue is on Hold for status as Replied + hold_statuses = [entry.status for entry in frappe.db.get_all("Pause SLA On Status", filters={ + "parent": doc.service_level_agreement + }, fields=["status"])] + + if not hold_statuses: + return + + if meta.has_field("status") and doc.status in hold_statuses and status not in hold_statuses: + apply_hold_status(doc, meta) + + # calculate hold time when status is changed from any hold status to any non-hold status + if meta.has_field("status") and doc.status not in hold_statuses and status in hold_statuses: + reset_hold_status_and_update_hold_time(doc, meta) + + +def apply_hold_status(doc, meta): + update_values = {'on_hold_since': frappe.flags.current_time or now_datetime(doc.get("owner"))} + + if meta.has_field("first_responded_on") and not doc.first_responded_on: + update_values['response_by'] = None + update_values['response_by_variance'] = 0 + + update_values['resolution_by'] = None + update_values['resolution_by_variance'] = 0 + + doc.db_set(update_values) + + +def reset_hold_status_and_update_hold_time(doc, meta): + hold_time = doc.total_hold_time if meta.has_field("total_hold_time") and doc.total_hold_time else 0 + now_time = frappe.flags.current_time or now_datetime(doc.get("owner")) + last_hold_time = 0 + update_values = {} + + if meta.has_field("on_hold_since") and doc.on_hold_since: + # last_hold_time will be added to the sla variables + last_hold_time = time_diff_in_seconds(now_time, doc.on_hold_since) + update_values['total_hold_time'] = hold_time + last_hold_time + + # re-calculate SLA variables after issue changes from any hold status to any non-hold status + start_date_time = get_datetime(doc.get("service_level_agreement_creation") or doc.creation) + priority = get_priority(doc) + now_time = frappe.flags.current_time or now_datetime(doc.get("owner")) + + # add hold time to response by variance + if meta.has_field("first_responded_on") and not doc.first_responded_on: + response_by = get_expected_time_for(parameter="response", service_level=priority, start_date_time=start_date_time) + response_by = add_to_date(response_by, seconds=round(last_hold_time)) + response_by_variance = round(time_diff_in_seconds(response_by, now_time)) + + update_values['response_by'] = response_by + update_values['response_by_variance'] = response_by_variance + last_hold_time + + # add hold time to resolution by variance + if frappe.db.get_value("Service Level Agreement", doc.service_level_agreement, "apply_sla_for_resolution"): + resolution_by = get_expected_time_for(parameter="resolution", service_level=priority, start_date_time=start_date_time) + resolution_by = add_to_date(resolution_by, seconds=round(last_hold_time)) + resolution_by_variance = round(time_diff_in_seconds(resolution_by, now_time)) + + update_values['resolution_by'] = resolution_by + update_values['resolution_by_variance'] = resolution_by_variance + last_hold_time + + update_values['on_hold_since'] = None + + doc.db_set(update_values) + + +def get_service_level_agreement_fields(): + return [ + { + "collapsible": 1, + "fieldname": "service_level_section", + "fieldtype": "Section Break", + "label": "Service Level" + }, + { + "fieldname": "service_level_agreement", + "fieldtype": "Link", + "label": "Service Level Agreement", + "options": "Service Level Agreement" + }, + { + "fieldname": "priority", + "fieldtype": "Link", + "label": "Priority", + "options": "Issue Priority" + }, + { + "fieldname": "response_by", + "fieldtype": "Datetime", + "label": "Response By", + "read_only": 1 + }, + { + "fieldname": "response_by_variance", + "fieldtype": "Duration", + "hide_seconds": 1, + "label": "Response By Variance", + "read_only": 1 + }, + { + "fieldname": "first_responded_on", + "fieldtype": "Datetime", + "label": "First Responded On", + "read_only": 1 + }, + { + "fieldname": "on_hold_since", + "fieldtype": "Datetime", + "hidden": 1, + "label": "On Hold Since", + "read_only": 1 + }, + { + "fieldname": "total_hold_time", + "fieldtype": "Duration", + "label": "Total Hold Time", + "read_only": 1 + }, + { + "fieldname": "cb", + "fieldtype": "Column Break", + "read_only": 1 + }, + { + "default": "Ongoing", + "fieldname": "agreement_status", + "fieldtype": "Select", + "label": "Service Level Agreement Status", + "options": "Ongoing\nFulfilled\nFailed", + "read_only": 1 + }, + { + "fieldname": "resolution_by", + "fieldtype": "Datetime", + "label": "Resolution By", + "read_only": 1 + }, + { + "fieldname": "resolution_by_variance", + "fieldtype": "Duration", + "hide_seconds": 1, + "label": "Resolution By Variance", + "read_only": 1 + }, + { + "fieldname": "service_level_agreement_creation", + "fieldtype": "Datetime", + "hidden": 1, + "label": "Service Level Agreement Creation", + "read_only": 1 + }, + { + "depends_on": "eval:!doc.__islocal", + "fieldname": "resolution_date", + "fieldtype": "Datetime", + "label": "Resolution Date", + "no_copy": 1, + "read_only": 1 + } + ] + + +def update_agreement_status_on_custom_status(doc): + # Update Agreement Fulfilled status using Custom Scripts for Custom Status + + meta = frappe.get_meta(doc.doctype) + now_time = frappe.flags.current_time or now_datetime(doc.get("owner")) + if meta.has_field("first_responded_on") and not doc.first_responded_on: + # first_responded_on set when first reply is sent to customer + doc.response_by_variance = round(time_diff_in_seconds(doc.response_by, now_time), 2) + + if meta.has_field("resolution_date") and not doc.resolution_date: + # resolution_date set when issue has been closed + doc.resolution_by_variance = round(time_diff_in_seconds(doc.resolution_by, now_time), 2) + + if meta.has_field("agreement_status"): + doc.agreement_status = "Fulfilled" if doc.response_by_variance > 0 and doc.resolution_by_variance > 0 else "Failed" + + +def update_agreement_status(doc, meta): + if meta.has_field("service_level_agreement") and meta.has_field("agreement_status") and \ + doc.service_level_agreement and doc.agreement_status == "Ongoing": + + apply_sla_for_resolution = frappe.db.get_value("Service Level Agreement", doc.service_level_agreement, + "apply_sla_for_resolution") + + # if SLA is applied for resolution check for response and resolution, else only response + if apply_sla_for_resolution: + if meta.has_field("response_by_variance") and meta.has_field("resolution_by_variance"): + if cint(frappe.db.get_value(doc.doctype, doc.name, "response_by_variance")) < 0 or \ + cint(frappe.db.get_value(doc.doctype, doc.name, "resolution_by_variance")) < 0: + + doc.agreement_status = "Failed" + else: + doc.agreement_status = "Fulfilled" + else: + if meta.has_field("response_by_variance") and \ + cint(frappe.db.get_value(doc.doctype, doc.name, "response_by_variance")) < 0: + doc.agreement_status = "Failed" + else: + doc.agreement_status = "Fulfilled" + + +def is_holiday(date, holidays): + return getdate(date) in holidays + + +def get_time_in_timedelta(time): + """Converts datetime.time(10, 36, 55, 961454) to datetime.timedelta(seconds=38215).""" + import datetime + return datetime.timedelta(hours=time.hour, minutes=time.minute, seconds=time.second) + + +def set_response_by_and_variance(doc, meta, start_date_time, priority): + if meta.has_field("response_by"): + doc.response_by = get_expected_time_for(parameter="response", service_level=priority, start_date_time=start_date_time) + + if meta.has_field("response_by_variance"): + now_time = frappe.flags.current_time or now_datetime(doc.get("owner")) + doc.response_by_variance = round(time_diff_in_seconds(doc.response_by, now_time), 2) + +def set_resolution_by_and_variance(doc, meta, start_date_time, priority): + if meta.has_field("resolution_by"): + doc.resolution_by = get_expected_time_for(parameter="resolution", service_level=priority, start_date_time=start_date_time) + + if meta.has_field("resolution_by_variance"): + now_time = frappe.flags.current_time or now_datetime(doc.get("owner")) + doc.resolution_by_variance = round(time_diff_in_seconds(doc.resolution_by, now_time), 2) + + +def now_datetime(user): + dt = convert_utc_to_user_timezone(datetime.utcnow(), user) + return dt.replace(tzinfo=None) + + +def convert_utc_to_user_timezone(utc_timestamp, user): + from pytz import timezone, UnknownTimeZoneError + + user_tz = get_tz(user) + utcnow = timezone('UTC').localize(utc_timestamp) + try: + return utcnow.astimezone(timezone(user_tz)) + except UnknownTimeZoneError: + return utcnow + + +def get_tz(user): + return frappe.db.get_value("User", user, "time_zone") or get_time_zone() + + +@frappe.whitelist() +def get_user_time(user, to_string=False): + return get_datetime_str(now_datetime(user)) if to_string else now_datetime(user) + + +@frappe.whitelist() +def get_sla_doctypes(): + doctypes = [] + data = frappe.get_list('Service Level Agreement', + {'enabled': 1}, + ['document_type'], + distinct=1 + ) + + for entry in data: + doctypes.append(entry.document_type) + + return doctypes diff --git a/erpnext/support/doctype/service_level_agreement/test_service_level_agreement.py b/erpnext/support/doctype/service_level_agreement/test_service_level_agreement.py index 07ef368cbe3..2a8446d29f9 100644 --- a/erpnext/support/doctype/service_level_agreement/test_service_level_agreement.py +++ b/erpnext/support/doctype/service_level_agreement/test_service_level_agreement.py @@ -5,19 +5,20 @@ from __future__ import unicode_literals import frappe import unittest -from erpnext.hr.doctype.employee_group.test_employee_group import make_employee_group +import datetime +from frappe.utils import flt from erpnext.support.doctype.issue_priority.test_issue_priority import make_priorities +from erpnext.support.doctype.service_level_agreement.service_level_agreement import get_service_level_agreement_fields class TestServiceLevelAgreement(unittest.TestCase): def setUp(self): - frappe.db.sql("delete from `tabService Level Agreement`") frappe.db.set_value("Support Settings", None, "track_service_level_agreement", 1) + frappe.db.sql("delete from `tabLead`") def test_service_level_agreement(self): # Default Service Level Agreement create_default_service_level_agreement = create_service_level_agreement(default_service_level_agreement=1, - holiday_list="__Test Holiday List", employee_group="_Test Employee Group", - entity_type=None, entity=None, response_time=14400, resolution_time=21600) + holiday_list="__Test Holiday List", entity_type=None, entity=None, response_time=14400, resolution_time=21600) get_default_service_level_agreement = get_service_level_agreement(default_service_level_agreement=1) @@ -29,8 +30,8 @@ class TestServiceLevelAgreement(unittest.TestCase): # Service Level Agreement for Customer customer = create_customer() create_customer_service_level_agreement = create_service_level_agreement(default_service_level_agreement=0, - holiday_list="__Test Holiday List", employee_group="_Test Employee Group", - entity_type="Customer", entity=customer, response_time=7200, resolution_time=10800) + holiday_list="__Test Holiday List", entity_type="Customer", entity=customer, + response_time=7200, resolution_time=10800) get_customer_service_level_agreement = get_service_level_agreement(entity_type="Customer", entity=customer) self.assertEqual(create_customer_service_level_agreement.name, get_customer_service_level_agreement.name) @@ -41,8 +42,8 @@ class TestServiceLevelAgreement(unittest.TestCase): # Service Level Agreement for Customer Group customer_group = create_customer_group() create_customer_group_service_level_agreement = create_service_level_agreement(default_service_level_agreement=0, - holiday_list="__Test Holiday List", employee_group="_Test Employee Group", - entity_type="Customer Group", entity=customer_group, response_time=7200, resolution_time=10800) + holiday_list="__Test Holiday List", entity_type="Customer Group", entity=customer_group, + response_time=7200, resolution_time=10800) get_customer_group_service_level_agreement = get_service_level_agreement(entity_type="Customer Group", entity=customer_group) self.assertEqual(create_customer_group_service_level_agreement.name, get_customer_group_service_level_agreement.name) @@ -53,7 +54,7 @@ class TestServiceLevelAgreement(unittest.TestCase): # Service Level Agreement for Territory territory = create_territory() create_territory_service_level_agreement = create_service_level_agreement(default_service_level_agreement=0, - holiday_list="__Test Holiday List", employee_group="_Test Employee Group", + holiday_list="__Test Holiday List", entity_type="Territory", entity=territory, response_time=7200, resolution_time=10800) get_territory_service_level_agreement = get_service_level_agreement(entity_type="Territory", entity=territory) @@ -62,64 +63,223 @@ class TestServiceLevelAgreement(unittest.TestCase): self.assertEqual(create_territory_service_level_agreement.entity, get_territory_service_level_agreement.entity) self.assertEqual(create_territory_service_level_agreement.default_service_level_agreement, get_territory_service_level_agreement.default_service_level_agreement) + def test_custom_field_creation_for_sla_on_standard_dt(self): + # Default Service Level Agreement + doctype = "Lead" + lead_sla = create_service_level_agreement( + default_service_level_agreement=1, + holiday_list="__Test Holiday List", + entity_type=None, entity=None, + response_time=14400, resolution_time=21600, + doctype=doctype, + sla_fulfilled_on=[{"status": "Converted"}] + ) -def get_service_level_agreement(default_service_level_agreement=None, entity_type=None, entity=None): + # check default SLA for lead + default_sla = get_service_level_agreement(default_service_level_agreement=1, doctype=doctype) + self.assertEqual(lead_sla.name, default_sla.name) + + # check SLA custom fields created for leads + sla_fields = get_service_level_agreement_fields() + meta = frappe.get_meta(doctype, cached=False) + + for field in sla_fields: + self.assertTrue(meta.has_field(field.get("fieldname"))) + + def test_docfield_creation_for_sla_on_custom_dt(self): + doctype = create_custom_doctype() + sla = create_service_level_agreement( + default_service_level_agreement=1, + holiday_list="__Test Holiday List", + entity_type=None, entity=None, + response_time=14400, resolution_time=21600, + doctype=doctype.name + ) + + # check default SLA for custom dt + default_sla = get_service_level_agreement(default_service_level_agreement=1, doctype=doctype.name) + self.assertEqual(sla.name, default_sla.name) + + # check SLA docfields created + sla_fields = get_service_level_agreement_fields() + meta = frappe.get_meta(doctype.name, cached=False) + + for field in sla_fields: + self.assertTrue(meta.has_field(field.get("fieldname"))) + + def test_sla_application(self): + # Default Service Level Agreement + doctype = "Lead" + lead_sla = create_service_level_agreement( + default_service_level_agreement=1, + holiday_list="__Test Holiday List", + entity_type=None, entity=None, + response_time=14400, resolution_time=21600, + doctype=doctype, + sla_fulfilled_on=[{"status": "Converted"}] + ) + + # make lead with default SLA + creation = datetime.datetime(2019, 3, 4, 12, 0) + lead = make_lead(creation=creation, index=1) + + self.assertEqual(lead.service_level_agreement, lead_sla.name) + self.assertEqual(lead.response_by, datetime.datetime(2019, 3, 4, 16, 0)) + self.assertEqual(lead.resolution_by, datetime.datetime(2019, 3, 4, 18, 0)) + + frappe.flags.current_time = datetime.datetime(2019, 3, 4, 15, 0) + lead.reload() + lead.status = 'Converted' + lead.save() + + self.assertEqual(lead.agreement_status, 'Fulfilled') + + def test_hold_time(self): + doctype = "Lead" + create_service_level_agreement( + default_service_level_agreement=1, + holiday_list="__Test Holiday List", + entity_type=None, entity=None, + response_time=14400, resolution_time=21600, + doctype=doctype, + sla_fulfilled_on=[{"status": "Converted"}], + pause_sla_on=[{"status": "Replied"}] + ) + + creation = datetime.datetime(2020, 3, 4, 4, 0) + lead = make_lead(creation, index=2) + + frappe.flags.current_time = datetime.datetime(2020, 3, 4, 4, 15) + lead.reload() + lead.status = 'Replied' + lead.save() + + lead.reload() + self.assertEqual(lead.on_hold_since, frappe.flags.current_time) + + frappe.flags.current_time = datetime.datetime(2020, 3, 4, 5, 5) + lead.reload() + lead.status = 'Converted' + lead.save() + + lead.reload() + self.assertEqual(flt(lead.total_hold_time, 2), 3000) + self.assertEqual(lead.resolution_by, datetime.datetime(2020, 3, 4, 16, 50)) + + def test_failed_sla_for_response_only(self): + doctype = "Lead" + create_service_level_agreement( + default_service_level_agreement=1, + holiday_list="__Test Holiday List", + entity_type=None, entity=None, + response_time=14400, + doctype=doctype, + sla_fulfilled_on=[{"status": "Replied"}], + pause_sla_on=[], + apply_sla_for_resolution=0 + ) + + creation = datetime.datetime(2019, 3, 4, 12, 0) + lead = make_lead(creation=creation, index=1) + self.assertEqual(lead.response_by, datetime.datetime(2019, 3, 4, 16, 0)) + + # failed with response time only + frappe.flags.current_time = datetime.datetime(2019, 3, 4, 16, 5) + lead.reload() + lead.status = 'Replied' + lead.save() + + lead.reload() + self.assertEqual(lead.agreement_status, 'Failed') + + def test_fulfilled_sla_for_response_only(self): + doctype = "Lead" + lead_sla = create_service_level_agreement( + default_service_level_agreement=1, + holiday_list="__Test Holiday List", + entity_type=None, entity=None, + response_time=14400, + doctype=doctype, + sla_fulfilled_on=[{"status": "Replied"}], + apply_sla_for_resolution=0 + ) + + # fulfilled with response time only + creation = datetime.datetime(2019, 3, 4, 12, 0) + lead = make_lead(creation=creation, index=2) + + self.assertEqual(lead.service_level_agreement, lead_sla.name) + self.assertEqual(lead.response_by, datetime.datetime(2019, 3, 4, 16, 0)) + + frappe.flags.current_time = datetime.datetime(2019, 3, 4, 15, 30) + lead.reload() + lead.status = 'Replied' + lead.save() + + lead.reload() + self.assertEqual(lead.agreement_status, 'Fulfilled') + + def tearDown(self): + for d in frappe.get_all("Service Level Agreement"): + frappe.delete_doc("Service Level Agreement", d.name, force=1) + + +def get_service_level_agreement(default_service_level_agreement=None, entity_type=None, entity=None, doctype="Issue"): if default_service_level_agreement: - filters = {"default_service_level_agreement": default_service_level_agreement} + filters = {"default_service_level_agreement": default_service_level_agreement, "document_type": doctype} else: filters = {"entity_type": entity_type, "entity": entity} service_level_agreement = frappe.get_doc("Service Level Agreement", filters) return service_level_agreement -def create_service_level_agreement(default_service_level_agreement, holiday_list, employee_group, - response_time, entity_type, entity, resolution_time): +def create_service_level_agreement(default_service_level_agreement, holiday_list, response_time, entity_type, + entity, resolution_time=0, doctype="Issue", sla_fulfilled_on=[], pause_sla_on=[], apply_sla_for_resolution=1): - employee_group = make_employee_group() make_holiday_list() make_priorities() - service_level_agreement = frappe.get_doc({ + if not sla_fulfilled_on: + sla_fulfilled_on = [ + {"status": "Resolved"}, + {"status": "Closed"} + ] + + pause_sla_on = [{"status": "Replied"}] if doctype == "Issue" else pause_sla_on + + service_level_agreement = frappe._dict({ "doctype": "Service Level Agreement", - "enable": 1, + "enabled": 1, + "document_type": doctype, "service_level": "__Test Service Level", "default_service_level_agreement": default_service_level_agreement, "default_priority": "Medium", "holiday_list": holiday_list, - "employee_group": employee_group, "entity_type": entity_type, "entity": entity, "start_date": frappe.utils.getdate(), "end_date": frappe.utils.add_to_date(frappe.utils.getdate(), days=100), + "apply_sla_for_resolution": apply_sla_for_resolution, "priorities": [ { "priority": "Low", "response_time": response_time, - "response_time_period": "Hour", "resolution_time": resolution_time, - "resolution_time_period": "Hour", }, { "priority": "Medium", "response_time": response_time, "default_priority": 1, - "response_time_period": "Hour", "resolution_time": resolution_time, - "resolution_time_period": "Hour", }, { "priority": "High", "response_time": response_time, - "response_time_period": "Hour", "resolution_time": resolution_time, - "resolution_time_period": "Hour", - } - ], - "pause_sla_on": [ - { - "status": "Replied" } ], + "sla_fulfilled_on": sla_fulfilled_on, + "pause_sla_on": pause_sla_on, "support_and_resolution": [ { "workday": "Monday", @@ -173,10 +333,13 @@ def create_service_level_agreement(default_service_level_agreement, holiday_list service_level_agreement_exists = frappe.db.exists("Service Level Agreement", filters) if not service_level_agreement_exists: - service_level_agreement.insert(ignore_permissions=True) - return service_level_agreement + doc = frappe.get_doc(service_level_agreement).insert(ignore_permissions=True) else: - return frappe.get_doc("Service Level Agreement", service_level_agreement_exists) + doc = frappe.get_doc("Service Level Agreement", service_level_agreement_exists) + doc.update(service_level_agreement) + doc.save() + + return doc def create_customer(): @@ -219,19 +382,19 @@ def create_territory(): def create_service_level_agreements_for_issues(): create_service_level_agreement(default_service_level_agreement=1, holiday_list="__Test Holiday List", - employee_group="_Test Employee Group", entity_type=None, entity=None, response_time=14400, resolution_time=21600) + entity_type=None, entity=None, response_time=14400, resolution_time=21600) create_customer() create_service_level_agreement(default_service_level_agreement=0, holiday_list="__Test Holiday List", - employee_group="_Test Employee Group", entity_type="Customer", entity="_Test Customer", response_time=7200, resolution_time=10800) + entity_type="Customer", entity="_Test Customer", response_time=7200, resolution_time=10800) create_customer_group() create_service_level_agreement(default_service_level_agreement=0, holiday_list="__Test Holiday List", - employee_group="_Test Employee Group", entity_type="Customer Group", entity="_Test SLA Customer Group", response_time=7200, resolution_time=10800) + entity_type="Customer Group", entity="_Test SLA Customer Group", response_time=7200, resolution_time=10800) create_territory() create_service_level_agreement(default_service_level_agreement=0, holiday_list="__Test Holiday List", - employee_group="_Test Employee Group", entity_type="Territory", entity="_Test SLA Territory", response_time=7200, resolution_time=10800) + entity_type="Territory", entity="_Test SLA Territory", response_time=7200, resolution_time=10800) def make_holiday_list(): holiday_list = frappe.db.exists("Holiday List", "__Test Holiday List") @@ -256,3 +419,55 @@ def make_holiday_list(): }, ] }).insert() + +def create_custom_doctype(): + if not frappe.db.exists("DocType", "Test SLA on Custom Dt"): + doc = frappe.get_doc({ + "doctype": "DocType", + "module": "Support", + "custom": 1, + "fields": [ + { + "label": "Date", + "fieldname": "date", + "fieldtype": "Date" + }, + { + "label": "Description", + "fieldname": "desc", + "fieldtype": "Long Text" + }, + { + "label": "Email ID", + "fieldname": "email_id", + "fieldtype": "Link", + "options": "Customer" + }, + { + "label": "Status", + "fieldname": "status", + "fieldtype": "Select", + "options": "Open\nReplied\nClosed" + } + ], + "permissions": [{ + "role": "System Manager", + "read": 1, + "write": 1 + }], + "name": "Test SLA on Custom Dt", + }) + doc.insert() + return doc + else: + return frappe.get_doc("DocType", "Test SLA on Custom Dt") + +def make_lead(creation=None, index=0): + return frappe.get_doc({ + "doctype": "Lead", + "email_id": "test_lead1@example{0}.com".format(index), + "lead_name": "_Test Lead {0}".format(index), + "status": "Open", + "creation": creation, + "service_level_agreement_creation": creation + }).insert(ignore_permissions=True) \ No newline at end of file diff --git a/erpnext/support/doctype/service_level_priority/service_level_priority.json b/erpnext/support/doctype/service_level_priority/service_level_priority.json index 65d51694cc3..0367fc6d887 100644 --- a/erpnext/support/doctype/service_level_priority/service_level_priority.json +++ b/erpnext/support/doctype/service_level_priority/service_level_priority.json @@ -15,12 +15,13 @@ ], "fields": [ { - "columns": 2, + "columns": 1, "fieldname": "priority", "fieldtype": "Link", "in_list_view": 1, "label": "Priority", - "options": "Issue Priority" + "options": "Issue Priority", + "reqd": 1 }, { "fieldname": "sb_00", @@ -32,7 +33,6 @@ "fieldtype": "Duration", "hide_days": 1, "hide_seconds": 1, - "in_list_view": 1, "label": "Resolution Time" }, { @@ -58,12 +58,13 @@ "hide_days": 1, "hide_seconds": 1, "in_list_view": 1, - "label": "First Response Time" + "label": "First Response Time", + "reqd": 1 } ], "istable": 1, "links": [], - "modified": "2020-06-10 12:45:47.545915", + "modified": "2021-05-29 19:52:51.733248", "modified_by": "Administrator", "module": "Support", "name": "Service Level Priority", @@ -73,4 +74,4 @@ "sort_field": "modified", "sort_order": "DESC", "track_changes": 1 -} +} \ No newline at end of file diff --git a/erpnext/support/doctype/sla_fulfilled_on_status/__init__.py b/erpnext/support/doctype/sla_fulfilled_on_status/__init__.py new file mode 100644 index 00000000000..e69de29bb2d diff --git a/erpnext/support/doctype/sla_fulfilled_on_status/sla_fulfilled_on_status.json b/erpnext/support/doctype/sla_fulfilled_on_status/sla_fulfilled_on_status.json new file mode 100644 index 00000000000..87124deaf8b --- /dev/null +++ b/erpnext/support/doctype/sla_fulfilled_on_status/sla_fulfilled_on_status.json @@ -0,0 +1,31 @@ +{ + "actions": [], + "creation": "2021-05-26 21:11:29.176369", + "doctype": "DocType", + "editable_grid": 1, + "engine": "InnoDB", + "field_order": [ + "status" + ], + "fields": [ + { + "fieldname": "status", + "fieldtype": "Select", + "in_list_view": 1, + "label": "Status", + "reqd": 1 + } + ], + "istable": 1, + "links": [], + "modified": "2021-05-26 21:11:29.176369", + "modified_by": "Administrator", + "module": "Support", + "name": "SLA Fulfilled On Status", + "owner": "Administrator", + "permissions": [], + "quick_entry": 1, + "sort_field": "modified", + "sort_order": "DESC", + "track_changes": 1 +} \ No newline at end of file diff --git a/erpnext/support/doctype/sla_fulfilled_on_status/sla_fulfilled_on_status.py b/erpnext/support/doctype/sla_fulfilled_on_status/sla_fulfilled_on_status.py new file mode 100644 index 00000000000..b0b5ffc8165 --- /dev/null +++ b/erpnext/support/doctype/sla_fulfilled_on_status/sla_fulfilled_on_status.py @@ -0,0 +1,8 @@ +# Copyright (c) 2021, Frappe Technologies Pvt. Ltd. and contributors +# For license information, please see license.txt + +# import frappe +from frappe.model.document import Document + +class SLAFulfilledOnStatus(Document): + pass diff --git a/erpnext/support/doctype/warranty_claim/warranty_claim.js b/erpnext/support/doctype/warranty_claim/warranty_claim.js index 79f46758d12..358768eb46c 100644 --- a/erpnext/support/doctype/warranty_claim/warranty_claim.js +++ b/erpnext/support/doctype/warranty_claim/warranty_claim.js @@ -36,8 +36,8 @@ frappe.ui.form.on("Warranty Claim", { } }); -erpnext.support.WarrantyClaim = frappe.ui.form.Controller.extend({ - refresh: function() { +erpnext.support.WarrantyClaim = class WarrantyClaim extends frappe.ui.form.Controller { + refresh() { frappe.dynamic_link = {doc: this.frm.doc, fieldname: 'customer', doctype: 'Customer'} if(!cur_frm.doc.__islocal && @@ -45,17 +45,17 @@ erpnext.support.WarrantyClaim = frappe.ui.form.Controller.extend({ cur_frm.add_custom_button(__('Maintenance Visit'), this.make_maintenance_visit); } - }, + } - make_maintenance_visit: function() { + make_maintenance_visit() { frappe.model.open_mapped_doc({ method: "erpnext.support.doctype.warranty_claim.warranty_claim.make_maintenance_visit", frm: cur_frm }) } -}); +}; -$.extend(cur_frm.cscript, new erpnext.support.WarrantyClaim({frm: cur_frm})); +extend_cscript(cur_frm.cscript, new erpnext.support.WarrantyClaim({frm: cur_frm})); cur_frm.fields_dict['serial_no'].get_query = function(doc, cdt, cdn) { var cond = []; @@ -93,4 +93,4 @@ cur_frm.fields_dict['item_code'].get_query = function(doc, cdt, cdn) { ] } } -}; \ No newline at end of file +}; diff --git a/erpnext/templates/generators/item/item.html b/erpnext/templates/generators/item/item.html index 135982d7090..17f6880293c 100644 --- a/erpnext/templates/generators/item/item.html +++ b/erpnext/templates/generators/item/item.html @@ -28,9 +28,7 @@ {% block base_scripts %} - - - - - -{% endblock %} \ No newline at end of file +{{ include_script("frappe-web.bundle.js") }} +{{ include_script("controls.bundle.js") }} +{{ include_script("dialog.bundle.js") }} +{% endblock %} diff --git a/erpnext/templates/includes/rfq.js b/erpnext/templates/includes/rfq.js index b56c416dbde..37beb5a584b 100644 --- a/erpnext/templates/includes/rfq.js +++ b/erpnext/templates/includes/rfq.js @@ -11,23 +11,23 @@ $(document).ready(function() { doc.buying_price_list = "{{ doc.buying_price_list }}" }); -rfq = Class.extend({ - init: function(){ +rfq = class rfq { + constructor(){ this.onfocus_select_all(); this.change_qty(); this.change_rate(); this.terms(); this.submit_rfq(); this.navigate_quotations(); - }, + } - onfocus_select_all: function(){ + onfocus_select_all(){ $("input").click(function(){ $(this).select(); }) - }, + } - change_qty: function(){ + change_qty(){ var me = this; $('.rfq-items').on("change", ".rfq-qty", function(){ me.idx = parseFloat($(this).attr('data-idx')); @@ -36,9 +36,9 @@ rfq = Class.extend({ me.update_qty_rate(); $(this).val(format_number(me.qty, doc.number_format, 2)); }) - }, + } - change_rate: function(){ + change_rate(){ var me = this; $(".rfq-items").on("change", ".rfq-rate", function(){ me.idx = parseFloat($(this).attr('data-idx')); @@ -47,15 +47,15 @@ rfq = Class.extend({ me.update_qty_rate(); $(this).val(format_number(me.rate, doc.number_format, 2)); }) - }, + } - terms: function(){ + terms(){ $(".terms").on("change", ".terms-feedback", function(){ doc.terms = $(this).val(); }) - }, + } - update_qty_rate: function(){ + update_qty_rate(){ var me = this; doc.grand_total = 0.0; $.each(doc.items, function(idx, data){ @@ -69,9 +69,9 @@ rfq = Class.extend({ doc.grand_total += flt(data.amount); $('.tax-grand-total').text(format_number(doc.grand_total, doc.number_format, 2)); }) - }, + } - submit_rfq: function(){ + submit_rfq(){ $('.btn-sm').click(function(){ frappe.freeze(); frappe.call({ @@ -90,12 +90,12 @@ rfq = Class.extend({ } }) }) - }, + } - navigate_quotations: function() { + navigate_quotations() { $('.quotations').click(function(){ name = $(this).attr('idx') window.location.href = "/quotations/" + encodeURIComponent(name); }) } -}) +} diff --git a/erpnext/templates/pages/cart.html b/erpnext/templates/pages/cart.html index ea343713a13..c64c6343cca 100644 --- a/erpnext/templates/pages/cart.html +++ b/erpnext/templates/pages/cart.html @@ -139,9 +139,7 @@ {% block base_scripts %} - - - - - +{{ include_script("frappe-web.bundle.js") }} +{{ include_script("controls.bundle.js") }} +{{ include_script("dialog.bundle.js") }} {% endblock %} diff --git a/erpnext/templates/pages/partners.py b/erpnext/templates/pages/partners.py index 6725a3e2948..a7e60e26168 100644 --- a/erpnext/templates/pages/partners.py +++ b/erpnext/templates/pages/partners.py @@ -3,7 +3,6 @@ from __future__ import unicode_literals import frappe -import frappe.website.render page_title = "Partners" diff --git a/requirements.txt b/requirements.txt index 32da48e9d57..f28906ae352 100644 --- a/requirements.txt +++ b/requirements.txt @@ -1,10 +1,11 @@ +future==0.18.2 # frappe # https://github.com/frappe/frappe is installed during bench-init gocardless-pro~=1.22.0 googlemaps # used in ERPNext, but dependency is defined in Frappe pandas~=1.1.5 plaid-python~=7.2.1 pycountry~=20.7.3 -PyGithub~=1.54.1 +PyGithub~=1.55 python-stdnum~=1.16 python-youtube~=0.8.0 taxjar~=1.9.2 diff --git a/yarn.lock b/yarn.lock index 0a2ac1affc8..242695c4b85 100644 --- a/yarn.lock +++ b/yarn.lock @@ -1540,16 +1540,11 @@ inherits@^2.0.1, inherits@^2.0.3, inherits@^2.0.4: resolved "https://registry.yarnpkg.com/inherits/-/inherits-2.0.4.tgz#0fa2c64f932917c3433a0ded55363aae37416b7c" integrity sha512-k/vGaX4/Yla3WzyMCvTQOXYeIHvqOKtnqBduzTHpzpQZzAskKMhZ2K+EnBiSM9zGSoIFeMpXKxa4dYeZIQqewQ== -ini@1.3.7: +ini@1.3.7, ini@~1.3.0: version "1.3.7" resolved "https://registry.yarnpkg.com/ini/-/ini-1.3.7.tgz#a09363e1911972ea16d7a8851005d84cf09a9a84" integrity sha512-iKpRpXP+CrP2jyrxvg1kMUpXDyRUFDWurxbnVT1vQPx+Wz9uCYsMIqYuSBLV+PAaZG/d7kRLKRFc9oDMsH+mFQ== -ini@~1.3.0: - version "1.3.5" - resolved "https://registry.yarnpkg.com/ini/-/ini-1.3.5.tgz#eee25f56db1c9ec6085e0c22778083f596abf927" - integrity sha512-RZY5huIKCMRWDUqZlEi72f/lmXKMvuszcMBduliQ3nnWbx9X/ZBQO7DijMEYS9EhHBb2qacRUMtC7svLwe0lcw== - is-callable@^1.1.5: version "1.2.3" resolved "https://registry.yarnpkg.com/is-callable/-/is-callable-1.2.3.tgz#8b1e0500b73a1d76c70487636f368e519de8db8e" @@ -2000,9 +1995,9 @@ lodash.values@^4.3.0: integrity sha1-o6bCsOvsxcLLocF+bmIP6BtT00c= lodash@^4.17.15: - version "4.17.19" - resolved "https://registry.yarnpkg.com/lodash/-/lodash-4.17.19.tgz#e48ddedbe30b3321783c5b4301fbd353bc1e4a4b" - integrity sha512-JNvd8XER9GQX0v2qJgsaN/mzFCNA5BRe/j8JN9d+tWyGLSodKQHKFicdwNYzWwI3wjRnaKPsGj1XkBjx/F96DQ== + version "4.17.21" + resolved "https://registry.yarnpkg.com/lodash/-/lodash-4.17.21.tgz#679591c564c3bffaae8454cf0b3df370c3d6911c" + integrity sha512-v2kDEe57lecTulaDIuNTPy3Ry4gLGJ6Z1O3vE1krgXZNrsQ+LFTGHVxVjcXPs17LhbZVGedAJv8XZ1tvj5FvSg== log-symbols@^4.0.0: version "4.1.0"