From 0357fbc9c1e084771f3f2648fab02dd60c6d3ade Mon Sep 17 00:00:00 2001 From: Nabin Hait Date: Fri, 9 Mar 2018 13:19:52 +0530 Subject: [PATCH] commonfied regional function for checking delete permission --- erpnext/hooks.py | 4 ++-- erpnext/regional/__init__.py | 11 +++++++++++ erpnext/regional/france/utils.py | 10 ---------- erpnext/regional/nepal/__init__.py | 0 erpnext/regional/nepal/utils.py | 13 ------------- 5 files changed, 13 insertions(+), 25 deletions(-) delete mode 100644 erpnext/regional/nepal/__init__.py delete mode 100644 erpnext/regional/nepal/utils.py diff --git a/erpnext/hooks.py b/erpnext/hooks.py index 7ed9b88a408..a97f80fddc4 100644 --- a/erpnext/hooks.py +++ b/erpnext/hooks.py @@ -201,11 +201,11 @@ doc_events = { "Sales Invoice": { 'validate': 'erpnext.regional.india.utils.set_place_of_supply', "on_submit": "erpnext.regional.france.utils.create_transaction_log", - "on_trash": ["erpnext.regional.france.utils.check_deletion_permission", "erpnext.regional.nepal.utils.check_deletion_permission"] + "on_trash": "erpnext.regional.check_deletion_permission" }, "Payment Entry": { "on_submit": ["erpnext.regional.france.utils.create_transaction_log", "erpnext.accounts.doctype.payment_request.payment_request.make_status_as_paid"], - "on_trash": "erpnext.regional.france.utils.check_deletion_permission" + "on_trash": "erpnext.regional.check_deletion_permission" }, 'Address': { 'validate': 'erpnext.regional.india.utils.validate_gstin_for_india' diff --git a/erpnext/regional/__init__.py b/erpnext/regional/__init__.py index e69de29bb2d..510ed587667 100644 --- a/erpnext/regional/__init__.py +++ b/erpnext/regional/__init__.py @@ -0,0 +1,11 @@ +# Copyright (c) 2018, Frappe Technologies and contributors +# For license information, please see license.txt + +import frappe +from frappe import _ +from erpnext import get_region + +def check_deletion_permission(doc, method): + region = get_region() + if region in ["Nepal", "France"]: + frappe.throw(_("Deletion is not permitted for country {0}".format(region))) \ No newline at end of file diff --git a/erpnext/regional/france/utils.py b/erpnext/regional/france/utils.py index c963d7431fd..9e9f0ad9bee 100644 --- a/erpnext/regional/france/utils.py +++ b/erpnext/regional/france/utils.py @@ -9,9 +9,7 @@ def create_transaction_log(doc, method): region = get_region() if region not in ["France"]: return - else: - data = str(doc.as_dict()) frappe.get_doc({ @@ -21,14 +19,6 @@ def create_transaction_log(doc, method): "data": data }).insert(ignore_permissions=True) -def check_deletion_permission(doc, method): - region = get_region() - if region not in ["France"]: - return - - else: - frappe.throw(_("Deletion is not permitted for country {0}".format(region))) - # don't remove this function it is used in tests def test_method(): '''test function''' diff --git a/erpnext/regional/nepal/__init__.py b/erpnext/regional/nepal/__init__.py deleted file mode 100644 index e69de29bb2d..00000000000 diff --git a/erpnext/regional/nepal/utils.py b/erpnext/regional/nepal/utils.py deleted file mode 100644 index 76801b9d844..00000000000 --- a/erpnext/regional/nepal/utils.py +++ /dev/null @@ -1,13 +0,0 @@ -# Copyright (c) 2018, Frappe Technologies and contributors -# For license information, please see license.txt - -import frappe -from frappe import _ -from erpnext import get_region - -def check_deletion_permission(doc, method): - region = get_region() - if region not in ["Nepal"]: - return - else: - frappe.throw(_("Deletion is not permitted for country {0}".format(region))) \ No newline at end of file