From eabf706f3728f0e571ea54fb825462a76984f245 Mon Sep 17 00:00:00 2001 From: 0xD0M1M0 <76812428+0xD0M1M0@users.noreply.github.com> Date: Wed, 10 Jan 2024 05:59:38 +0100 Subject: [PATCH 1/2] fix: projects website list visible for guests and all logged in customers (#39164) * fix: projects website list visible for guests fix: projects website list visible for guests and all logged in customers see the issue for details fixes issue #39009 * fix: remove user = frappe.session.user --- erpnext/projects/doctype/project/project.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/erpnext/projects/doctype/project/project.py b/erpnext/projects/doctype/project/project.py index d17d21cf274..382437fd667 100644 --- a/erpnext/projects/doctype/project/project.py +++ b/erpnext/projects/doctype/project/project.py @@ -370,18 +370,16 @@ def get_timeline_data(doctype: str, name: str) -> dict[int, int]: def get_project_list( doctype, txt, filters, limit_start, limit_page_length=20, order_by="modified" ): - user = frappe.session.user customers, suppliers = get_customers_suppliers("Project", frappe.session.user) ignore_permissions = False - if is_website_user(): + if is_website_user() and frappe.session.user != "Guest": if not filters: filters = [] if customers: filters.append([doctype, "customer", "in", customers]) - - ignore_permissions = True + ignore_permissions = True meta = frappe.get_meta(doctype) From 2178fdc65a1f3557b7fa286c6872dc86eed5bc10 Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Wed, 10 Jan 2024 10:39:45 +0530 Subject: [PATCH 2/2] fix: get_single_value doesn't support multiple fields --- .../doctype/repost_item_valuation/repost_item_valuation.py | 4 +--- erpnext/utilities/doctype/video/video.py | 5 ++--- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/erpnext/stock/doctype/repost_item_valuation/repost_item_valuation.py b/erpnext/stock/doctype/repost_item_valuation/repost_item_valuation.py index 909aa367101..f34ac5d7af0 100644 --- a/erpnext/stock/doctype/repost_item_valuation/repost_item_valuation.py +++ b/erpnext/stock/doctype/repost_item_valuation/repost_item_valuation.py @@ -140,9 +140,7 @@ class RepostItemValuation(Document): return query[0][0] if query else None def validate_accounts_freeze(self): - acc_settings = frappe.db.get_single_value( - "Accounts Settings", ["acc_frozen_upto", "frozen_accounts_modifier"], as_dict=1 - ) + acc_settings = frappe.get_cached_doc("Account Settings") if not acc_settings.acc_frozen_upto: return if getdate(self.posting_date) <= getdate(acc_settings.acc_frozen_upto): diff --git a/erpnext/utilities/doctype/video/video.py b/erpnext/utilities/doctype/video/video.py index 7a04329cb98..c3a653a5cf3 100644 --- a/erpnext/utilities/doctype/video/video.py +++ b/erpnext/utilities/doctype/video/video.py @@ -78,9 +78,8 @@ def get_frequency(value): def update_youtube_data(): # Called every 30 minutes via hooks - enable_youtube_tracking, frequency = frappe.db.get_single_value( - "Video Settings", ["enable_youtube_tracking", "frequency"] - ) + enable_youtube_tracking = frappe.db.get_single_value("Video Settings", "enable_youtube_tracking") + frequency = frappe.db.get_single_value("Video Settings", "frequency") if not cint(enable_youtube_tracking): return