From 01811ccf8527ee2c632a72fe20f9f55c3c98aef3 Mon Sep 17 00:00:00 2001 From: Mihir Kandoi Date: Mon, 29 Jun 2026 22:42:48 +0530 Subject: [PATCH] fix(telephony): rollback before logging in call_log link_existing_conversations (Postgres) The hook saves Call Logs in a loop; on failure the except calls frappe.log_error (INSERT) with no rollback, raising InFailedSqlTransaction on Postgres (it runs on every Contact create/update). Full frappe.db.rollback() before log_error. No-op on MariaDB. --- erpnext/telephony/doctype/call_log/call_log.py | 1 + 1 file changed, 1 insertion(+) diff --git a/erpnext/telephony/doctype/call_log/call_log.py b/erpnext/telephony/doctype/call_log/call_log.py index 9c00e5aeb6d..2a6660c101f 100644 --- a/erpnext/telephony/doctype/call_log/call_log.py +++ b/erpnext/telephony/doctype/call_log/call_log.py @@ -196,6 +196,7 @@ def link_existing_conversations(doc, state): if not frappe.in_test: frappe.db.commit() except Exception: + frappe.db.rollback() frappe.log_error(title=_("Error during caller information update"))